All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] arch: powerpc: platforms: 512x: Add missing of_node_put()
@ 2022-06-15 14:37 ` Liang He
  0 siblings, 0 replies; 4+ messages in thread
From: Liang He @ 2022-06-15 14:37 UTC (permalink / raw)
  To: agust, mpe, benh, paulus, ulia.Lawall, nick.child
  Cc: joel, linuxppc-dev, linux-kernel, windhl

In mpc5121_clk_init(), of_find_compatible_node() will return a
node pointer with refcount incremented. We should use of_node_put()
when it is not used anymore.

Signed-off-by: Liang He <windhl@126.com>
---
 arch/powerpc/platforms/512x/clock-commonclk.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/arch/powerpc/platforms/512x/clock-commonclk.c b/arch/powerpc/platforms/512x/clock-commonclk.c
index 0652c7e69225..ca475462e95b 100644
--- a/arch/powerpc/platforms/512x/clock-commonclk.c
+++ b/arch/powerpc/platforms/512x/clock-commonclk.c
@@ -1208,6 +1208,8 @@ int __init mpc5121_clk_init(void)
 	/* register as an OF clock provider */
 	mpc5121_clk_register_of_provider(clk_np);
 
+	of_node_put(clk_np);
+
 	/*
 	 * unbreak not yet adjusted peripheral drivers during migration
 	 * towards fully operational common clock support, and allow
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [PATCH] arch: powerpc: platforms: 512x: Add missing of_node_put()
@ 2022-06-15 14:37 ` Liang He
  0 siblings, 0 replies; 4+ messages in thread
From: Liang He @ 2022-06-15 14:37 UTC (permalink / raw)
  To: agust, mpe, benh, paulus, ulia.Lawall, nick.child
  Cc: windhl, linuxppc-dev, joel, linux-kernel

In mpc5121_clk_init(), of_find_compatible_node() will return a
node pointer with refcount incremented. We should use of_node_put()
when it is not used anymore.

Signed-off-by: Liang He <windhl@126.com>
---
 arch/powerpc/platforms/512x/clock-commonclk.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/arch/powerpc/platforms/512x/clock-commonclk.c b/arch/powerpc/platforms/512x/clock-commonclk.c
index 0652c7e69225..ca475462e95b 100644
--- a/arch/powerpc/platforms/512x/clock-commonclk.c
+++ b/arch/powerpc/platforms/512x/clock-commonclk.c
@@ -1208,6 +1208,8 @@ int __init mpc5121_clk_init(void)
 	/* register as an OF clock provider */
 	mpc5121_clk_register_of_provider(clk_np);
 
+	of_node_put(clk_np);
+
 	/*
 	 * unbreak not yet adjusted peripheral drivers during migration
 	 * towards fully operational common clock support, and allow
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] arch: powerpc: platforms: 512x: Add missing of_node_put()
  2022-06-15 14:37 ` Liang He
@ 2022-09-09 12:07   ` Michael Ellerman
  -1 siblings, 0 replies; 4+ messages in thread
From: Michael Ellerman @ 2022-09-09 12:07 UTC (permalink / raw)
  To: agust, paulus, Liang He, nick.child, ulia.Lawall, benh, mpe
  Cc: joel, linuxppc-dev, linux-kernel

On Wed, 15 Jun 2022 22:37:03 +0800, Liang He wrote:
> In mpc5121_clk_init(), of_find_compatible_node() will return a
> node pointer with refcount incremented. We should use of_node_put()
> when it is not used anymore.
> 
> 

Applied to powerpc/next.

[1/1] arch: powerpc: platforms: 512x: Add missing of_node_put()
      https://git.kernel.org/powerpc/c/06f48f5cb5df2299f5e4b42e9dda1858bf172bcb

cheers

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] arch: powerpc: platforms: 512x: Add missing of_node_put()
@ 2022-09-09 12:07   ` Michael Ellerman
  0 siblings, 0 replies; 4+ messages in thread
From: Michael Ellerman @ 2022-09-09 12:07 UTC (permalink / raw)
  To: agust, paulus, Liang He, nick.child, ulia.Lawall, benh, mpe
  Cc: linuxppc-dev, joel, linux-kernel

On Wed, 15 Jun 2022 22:37:03 +0800, Liang He wrote:
> In mpc5121_clk_init(), of_find_compatible_node() will return a
> node pointer with refcount incremented. We should use of_node_put()
> when it is not used anymore.
> 
> 

Applied to powerpc/next.

[1/1] arch: powerpc: platforms: 512x: Add missing of_node_put()
      https://git.kernel.org/powerpc/c/06f48f5cb5df2299f5e4b42e9dda1858bf172bcb

cheers

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2022-09-09 12:13 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-06-15 14:37 [PATCH] arch: powerpc: platforms: 512x: Add missing of_node_put() Liang He
2022-06-15 14:37 ` Liang He
2022-09-09 12:07 ` Michael Ellerman
2022-09-09 12:07   ` Michael Ellerman

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.