All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: Fabio Estevam <festevam@gmail.com>
Cc: shawnguo@kernel.org, marcel.ziswiler@toradex.com,
	francesco.dolcini@toradex.com,
	linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
	Fabio Estevam <festevam@denx.de>
Subject: Re: [PATCH] dt-bindings: arm: fsl: Decrease the line length
Date: Thu, 16 Jun 2022 08:51:49 -0600	[thread overview]
Message-ID: <20220616145149.GA3451750-robh@kernel.org> (raw)
In-Reply-To: <20220614173206.2885817-1-festevam@gmail.com>

On Tue, Jun 14, 2022 at 02:32:06PM -0300, Fabio Estevam wrote:
> From: Fabio Estevam <festevam@denx.de>
> 
> Decrease the line length of the toradex,colibri-imx6ull-emmc boards
> to fix the following build warning:
> 
> ./Documentation/devicetree/bindings/arm/fsl.yaml:684:111: [warning]
> line too long (111 > 110 characters) (line-length)

110 is not really the goal, but 80 with some 100 exceptions. Same as 
kernel. It's set to 110 because there were more than I cared to fixed.

> 
> Fixes: bb0fa1533715 ("dt-bindings: arm: fsl: correct 1g vs. 1gb in toradex,colibri-imx6ull-*")
> Reported-by: Rob Herring <robh+dt@kernel.org>
> Signed-off-by: Fabio Estevam <festevam@denx.de>
> ---
>  Documentation/devicetree/bindings/arm/fsl.yaml | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml
> index 7e5cd4fe5809..1d757af4d05c 100644
> --- a/Documentation/devicetree/bindings/arm/fsl.yaml
> +++ b/Documentation/devicetree/bindings/arm/fsl.yaml
> @@ -680,11 +680,11 @@ properties:
>        - description: i.MX6ULL Boards with Toradex Colibri iMX6ULL 1GB (eMMC) Module
>          items:
>            - enum:
> -              - toradex,colibri-imx6ull-emmc-aster     # Colibri iMX6ULL 1GB (eMMC) on Aster Carrier Board
> -              - toradex,colibri-imx6ull-emmc-eval      # Colibri iMX6ULL 1GB (eMMC) on Colibri Evaluation B. V3
> -              - toradex,colibri-imx6ull-emmc-iris      # Colibri iMX6ULL 1GB (eMMC) on Iris Carrier Board
> -              - toradex,colibri-imx6ull-emmc-iris-v2   # Colibri iMX6ULL 1GB (eMMC) on Iris V2 Carrier Board
> -          - const: toradex,colibri-imx6ull-emmc        # Colibri iMX6ULL 1GB (eMMC) Module
> +              - toradex,colibri-imx6ull-emmc-aster    # Colibri iMX6ULL 1GB (eMMC) on Aster Carrier Board
> +              - toradex,colibri-imx6ull-emmc-eval     # Colibri iMX6ULL 1GB (eMMC) on Colibri Evaluation B. V3
> +              - toradex,colibri-imx6ull-emmc-iris     # Colibri iMX6ULL 1GB (eMMC) on Iris Carrier Board
> +              - toradex,colibri-imx6ull-emmc-iris-v2  # Colibri iMX6ULL 1GB (eMMC) on Iris V2 Carrier Board
> +          - const: toradex,colibri-imx6ull-emmc       # Colibri iMX6ULL 1GB (eMMC) Module

The description already says 'Colibri iMX6ULL 1GB (eMMC)'. Why repeat 
that everywhere?

>            - const: fsl,imx6ull
>  
>        - description: i.MX6ULL Boards with Toradex Colibri iMX6ULL Wi-Fi / BT Modules
> -- 
> 2.25.1
> 
> 

WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: Fabio Estevam <festevam@gmail.com>
Cc: shawnguo@kernel.org, marcel.ziswiler@toradex.com,
	francesco.dolcini@toradex.com,
	linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
	Fabio Estevam <festevam@denx.de>
Subject: Re: [PATCH] dt-bindings: arm: fsl: Decrease the line length
Date: Thu, 16 Jun 2022 08:51:49 -0600	[thread overview]
Message-ID: <20220616145149.GA3451750-robh@kernel.org> (raw)
In-Reply-To: <20220614173206.2885817-1-festevam@gmail.com>

On Tue, Jun 14, 2022 at 02:32:06PM -0300, Fabio Estevam wrote:
> From: Fabio Estevam <festevam@denx.de>
> 
> Decrease the line length of the toradex,colibri-imx6ull-emmc boards
> to fix the following build warning:
> 
> ./Documentation/devicetree/bindings/arm/fsl.yaml:684:111: [warning]
> line too long (111 > 110 characters) (line-length)

110 is not really the goal, but 80 with some 100 exceptions. Same as 
kernel. It's set to 110 because there were more than I cared to fixed.

> 
> Fixes: bb0fa1533715 ("dt-bindings: arm: fsl: correct 1g vs. 1gb in toradex,colibri-imx6ull-*")
> Reported-by: Rob Herring <robh+dt@kernel.org>
> Signed-off-by: Fabio Estevam <festevam@denx.de>
> ---
>  Documentation/devicetree/bindings/arm/fsl.yaml | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml
> index 7e5cd4fe5809..1d757af4d05c 100644
> --- a/Documentation/devicetree/bindings/arm/fsl.yaml
> +++ b/Documentation/devicetree/bindings/arm/fsl.yaml
> @@ -680,11 +680,11 @@ properties:
>        - description: i.MX6ULL Boards with Toradex Colibri iMX6ULL 1GB (eMMC) Module
>          items:
>            - enum:
> -              - toradex,colibri-imx6ull-emmc-aster     # Colibri iMX6ULL 1GB (eMMC) on Aster Carrier Board
> -              - toradex,colibri-imx6ull-emmc-eval      # Colibri iMX6ULL 1GB (eMMC) on Colibri Evaluation B. V3
> -              - toradex,colibri-imx6ull-emmc-iris      # Colibri iMX6ULL 1GB (eMMC) on Iris Carrier Board
> -              - toradex,colibri-imx6ull-emmc-iris-v2   # Colibri iMX6ULL 1GB (eMMC) on Iris V2 Carrier Board
> -          - const: toradex,colibri-imx6ull-emmc        # Colibri iMX6ULL 1GB (eMMC) Module
> +              - toradex,colibri-imx6ull-emmc-aster    # Colibri iMX6ULL 1GB (eMMC) on Aster Carrier Board
> +              - toradex,colibri-imx6ull-emmc-eval     # Colibri iMX6ULL 1GB (eMMC) on Colibri Evaluation B. V3
> +              - toradex,colibri-imx6ull-emmc-iris     # Colibri iMX6ULL 1GB (eMMC) on Iris Carrier Board
> +              - toradex,colibri-imx6ull-emmc-iris-v2  # Colibri iMX6ULL 1GB (eMMC) on Iris V2 Carrier Board
> +          - const: toradex,colibri-imx6ull-emmc       # Colibri iMX6ULL 1GB (eMMC) Module

The description already says 'Colibri iMX6ULL 1GB (eMMC)'. Why repeat 
that everywhere?

>            - const: fsl,imx6ull
>  
>        - description: i.MX6ULL Boards with Toradex Colibri iMX6ULL Wi-Fi / BT Modules
> -- 
> 2.25.1
> 
> 

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  parent reply	other threads:[~2022-06-16 14:51 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-14 17:32 [PATCH] dt-bindings: arm: fsl: Decrease the line length Fabio Estevam
2022-06-14 17:32 ` Fabio Estevam
2022-06-14 18:06 ` Francesco Dolcini
2022-06-14 18:06   ` Francesco Dolcini
2022-06-14 18:13   ` Marcel Ziswiler
2022-06-14 18:13     ` Marcel Ziswiler
2022-06-16 14:51 ` Rob Herring [this message]
2022-06-16 14:51   ` Rob Herring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220616145149.GA3451750-robh@kernel.org \
    --to=robh@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=festevam@denx.de \
    --cc=festevam@gmail.com \
    --cc=francesco.dolcini@toradex.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=marcel.ziswiler@toradex.com \
    --cc=shawnguo@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.