* [PATCH v2] macintosh: via-pmu-backlight: Use backlight helper
@ 2022-06-16 17:04 ` Stephen Kitt
0 siblings, 0 replies; 4+ messages in thread
From: Stephen Kitt @ 2022-06-16 17:04 UTC (permalink / raw)
To: Benjamin Herrenschmidt
Cc: Daniel Thompson, Stephen Kitt, Michael Ellerman,
Christophe Leroy, linuxppc-dev, linux-kernel
backlight_properties.fb_blank is deprecated. The states it represents
are handled by other properties; but instead of accessing those
properties directly, drivers should use the helpers provided by
backlight.h.
Instead of retrieving the backlight brightness in struct
backlight_properties manually, and then checking whether the backlight
should be on at all, use backlight_get_brightness() which does all
this and insulates this from future changes.
Signed-off-by: Stephen Kitt <steve@sk2.org>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: Michael Ellerman <mpe@ellerman.id.au>
Cc: Christophe Leroy <christophe.leroy@csgroup.eu>
Cc: linuxppc-dev@lists.ozlabs.org
---
Changes since v2: clarified commit title
---
drivers/macintosh/via-pmu-backlight.c | 7 +------
1 file changed, 1 insertion(+), 6 deletions(-)
diff --git a/drivers/macintosh/via-pmu-backlight.c b/drivers/macintosh/via-pmu-backlight.c
index 2194016122d2..c2d87e7fa85b 100644
--- a/drivers/macintosh/via-pmu-backlight.c
+++ b/drivers/macintosh/via-pmu-backlight.c
@@ -71,12 +71,7 @@ static int pmu_backlight_get_level_brightness(int level)
static int __pmu_backlight_update_status(struct backlight_device *bd)
{
struct adb_request req;
- int level = bd->props.brightness;
-
-
- if (bd->props.power != FB_BLANK_UNBLANK ||
- bd->props.fb_blank != FB_BLANK_UNBLANK)
- level = 0;
+ int level = backlight_get_brightness(bd);
if (level > 0) {
int pmulevel = pmu_backlight_get_level_brightness(level);
base-commit: f2906aa863381afb0015a9eb7fefad885d4e5a56
--
2.30.2
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH v2] macintosh: via-pmu-backlight: Use backlight helper
@ 2022-06-16 17:04 ` Stephen Kitt
0 siblings, 0 replies; 4+ messages in thread
From: Stephen Kitt @ 2022-06-16 17:04 UTC (permalink / raw)
To: Benjamin Herrenschmidt
Cc: Daniel Thompson, Stephen Kitt, linux-kernel, linuxppc-dev
backlight_properties.fb_blank is deprecated. The states it represents
are handled by other properties; but instead of accessing those
properties directly, drivers should use the helpers provided by
backlight.h.
Instead of retrieving the backlight brightness in struct
backlight_properties manually, and then checking whether the backlight
should be on at all, use backlight_get_brightness() which does all
this and insulates this from future changes.
Signed-off-by: Stephen Kitt <steve@sk2.org>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: Michael Ellerman <mpe@ellerman.id.au>
Cc: Christophe Leroy <christophe.leroy@csgroup.eu>
Cc: linuxppc-dev@lists.ozlabs.org
---
Changes since v2: clarified commit title
---
drivers/macintosh/via-pmu-backlight.c | 7 +------
1 file changed, 1 insertion(+), 6 deletions(-)
diff --git a/drivers/macintosh/via-pmu-backlight.c b/drivers/macintosh/via-pmu-backlight.c
index 2194016122d2..c2d87e7fa85b 100644
--- a/drivers/macintosh/via-pmu-backlight.c
+++ b/drivers/macintosh/via-pmu-backlight.c
@@ -71,12 +71,7 @@ static int pmu_backlight_get_level_brightness(int level)
static int __pmu_backlight_update_status(struct backlight_device *bd)
{
struct adb_request req;
- int level = bd->props.brightness;
-
-
- if (bd->props.power != FB_BLANK_UNBLANK ||
- bd->props.fb_blank != FB_BLANK_UNBLANK)
- level = 0;
+ int level = backlight_get_brightness(bd);
if (level > 0) {
int pmulevel = pmu_backlight_get_level_brightness(level);
base-commit: f2906aa863381afb0015a9eb7fefad885d4e5a56
--
2.30.2
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH v2] macintosh: via-pmu-backlight: Use backlight helper
2022-06-16 17:04 ` Stephen Kitt
@ 2022-11-30 9:23 ` Michael Ellerman
-1 siblings, 0 replies; 4+ messages in thread
From: Michael Ellerman @ 2022-11-30 9:23 UTC (permalink / raw)
To: Stephen Kitt, Benjamin Herrenschmidt
Cc: Michael Ellerman, Daniel Thompson, linux-kernel,
Christophe Leroy, linuxppc-dev
On Thu, 16 Jun 2022 19:04:24 +0200, Stephen Kitt wrote:
> backlight_properties.fb_blank is deprecated. The states it represents
> are handled by other properties; but instead of accessing those
> properties directly, drivers should use the helpers provided by
> backlight.h.
>
> Instead of retrieving the backlight brightness in struct
> backlight_properties manually, and then checking whether the backlight
> should be on at all, use backlight_get_brightness() which does all
> this and insulates this from future changes.
>
> [...]
Applied to powerpc/next.
[1/1] macintosh: via-pmu-backlight: Use backlight helper
https://git.kernel.org/powerpc/c/a0542d2c45a64162e63ad2d80684e57de0566271
cheers
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2] macintosh: via-pmu-backlight: Use backlight helper
@ 2022-11-30 9:23 ` Michael Ellerman
0 siblings, 0 replies; 4+ messages in thread
From: Michael Ellerman @ 2022-11-30 9:23 UTC (permalink / raw)
To: Stephen Kitt, Benjamin Herrenschmidt
Cc: Daniel Thompson, linuxppc-dev, linux-kernel
On Thu, 16 Jun 2022 19:04:24 +0200, Stephen Kitt wrote:
> backlight_properties.fb_blank is deprecated. The states it represents
> are handled by other properties; but instead of accessing those
> properties directly, drivers should use the helpers provided by
> backlight.h.
>
> Instead of retrieving the backlight brightness in struct
> backlight_properties manually, and then checking whether the backlight
> should be on at all, use backlight_get_brightness() which does all
> this and insulates this from future changes.
>
> [...]
Applied to powerpc/next.
[1/1] macintosh: via-pmu-backlight: Use backlight helper
https://git.kernel.org/powerpc/c/a0542d2c45a64162e63ad2d80684e57de0566271
cheers
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-11-30 9:48 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-06-16 17:04 [PATCH v2] macintosh: via-pmu-backlight: Use backlight helper Stephen Kitt
2022-06-16 17:04 ` Stephen Kitt
2022-11-30 9:23 ` Michael Ellerman
2022-11-30 9:23 ` Michael Ellerman
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.