* [PATCH v4] clk: nomadik: Add missing of_node_put()
@ 2022-06-17 1:43 ` Liang He
0 siblings, 0 replies; 6+ messages in thread
From: Liang He @ 2022-06-17 1:43 UTC (permalink / raw)
To: linus.walleij, mturquette, sboyd
Cc: windhl, linux-arm-kernel, linux-clk, linux-kernel
In nomadik_src_init(), of_find_matching_node() will return a node
pointer with refcount incremented. We should use of_node_put() in
fail path or when it is not used anymore.
Signed-off-by: Liang He <windhl@126.com>
---
changelog:
v4: split v3 into nmadik and tegra
v3: merge clk 'missing of_node_put()' patches into one commit.
v2: use Liang He as real name for S-o-b.
v1: fix the missing of_node_put().
drivers/clk/clk-nomadik.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/clk/clk-nomadik.c b/drivers/clk/clk-nomadik.c
index bad2677e11ae..71fbe687fa7b 100644
--- a/drivers/clk/clk-nomadik.c
+++ b/drivers/clk/clk-nomadik.c
@@ -99,7 +99,7 @@ static void __init nomadik_src_init(void)
if (!src_base) {
pr_err("%s: must have src parent node with REGS (%pOFn)\n",
__func__, np);
- return;
+ goto out_put;
}
/* Set all timers to use the 2.4 MHz TIMCLK */
@@ -132,6 +132,9 @@ static void __init nomadik_src_init(void)
}
writel(val, src_base + SRC_XTALCR);
register_reboot_notifier(&nomadik_clk_reboot_notifier);
+
+out_put:
+ of_node_put(np);
}
/**
--
2.25.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH v4] clk: nomadik: Add missing of_node_put()
@ 2022-06-17 1:43 ` Liang He
0 siblings, 0 replies; 6+ messages in thread
From: Liang He @ 2022-06-17 1:43 UTC (permalink / raw)
To: linus.walleij, mturquette, sboyd
Cc: windhl, linux-arm-kernel, linux-clk, linux-kernel
In nomadik_src_init(), of_find_matching_node() will return a node
pointer with refcount incremented. We should use of_node_put() in
fail path or when it is not used anymore.
Signed-off-by: Liang He <windhl@126.com>
---
changelog:
v4: split v3 into nmadik and tegra
v3: merge clk 'missing of_node_put()' patches into one commit.
v2: use Liang He as real name for S-o-b.
v1: fix the missing of_node_put().
drivers/clk/clk-nomadik.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/clk/clk-nomadik.c b/drivers/clk/clk-nomadik.c
index bad2677e11ae..71fbe687fa7b 100644
--- a/drivers/clk/clk-nomadik.c
+++ b/drivers/clk/clk-nomadik.c
@@ -99,7 +99,7 @@ static void __init nomadik_src_init(void)
if (!src_base) {
pr_err("%s: must have src parent node with REGS (%pOFn)\n",
__func__, np);
- return;
+ goto out_put;
}
/* Set all timers to use the 2.4 MHz TIMCLK */
@@ -132,6 +132,9 @@ static void __init nomadik_src_init(void)
}
writel(val, src_base + SRC_XTALCR);
register_reboot_notifier(&nomadik_clk_reboot_notifier);
+
+out_put:
+ of_node_put(np);
}
/**
--
2.25.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH v4] clk: nomadik: Add missing of_node_put()
2022-06-17 1:43 ` Liang He
@ 2022-06-27 9:26 ` Linus Walleij
-1 siblings, 0 replies; 6+ messages in thread
From: Linus Walleij @ 2022-06-27 9:26 UTC (permalink / raw)
To: Liang He; +Cc: mturquette, sboyd, linux-arm-kernel, linux-clk, linux-kernel
On Fri, Jun 17, 2022 at 3:43 AM Liang He <windhl@126.com> wrote:
> In nomadik_src_init(), of_find_matching_node() will return a node
> pointer with refcount incremented. We should use of_node_put() in
> fail path or when it is not used anymore.
>
> Signed-off-by: Liang He <windhl@126.com>
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v4] clk: nomadik: Add missing of_node_put()
@ 2022-06-27 9:26 ` Linus Walleij
0 siblings, 0 replies; 6+ messages in thread
From: Linus Walleij @ 2022-06-27 9:26 UTC (permalink / raw)
To: Liang He; +Cc: mturquette, sboyd, linux-arm-kernel, linux-clk, linux-kernel
On Fri, Jun 17, 2022 at 3:43 AM Liang He <windhl@126.com> wrote:
> In nomadik_src_init(), of_find_matching_node() will return a node
> pointer with refcount incremented. We should use of_node_put() in
> fail path or when it is not used anymore.
>
> Signed-off-by: Liang He <windhl@126.com>
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Yours,
Linus Walleij
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v4] clk: nomadik: Add missing of_node_put()
2022-06-17 1:43 ` Liang He
@ 2022-08-19 21:24 ` Stephen Boyd
-1 siblings, 0 replies; 6+ messages in thread
From: Stephen Boyd @ 2022-08-19 21:24 UTC (permalink / raw)
To: Liang He, linus.walleij, mturquette
Cc: windhl, linux-arm-kernel, linux-clk, linux-kernel
Quoting Liang He (2022-06-16 18:43:08)
> In nomadik_src_init(), of_find_matching_node() will return a node
> pointer with refcount incremented. We should use of_node_put() in
> fail path or when it is not used anymore.
>
> Signed-off-by: Liang He <windhl@126.com>
> ---
Applied to clk-next
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v4] clk: nomadik: Add missing of_node_put()
@ 2022-08-19 21:24 ` Stephen Boyd
0 siblings, 0 replies; 6+ messages in thread
From: Stephen Boyd @ 2022-08-19 21:24 UTC (permalink / raw)
To: Liang He, linus.walleij, mturquette
Cc: windhl, linux-arm-kernel, linux-clk, linux-kernel
Quoting Liang He (2022-06-16 18:43:08)
> In nomadik_src_init(), of_find_matching_node() will return a node
> pointer with refcount incremented. We should use of_node_put() in
> fail path or when it is not used anymore.
>
> Signed-off-by: Liang He <windhl@126.com>
> ---
Applied to clk-next
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2022-08-19 21:25 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-06-17 1:43 [PATCH v4] clk: nomadik: Add missing of_node_put() Liang He
2022-06-17 1:43 ` Liang He
2022-06-27 9:26 ` Linus Walleij
2022-06-27 9:26 ` Linus Walleij
2022-08-19 21:24 ` Stephen Boyd
2022-08-19 21:24 ` Stephen Boyd
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.