From: madvenka@linux.microsoft.com To: broonie@kernel.org, mark.rutland@arm.com, jpoimboe@redhat.com, ardb@kernel.org, nobuta.keiya@fujitsu.com, sjitindarsingh@gmail.com, catalin.marinas@arm.com, will@kernel.org, jamorris@linux.microsoft.com, linux-arm-kernel@lists.infradead.org, live-patching@vger.kernel.org, linux-kernel@vger.kernel.org, madvenka@linux.microsoft.com Subject: [PATCH v15 6/6] arm64: Introduce arch_stack_walk_reliable() Date: Fri, 17 Jun 2022 16:07:17 -0500 [thread overview] Message-ID: <20220617210717.27126-7-madvenka@linux.microsoft.com> (raw) In-Reply-To: <20220617210717.27126-1-madvenka@linux.microsoft.com> From: "Madhavan T. Venkataraman" <madvenka@linux.microsoft.com> Introduce arch_stack_walk_reliable() for ARM64. This works like arch_stack_walk() except that it returns -EINVAL if the stack trace is not reliable. Until all the reliability checks are in place, arch_stack_walk_reliable() may not be used by livepatch. But it may be used by debug and test code. Signed-off-by: Madhavan T. Venkataraman <madvenka@linux.microsoft.com> Reviewed-by: Mark Brown <broonie@kernel.org> --- arch/arm64/kernel/stacktrace.c | 23 +++++++++++++++++++++++ 1 file changed, 23 insertions(+) diff --git a/arch/arm64/kernel/stacktrace.c b/arch/arm64/kernel/stacktrace.c index eda8581f7dbe..8016ba0e2c96 100644 --- a/arch/arm64/kernel/stacktrace.c +++ b/arch/arm64/kernel/stacktrace.c @@ -383,3 +383,26 @@ noinline notrace void arch_stack_walk(stack_trace_consume_fn consume_entry, unwind(&state, consume_entry, cookie); } + +/* + * arch_stack_walk_reliable() may not be used for livepatch until all of + * the reliability checks are in place in unwind_consume(). However, + * debug and test code can choose to use it even if all the checks are not + * in place. + */ +noinline int notrace arch_stack_walk_reliable( + stack_trace_consume_fn consume_entry, + void *cookie, + struct task_struct *task) +{ + struct unwind_state state; + bool reliable; + + if (task == current) + unwind_init_from_caller(&state); + else + unwind_init_from_task(&state, task); + + reliable = unwind(&state, consume_entry, cookie); + return reliable ? 0 : -EINVAL; +} -- 2.25.1
WARNING: multiple messages have this Message-ID (diff)
From: madvenka@linux.microsoft.com To: broonie@kernel.org, mark.rutland@arm.com, jpoimboe@redhat.com, ardb@kernel.org, nobuta.keiya@fujitsu.com, sjitindarsingh@gmail.com, catalin.marinas@arm.com, will@kernel.org, jamorris@linux.microsoft.com, linux-arm-kernel@lists.infradead.org, live-patching@vger.kernel.org, linux-kernel@vger.kernel.org, madvenka@linux.microsoft.com Subject: [PATCH v15 6/6] arm64: Introduce arch_stack_walk_reliable() Date: Fri, 17 Jun 2022 16:07:17 -0500 [thread overview] Message-ID: <20220617210717.27126-7-madvenka@linux.microsoft.com> (raw) In-Reply-To: <20220617210717.27126-1-madvenka@linux.microsoft.com> From: "Madhavan T. Venkataraman" <madvenka@linux.microsoft.com> Introduce arch_stack_walk_reliable() for ARM64. This works like arch_stack_walk() except that it returns -EINVAL if the stack trace is not reliable. Until all the reliability checks are in place, arch_stack_walk_reliable() may not be used by livepatch. But it may be used by debug and test code. Signed-off-by: Madhavan T. Venkataraman <madvenka@linux.microsoft.com> Reviewed-by: Mark Brown <broonie@kernel.org> --- arch/arm64/kernel/stacktrace.c | 23 +++++++++++++++++++++++ 1 file changed, 23 insertions(+) diff --git a/arch/arm64/kernel/stacktrace.c b/arch/arm64/kernel/stacktrace.c index eda8581f7dbe..8016ba0e2c96 100644 --- a/arch/arm64/kernel/stacktrace.c +++ b/arch/arm64/kernel/stacktrace.c @@ -383,3 +383,26 @@ noinline notrace void arch_stack_walk(stack_trace_consume_fn consume_entry, unwind(&state, consume_entry, cookie); } + +/* + * arch_stack_walk_reliable() may not be used for livepatch until all of + * the reliability checks are in place in unwind_consume(). However, + * debug and test code can choose to use it even if all the checks are not + * in place. + */ +noinline int notrace arch_stack_walk_reliable( + stack_trace_consume_fn consume_entry, + void *cookie, + struct task_struct *task) +{ + struct unwind_state state; + bool reliable; + + if (task == current) + unwind_init_from_caller(&state); + else + unwind_init_from_task(&state, task); + + reliable = unwind(&state, consume_entry, cookie); + return reliable ? 0 : -EINVAL; +} -- 2.25.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-06-17 21:07 UTC|newest] Thread overview: 76+ messages / expand[flat|nested] mbox.gz Atom feed top [not found] <ff68fb850d42e1adaa6a0a6c9c258acabb898b24> 2022-06-17 18:02 ` [RFC PATCH v15 0/6] arm64: Reorganize the unwinder and implement stack trace reliability checks madvenka 2022-06-17 18:02 ` madvenka 2022-06-17 18:02 ` [RFC PATCH v15 1/6] arm64: Split unwind_init() madvenka 2022-06-17 18:02 ` madvenka 2022-06-17 18:02 ` [RFC PATCH v15 2/6] arm64: Copy the task argument to unwind_state madvenka 2022-06-17 18:02 ` madvenka 2022-06-17 18:02 ` [RFC PATCH v15 3/6] arm64: Make the unwind loop in unwind() similar to other architectures madvenka 2022-06-17 18:02 ` madvenka 2022-06-17 18:02 ` [RFC PATCH v15 4/6] arm64: Introduce stack trace reliability checks in the unwinder madvenka 2022-06-17 18:02 ` madvenka 2022-06-17 18:02 ` [RFC PATCH v15 5/6] arm64: Create a list of SYM_CODE functions, check return PC against list madvenka 2022-06-17 18:02 ` madvenka 2022-06-17 18:02 ` [RFC PATCH v15 6/6] arm64: Introduce arch_stack_walk_reliable() madvenka 2022-06-17 18:02 ` madvenka 2022-06-17 20:50 ` [RFC PATCH v15 0/6] arm64: Reorganize the unwinder and implement stack trace reliability checks Madhavan T. Venkataraman 2022-06-17 20:50 ` Madhavan T. Venkataraman 2022-06-27 13:00 ` Will Deacon 2022-06-27 13:00 ` Will Deacon 2022-06-27 17:06 ` Madhavan T. Venkataraman 2022-06-27 17:06 ` Madhavan T. Venkataraman 2022-06-17 21:07 ` [PATCH " madvenka 2022-06-17 21:07 ` madvenka 2022-06-17 21:07 ` [PATCH v15 1/6] arm64: Split unwind_init() madvenka 2022-06-17 21:07 ` madvenka 2022-06-26 7:39 ` Mark Rutland 2022-06-26 7:39 ` Mark Rutland 2022-06-17 21:07 ` [PATCH v15 2/6] arm64: Copy the task argument to unwind_state madvenka 2022-06-17 21:07 ` madvenka 2022-06-26 7:39 ` Mark Rutland 2022-06-26 7:39 ` Mark Rutland 2022-06-17 21:07 ` [PATCH v15 3/6] arm64: Make the unwind loop in unwind() similar to other architectures madvenka 2022-06-17 21:07 ` madvenka 2022-06-26 8:21 ` Mark Rutland 2022-06-26 8:21 ` Mark Rutland 2022-06-27 4:51 ` Madhavan T. Venkataraman 2022-06-27 4:51 ` Madhavan T. Venkataraman 2022-06-17 21:07 ` [PATCH v15 4/6] arm64: Introduce stack trace reliability checks in the unwinder madvenka 2022-06-17 21:07 ` madvenka 2022-06-26 8:32 ` Mark Rutland 2022-06-26 8:32 ` Mark Rutland 2022-06-27 5:01 ` Madhavan T. Venkataraman 2022-06-27 5:01 ` Madhavan T. Venkataraman 2022-06-17 21:07 ` [PATCH v15 5/6] arm64: Create a list of SYM_CODE functions, check return PC against list madvenka 2022-06-17 21:07 ` madvenka 2022-06-26 8:46 ` Mark Rutland 2022-06-26 8:46 ` Mark Rutland 2022-06-27 5:06 ` Madhavan T. Venkataraman 2022-06-27 5:06 ` Madhavan T. Venkataraman 2022-06-17 21:07 ` madvenka [this message] 2022-06-17 21:07 ` [PATCH v15 6/6] arm64: Introduce arch_stack_walk_reliable() madvenka 2022-06-26 8:57 ` Mark Rutland 2022-06-26 8:57 ` Mark Rutland 2022-06-27 5:53 ` Madhavan T. Venkataraman 2022-06-27 5:53 ` Madhavan T. Venkataraman 2022-06-23 17:32 ` [PATCH v15 0/6] arm64: Reorganize the unwinder and implement stack trace reliability checks Will Deacon 2022-06-23 17:32 ` Will Deacon 2022-06-24 5:19 ` Madhavan T. Venkataraman 2022-06-24 5:19 ` Madhavan T. Venkataraman 2022-06-24 5:27 ` Madhavan T. Venkataraman 2022-06-24 5:27 ` Madhavan T. Venkataraman 2022-06-26 9:18 ` Mark Rutland 2022-06-26 9:18 ` Mark Rutland 2022-06-27 4:33 ` Madhavan T. Venkataraman 2022-06-27 4:33 ` Madhavan T. Venkataraman 2022-06-27 16:32 ` Kalesh Singh 2022-06-27 16:32 ` Kalesh Singh 2022-06-27 17:04 ` Madhavan T. Venkataraman 2022-06-27 17:04 ` Madhavan T. Venkataraman 2022-06-27 4:48 ` Madhavan T. Venkataraman 2022-06-27 4:48 ` Madhavan T. Venkataraman 2022-06-27 9:42 ` Will Deacon 2022-06-27 9:42 ` Will Deacon 2022-06-24 11:42 ` Mark Brown 2022-06-24 11:42 ` Mark Brown 2022-06-24 22:15 ` Madhavan T. Venkataraman 2022-06-24 22:15 ` Madhavan T. Venkataraman
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20220617210717.27126-7-madvenka@linux.microsoft.com \ --to=madvenka@linux.microsoft.com \ --cc=ardb@kernel.org \ --cc=broonie@kernel.org \ --cc=catalin.marinas@arm.com \ --cc=jamorris@linux.microsoft.com \ --cc=jpoimboe@redhat.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=live-patching@vger.kernel.org \ --cc=mark.rutland@arm.com \ --cc=nobuta.keiya@fujitsu.com \ --cc=sjitindarsingh@gmail.com \ --cc=will@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.