From: Jonathan Cameron <jic23@kernel.org>
To: Jakob Hauser <jahau@rocketmail.com>
Cc: Lars-Peter Clausen <lars@metafoo.de>,
Linus Walleij <linus.walleij@linaro.org>,
Andy Shevchenko <andy.shevchenko@gmail.com>,
Hans de Goede <hdegoede@redhat.com>,
linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
phone-devel@vger.kernel.org,
~postmarketos/upstreaming@lists.sr.ht
Subject: Re: [PATCH v3 2/8] iio: magnetometer: yas530: Change range of data in volatile register
Date: Sat, 18 Jun 2022 15:21:37 +0100 [thread overview]
Message-ID: <20220618152137.59de13fb@jic23-huawei> (raw)
In-Reply-To: <bd9cd1d425afc07cd9939e4b41ada39a9ca350b4.1655509425.git.jahau@rocketmail.com>
On Sat, 18 Jun 2022 02:13:10 +0200
Jakob Hauser <jahau@rocketmail.com> wrote:
> In function yas5xx_volatile_reg(), the range for measure data should end at
> "YAS5XX_MEASURE_DATA + 7" instead of "+ 8" as we count from 0 to 7 here.
>
> This change is of low importance as the "+ 8" register isn't called.
>
> Cc: Linus Walleij <linus.walleij@linaro.org>
Drop the Cc now you have an RB from Linus.
> Signed-off-by: Jakob Hauser <jahau@rocketmail.com>
> Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
> Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
> ---
> drivers/iio/magnetometer/yamaha-yas530.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/iio/magnetometer/yamaha-yas530.c b/drivers/iio/magnetometer/yamaha-yas530.c
> index 40192aa46b04..2799ae0784fd 100644
> --- a/drivers/iio/magnetometer/yamaha-yas530.c
> +++ b/drivers/iio/magnetometer/yamaha-yas530.c
> @@ -527,7 +527,7 @@ static bool yas5xx_volatile_reg(struct device *dev, unsigned int reg)
> {
> return reg == YAS5XX_ACTUATE_INIT_COIL ||
> reg == YAS5XX_MEASURE ||
> - (reg >= YAS5XX_MEASURE_DATA && reg <= YAS5XX_MEASURE_DATA + 8);
> + (reg >= YAS5XX_MEASURE_DATA && reg <= YAS5XX_MEASURE_DATA + 7);
trivial, but I'd prefer it as
reg < RAS5XX_MEASURE_DATA + 8
because we have 8 registers and do bulk reads of sizeof(u8[8]) so it is more natural
to use 8 as the constant.
> }
>
> /* TODO: enable regmap cache, using mark dirty and sync at runtime resume */
next prev parent reply other threads:[~2022-06-18 14:12 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1655509425.git.jahau.ref@rocketmail.com>
2022-06-18 0:13 ` [PATCH v3 0/8] Add support for magnetometer Yamaha YAS537 Jakob Hauser
2022-06-18 0:13 ` [PATCH v3 1/8] iio: magnetometer: yas530: Change data type of hard_offsets to signed Jakob Hauser
2022-06-18 14:18 ` Jonathan Cameron
2022-06-21 0:36 ` Jakob Hauser
2022-06-18 0:13 ` [PATCH v3 2/8] iio: magnetometer: yas530: Change range of data in volatile register Jakob Hauser
2022-06-18 14:21 ` Jonathan Cameron [this message]
2022-06-21 0:39 ` Jakob Hauser
2022-06-18 0:13 ` [PATCH v3 3/8] iio: magnetometer: yas530: Correct scaling of magnetic axes Jakob Hauser
2022-06-18 0:13 ` [PATCH v3 4/8] iio: magnetometer: yas530: Correct temperature handling Jakob Hauser
2022-06-18 14:53 ` Jonathan Cameron
2022-06-21 0:48 ` Jakob Hauser
2022-06-25 14:14 ` Jonathan Cameron
2022-06-18 0:13 ` [PATCH v3 5/8] iio: magnetometer: yas530: Change data type of calibration coefficients Jakob Hauser
2022-06-18 14:56 ` Jonathan Cameron
2022-06-21 0:51 ` Jakob Hauser
2022-06-22 8:49 ` Linus Walleij
2022-06-26 7:51 ` Jakob Hauser
2022-06-18 0:13 ` [PATCH v3 6/8] iio: magnetometer: yas530: Rename functions and registers Jakob Hauser
2022-06-18 15:00 ` Jonathan Cameron
2022-06-21 0:53 ` Jakob Hauser
2022-06-21 8:51 ` Andy Shevchenko
2022-06-25 14:16 ` Jonathan Cameron
2022-06-26 8:39 ` Jakob Hauser
2022-06-18 0:13 ` [PATCH v3 7/8] iio: magnetometer: yas530: Apply minor cleanups Jakob Hauser
2022-06-18 9:53 ` Andy Shevchenko
2022-06-21 0:57 ` Jakob Hauser
2022-06-18 0:13 ` [PATCH v3 8/8] iio: magnetometer: yas530: Add YAS537 variant Jakob Hauser
2022-06-18 10:57 ` Andy Shevchenko
2022-06-21 1:10 ` Jakob Hauser
2022-06-18 15:28 ` Jonathan Cameron
2022-06-19 10:32 ` Andy Shevchenko
2022-06-19 10:58 ` Jonathan Cameron
2022-06-21 1:29 ` Jakob Hauser
2022-06-25 14:22 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220618152137.59de13fb@jic23-huawei \
--to=jic23@kernel.org \
--cc=andy.shevchenko@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=hdegoede@redhat.com \
--cc=jahau@rocketmail.com \
--cc=lars@metafoo.de \
--cc=linus.walleij@linaro.org \
--cc=linux-iio@vger.kernel.org \
--cc=phone-devel@vger.kernel.org \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.