All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] sparc: kernel: Fix refcount bug in irq_64.c
@ 2022-06-19  6:18 Liang He
  0 siblings, 0 replies; only message in thread
From: Liang He @ 2022-06-19  6:18 UTC (permalink / raw)
  To: davem, windhl, sparclinux, linux-kernel

In map_prom_timers(), of_find_node_by_path() will return
a node pointer with refcount incremented. We should use of_node_put()
when it is not used anymore.

Signed-off-by: Liang He <windhl@126.com>
---
 arch/sparc/kernel/irq_64.c | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/arch/sparc/kernel/irq_64.c b/arch/sparc/kernel/irq_64.c
index c8848bb681a1..84abfe584a08 100644
--- a/arch/sparc/kernel/irq_64.c
+++ b/arch/sparc/kernel/irq_64.c
@@ -909,12 +909,13 @@ static u64 prom_limit0, prom_limit1;
 
 static void map_prom_timers(void)
 {
-	struct device_node *dp;
+	struct device_node *dp, *tp;
 	const unsigned int *addr;
 
 	/* PROM timer node hangs out in the top level of device siblings... */
-	dp = of_find_node_by_path("/");
-	dp = dp->child;
+	tp = of_find_node_by_path("/");
+	dp = tp->child;
+	of_node_put(tp);
 	while (dp) {
 		if (of_node_name_eq(dp, "counter-timer"))
 			break;
-- 
2.25.1


^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2022-06-19  6:18 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-06-19  6:18 [PATCH] sparc: kernel: Fix refcount bug in irq_64.c Liang He

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.