* [PATCH v2] arm64: freescale/imx8mp-evk.dts: reorder nodes alphabetically
@ 2022-06-17 17:32 ` Uwe Kleine-König
0 siblings, 0 replies; 4+ messages in thread
From: Uwe Kleine-König @ 2022-06-17 17:32 UTC (permalink / raw)
To: Shawn Guo
Cc: devicetree, Rob Herring, NXP Linux Team, kernel, Fabio Estevam,
linux-arm-kernel
The nodes after the root nodes are supposed to be ordered
alphabetically. There is however an expection for &pinctrl that some
consider to be good placed at the end of the file. So only move flexcan1
and flexcan2 to their proper place.
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
---
(implicit) v1 was send a year ago and also moved pinctrl. Just stumbled
over this mail and the concerns back then that pinctrl is good at the
end. I don't fully agree, but here comes at least the non-disputed part
of the patch.
Reference: https://lore.kernel.org/linux-arm-kernel/20210707105309.1693138-1-u.kleine-koenig@pengutronix.de
Best regards
Uwe
arch/arm64/boot/dts/freescale/imx8mp-evk.dts | 28 ++++++++++----------
1 file changed, 14 insertions(+), 14 deletions(-)
diff --git a/arch/arm64/boot/dts/freescale/imx8mp-evk.dts b/arch/arm64/boot/dts/freescale/imx8mp-evk.dts
index 4c3ac4214a2c..97e91db08ae8 100644
--- a/arch/arm64/boot/dts/freescale/imx8mp-evk.dts
+++ b/arch/arm64/boot/dts/freescale/imx8mp-evk.dts
@@ -67,20 +67,6 @@ reg_usdhc2_vmmc: regulator-usdhc2 {
};
};
-&flexcan1 {
- pinctrl-names = "default";
- pinctrl-0 = <&pinctrl_flexcan1>;
- xceiver-supply = <®_can1_stby>;
- status = "okay";
-};
-
-&flexcan2 {
- pinctrl-names = "default";
- pinctrl-0 = <&pinctrl_flexcan2>;
- xceiver-supply = <®_can2_stby>;
- status = "disabled";/* can2 pin conflict with pdm */
-};
-
&eqos {
pinctrl-names = "default";
pinctrl-0 = <&pinctrl_eqos>;
@@ -197,6 +183,20 @@ ethphy1: ethernet-phy@1 {
};
};
+&flexcan1 {
+ pinctrl-names = "default";
+ pinctrl-0 = <&pinctrl_flexcan1>;
+ xceiver-supply = <®_can1_stby>;
+ status = "okay";
+};
+
+&flexcan2 {
+ pinctrl-names = "default";
+ pinctrl-0 = <&pinctrl_flexcan2>;
+ xceiver-supply = <®_can2_stby>;
+ status = "disabled";/* can2 pin conflict with pdm */
+};
+
&i2c1 {
clock-frequency = <400000>;
pinctrl-names = "default";
base-commit: b13baccc3850ca8b8cccbf8ed9912dbaa0fdf7f3
--
2.36.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH v2] arm64: freescale/imx8mp-evk.dts: reorder nodes alphabetically
@ 2022-06-17 17:32 ` Uwe Kleine-König
0 siblings, 0 replies; 4+ messages in thread
From: Uwe Kleine-König @ 2022-06-17 17:32 UTC (permalink / raw)
To: Shawn Guo
Cc: devicetree, Rob Herring, NXP Linux Team, kernel, Fabio Estevam,
linux-arm-kernel
The nodes after the root nodes are supposed to be ordered
alphabetically. There is however an expection for &pinctrl that some
consider to be good placed at the end of the file. So only move flexcan1
and flexcan2 to their proper place.
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
---
(implicit) v1 was send a year ago and also moved pinctrl. Just stumbled
over this mail and the concerns back then that pinctrl is good at the
end. I don't fully agree, but here comes at least the non-disputed part
of the patch.
Reference: https://lore.kernel.org/linux-arm-kernel/20210707105309.1693138-1-u.kleine-koenig@pengutronix.de
Best regards
Uwe
arch/arm64/boot/dts/freescale/imx8mp-evk.dts | 28 ++++++++++----------
1 file changed, 14 insertions(+), 14 deletions(-)
diff --git a/arch/arm64/boot/dts/freescale/imx8mp-evk.dts b/arch/arm64/boot/dts/freescale/imx8mp-evk.dts
index 4c3ac4214a2c..97e91db08ae8 100644
--- a/arch/arm64/boot/dts/freescale/imx8mp-evk.dts
+++ b/arch/arm64/boot/dts/freescale/imx8mp-evk.dts
@@ -67,20 +67,6 @@ reg_usdhc2_vmmc: regulator-usdhc2 {
};
};
-&flexcan1 {
- pinctrl-names = "default";
- pinctrl-0 = <&pinctrl_flexcan1>;
- xceiver-supply = <®_can1_stby>;
- status = "okay";
-};
-
-&flexcan2 {
- pinctrl-names = "default";
- pinctrl-0 = <&pinctrl_flexcan2>;
- xceiver-supply = <®_can2_stby>;
- status = "disabled";/* can2 pin conflict with pdm */
-};
-
&eqos {
pinctrl-names = "default";
pinctrl-0 = <&pinctrl_eqos>;
@@ -197,6 +183,20 @@ ethphy1: ethernet-phy@1 {
};
};
+&flexcan1 {
+ pinctrl-names = "default";
+ pinctrl-0 = <&pinctrl_flexcan1>;
+ xceiver-supply = <®_can1_stby>;
+ status = "okay";
+};
+
+&flexcan2 {
+ pinctrl-names = "default";
+ pinctrl-0 = <&pinctrl_flexcan2>;
+ xceiver-supply = <®_can2_stby>;
+ status = "disabled";/* can2 pin conflict with pdm */
+};
+
&i2c1 {
clock-frequency = <400000>;
pinctrl-names = "default";
base-commit: b13baccc3850ca8b8cccbf8ed9912dbaa0fdf7f3
--
2.36.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH v2] arm64: freescale/imx8mp-evk.dts: reorder nodes alphabetically
2022-06-17 17:32 ` Uwe Kleine-König
@ 2022-06-20 0:58 ` Shawn Guo
-1 siblings, 0 replies; 4+ messages in thread
From: Shawn Guo @ 2022-06-20 0:58 UTC (permalink / raw)
To: Uwe Kleine-König
Cc: devicetree, Rob Herring, NXP Linux Team, kernel, Fabio Estevam,
linux-arm-kernel
On Fri, Jun 17, 2022 at 07:32:54PM +0200, Uwe Kleine-König wrote:
> The nodes after the root nodes are supposed to be ordered
> alphabetically. There is however an expection for &pinctrl that some
> consider to be good placed at the end of the file. So only move flexcan1
> and flexcan2 to their proper place.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Applied, thanks!
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2] arm64: freescale/imx8mp-evk.dts: reorder nodes alphabetically
@ 2022-06-20 0:58 ` Shawn Guo
0 siblings, 0 replies; 4+ messages in thread
From: Shawn Guo @ 2022-06-20 0:58 UTC (permalink / raw)
To: Uwe Kleine-König
Cc: devicetree, Rob Herring, NXP Linux Team, kernel, Fabio Estevam,
linux-arm-kernel
On Fri, Jun 17, 2022 at 07:32:54PM +0200, Uwe Kleine-König wrote:
> The nodes after the root nodes are supposed to be ordered
> alphabetically. There is however an expection for &pinctrl that some
> consider to be good placed at the end of the file. So only move flexcan1
> and flexcan2 to their proper place.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Applied, thanks!
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-06-20 0:59 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-06-17 17:32 [PATCH v2] arm64: freescale/imx8mp-evk.dts: reorder nodes alphabetically Uwe Kleine-König
2022-06-17 17:32 ` Uwe Kleine-König
2022-06-20 0:58 ` Shawn Guo
2022-06-20 0:58 ` Shawn Guo
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.