[PATCH] clk: qcom: a53-pll: convert to use parent_data rather than parent_names

[PATCH] clk: qcom: a53-pll: convert to use parent_data rather than parent_names

[Dmitry Baryshkov]

Change a53-pll driver to use clk_parent_data rather than always looking
up the xo clock in the system clock list.

Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
---
 drivers/clk/qcom/a53-pll.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/clk/qcom/a53-pll.c b/drivers/clk/qcom/a53-pll.c
index 329d2c5356d8..f9c5e296dba2 100644
--- a/drivers/clk/qcom/a53-pll.c
+++ b/drivers/clk/qcom/a53-pll.c
@@ -127,7 +127,9 @@ static int qcom_a53pll_probe(struct platform_device *pdev)
 	if (!init.name)
 		return -ENOMEM;
 
-	init.parent_names = (const char *[]){ "xo" };
+	init.parent_data = &(const struct clk_parent_data){
+		.fw_name = "xo", .name = "xo_board",
+	};
 	init.num_parents = 1;
 	init.ops = &clk_pll_sr2_ops;
 	pll->clkr.hw.init = &init;
-- 
2.35.1

Re: [PATCH] clk: qcom: a53-pll: convert to use parent_data rather than parent_names

[Bjorn Andersson]

On Sun 19 Jun 20:06 CDT 2022, Dmitry Baryshkov wrote:

> Change a53-pll driver to use clk_parent_data rather than always looking
> up the xo clock in the system clock list.
> 
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> ---
>  drivers/clk/qcom/a53-pll.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/clk/qcom/a53-pll.c b/drivers/clk/qcom/a53-pll.c
> index 329d2c5356d8..f9c5e296dba2 100644
> --- a/drivers/clk/qcom/a53-pll.c
> +++ b/drivers/clk/qcom/a53-pll.c
> @@ -127,7 +127,9 @@ static int qcom_a53pll_probe(struct platform_device *pdev)
>  	if (!init.name)
>  		return -ENOMEM;
>  
> -	init.parent_names = (const char *[]){ "xo" };
> +	init.parent_data = &(const struct clk_parent_data){
> +		.fw_name = "xo", .name = "xo_board",

This used to look up the globally named clock "xo", now it picked up
"xo_board". If this is intentional, could you please update the commit
message to cover this part?

Thanks,
Bjorn

> +	};
>  	init.num_parents = 1;
>  	init.ops = &clk_pll_sr2_ops;
>  	pll->clkr.hw.init = &init;
> -- 
> 2.35.1
>