From: Christoph Hellwig <hch@lst.de> To: Mike Christie <michael.christie@oracle.com> Cc: linux-block@vger.kernel.org, dm-devel@redhat.com, snitzer@kernel.org, hch@lst.de, axboe@kernel.dk, martin.petersen@oracle.com, james.bottomley@hansenpartnership.com, linux-scsi@vger.kernel.org, target-devel@vger.kernel.org Subject: Re: [PATCH 08/11] scsi: target: Add block PR support to iblock. Date: Mon, 20 Jun 2022 09:18:04 +0200 [thread overview] Message-ID: <20220620071804.GH11418@lst.de> (raw) In-Reply-To: <20220603065536.5641-9-michael.christie@oracle.com> > +static sense_reason_t iblock_execute_pr_in(struct se_cmd *cmd, u8 sa, > + unsigned char *param_data) > +{ > + sense_reason_t ret; > + > + switch (sa) { > + case PRI_REPORT_CAPABILITIES: > + iblock_pr_report_caps(param_data); > + break; > + case PRI_READ_KEYS: > + ret = iblock_pr_read_keys(cmd, param_data); > + break; > + case PRI_READ_RESERVATION: > + ret = iblock_pr_read_reservation(cmd, param_data); > + break; > + case PRI_READ_FULL_STATUS: > + default: > + pr_err("Unknown PERSISTENT_RESERVE_IN SA: 0x%02x\n", sa); > + return TCM_UNSUPPORTED_SCSI_OPCODE; > + } > + > + return ret; ret is uninitialize in the iblock_pr_report_caps case. > + switch (cdb[0]) { > + case RESERVE: > + case RESERVE_10: > + case RELEASE: > + case RELEASE_10: > + /* > + * The block layer pr_ops don't support the old RESERVE/RELEASE > + * commands. > + */ > + if (dev->dev_attrib.emulate_pr && > + (dev->transport_flags & TRANSPORT_FLAG_PASSTHROUGH_PGR)) > + return TCM_UNSUPPORTED_SCSI_OPCODE; > + } Can't this check go straight int sbc_parse_cdb?
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@lst.de> To: Mike Christie <michael.christie@oracle.com> Cc: axboe@kernel.dk, james.bottomley@hansenpartnership.com, linux-scsi@vger.kernel.org, martin.petersen@oracle.com, snitzer@kernel.org, linux-block@vger.kernel.org, dm-devel@redhat.com, target-devel@vger.kernel.org, hch@lst.de Subject: Re: [dm-devel] [PATCH 08/11] scsi: target: Add block PR support to iblock. Date: Mon, 20 Jun 2022 09:18:04 +0200 [thread overview] Message-ID: <20220620071804.GH11418@lst.de> (raw) In-Reply-To: <20220603065536.5641-9-michael.christie@oracle.com> > +static sense_reason_t iblock_execute_pr_in(struct se_cmd *cmd, u8 sa, > + unsigned char *param_data) > +{ > + sense_reason_t ret; > + > + switch (sa) { > + case PRI_REPORT_CAPABILITIES: > + iblock_pr_report_caps(param_data); > + break; > + case PRI_READ_KEYS: > + ret = iblock_pr_read_keys(cmd, param_data); > + break; > + case PRI_READ_RESERVATION: > + ret = iblock_pr_read_reservation(cmd, param_data); > + break; > + case PRI_READ_FULL_STATUS: > + default: > + pr_err("Unknown PERSISTENT_RESERVE_IN SA: 0x%02x\n", sa); > + return TCM_UNSUPPORTED_SCSI_OPCODE; > + } > + > + return ret; ret is uninitialize in the iblock_pr_report_caps case. > + switch (cdb[0]) { > + case RESERVE: > + case RESERVE_10: > + case RELEASE: > + case RELEASE_10: > + /* > + * The block layer pr_ops don't support the old RESERVE/RELEASE > + * commands. > + */ > + if (dev->dev_attrib.emulate_pr && > + (dev->transport_flags & TRANSPORT_FLAG_PASSTHROUGH_PGR)) > + return TCM_UNSUPPORTED_SCSI_OPCODE; > + } Can't this check go straight int sbc_parse_cdb? -- dm-devel mailing list dm-devel@redhat.com https://listman.redhat.com/mailman/listinfo/dm-devel
next prev parent reply other threads:[~2022-06-20 7:18 UTC|newest] Thread overview: 66+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-06-03 6:55 [PATCH 0/8] Use block pr_ops in LIO Mike Christie 2022-06-03 6:55 ` [dm-devel] " Mike Christie 2022-06-03 6:55 ` [PATCH 01/11] scsi: target: Rename sbc_ops to exec_cmd_ops Mike Christie 2022-06-03 6:55 ` [dm-devel] " Mike Christie 2022-06-20 7:12 ` Christoph Hellwig 2022-06-20 7:12 ` [dm-devel] " Christoph Hellwig 2022-06-03 6:55 ` [PATCH 02/11] scsi: Rename sd_pr_command Mike Christie 2022-06-03 6:55 ` [dm-devel] " Mike Christie 2022-06-20 7:13 ` Christoph Hellwig 2022-06-20 7:13 ` [dm-devel] " Christoph Hellwig 2022-06-03 6:55 ` [PATCH 03/11] scsi: Move sd_pr_type to header to share Mike Christie 2022-06-03 6:55 ` [dm-devel] " Mike Christie 2022-06-05 3:58 ` Bart Van Assche 2022-06-05 3:58 ` [dm-devel] " Bart Van Assche 2022-06-20 7:13 ` Christoph Hellwig 2022-06-20 7:13 ` [dm-devel] " Christoph Hellwig 2022-06-03 6:55 ` [PATCH 04/11] block: Add PR callouts for read keys and reservation Mike Christie 2022-06-03 6:55 ` [dm-devel] " Mike Christie 2022-06-20 7:14 ` Christoph Hellwig 2022-06-20 7:14 ` [dm-devel] " Christoph Hellwig 2022-06-03 6:55 ` [PATCH 05/11] scsi: Add support for block PR read keys/reservation Mike Christie 2022-06-03 6:55 ` [dm-devel] " Mike Christie 2022-06-03 6:55 ` [PATCH 06/11] dm: " Mike Christie 2022-06-03 6:55 ` [dm-devel] " Mike Christie 2022-06-03 6:55 ` [PATCH 07/11] scsi: target: Allow backends to hook into PR handling Mike Christie 2022-06-03 6:55 ` [dm-devel] " Mike Christie 2022-06-20 7:15 ` Christoph Hellwig 2022-06-20 7:15 ` [dm-devel] " Christoph Hellwig 2022-06-03 6:55 ` [PATCH 08/11] scsi: target: Add block PR support to iblock Mike Christie 2022-06-03 6:55 ` [dm-devel] " Mike Christie 2022-06-20 7:18 ` Christoph Hellwig [this message] 2022-06-20 7:18 ` Christoph Hellwig 2022-06-03 6:55 ` [PATCH 09/11] block, nvme: Add error for reservation conflicts Mike Christie 2022-06-03 6:55 ` [dm-devel] " Mike Christie 2022-06-03 19:45 ` Keith Busch 2022-06-03 19:45 ` [dm-devel] " Keith Busch 2022-06-03 23:08 ` Mike Christie 2022-06-03 23:08 ` [dm-devel] " Mike Christie 2022-06-04 7:38 ` Hannes Reinecke 2022-06-04 7:38 ` [dm-devel] " Hannes Reinecke 2022-06-04 17:13 ` michael.christie 2022-06-04 17:13 ` [dm-devel] " michael.christie 2022-06-05 9:42 ` Hannes Reinecke 2022-06-05 9:42 ` [dm-devel] " Hannes Reinecke 2022-06-20 7:23 ` Christoph Hellwig 2022-06-20 7:23 ` [dm-devel] " Christoph Hellwig 2022-06-05 4:00 ` Bart Van Assche 2022-06-05 4:00 ` Bart Van Assche 2022-06-03 6:55 ` [PATCH 10/11] scsi: Use BLK_STS_RSV_CONFLICT " Mike Christie 2022-06-03 6:55 ` [dm-devel] " Mike Christie 2022-06-03 6:55 ` [PATCH 11/11] scsi: target: Handle BLK_STS_RSV_CONFLICT Mike Christie 2022-06-03 6:55 ` [dm-devel] " Mike Christie 2022-06-03 11:46 ` [PATCH 0/8] Use block pr_ops in LIO Christoph Hellwig 2022-06-03 11:46 ` [dm-devel] " Christoph Hellwig 2022-06-03 17:55 ` Mike Christie 2022-06-03 17:55 ` [dm-devel] " Mike Christie 2022-06-20 7:12 ` Christoph Hellwig 2022-06-20 7:12 ` [dm-devel] " Christoph Hellwig 2022-06-05 4:01 ` Bart Van Assche 2022-06-05 4:01 ` Bart Van Assche 2022-06-05 16:55 ` Mike Christie 2022-06-05 16:55 ` Mike Christie 2022-06-05 18:15 ` Bart Van Assche 2022-06-05 18:15 ` Bart Van Assche 2022-06-06 16:38 ` Mike Christie 2022-06-06 16:38 ` Mike Christie
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20220620071804.GH11418@lst.de \ --to=hch@lst.de \ --cc=axboe@kernel.dk \ --cc=dm-devel@redhat.com \ --cc=james.bottomley@hansenpartnership.com \ --cc=linux-block@vger.kernel.org \ --cc=linux-scsi@vger.kernel.org \ --cc=martin.petersen@oracle.com \ --cc=michael.christie@oracle.com \ --cc=snitzer@kernel.org \ --cc=target-devel@vger.kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.