All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marco Felsch <m.felsch@pengutronix.de>
To: Shengjiu Wang <shengjiu.wang@nxp.com>
Cc: robh+dt@kernel.org, shawnguo@kernel.org, s.hauer@pengutronix.de,
	kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, shengjiu.wang@gmail.com
Subject: Re: [PATCH v2 1/3] arm64: dts: imx8mm-evk: add bt-sco sound card support
Date: Mon, 20 Jun 2022 10:30:34 +0200	[thread overview]
Message-ID: <20220620083034.hy5qtfpl3hdr5van@pengutronix.de> (raw)
In-Reply-To: <1655691813-19878-2-git-send-email-shengjiu.wang@nxp.com>

Hi Shengjiu,

On 22-06-20, Shengjiu Wang wrote:
> Add bt-sco sound card, which supports wb profile as default
> 
> Signed-off-by: Shengjiu Wang <shengjiu.wang@nxp.com>
> ---
>  arch/arm64/boot/dts/freescale/imx8mm-evk.dtsi | 43 +++++++++++++++++++
>  1 file changed, 43 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/freescale/imx8mm-evk.dtsi b/arch/arm64/boot/dts/freescale/imx8mm-evk.dtsi
> index c42b966f7a64..cf734d2a94be 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mm-evk.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8mm-evk.dtsi
> @@ -75,6 +75,11 @@
>  		linux,autosuspend-period = <125>;
>  	};
>  
> +	audio_codec_bt_sco: audio-codec-bt-sco {
> +		#sound-dai-cells = <1>;
> +		compatible = "linux,bt-sco";

The compatible property should always be the first property. This
apply to your other patches as well.

Regards,
  Marco

> +	};
> +
>  	wm8524: audio-codec {
>  		#sound-dai-cells = <0>;
>  		compatible = "wlf,wm8524";
> @@ -107,6 +112,25 @@
>  			clocks = <&clk IMX8MM_CLK_SAI3_ROOT>;
>  		};
>  	};
> +
> +	sound-bt-sco {
> +		compatible = "simple-audio-card";
> +		simple-audio-card,name = "bt-sco-audio";
> +		simple-audio-card,format = "dsp_a";
> +		simple-audio-card,bitclock-inversion;
> +		simple-audio-card,frame-master = <&btcpu>;
> +		simple-audio-card,bitclock-master = <&btcpu>;
> +
> +		btcpu: simple-audio-card,cpu {
> +			sound-dai = <&sai2>;
> +			dai-tdm-slot-num = <2>;
> +			dai-tdm-slot-width = <16>;
> +		};
> +
> +		simple-audio-card,codec {
> +			sound-dai = <&audio_codec_bt_sco 1>;
> +		};
> +	};
>  };
>  
>  &A53_0 {
> @@ -346,6 +370,16 @@
>  	status = "okay";
>  };
>  
> +&sai2 {
> +	#sound-dai-cells = <0>;
> +	pinctrl-names = "default";
> +	pinctrl-0 = <&pinctrl_sai2>;
> +	assigned-clocks = <&clk IMX8MM_CLK_SAI2>;
> +	assigned-clock-parents = <&clk IMX8MM_AUDIO_PLL1_OUT>;
> +	assigned-clock-rates = <24576000>;
> +	status = "okay";
> +};
> +
>  &sai3 {
>  	pinctrl-names = "default";
>  	pinctrl-0 = <&pinctrl_sai3>;
> @@ -494,6 +528,15 @@
>  		>;
>  	};
>  
> +	pinctrl_sai2: sai2grp {
> +		fsl,pins = <
> +			MX8MM_IOMUXC_SAI2_TXC_SAI2_TX_BCLK      0xd6
> +			MX8MM_IOMUXC_SAI2_TXFS_SAI2_TX_SYNC     0xd6
> +			MX8MM_IOMUXC_SAI2_TXD0_SAI2_TX_DATA0    0xd6
> +			MX8MM_IOMUXC_SAI2_RXD0_SAI2_RX_DATA0    0xd6
> +		>;
> +	};
> +
>  	pinctrl_sai3: sai3grp {
>  		fsl,pins = <
>  			MX8MM_IOMUXC_SAI3_TXFS_SAI3_TX_SYNC     0xd6
> -- 
> 2.17.1
> 
> 
> 

WARNING: multiple messages have this Message-ID (diff)
From: Marco Felsch <m.felsch@pengutronix.de>
To: Shengjiu Wang <shengjiu.wang@nxp.com>
Cc: robh+dt@kernel.org, shawnguo@kernel.org, s.hauer@pengutronix.de,
	kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, shengjiu.wang@gmail.com
Subject: Re: [PATCH v2 1/3] arm64: dts: imx8mm-evk: add bt-sco sound card support
Date: Mon, 20 Jun 2022 10:30:34 +0200	[thread overview]
Message-ID: <20220620083034.hy5qtfpl3hdr5van@pengutronix.de> (raw)
In-Reply-To: <1655691813-19878-2-git-send-email-shengjiu.wang@nxp.com>

Hi Shengjiu,

On 22-06-20, Shengjiu Wang wrote:
> Add bt-sco sound card, which supports wb profile as default
> 
> Signed-off-by: Shengjiu Wang <shengjiu.wang@nxp.com>
> ---
>  arch/arm64/boot/dts/freescale/imx8mm-evk.dtsi | 43 +++++++++++++++++++
>  1 file changed, 43 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/freescale/imx8mm-evk.dtsi b/arch/arm64/boot/dts/freescale/imx8mm-evk.dtsi
> index c42b966f7a64..cf734d2a94be 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mm-evk.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8mm-evk.dtsi
> @@ -75,6 +75,11 @@
>  		linux,autosuspend-period = <125>;
>  	};
>  
> +	audio_codec_bt_sco: audio-codec-bt-sco {
> +		#sound-dai-cells = <1>;
> +		compatible = "linux,bt-sco";

The compatible property should always be the first property. This
apply to your other patches as well.

Regards,
  Marco

> +	};
> +
>  	wm8524: audio-codec {
>  		#sound-dai-cells = <0>;
>  		compatible = "wlf,wm8524";
> @@ -107,6 +112,25 @@
>  			clocks = <&clk IMX8MM_CLK_SAI3_ROOT>;
>  		};
>  	};
> +
> +	sound-bt-sco {
> +		compatible = "simple-audio-card";
> +		simple-audio-card,name = "bt-sco-audio";
> +		simple-audio-card,format = "dsp_a";
> +		simple-audio-card,bitclock-inversion;
> +		simple-audio-card,frame-master = <&btcpu>;
> +		simple-audio-card,bitclock-master = <&btcpu>;
> +
> +		btcpu: simple-audio-card,cpu {
> +			sound-dai = <&sai2>;
> +			dai-tdm-slot-num = <2>;
> +			dai-tdm-slot-width = <16>;
> +		};
> +
> +		simple-audio-card,codec {
> +			sound-dai = <&audio_codec_bt_sco 1>;
> +		};
> +	};
>  };
>  
>  &A53_0 {
> @@ -346,6 +370,16 @@
>  	status = "okay";
>  };
>  
> +&sai2 {
> +	#sound-dai-cells = <0>;
> +	pinctrl-names = "default";
> +	pinctrl-0 = <&pinctrl_sai2>;
> +	assigned-clocks = <&clk IMX8MM_CLK_SAI2>;
> +	assigned-clock-parents = <&clk IMX8MM_AUDIO_PLL1_OUT>;
> +	assigned-clock-rates = <24576000>;
> +	status = "okay";
> +};
> +
>  &sai3 {
>  	pinctrl-names = "default";
>  	pinctrl-0 = <&pinctrl_sai3>;
> @@ -494,6 +528,15 @@
>  		>;
>  	};
>  
> +	pinctrl_sai2: sai2grp {
> +		fsl,pins = <
> +			MX8MM_IOMUXC_SAI2_TXC_SAI2_TX_BCLK      0xd6
> +			MX8MM_IOMUXC_SAI2_TXFS_SAI2_TX_SYNC     0xd6
> +			MX8MM_IOMUXC_SAI2_TXD0_SAI2_TX_DATA0    0xd6
> +			MX8MM_IOMUXC_SAI2_RXD0_SAI2_RX_DATA0    0xd6
> +		>;
> +	};
> +
>  	pinctrl_sai3: sai3grp {
>  		fsl,pins = <
>  			MX8MM_IOMUXC_SAI3_TXFS_SAI3_TX_SYNC     0xd6
> -- 
> 2.17.1
> 
> 
> 

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2022-06-20  8:30 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-20  2:23 [PATCH v2 0/3] add bt-sco sound card support for i.MX8MQ/MM/MN Shengjiu Wang
2022-06-20  2:23 ` Shengjiu Wang
2022-06-20  2:23 ` [PATCH v2 1/3] arm64: dts: imx8mm-evk: add bt-sco sound card support Shengjiu Wang
2022-06-20  2:23   ` Shengjiu Wang
2022-06-20  8:30   ` Marco Felsch [this message]
2022-06-20  8:30     ` Marco Felsch
2022-06-20  2:23 ` [PATCH v2 2/3] arm64: dts: imx8mq-evk: " Shengjiu Wang
2022-06-20  2:23   ` Shengjiu Wang
2022-06-20  2:23 ` [PATCH v2 3/3] arm64: dts: imx8mn-evk: " Shengjiu Wang
2022-06-20  2:23   ` Shengjiu Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220620083034.hy5qtfpl3hdr5van@pengutronix.de \
    --to=m.felsch@pengutronix.de \
    --cc=devicetree@vger.kernel.org \
    --cc=festevam@gmail.com \
    --cc=kernel@pengutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-imx@nxp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    --cc=s.hauer@pengutronix.de \
    --cc=shawnguo@kernel.org \
    --cc=shengjiu.wang@gmail.com \
    --cc=shengjiu.wang@nxp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.