* [PATCH] ARM: dts: am33xx: Fix MMCHS0 dma properties
@ 2022-06-20 9:34 YuTong Chang
2022-06-20 11:21 ` Krzysztof Kozlowski
0 siblings, 1 reply; 2+ messages in thread
From: YuTong Chang @ 2022-06-20 9:34 UTC (permalink / raw)
To: bcousson
Cc: tony, robh+dt, krzysztof.kozlowski+dt, linux-omap, devicetree,
linux-kernel, YuTong Chang
According to technical manual(table 11-24),
the DMA of MMCHS0 should be direct mapped.
Signed-off-by: YuTong Chang <mtwget@gmail.com>
---
arch/arm/boot/dts/am33xx-l4.dtsi | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm/boot/dts/am33xx-l4.dtsi b/arch/arm/boot/dts/am33xx-l4.dtsi
index 7da42a5b959c..0446e2622d5f 100644
--- a/arch/arm/boot/dts/am33xx-l4.dtsi
+++ b/arch/arm/boot/dts/am33xx-l4.dtsi
@@ -1502,8 +1502,8 @@ SYSC_OMAP2_SOFTRESET |
mmc1: mmc@0 {
compatible = "ti,am335-sdhci";
ti,needs-special-reset;
- dmas = <&edma_xbar 24 0 0
- &edma_xbar 25 0 0>;
+ dmas = <&edma 24 0
+ &edma 25 0>;
dma-names = "tx", "rx";
interrupts = <64>;
reg = <0x0 0x1000>;
--
2.36.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ARM: dts: am33xx: Fix MMCHS0 dma properties
2022-06-20 9:34 [PATCH] ARM: dts: am33xx: Fix MMCHS0 dma properties YuTong Chang
@ 2022-06-20 11:21 ` Krzysztof Kozlowski
0 siblings, 0 replies; 2+ messages in thread
From: Krzysztof Kozlowski @ 2022-06-20 11:21 UTC (permalink / raw)
To: YuTong Chang, bcousson
Cc: tony, robh+dt, krzysztof.kozlowski+dt, linux-omap, devicetree,
linux-kernel
On 20/06/2022 11:34, YuTong Chang wrote:
> According to technical manual(table 11-24),
> the DMA of MMCHS0 should be direct mapped.
Please wrap the commit according to Linux coding style.
https://elixir.bootlin.com/linux/v5.18-rc4/source/Documentation/process/submitting-patches.rst#L586
>
> Signed-off-by: YuTong Chang <mtwget@gmail.com>
> ---
> arch/arm/boot/dts/am33xx-l4.dtsi | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/boot/dts/am33xx-l4.dtsi b/arch/arm/boot/dts/am33xx-l4.dtsi
> index 7da42a5b959c..0446e2622d5f 100644
> --- a/arch/arm/boot/dts/am33xx-l4.dtsi
> +++ b/arch/arm/boot/dts/am33xx-l4.dtsi
> @@ -1502,8 +1502,8 @@ SYSC_OMAP2_SOFTRESET |
> mmc1: mmc@0 {
> compatible = "ti,am335-sdhci";
> ti,needs-special-reset;
> - dmas = <&edma_xbar 24 0 0
> - &edma_xbar 25 0 0>;
> + dmas = <&edma 24 0
> + &edma 25 0>;
This is still wrong from syntax point of view - should be two phandles,
so <edma ...>, <edma ...>
> dma-names = "tx", "rx";
> interrupts = <64>;
> reg = <0x0 0x1000>;
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-06-20 11:21 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-06-20 9:34 [PATCH] ARM: dts: am33xx: Fix MMCHS0 dma properties YuTong Chang
2022-06-20 11:21 ` Krzysztof Kozlowski
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.