[PATCH 1/3] platform/x86: acer_wmi: Cleanup Kconfig selects

[PATCH 1/3] platform/x86: acer_wmi: Cleanup Kconfig selects

[Hans de Goede]

ACER_WMI already depends on ACPI_WMI which depends on ACPI
so the "depends on ACPI" is unnecessary.

And since ACER_WMI already depends on ACPI adding an "if ACPI"
to the ACPI_VIDEO select is non-sense.

While at it also group all the selects together.

Signed-off-by: Hans de Goede <hdegoede@redhat.com>
---
 drivers/platform/x86/Kconfig | 8 +++-----
 1 file changed, 3 insertions(+), 5 deletions(-)

diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig
index 08852a1cd51d..6e22ac916f7a 100644
--- a/drivers/platform/x86/Kconfig
+++ b/drivers/platform/x86/Kconfig
@@ -177,17 +177,15 @@ config ACER_WIRELESS
 
 config ACER_WMI
 	tristate "Acer WMI Laptop Extras"
-	depends on ACPI
-	select LEDS_CLASS
-	select NEW_LEDS
 	depends on BACKLIGHT_CLASS_DEVICE
 	depends on SERIO_I8042
 	depends on INPUT
 	depends on RFKILL || RFKILL = n
 	depends on ACPI_WMI
+	select ACPI_VIDEO
 	select INPUT_SPARSEKMAP
-	# Acer WMI depends on ACPI_VIDEO when ACPI is enabled
-        select ACPI_VIDEO if ACPI
+	select LEDS_CLASS
+	select NEW_LEDS
 	help
 	  This is a driver for newer Acer (and Wistron) laptops. It adds
 	  wireless radio and bluetooth control, and on some laptops,
-- 
2.36.0

[PATCH 2/3] platform/x86: Kconfig: Remove unnecessary "depends on X86"

[Hans de Goede]

The sourcing of drivers/platform/x86/Kconfig is protected by
a "if X86", so the "depends on X86" for X86_PLATFORM_DEVICES
is unnecessary, remove it.

Signed-off-by: Hans de Goede <hdegoede@redhat.com>
---
 drivers/platform/x86/Kconfig | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig
index 6e22ac916f7a..0f723c34a637 100644
--- a/drivers/platform/x86/Kconfig
+++ b/drivers/platform/x86/Kconfig
@@ -6,7 +6,6 @@
 menuconfig X86_PLATFORM_DEVICES
 	bool "X86 Platform Specific Device Drivers"
 	default y
-	depends on X86
 	help
 	  Say Y here to get to see options for device drivers for various
 	  x86 platforms, including vendor-specific laptop extension drivers.
-- 
2.36.0

[PATCH 3/3] platform/x86/dell: Kconfig: Remove unnecessary "depends on X86_PLATFORM_DEVICES"

[Hans de Goede]

platform/x86/dell/Kconfig is only sourced if X86_PLATFORM_DEVICES is set,
so it does not need to depend on it.

Signed-off-by: Hans de Goede <hdegoede@redhat.com>
---
 drivers/platform/x86/dell/Kconfig | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/platform/x86/dell/Kconfig b/drivers/platform/x86/dell/Kconfig
index fe224a54f24c..25421e061c47 100644
--- a/drivers/platform/x86/dell/Kconfig
+++ b/drivers/platform/x86/dell/Kconfig
@@ -5,7 +5,6 @@
 
 menuconfig X86_PLATFORM_DRIVERS_DELL
 	bool "Dell X86 Platform Specific Device Drivers"
-	depends on X86_PLATFORM_DEVICES
 	help
 	  Say Y here to get to see options for device drivers for various
 	  Dell x86 platforms, including vendor-specific laptop extension drivers.
-- 
2.36.0

Re: [PATCH 2/3] platform/x86: Kconfig: Remove unnecessary "depends on X86"

[Andy Shevchenko]

On Mon, Jun 20, 2022 at 11:36 AM Hans de Goede <hdegoede@redhat.com> wrote:
>
> The sourcing of drivers/platform/x86/Kconfig is protected by
> a "if X86", so the "depends on X86" for X86_PLATFORM_DEVICES
> is unnecessary, remove it.

Looking into the upper Kconfig, I would rather go and drop dependency
there to be consistent with the rest of drivers/platform/ cases.
Perhaps it needs to be done separately for MIPS.

-- 
With Best Regards,
Andy Shevchenko

Re: [PATCH 1/3] platform/x86: acer_wmi: Cleanup Kconfig selects

[Andy Shevchenko]

On Mon, Jun 20, 2022 at 11:36 AM Hans de Goede <hdegoede@redhat.com> wrote:
>
> ACER_WMI already depends on ACPI_WMI which depends on ACPI
> so the "depends on ACPI" is unnecessary.
>
> And since ACER_WMI already depends on ACPI adding an "if ACPI"
> to the ACPI_VIDEO select is non-sense.

nonsense

> While at it also group all the selects together.


Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>

> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
> ---
>  drivers/platform/x86/Kconfig | 8 +++-----
>  1 file changed, 3 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig
> index 08852a1cd51d..6e22ac916f7a 100644
> --- a/drivers/platform/x86/Kconfig
> +++ b/drivers/platform/x86/Kconfig
> @@ -177,17 +177,15 @@ config ACER_WIRELESS
>
>  config ACER_WMI
>         tristate "Acer WMI Laptop Extras"
> -       depends on ACPI
> -       select LEDS_CLASS
> -       select NEW_LEDS
>         depends on BACKLIGHT_CLASS_DEVICE
>         depends on SERIO_I8042
>         depends on INPUT
>         depends on RFKILL || RFKILL = n
>         depends on ACPI_WMI
> +       select ACPI_VIDEO
>         select INPUT_SPARSEKMAP
> -       # Acer WMI depends on ACPI_VIDEO when ACPI is enabled
> -        select ACPI_VIDEO if ACPI
> +       select LEDS_CLASS
> +       select NEW_LEDS
>         help
>           This is a driver for newer Acer (and Wistron) laptops. It adds
>           wireless radio and bluetooth control, and on some laptops,
> --
> 2.36.0
>


-- 
With Best Regards,
Andy Shevchenko

Re: [PATCH 3/3] platform/x86/dell: Kconfig: Remove unnecessary "depends on X86_PLATFORM_DEVICES"

[Andy Shevchenko]

On Mon, Jun 20, 2022 at 11:36 AM Hans de Goede <hdegoede@redhat.com> wrote:
>
> platform/x86/dell/Kconfig is only sourced if X86_PLATFORM_DEVICES is set,
> so it does not need to depend on it.

Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>

> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
> ---
>  drivers/platform/x86/dell/Kconfig | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/drivers/platform/x86/dell/Kconfig b/drivers/platform/x86/dell/Kconfig
> index fe224a54f24c..25421e061c47 100644
> --- a/drivers/platform/x86/dell/Kconfig
> +++ b/drivers/platform/x86/dell/Kconfig
> @@ -5,7 +5,6 @@
>
>  menuconfig X86_PLATFORM_DRIVERS_DELL
>         bool "Dell X86 Platform Specific Device Drivers"
> -       depends on X86_PLATFORM_DEVICES
>         help
>           Say Y here to get to see options for device drivers for various
>           Dell x86 platforms, including vendor-specific laptop extension drivers.
> --
> 2.36.0
>


-- 
With Best Regards,
Andy Shevchenko

Re: [PATCH 2/3] platform/x86: Kconfig: Remove unnecessary "depends on X86"

[Hans de Goede]

Hi,

On 6/20/22 12:21, Andy Shevchenko wrote:
> On Mon, Jun 20, 2022 at 11:36 AM Hans de Goede <hdegoede@redhat.com> wrote:
>>
>> The sourcing of drivers/platform/x86/Kconfig is protected by
>> a "if X86", so the "depends on X86" for X86_PLATFORM_DEVICES
>> is unnecessary, remove it.
> 
> Looking into the upper Kconfig, I would rather go and drop dependency
> there to be consistent with the rest of drivers/platform/ cases.

I did consider doing things this way myself too :)

I'll go and prep a v2 of the series with this changed.

> Perhaps it needs to be done separately for MIPS.

That would make everything consistent, but I'll leave doing this
to someone else.

Regards,

Hans