* [PATCH -next] selinux: Cleanup the enum SEL_COMPAT_NET
@ 2022-06-21 6:38 Xiu Jianfeng
2022-06-21 15:30 ` Paul Moore
0 siblings, 1 reply; 2+ messages in thread
From: Xiu Jianfeng @ 2022-06-21 6:38 UTC (permalink / raw)
To: paul, stephen.smalley.work, eparis; +Cc: selinux, linux-kernel
The "compat_net" compatibility code has been removed since commit
58bfbb51ff2b ("selinux: Remove the "compat_net" compatibility code"),
so SEL_COMPAT_NET need to be removed as well.
Signed-off-by: Xiu Jianfeng <xiujianfeng@huawei.com>
---
security/selinux/selinuxfs.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/security/selinux/selinuxfs.c b/security/selinux/selinuxfs.c
index 8fcdd494af27..7115ca91ec05 100644
--- a/security/selinux/selinuxfs.c
+++ b/security/selinux/selinuxfs.c
@@ -58,7 +58,6 @@ enum sel_inos {
SEL_DISABLE, /* disable SELinux until next reboot */
SEL_MEMBER, /* compute polyinstantiation membership decision */
SEL_CHECKREQPROT, /* check requested protection, not kernel-applied one */
- SEL_COMPAT_NET, /* whether to use old compat network packet controls */
SEL_REJECT_UNKNOWN, /* export unknown reject handling to userspace */
SEL_DENY_UNKNOWN, /* export unknown deny handling to userspace */
SEL_STATUS, /* export current status using mmap() */
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH -next] selinux: Cleanup the enum SEL_COMPAT_NET
2022-06-21 6:38 [PATCH -next] selinux: Cleanup the enum SEL_COMPAT_NET Xiu Jianfeng
@ 2022-06-21 15:30 ` Paul Moore
0 siblings, 0 replies; 2+ messages in thread
From: Paul Moore @ 2022-06-21 15:30 UTC (permalink / raw)
To: Xiu Jianfeng; +Cc: stephen.smalley.work, eparis, selinux, linux-kernel
On Tue, Jun 21, 2022 at 2:40 AM Xiu Jianfeng <xiujianfeng@huawei.com> wrote:
>
> The "compat_net" compatibility code has been removed since commit
> 58bfbb51ff2b ("selinux: Remove the "compat_net" compatibility code"),
> so SEL_COMPAT_NET need to be removed as well.
>
> Signed-off-by: Xiu Jianfeng <xiujianfeng@huawei.com>
> ---
> security/selinux/selinuxfs.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/security/selinux/selinuxfs.c b/security/selinux/selinuxfs.c
> index 8fcdd494af27..7115ca91ec05 100644
> --- a/security/selinux/selinuxfs.c
> +++ b/security/selinux/selinuxfs.c
> @@ -58,7 +58,6 @@ enum sel_inos {
> SEL_DISABLE, /* disable SELinux until next reboot */
> SEL_MEMBER, /* compute polyinstantiation membership decision */
> SEL_CHECKREQPROT, /* check requested protection, not kernel-applied one */
> - SEL_COMPAT_NET, /* whether to use old compat network packet controls */
> SEL_REJECT_UNKNOWN, /* export unknown reject handling to userspace */
> SEL_DENY_UNKNOWN, /* export unknown deny handling to userspace */
> SEL_STATUS, /* export current status using mmap() */
Thanks for the patch, but keeping the old enum value is harmless
considering the size of sel_inos and I would rather see it preserved
just on the odd chance that some userspace tool is relying on specific
inode values.
--
paul-moore.com
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-06-21 15:31 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-06-21 6:38 [PATCH -next] selinux: Cleanup the enum SEL_COMPAT_NET Xiu Jianfeng
2022-06-21 15:30 ` Paul Moore
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.