* [PATCH] iio: aligned '*' each line
@ 2022-06-21 6:43 Jiang Jian
2022-06-21 8:56 ` Andy Shevchenko
0 siblings, 1 reply; 2+ messages in thread
From: Jiang Jian @ 2022-06-21 6:43 UTC (permalink / raw)
To: jic23; +Cc: lars, Michael.Hennerich, linux-iio, linux-kernel, jiangjian
Consider '*' alignment in comments
Signed-off-by: Jiang Jian <jiangjian@cdjrlc.com>
---
drivers/iio/dac/ad5380.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/iio/dac/ad5380.c b/drivers/iio/dac/ad5380.c
index a44c83242fb1..f8291cb013ce 100644
--- a/drivers/iio/dac/ad5380.c
+++ b/drivers/iio/dac/ad5380.c
@@ -36,7 +36,7 @@
* @channel_template: channel specification template
* @num_channels: number of channels
* @int_vref: internal vref in uV
-*/
+ */
struct ad5380_chip_info {
struct iio_chan_spec channel_template;
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] iio: aligned '*' each line
2022-06-21 6:43 [PATCH] iio: aligned '*' each line Jiang Jian
@ 2022-06-21 8:56 ` Andy Shevchenko
0 siblings, 0 replies; 2+ messages in thread
From: Andy Shevchenko @ 2022-06-21 8:56 UTC (permalink / raw)
To: Jiang Jian
Cc: Jonathan Cameron, Lars-Peter Clausen, Michael Hennerich,
linux-iio, Linux Kernel Mailing List
On Tue, Jun 21, 2022 at 8:57 AM Jiang Jian <jiangjian@cdjrlc.com> wrote:
>
> Consider '*' alignment in comments
Subject should start with "iio: dac: ad5380: ..."
The commit message should follow English grammar (missed period in
your case) and explain a little bit more, e.g. "Consider '*' alignment
in the comments of struct ad5380_chip_info declaration".
...
> * @channel_template: channel specification template
> * @num_channels: number of channels
> * @int_vref: internal vref in uV
> -*/
> + */
>
While at it, drop the unneeded blank line here.
> struct ad5380_chip_info {
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-06-21 8:57 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-06-21 6:43 [PATCH] iio: aligned '*' each line Jiang Jian
2022-06-21 8:56 ` Andy Shevchenko
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.