[igt-dev] [PATCH i-g-t v1] tests/kms_writeback: Detach pipe only for valid FB_ID

[igt-dev] [PATCH i-g-t v1] tests/kms_writeback: Detach pipe only for valid FB_ID

[Jessica Zhang]

Currently, the writeback DRM driver will accept a commit on the
writeback connector only if a valid FB_ID is presented. When we run
the "writeback-invalid-parameters" or "writeback-format-pixels" subtests
individually, this will not be true because no successful commit has
happened. So there is no need to clean up the pipes in detach_crtc.

Only issue a NULL commit if FB_ID is greater than zero. This will make
sure that a cleanup happens only when necessary.

Signed-off-by: Jessica Zhang <quic_jesszhan@quicinc.com>
---
 tests/kms_writeback.c | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/tests/kms_writeback.c b/tests/kms_writeback.c
index d5e86df7b0ae..bdfbd227f7c4 100644
--- a/tests/kms_writeback.c
+++ b/tests/kms_writeback.c
@@ -167,8 +167,15 @@ static igt_output_t *kms_writeback_get_output(igt_display_t *display)
 	return NULL;
 }
 
-static void detach_crtc(igt_display_t *display, igt_output_t *output)
+static uint64_t get_writeback_fb_id(igt_output_t *output)
 {
+	return igt_output_get_prop(output, IGT_CONNECTOR_WRITEBACK_FB_ID);
+}
+
+static void detach_crtc(igt_display_t *display, igt_output_t *output) {
+	if (get_writeback_fb_id(output) == 0)
+		return;
+
 	igt_output_set_pipe(output, PIPE_NONE);
 	igt_display_commit2(display, COMMIT_ATOMIC);
 }
-- 
2.35.1

[igt-dev] ✗ Fi.CI.BUILD: failure for tests/kms_writeback: Detach pipe only for valid FB_ID

[Patchwork]

== Series Details ==

Series: tests/kms_writeback: Detach pipe only for valid FB_ID
URL   : https://patchwork.freedesktop.org/series/105450/
State : failure

== Summary ==

Applying: tests/kms_writeback: Detach pipe only for valid FB_ID
Patch failed at 0001 tests/kms_writeback: Detach pipe only for valid FB_ID
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".