[PATCH v2] mips: lantiq: Add missing of_node_put() in irq.c

[PATCH v2] mips: lantiq: Add missing of_node_put() in irq.c

[Liang He]

In icu_of_init(), of_find_compatible_node() will return a node
pointer with refcount incremented. We should use of_node_put()
when it is not used anymore.

Signed-off-by: Liang He <windhl@126.com>
---
 changelog:

 v2: fix bug intro-ed by v1, only one put needed.
 v1: add missing of_node_put()

 arch/mips/lantiq/irq.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/mips/lantiq/irq.c b/arch/mips/lantiq/irq.c
index b732495f138a..20622bf0a9b3 100644
--- a/arch/mips/lantiq/irq.c
+++ b/arch/mips/lantiq/irq.c
@@ -408,6 +408,7 @@ int __init icu_of_init(struct device_node *node, struct device_node *parent)
 		if (!ltq_eiu_membase)
 			panic("Failed to remap eiu memory");
 	}
+	of_node_put(eiu_node);
 
 	return 0;
 }
-- 
2.25.1

Re: [PATCH v2] mips: lantiq: Add missing of_node_put() in irq.c

[Thomas Bogendoerfer]

On Tue, Jun 21, 2022 at 11:41:25PM +0800, Liang He wrote:
> In icu_of_init(), of_find_compatible_node() will return a node
> pointer with refcount incremented. We should use of_node_put()
> when it is not used anymore.
> 
> Signed-off-by: Liang He <windhl@126.com>
> ---
>  changelog:
> 
>  v2: fix bug intro-ed by v1, only one put needed.
>  v1: add missing of_node_put()
> 
>  arch/mips/lantiq/irq.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/mips/lantiq/irq.c b/arch/mips/lantiq/irq.c
> index b732495f138a..20622bf0a9b3 100644
> --- a/arch/mips/lantiq/irq.c
> +++ b/arch/mips/lantiq/irq.c
> @@ -408,6 +408,7 @@ int __init icu_of_init(struct device_node *node, struct device_node *parent)
>  		if (!ltq_eiu_membase)
>  			panic("Failed to remap eiu memory");
>  	}
> +	of_node_put(eiu_node);
>  
>  	return 0;
>  }
> -- 
> 2.25.1

applied to mips-fixes.

Thomas.

-- 
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea.                                                [ RFC1925, 2.3 ]