* [PATCH v3] nvme: Fix CRMS masks for TP4084 - Time-to-ready
[not found] <CGME20220621070724eucas1p186a9c118c37b140e60c2d1f8cacf636a@eucas1p1.samsung.com>
@ 2022-06-21 7:05 ` Joel Granados
2022-06-21 15:42 ` Chaitanya Kulkarni
` (3 more replies)
0 siblings, 4 replies; 6+ messages in thread
From: Joel Granados @ 2022-06-21 7:05 UTC (permalink / raw)
To: hch, kbusch; +Cc: gost.dev, linux-nvme, joshi.k, Joel Granados
Adjust the values of NVME_CAP_CRMS_CRIMS and NVME_CAP_CRMS_CRWMS masks as
they are different from the ones in TP4084 - Time-to-ready.
Fixes: 354201c53e61 ("nvme: add support for TP4084 - Time-to-Ready Enhancements").
Signed-off-by: Joel Granados <j.granados@samsung.com>
---
include/linux/nvme.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/include/linux/nvme.h b/include/linux/nvme.h
index 29ec3e3481ff..e3934003f239 100644
--- a/include/linux/nvme.h
+++ b/include/linux/nvme.h
@@ -233,8 +233,8 @@ enum {
};
enum {
- NVME_CAP_CRMS_CRIMS = 1ULL << 59,
- NVME_CAP_CRMS_CRWMS = 1ULL << 60,
+ NVME_CAP_CRMS_CRWMS = 1ULL << 59,
+ NVME_CAP_CRMS_CRIMS = 1ULL << 60,
};
struct nvme_id_power_state {
--
2.30.2
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH v3] nvme: Fix CRMS masks for TP4084 - Time-to-ready
2022-06-21 7:05 ` [PATCH v3] nvme: Fix CRMS masks for TP4084 - Time-to-ready Joel Granados
@ 2022-06-21 15:42 ` Chaitanya Kulkarni
2022-06-21 16:01 ` Keith Busch
` (2 subsequent siblings)
3 siblings, 0 replies; 6+ messages in thread
From: Chaitanya Kulkarni @ 2022-06-21 15:42 UTC (permalink / raw)
To: Joel Granados, hch, kbusch; +Cc: gost.dev, linux-nvme, joshi.k
On 6/21/22 00:05, Joel Granados wrote:
> Adjust the values of NVME_CAP_CRMS_CRIMS and NVME_CAP_CRMS_CRWMS masks as
> they are different from the ones in TP4084 - Time-to-ready.
>
> Fixes: 354201c53e61 ("nvme: add support for TP4084 - Time-to-Ready Enhancements").
>
> Signed-off-by: Joel Granados <j.granados@samsung.com>
> ---
Looks good.
Reviewed-by: Chaitanya Kulkarni <kch@nvidia.com>
-ck
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v3] nvme: Fix CRMS masks for TP4084 - Time-to-ready
2022-06-21 7:05 ` [PATCH v3] nvme: Fix CRMS masks for TP4084 - Time-to-ready Joel Granados
2022-06-21 15:42 ` Chaitanya Kulkarni
@ 2022-06-21 16:01 ` Keith Busch
2022-06-22 8:16 ` Chaitanya Kulkarni
2022-06-21 21:23 ` Sagi Grimberg
2022-06-22 10:25 ` Christoph Hellwig
3 siblings, 1 reply; 6+ messages in thread
From: Keith Busch @ 2022-06-21 16:01 UTC (permalink / raw)
To: Joel Granados; +Cc: hch, gost.dev, linux-nvme, joshi.k
On Tue, Jun 21, 2022 at 09:05:00AM +0200, Joel Granados wrote:
> Adjust the values of NVME_CAP_CRMS_CRIMS and NVME_CAP_CRMS_CRWMS masks as
> they are different from the ones in TP4084 - Time-to-ready.
>
> Fixes: 354201c53e61 ("nvme: add support for TP4084 - Time-to-Ready Enhancements").
>
> Signed-off-by: Joel Granados <j.granados@samsung.com>
Looks good.
Reviewed-by: Keith Busch <kbusch@kernel.org>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v3] nvme: Fix CRMS masks for TP4084 - Time-to-ready
2022-06-21 7:05 ` [PATCH v3] nvme: Fix CRMS masks for TP4084 - Time-to-ready Joel Granados
2022-06-21 15:42 ` Chaitanya Kulkarni
2022-06-21 16:01 ` Keith Busch
@ 2022-06-21 21:23 ` Sagi Grimberg
2022-06-22 10:25 ` Christoph Hellwig
3 siblings, 0 replies; 6+ messages in thread
From: Sagi Grimberg @ 2022-06-21 21:23 UTC (permalink / raw)
To: Joel Granados, hch, kbusch; +Cc: gost.dev, linux-nvme, joshi.k
Reviewed-by: Sagi Grimberg <sagi@grimberg.me>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v3] nvme: Fix CRMS masks for TP4084 - Time-to-ready
2022-06-21 16:01 ` Keith Busch
@ 2022-06-22 8:16 ` Chaitanya Kulkarni
0 siblings, 0 replies; 6+ messages in thread
From: Chaitanya Kulkarni @ 2022-06-22 8:16 UTC (permalink / raw)
To: Keith Busch, Joel Granados; +Cc: hch, gost.dev, linux-nvme, joshi.k
On 6/21/2022 9:01 AM, Keith Busch wrote:
> On Tue, Jun 21, 2022 at 09:05:00AM +0200, Joel Granados wrote:
>> Adjust the values of NVME_CAP_CRMS_CRIMS and NVME_CAP_CRMS_CRWMS masks as
>> they are different from the ones in TP4084 - Time-to-ready.
>>
>> Fixes: 354201c53e61 ("nvme: add support for TP4084 - Time-to-Ready Enhancements").
>>
>> Signed-off-by: Joel Granados <j.granados@samsung.com>
>
> Looks good.
>
> Reviewed-by: Keith Busch <kbusch@kernel.org>
>
This seems to address previous comments with rearranging the enum
values in increasing order.
Reviewed-by: Chaitanya Kulkarni <kch@nvidia.com>
-ck
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v3] nvme: Fix CRMS masks for TP4084 - Time-to-ready
2022-06-21 7:05 ` [PATCH v3] nvme: Fix CRMS masks for TP4084 - Time-to-ready Joel Granados
` (2 preceding siblings ...)
2022-06-21 21:23 ` Sagi Grimberg
@ 2022-06-22 10:25 ` Christoph Hellwig
3 siblings, 0 replies; 6+ messages in thread
From: Christoph Hellwig @ 2022-06-22 10:25 UTC (permalink / raw)
To: Joel Granados; +Cc: hch, kbusch, gost.dev, linux-nvme, joshi.k
Thanks,
applied to nvme-5.19.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2022-06-22 10:26 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <CGME20220621070724eucas1p186a9c118c37b140e60c2d1f8cacf636a@eucas1p1.samsung.com>
2022-06-21 7:05 ` [PATCH v3] nvme: Fix CRMS masks for TP4084 - Time-to-ready Joel Granados
2022-06-21 15:42 ` Chaitanya Kulkarni
2022-06-21 16:01 ` Keith Busch
2022-06-22 8:16 ` Chaitanya Kulkarni
2022-06-21 21:23 ` Sagi Grimberg
2022-06-22 10:25 ` Christoph Hellwig
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.