* [PATCH RESEND] usb: gadget: f_mass_storage: Make CD-ROM emulation works with Windows OS
@ 2022-06-23 3:04 Neal Liu
2022-06-23 7:52 ` Greg Kroah-Hartman
2022-06-23 14:48 ` Alan Stern
0 siblings, 2 replies; 5+ messages in thread
From: Neal Liu @ 2022-06-23 3:04 UTC (permalink / raw)
To: Felipe Balbi, Greg Kroah-Hartman, Alan Stern
Cc: Roger Quadros, Miaohe Lin, Wesley Cheng, Eric W . Biederman,
Matthew Wilcox, Nikita Yushchenko, Cai Huoqing, linux-usb,
linux-kernel, BMC-SW
Add read TOC with format 2 to support CD-ROM emulation with
Windows OS.
This patch is tested on Windows OS Server 2019.
Signed-off-by: Neal Liu <neal_liu@aspeedtech.com>
---
drivers/usb/gadget/function/f_mass_storage.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/usb/gadget/function/f_mass_storage.c b/drivers/usb/gadget/function/f_mass_storage.c
index 3a77bca0ebe1..3c2a5f1e8b66 100644
--- a/drivers/usb/gadget/function/f_mass_storage.c
+++ b/drivers/usb/gadget/function/f_mass_storage.c
@@ -1209,6 +1209,7 @@ static int do_read_toc(struct fsg_common *common, struct fsg_buffhd *bh)
switch (format) {
case 0:
+ case 1:
/* Formatted TOC */
len = 4 + 2*8; /* 4 byte header + 2 descriptors */
memset(buf, 0, len);
--
2.25.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH RESEND] usb: gadget: f_mass_storage: Make CD-ROM emulation works with Windows OS
2022-06-23 3:04 [PATCH RESEND] usb: gadget: f_mass_storage: Make CD-ROM emulation works with Windows OS Neal Liu
@ 2022-06-23 7:52 ` Greg Kroah-Hartman
2022-06-23 8:43 ` Neal Liu
2022-06-23 14:48 ` Alan Stern
1 sibling, 1 reply; 5+ messages in thread
From: Greg Kroah-Hartman @ 2022-06-23 7:52 UTC (permalink / raw)
To: Neal Liu
Cc: Felipe Balbi, Alan Stern, Roger Quadros, Miaohe Lin,
Wesley Cheng, Eric W . Biederman, Matthew Wilcox,
Nikita Yushchenko, Cai Huoqing, linux-usb, linux-kernel, BMC-SW
On Thu, Jun 23, 2022 at 11:04:05AM +0800, Neal Liu wrote:
> Add read TOC with format 2 to support CD-ROM emulation with
> Windows OS.
> This patch is tested on Windows OS Server 2019.
>
> Signed-off-by: Neal Liu <neal_liu@aspeedtech.com>
> ---
> drivers/usb/gadget/function/f_mass_storage.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/usb/gadget/function/f_mass_storage.c b/drivers/usb/gadget/function/f_mass_storage.c
> index 3a77bca0ebe1..3c2a5f1e8b66 100644
> --- a/drivers/usb/gadget/function/f_mass_storage.c
> +++ b/drivers/usb/gadget/function/f_mass_storage.c
> @@ -1209,6 +1209,7 @@ static int do_read_toc(struct fsg_common *common, struct fsg_buffhd *bh)
>
> switch (format) {
> case 0:
> + case 1:
> /* Formatted TOC */
> len = 4 + 2*8; /* 4 byte header + 2 descriptors */
> memset(buf, 0, len);
> --
> 2.25.1
>
Why was this a "RESEND"? Always put the reason why below the --- line
so we know what is going on...
thanks,
greg k-h
^ permalink raw reply [flat|nested] 5+ messages in thread
* RE: [PATCH RESEND] usb: gadget: f_mass_storage: Make CD-ROM emulation works with Windows OS
2022-06-23 7:52 ` Greg Kroah-Hartman
@ 2022-06-23 8:43 ` Neal Liu
0 siblings, 0 replies; 5+ messages in thread
From: Neal Liu @ 2022-06-23 8:43 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: Felipe Balbi, Alan Stern, Roger Quadros, Miaohe Lin,
Wesley Cheng, Eric W . Biederman, Matthew Wilcox,
Nikita Yushchenko, Cai Huoqing, linux-usb, linux-kernel, BMC-SW
> On Thu, Jun 23, 2022 at 11:04:05AM +0800, Neal Liu wrote:
> > Add read TOC with format 2 to support CD-ROM emulation with Windows
> > OS.
> > This patch is tested on Windows OS Server 2019.
> >
> > Signed-off-by: Neal Liu <neal_liu@aspeedtech.com>
> > ---
Reason for resend: mail recipient is broken. Resend it correctly.
---
> > drivers/usb/gadget/function/f_mass_storage.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/usb/gadget/function/f_mass_storage.c
> > b/drivers/usb/gadget/function/f_mass_storage.c
> > index 3a77bca0ebe1..3c2a5f1e8b66 100644
> > --- a/drivers/usb/gadget/function/f_mass_storage.c
> > +++ b/drivers/usb/gadget/function/f_mass_storage.c
> > @@ -1209,6 +1209,7 @@ static int do_read_toc(struct fsg_common
> > *common, struct fsg_buffhd *bh)
> >
> > switch (format) {
> > case 0:
> > + case 1:
> > /* Formatted TOC */
> > len = 4 + 2*8; /* 4 byte header + 2 descriptors */
> > memset(buf, 0, len);
> > --
> > 2.25.1
> >
>
> Why was this a "RESEND"? Always put the reason why below the --- line
> so we know what is going on...
>
Add reason above, thanks.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH RESEND] usb: gadget: f_mass_storage: Make CD-ROM emulation works with Windows OS
2022-06-23 3:04 [PATCH RESEND] usb: gadget: f_mass_storage: Make CD-ROM emulation works with Windows OS Neal Liu
2022-06-23 7:52 ` Greg Kroah-Hartman
@ 2022-06-23 14:48 ` Alan Stern
2022-06-24 2:11 ` Neal Liu
1 sibling, 1 reply; 5+ messages in thread
From: Alan Stern @ 2022-06-23 14:48 UTC (permalink / raw)
To: Neal Liu
Cc: Felipe Balbi, Greg Kroah-Hartman, Roger Quadros, Miaohe Lin,
Wesley Cheng, Eric W . Biederman, Matthew Wilcox,
Nikita Yushchenko, Cai Huoqing, linux-usb, linux-kernel, BMC-SW
On Thu, Jun 23, 2022 at 11:04:05AM +0800, Neal Liu wrote:
> Add read TOC with format 2 to support CD-ROM emulation with
> Windows OS.
> This patch is tested on Windows OS Server 2019.
This description says "format 2", but the patch actually adds code for
the case where format is 1. This sort of mistake is not acceptable.
> Signed-off-by: Neal Liu <neal_liu@aspeedtech.com>
> ---
> drivers/usb/gadget/function/f_mass_storage.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/usb/gadget/function/f_mass_storage.c b/drivers/usb/gadget/function/f_mass_storage.c
> index 3a77bca0ebe1..3c2a5f1e8b66 100644
> --- a/drivers/usb/gadget/function/f_mass_storage.c
> +++ b/drivers/usb/gadget/function/f_mass_storage.c
> @@ -1209,6 +1209,7 @@ static int do_read_toc(struct fsg_common *common, struct fsg_buffhd *bh)
>
> switch (format) {
> case 0:
> + case 1:
> /* Formatted TOC */
> len = 4 + 2*8; /* 4 byte header + 2 descriptors */
> memset(buf, 0, len);
When format is 1, the driver is supposed to ignore the start_track
value. Your patch does not do this.
The default case in this switch statement has a comment saying that
Mutil-session is not supported. As a result of this change, it now _is_
supported. The patch needs to update that comment.
Alan Stern
^ permalink raw reply [flat|nested] 5+ messages in thread
* RE: [PATCH RESEND] usb: gadget: f_mass_storage: Make CD-ROM emulation works with Windows OS
2022-06-23 14:48 ` Alan Stern
@ 2022-06-24 2:11 ` Neal Liu
0 siblings, 0 replies; 5+ messages in thread
From: Neal Liu @ 2022-06-24 2:11 UTC (permalink / raw)
To: Alan Stern
Cc: Felipe Balbi, Greg Kroah-Hartman, Roger Quadros, Miaohe Lin,
Wesley Cheng, Eric W . Biederman, Matthew Wilcox,
Nikita Yushchenko, Cai Huoqing, linux-usb, linux-kernel, BMC-SW
> On Thu, Jun 23, 2022 at 11:04:05AM +0800, Neal Liu wrote:
> > Add read TOC with format 2 to support CD-ROM emulation with Windows
> > OS.
> > This patch is tested on Windows OS Server 2019.
>
> This description says "format 2", but the patch actually adds code for the case
> where format is 1. This sort of mistake is not acceptable.
Sorry for typo. I'll update it for next patch.
>
> > Signed-off-by: Neal Liu <neal_liu@aspeedtech.com>
> > ---
> > drivers/usb/gadget/function/f_mass_storage.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/usb/gadget/function/f_mass_storage.c
> > b/drivers/usb/gadget/function/f_mass_storage.c
> > index 3a77bca0ebe1..3c2a5f1e8b66 100644
> > --- a/drivers/usb/gadget/function/f_mass_storage.c
> > +++ b/drivers/usb/gadget/function/f_mass_storage.c
> > @@ -1209,6 +1209,7 @@ static int do_read_toc(struct fsg_common
> > *common, struct fsg_buffhd *bh)
> >
> > switch (format) {
> > case 0:
> > + case 1:
> > /* Formatted TOC */
> > len = 4 + 2*8; /* 4 byte header + 2 descriptors */
> > memset(buf, 0, len);
>
> When format is 1, the driver is supposed to ignore the start_track value. Your
> patch does not do this.
>
> The default case in this switch statement has a comment saying that
> Mutil-session is not supported. As a result of this change, it now _is_
> supported. The patch needs to update that comment.
Okay, thanks for pointing out. I'll update it as well.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2022-06-24 2:11 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-06-23 3:04 [PATCH RESEND] usb: gadget: f_mass_storage: Make CD-ROM emulation works with Windows OS Neal Liu
2022-06-23 7:52 ` Greg Kroah-Hartman
2022-06-23 8:43 ` Neal Liu
2022-06-23 14:48 ` Alan Stern
2022-06-24 2:11 ` Neal Liu
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.