[PATCH] cfg80211: fix kernel-doc

[PATCH] cfg80211: fix kernel-doc

[Johannes Berg]

From: Johannes Berg <johannes.berg@intel.com>

Some things are now removed, and some are not documented, but
mark all the new things as private since drivers shouldn't be
using them anyway.

Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
---
 include/net/cfg80211.h | 11 +----------
 1 file changed, 1 insertion(+), 10 deletions(-)

diff --git a/include/net/cfg80211.h b/include/net/cfg80211.h
index 996782c44838..44f185a2f424 100644
--- a/include/net/cfg80211.h
+++ b/include/net/cfg80211.h
@@ -5563,18 +5563,8 @@ static inline void wiphy_unlock(struct wiphy *wiphy)
  * @netdev: (private) Used to reference back to the netdev, may be %NULL
  * @identifier: (private) Identifier used in nl80211 to identify this
  *	wireless device if it has no netdev
- * @connected_addr: (private) BSSID or AP MLD address if connected
  * @connected: indicates if connected or not (STA mode)
- * @current_bss: (private) Used by the internal configuration code
- * @chandef: (private) Used by the internal configuration code to track
- *	the user-set channel definition.
- * @preset_chandef: (private) Used by the internal configuration code to
- *	track the channel to be used for AP later
  * @bssid: (private) Used by the internal configuration code
- * @ssid: (private) Used by the internal configuration code
- * @ssid_len: (private) Used by the internal configuration code
- * @mesh_id_len: (private) Used by the internal configuration code
- * @mesh_id_up_len: (private) Used by the internal configuration code
  * @wext: (private) Used by the internal wireless extensions compat code
  * @wext.ibss: (private) IBSS data part of wext handling
  * @wext.connect: (private) connection handling data
@@ -5695,6 +5685,7 @@ struct wireless_dev {
 
 	unsigned long unprot_beacon_reported;
 
+	/* private: */
 	union {
 		struct {
 			u8 connected_addr[ETH_ALEN] __aligned(2);
-- 
2.36.1

Re: [PATCH] cfg80211: fix kernel-doc

[Johannes Berg]

Ok, let's try another address for Randy :-)

johannes

> I forgot to update the kernel-doc in my patch
> to redesign AP mode APIs, fix that now.
> 
> Signed-off-by: Johannes Berg <johannes.berg@intel.com>
> ---
> Cc Randy, just in case you notice it too :)
> 
>  include/net/cfg80211.h |   10 ++++------
>  1 file changed, 4 insertions(+), 6 deletions(-)
> 
> --- a/include/net/cfg80211.h	2012-02-25 10:21:14.000000000 +0100
> +++ b/include/net/cfg80211.h	2012-03-01 15:26:54.000000000 +0100
> @@ -1356,12 +1356,10 @@ struct cfg80211_gtk_rekey_data {
>   *
>   * @set_rekey_data: give the data necessary for GTK rekeying to the driver
>   *
> - * @add_beacon: Add a beacon with given parameters, @head, @interval
> - *	and @dtim_period will be valid, @tail is optional.
> - * @set_beacon: Change the beacon parameters for an access point mode
> - *	interface. This should reject the call when no beacon has been
> - *	configured.
> - * @del_beacon: Remove beacon configuration and stop sending the beacon.
> + * @start_ap: Start acting in AP mode defined by the parameters.
> + * @change_beacon: Change the beacon parameters for an access point mode
> + *	interface. This should reject the call when AP mode wasn't started.
> + * @stop_ap: Stop being an AP, including stopping beaconing.

[PATCH] cfg80211: fix kernel-doc

[Johannes Berg]

From: Johannes Berg <johannes.berg@intel.com>

I forgot to update the kernel-doc in my patch
to redesign AP mode APIs, fix that now.

Signed-off-by: Johannes Berg <johannes.berg@intel.com>
---
Cc Randy, just in case you notice it too :)

 include/net/cfg80211.h |   10 ++++------
 1 file changed, 4 insertions(+), 6 deletions(-)

--- a/include/net/cfg80211.h	2012-02-25 10:21:14.000000000 +0100
+++ b/include/net/cfg80211.h	2012-03-01 15:26:54.000000000 +0100
@@ -1356,12 +1356,10 @@ struct cfg80211_gtk_rekey_data {
  *
  * @set_rekey_data: give the data necessary for GTK rekeying to the driver
  *
- * @add_beacon: Add a beacon with given parameters, @head, @interval
- *	and @dtim_period will be valid, @tail is optional.
- * @set_beacon: Change the beacon parameters for an access point mode
- *	interface. This should reject the call when no beacon has been
- *	configured.
- * @del_beacon: Remove beacon configuration and stop sending the beacon.
+ * @start_ap: Start acting in AP mode defined by the parameters.
+ * @change_beacon: Change the beacon parameters for an access point mode
+ *	interface. This should reject the call when AP mode wasn't started.
+ * @stop_ap: Stop being an AP, including stopping beaconing.
  *
  * @add_station: Add a new station.
  * @del_station: Remove a station; @mac may be NULL to remove all stations.