[PATCH-next] drivers/spi: Add missing clk_disable_unprepare()

[PATCH-next] drivers/spi: Add missing clk_disable_unprepare()

[Guo Mengqi]

Add missing clk_disable_unprepare() in synquacer_spi_resume().

Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Guo Mengqi <guomengqi3@huawei.com>
---
 drivers/spi/spi-synquacer.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/spi/spi-synquacer.c b/drivers/spi/spi-synquacer.c
index ea706d9629cb..47cbe73137c2 100644
--- a/drivers/spi/spi-synquacer.c
+++ b/drivers/spi/spi-synquacer.c
@@ -783,6 +783,7 @@ static int __maybe_unused synquacer_spi_resume(struct device *dev)
 
 		ret = synquacer_spi_enable(master);
 		if (ret) {
+			clk_disable_unprepare(sspi->clk);
 			dev_err(dev, "failed to enable spi (%d)\n", ret);
 			return ret;
 		}
-- 
2.17.1

Re: [PATCH-next] drivers/spi: Add missing clk_disable_unprepare()

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 457 bytes --]

On Fri, Jun 24, 2022 at 08:56:14AM +0800, Guo Mengqi wrote:

> Add missing clk_disable_unprepare() in synquacer_spi_resume().

Please submit patches using subject lines reflecting the style for the
subsystem, this makes it easier for people to identify relevant patches.
Look at what existing commits in the area you're changing are doing and
make sure your subject lines visually resemble what they're doing.
There's no need to resubmit to fix this alone.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: [PATCH-next] drivers/spi: Add missing clk_disable_unprepare()

[Mark Brown]

On Fri, 24 Jun 2022 08:56:14 +0800, Guo Mengqi wrote:
> Add missing clk_disable_unprepare() in synquacer_spi_resume().
> 
> 

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next

Thanks!

[1/1] drivers/spi: Add missing clk_disable_unprepare()
      commit: 917e43de2a56d9b82576f1cc94748261f1988458

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark