* [PATCH v2] net: sfp: fix memory leak in sfp_probe()
@ 2022-06-24 4:49 Jianglei Nie
2022-06-28 5:11 ` Jakub Kicinski
0 siblings, 1 reply; 2+ messages in thread
From: Jianglei Nie @ 2022-06-24 4:49 UTC (permalink / raw)
To: linux, andrew, hkallweit1, davem, edumazet, kuba, pabeni
Cc: netdev, linux-kernel, Jianglei Nie
sfp_probe() allocates a memory chunk from sfp with sfp_alloc(). When
devm_add_action() fails, sfp is not freed, which leads to a memory leak.
We should use devm_add_action_or_reset() instead of devm_add_action().
Signed-off-by: Jianglei Nie <niejianglei2021@163.com>
---
drivers/net/phy/sfp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/phy/sfp.c b/drivers/net/phy/sfp.c
index 9a5d5a10560f..e7b0e12cc75b 100644
--- a/drivers/net/phy/sfp.c
+++ b/drivers/net/phy/sfp.c
@@ -2516,7 +2516,7 @@ static int sfp_probe(struct platform_device *pdev)
platform_set_drvdata(pdev, sfp);
- err = devm_add_action(sfp->dev, sfp_cleanup, sfp);
+ err = devm_add_action_or_reset(sfp->dev, sfp_cleanup, sfp);
if (err < 0)
return err;
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2] net: sfp: fix memory leak in sfp_probe()
2022-06-24 4:49 [PATCH v2] net: sfp: fix memory leak in sfp_probe() Jianglei Nie
@ 2022-06-28 5:11 ` Jakub Kicinski
0 siblings, 0 replies; 2+ messages in thread
From: Jakub Kicinski @ 2022-06-28 5:11 UTC (permalink / raw)
To: Jianglei Nie
Cc: linux, andrew, hkallweit1, davem, edumazet, pabeni, netdev, linux-kernel
On Fri, 24 Jun 2022 12:49:41 +0800 Jianglei Nie wrote:
> sfp_probe() allocates a memory chunk from sfp with sfp_alloc(). When
> devm_add_action() fails, sfp is not freed, which leads to a memory leak.
>
> We should use devm_add_action_or_reset() instead of devm_add_action().
Please add a Fixes tag referencing the commit which added the bug.
The subject for the next version should be start with [PATCH net v3].
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-06-28 5:11 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-06-24 4:49 [PATCH v2] net: sfp: fix memory leak in sfp_probe() Jianglei Nie
2022-06-28 5:11 ` Jakub Kicinski
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.