All of lore.kernel.org
 help / color / mirror / Atom feed
From: Nidhi Gupta <nidhi1.gupta@intel.com>
To: igt-dev@lists.freedesktop.org
Cc: Nidhi Gupta <nidhi1.gupta@intel.com>
Subject: [igt-dev] [PATCH i-g-t] tests/kms_concurrent: Fix regression in test_resolution_with_output
Date: Fri, 24 Jun 2022 10:30:00 +0530	[thread overview]
Message-ID: <20220624050000.22886-1-nidhi1.gupta@intel.com> (raw)

Fix regression caused by commit 14ad49f5b6ed861eda93e9d6b6ed0f3c77d228d1
to skip the subtest if the suitable resolution is not found.

The kms_concurrent is about testing mode setting with
reducing the resolution and then again increasing it,
for this the test will take the high resolution supported
by the connector and then calculate the lowest resolution,
if the calculated resolution is not supported by the connector
it will assign the default resolution of 1024x 768 without
checking.

Added check to skip the subtest if the current mode is smaller
than 1024 mode (igt_skip_on_f(mode_default->hdisplay < 1024))
becuase if the default resolution is greater then the highest
resolution supported by the connector then the test should skip.

Fixes: 14ad49f5b6ed861eda93e9d6b6ed0f3c77d228d1
Signed-off-by: Nidhi Gupta <nidhi1.gupta@intel.com>
---
 tests/kms_concurrent.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/kms_concurrent.c b/tests/kms_concurrent.c
index d4536e3b..6f8ffd4a 100644
--- a/tests/kms_concurrent.c
+++ b/tests/kms_concurrent.c
@@ -252,7 +252,7 @@ get_lowres_mode(data_t *data, const drmModeModeInfo *mode_default,
 			return igt_memdup(mode, sizeof(*mode));
 	}
 
-	igt_skip_on_f(mode_default->vdisplay < 1024, "No suitable resolution was found\n");
+	igt_skip_on_f(mode_default->hdisplay < 1024, "No suitable resolution was found\n");
 	return igt_std_1024_mode_get(igt_output_preferred_vrefresh(output));
 }
 
-- 
2.26.2

             reply	other threads:[~2022-06-24  4:56 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-24  5:00 Nidhi Gupta [this message]
2022-06-24  6:02 ` [igt-dev] ✓ Fi.CI.BAT: success for tests/kms_concurrent: Fix regression in test_resolution_with_output (rev4) Patchwork
2022-06-24  8:11 ` [igt-dev] [PATCH i-g-t] tests/kms_concurrent: Fix regression in test_resolution_with_output Karthik B S
2022-06-27 17:57 ` [igt-dev] ✓ Fi.CI.IGT: success for tests/kms_concurrent: Fix regression in test_resolution_with_output (rev4) Patchwork
  -- strict thread matches above, loose matches on Subject: below --
2022-05-31  5:14 [igt-dev] [PATCH i-g-t] tests/kms_concurrent: Fix regression in test_resolution_with_output Nidhi Gupta
2022-06-13  9:11 ` Karthik B S
2021-09-16 14:18 Vidya Srinivas
2021-09-16 15:36 ` Mark Yacoub
2021-09-17 15:03   ` Rodrigo Siqueira
2021-09-17 16:35     ` Mark Yacoub
2021-09-20  8:29     ` Srinivas, Vidya
2021-09-20 15:27       ` Mark Yacoub
2021-09-20 16:59         ` Srinivas, Vidya
2021-09-20  8:17 ` Vidya Srinivas
2021-09-23 17:55   ` Rodrigo Siqueira
2021-09-24  4:06     ` Srinivas, Vidya

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220624050000.22886-1-nidhi1.gupta@intel.com \
    --to=nidhi1.gupta@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.