All of lore.kernel.org
 help / color / mirror / Atom feed
* [igt-dev] [PATCH i-g-t] tests/kms_concurrent: Fix regression in test_resolution_with_output
@ 2022-06-24  5:00 Nidhi Gupta
  2022-06-24  6:02 ` [igt-dev] ✓ Fi.CI.BAT: success for tests/kms_concurrent: Fix regression in test_resolution_with_output (rev4) Patchwork
                   ` (2 more replies)
  0 siblings, 3 replies; 16+ messages in thread
From: Nidhi Gupta @ 2022-06-24  5:00 UTC (permalink / raw)
  To: igt-dev; +Cc: Nidhi Gupta

Fix regression caused by commit 14ad49f5b6ed861eda93e9d6b6ed0f3c77d228d1
to skip the subtest if the suitable resolution is not found.

The kms_concurrent is about testing mode setting with
reducing the resolution and then again increasing it,
for this the test will take the high resolution supported
by the connector and then calculate the lowest resolution,
if the calculated resolution is not supported by the connector
it will assign the default resolution of 1024x 768 without
checking.

Added check to skip the subtest if the current mode is smaller
than 1024 mode (igt_skip_on_f(mode_default->hdisplay < 1024))
becuase if the default resolution is greater then the highest
resolution supported by the connector then the test should skip.

Fixes: 14ad49f5b6ed861eda93e9d6b6ed0f3c77d228d1
Signed-off-by: Nidhi Gupta <nidhi1.gupta@intel.com>
---
 tests/kms_concurrent.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/kms_concurrent.c b/tests/kms_concurrent.c
index d4536e3b..6f8ffd4a 100644
--- a/tests/kms_concurrent.c
+++ b/tests/kms_concurrent.c
@@ -252,7 +252,7 @@ get_lowres_mode(data_t *data, const drmModeModeInfo *mode_default,
 			return igt_memdup(mode, sizeof(*mode));
 	}
 
-	igt_skip_on_f(mode_default->vdisplay < 1024, "No suitable resolution was found\n");
+	igt_skip_on_f(mode_default->hdisplay < 1024, "No suitable resolution was found\n");
 	return igt_std_1024_mode_get(igt_output_preferred_vrefresh(output));
 }
 
-- 
2.26.2

^ permalink raw reply related	[flat|nested] 16+ messages in thread
* [igt-dev] [PATCH i-g-t] tests/kms_concurrent: Fix regression in test_resolution_with_output
@ 2022-05-31  5:14 Nidhi Gupta
  2022-06-13  9:11 ` Karthik B S
  0 siblings, 1 reply; 16+ messages in thread
From: Nidhi Gupta @ 2022-05-31  5:14 UTC (permalink / raw)
  To: igt-dev, karthik.b.s; +Cc: Nidhi Gupta

Fix regression caused by commit 14ad49f5b6ed861eda93e9d6b6ed0f3c77d228d1
to skip the subtest if the suitable resolution is not found.

-the test will calculate the high resolution and low resolution supported by
the connector.
-high resolution will be the default highest resolution supported by the connector
and using that test calculates the lower resolution.
-if the lower resolution is not supported by the connector it will assign the
default resolution of 1024x768
-if the default  resolution value is higher than the high resolutin, skip in that
situation to avoid failure of the test.

Signed-off-by: Nidhi Gupta <nidhi1.gupta@intel.com>
---
 tests/kms_concurrent.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/tests/kms_concurrent.c b/tests/kms_concurrent.c
index d4536e3b..f3cec242 100644
--- a/tests/kms_concurrent.c
+++ b/tests/kms_concurrent.c
@@ -252,7 +252,6 @@ get_lowres_mode(data_t *data, const drmModeModeInfo *mode_default,
 			return igt_memdup(mode, sizeof(*mode));
 	}
 
-	igt_skip_on_f(mode_default->vdisplay < 1024, "No suitable resolution was found\n");
 	return igt_std_1024_mode_get(igt_output_preferred_vrefresh(output));
 }
 
@@ -273,6 +272,8 @@ test_resolution_with_output(data_t *data, enum pipe pipe, int max_planes, igt_ou
 		mode_hi = igt_output_get_mode(output);
 		mode_lo = get_lowres_mode(data, mode_hi, output);
 
+		igt_skip_on_f(mode_lo->vdisplay > mode_hi->vdisplay, "No suitable resolution was found\n");
+		
 		/* switch to lower resolution */
 		igt_output_override_mode(output, mode_lo);
 		free(mode_lo);
-- 
2.26.2

^ permalink raw reply related	[flat|nested] 16+ messages in thread
* [igt-dev] [PATCH i-g-t] tests/kms_concurrent: Fix regression in test_resolution_with_output
@ 2021-09-16 14:18 Vidya Srinivas
  2021-09-16 15:36 ` Mark Yacoub
  2021-09-20  8:17 ` Vidya Srinivas
  0 siblings, 2 replies; 16+ messages in thread
From: Vidya Srinivas @ 2021-09-16 14:18 UTC (permalink / raw)
  To: igt-dev; +Cc: Bhanuprakash.Modem, markyacoub, Vidya Srinivas

Staring commit fea0e38e690c30c6 "Making the test more generic"
test_resolution_with_output introduced setting igt_output_set_pipe
to PIPE_NONE. This is triggering atomic check failure resulting in
"enabled/connectors mismatch" under drm_atomic_helper_check_modeset.
Patch fixes this issue.

Signed-off-by: Vidya Srinivas <vidya.srinivas@intel.com>
---
 tests/kms_concurrent.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/tests/kms_concurrent.c b/tests/kms_concurrent.c
index 25c67eb469d1..40096ea1c457 100644
--- a/tests/kms_concurrent.c
+++ b/tests/kms_concurrent.c
@@ -268,7 +268,6 @@ test_resolution_with_output(data_t *data, enum pipe pipe, int max_planes, igt_ou
 
 		/* switch to lower resolution */
 		igt_output_override_mode(output, mode_lo);
-		igt_output_set_pipe(output, PIPE_NONE);
 		igt_display_commit2(&data->display, COMMIT_ATOMIC);
 
 		/* switch back to higher resolution */
-- 
2.33.0

^ permalink raw reply related	[flat|nested] 16+ messages in thread
end of thread, other threads:[~2022-06-27 17:57 UTC | newest]

Thread overview: 16+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-06-24  5:00 [igt-dev] [PATCH i-g-t] tests/kms_concurrent: Fix regression in test_resolution_with_output Nidhi Gupta
2022-06-24  6:02 ` [igt-dev] ✓ Fi.CI.BAT: success for tests/kms_concurrent: Fix regression in test_resolution_with_output (rev4) Patchwork
2022-06-24  8:11 ` [igt-dev] [PATCH i-g-t] tests/kms_concurrent: Fix regression in test_resolution_with_output Karthik B S
2022-06-27 17:57 ` [igt-dev] ✓ Fi.CI.IGT: success for tests/kms_concurrent: Fix regression in test_resolution_with_output (rev4) Patchwork
  -- strict thread matches above, loose matches on Subject: below --
2022-05-31  5:14 [igt-dev] [PATCH i-g-t] tests/kms_concurrent: Fix regression in test_resolution_with_output Nidhi Gupta
2022-06-13  9:11 ` Karthik B S
2021-09-16 14:18 Vidya Srinivas
2021-09-16 15:36 ` Mark Yacoub
2021-09-17 15:03   ` Rodrigo Siqueira
2021-09-17 16:35     ` Mark Yacoub
2021-09-20  8:29     ` Srinivas, Vidya
2021-09-20 15:27       ` Mark Yacoub
2021-09-20 16:59         ` Srinivas, Vidya
2021-09-20  8:17 ` Vidya Srinivas
2021-09-23 17:55   ` Rodrigo Siqueira
2021-09-24  4:06     ` Srinivas, Vidya

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.