* [PATCH net-next v1 1/1] net: asix: add optional flow control support
@ 2022-06-24 8:02 Oleksij Rempel
2022-06-24 8:03 ` Oleksij Rempel
0 siblings, 1 reply; 3+ messages in thread
From: Oleksij Rempel @ 2022-06-24 8:02 UTC (permalink / raw)
To: David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni
Cc: Oleksij Rempel, kernel, linux-kernel, netdev, Lukas Wunner
Add optional flow control support with respect to the link partners
abilities.
Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
---
drivers/net/usb/asix_common.c | 10 ++++++++++
drivers/net/usb/asix_devices.c | 2 ++
2 files changed, 12 insertions(+)
diff --git a/drivers/net/usb/asix_common.c b/drivers/net/usb/asix_common.c
index b4a1b7abcfc9..c9df7cd8daae 100644
--- a/drivers/net/usb/asix_common.c
+++ b/drivers/net/usb/asix_common.c
@@ -420,6 +420,8 @@ void asix_adjust_link(struct net_device *netdev)
u16 mode = 0;
if (phydev->link) {
+ bool tx_pause, rx_pause;
+
mode = AX88772_MEDIUM_DEFAULT;
if (phydev->duplex == DUPLEX_HALF)
@@ -427,6 +429,14 @@ void asix_adjust_link(struct net_device *netdev)
if (phydev->speed != SPEED_100)
mode &= ~AX_MEDIUM_PS;
+
+ phy_get_pause(phydev, &tx_pause, &rx_pause);
+
+ if (rx_pause)
+ mode |= AX_MEDIUM_RFC;
+
+ if (tx_pause)
+ mode |= AX_MEDIUM_TFC;
}
asix_write_medium_mode(dev, mode, 0);
diff --git a/drivers/net/usb/asix_devices.c b/drivers/net/usb/asix_devices.c
index 5b5eb630c4b7..1bb12bbc34bf 100644
--- a/drivers/net/usb/asix_devices.c
+++ b/drivers/net/usb/asix_devices.c
@@ -677,6 +677,8 @@ static int ax88772_init_phy(struct usbnet *dev)
phy_suspend(priv->phydev);
priv->phydev->mac_managed_pm = 1;
+ phy_support_asym_pause(priv->phydev);
+
phy_attached_info(priv->phydev);
if (priv->embd_phy)
--
2.30.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH net-next v1 1/1] net: asix: add optional flow control support
2022-06-24 8:02 [PATCH net-next v1 1/1] net: asix: add optional flow control support Oleksij Rempel
@ 2022-06-24 8:03 ` Oleksij Rempel
2022-06-24 17:23 ` Jakub Kicinski
0 siblings, 1 reply; 3+ messages in thread
From: Oleksij Rempel @ 2022-06-24 8:03 UTC (permalink / raw)
To: David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni
Cc: kernel, linux-kernel, netdev, Lukas Wunner
On Fri, Jun 24, 2022 at 10:02:07AM +0200, Oleksij Rempel wrote:
> Add optional flow control support with respect to the link partners
> abilities.
>
> Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
This is a net-next patch, depending on other net patch:
https://lore.kernel.org/all/20220624075139.3139300-2-o.rempel@pengutronix.de/
> ---
> drivers/net/usb/asix_common.c | 10 ++++++++++
> drivers/net/usb/asix_devices.c | 2 ++
> 2 files changed, 12 insertions(+)
>
> diff --git a/drivers/net/usb/asix_common.c b/drivers/net/usb/asix_common.c
> index b4a1b7abcfc9..c9df7cd8daae 100644
> --- a/drivers/net/usb/asix_common.c
> +++ b/drivers/net/usb/asix_common.c
> @@ -420,6 +420,8 @@ void asix_adjust_link(struct net_device *netdev)
> u16 mode = 0;
>
> if (phydev->link) {
> + bool tx_pause, rx_pause;
> +
> mode = AX88772_MEDIUM_DEFAULT;
>
> if (phydev->duplex == DUPLEX_HALF)
> @@ -427,6 +429,14 @@ void asix_adjust_link(struct net_device *netdev)
>
> if (phydev->speed != SPEED_100)
> mode &= ~AX_MEDIUM_PS;
> +
> + phy_get_pause(phydev, &tx_pause, &rx_pause);
> +
> + if (rx_pause)
> + mode |= AX_MEDIUM_RFC;
> +
> + if (tx_pause)
> + mode |= AX_MEDIUM_TFC;
> }
>
> asix_write_medium_mode(dev, mode, 0);
> diff --git a/drivers/net/usb/asix_devices.c b/drivers/net/usb/asix_devices.c
> index 5b5eb630c4b7..1bb12bbc34bf 100644
> --- a/drivers/net/usb/asix_devices.c
> +++ b/drivers/net/usb/asix_devices.c
> @@ -677,6 +677,8 @@ static int ax88772_init_phy(struct usbnet *dev)
> phy_suspend(priv->phydev);
> priv->phydev->mac_managed_pm = 1;
>
> + phy_support_asym_pause(priv->phydev);
> +
> phy_attached_info(priv->phydev);
>
> if (priv->embd_phy)
> --
> 2.30.2
>
>
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH net-next v1 1/1] net: asix: add optional flow control support
2022-06-24 8:03 ` Oleksij Rempel
@ 2022-06-24 17:23 ` Jakub Kicinski
0 siblings, 0 replies; 3+ messages in thread
From: Jakub Kicinski @ 2022-06-24 17:23 UTC (permalink / raw)
To: Oleksij Rempel
Cc: David S. Miller, Eric Dumazet, Paolo Abeni, kernel, linux-kernel,
netdev, Lukas Wunner
On Fri, 24 Jun 2022 10:03:37 +0200 Oleksij Rempel wrote:
> On Fri, Jun 24, 2022 at 10:02:07AM +0200, Oleksij Rempel wrote:
> > Add optional flow control support with respect to the link partners
> > abilities.
> >
> > Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
>
> This is a net-next patch, depending on other net patch:
> https://lore.kernel.org/all/20220624075139.3139300-2-o.rempel@pengutronix.de/
Unfortunately you're gonna have to repost if there's a dependency.
We're a full week away from the fixes making it to net-next, so
too long to keep a patch sitting in pw with the current patch rate.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-06-24 17:26 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-06-24 8:02 [PATCH net-next v1 1/1] net: asix: add optional flow control support Oleksij Rempel
2022-06-24 8:03 ` Oleksij Rempel
2022-06-24 17:23 ` Jakub Kicinski
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.