All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Nícolas F. R. A. Prado" <nfraprado@collabora.com>
To: Guodong Liu <guodong.liu@mediatek.com>
Cc: Linus Walleij <linus.walleij@linaro.org>,
	Rob Herring <robh+dt@kernel.org>,
	Matthias Brugger <matthias.bgg@gmail.com>,
	Sean Wang <sean.wang@kernel.org>,
	Sean Wang <sean.wang@mediatek.com>,
	Zhiyong Tao <zhiyong.tao@mediatek.com>,
	linux-gpio@vger.kernel.org, devicetree@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org,
	Project_Global_Chrome_Upstream_Group@mediatek.com
Subject: Re: [PATCH v2 4/5] pinctrl: mediatek: dropping original advanced drive configuration function
Date: Fri, 24 Jun 2022 12:08:10 -0400	[thread overview]
Message-ID: <20220624160810.alotw7iwvivp5zg6@notapiano> (raw)
In-Reply-To: <20220624133700.15487-5-guodong.liu@mediatek.com>

Hi Guodong,

On Fri, Jun 24, 2022 at 09:36:59PM +0800, Guodong Liu wrote:
> Function bias_combo getter/setters already handle all cases advanced drive
> configuration, include drive for I2C related pins.

This commit message could be improved. I suggest using the following commit
message:

The bias_combo getter/setter is already able to handle advanced drive
configuration, which is the reason commit 353d2ef77f2b ("dt-bindings: pinctrl:
mt8192: Use generic bias instead of pull-*-adv") dropped the pull-up-adv and
pull-down-adv properties from the binding. With those properties removed,
there's no longer any use for the adv_pull callbacks, so drop them.

> 
> Signed-off-by: Guodong Liu <guodong.liu@mediatek.com>

Reviewed-by: Nícolas F. R. A. Prado <nfraprado@collabora.com>
Tested-by: Nícolas F. R. A. Prado <nfraprado@collabora.com>

Thanks,
Nícolas

WARNING: multiple messages have this Message-ID (diff)
From: "Nícolas F. R. A. Prado" <nfraprado@collabora.com>
To: Guodong Liu <guodong.liu@mediatek.com>
Cc: Linus Walleij <linus.walleij@linaro.org>,
	Rob Herring <robh+dt@kernel.org>,
	Matthias Brugger <matthias.bgg@gmail.com>,
	Sean Wang <sean.wang@kernel.org>,
	Sean Wang <sean.wang@mediatek.com>,
	Zhiyong Tao <zhiyong.tao@mediatek.com>,
	linux-gpio@vger.kernel.org, devicetree@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org,
	Project_Global_Chrome_Upstream_Group@mediatek.com
Subject: Re: [PATCH v2 4/5] pinctrl: mediatek: dropping original advanced drive configuration function
Date: Fri, 24 Jun 2022 12:08:10 -0400	[thread overview]
Message-ID: <20220624160810.alotw7iwvivp5zg6@notapiano> (raw)
In-Reply-To: <20220624133700.15487-5-guodong.liu@mediatek.com>

Hi Guodong,

On Fri, Jun 24, 2022 at 09:36:59PM +0800, Guodong Liu wrote:
> Function bias_combo getter/setters already handle all cases advanced drive
> configuration, include drive for I2C related pins.

This commit message could be improved. I suggest using the following commit
message:

The bias_combo getter/setter is already able to handle advanced drive
configuration, which is the reason commit 353d2ef77f2b ("dt-bindings: pinctrl:
mt8192: Use generic bias instead of pull-*-adv") dropped the pull-up-adv and
pull-down-adv properties from the binding. With those properties removed,
there's no longer any use for the adv_pull callbacks, so drop them.

> 
> Signed-off-by: Guodong Liu <guodong.liu@mediatek.com>

Reviewed-by: Nícolas F. R. A. Prado <nfraprado@collabora.com>
Tested-by: Nícolas F. R. A. Prado <nfraprado@collabora.com>

Thanks,
Nícolas

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2022-06-24 16:08 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-24 13:36 [PATCH v2 0/5] pinctrl: mediatek: add driver support driving and resistance property on mt8192 Guodong Liu
2022-06-24 13:36 ` Guodong Liu
2022-06-24 13:36 ` [PATCH v2 1/5] pinctrl: mediatek: add generic driving setup " Guodong Liu
2022-06-24 13:36   ` Guodong Liu
2022-06-24 15:52   ` Nícolas F. R. A. Prado
2022-06-24 15:52     ` Nícolas F. R. A. Prado
2022-06-26  4:45     ` Guodong Liu
2022-06-26  4:45       ` Guodong Liu
2022-06-25 23:26   ` Linus Walleij
2022-06-25 23:26     ` Linus Walleij
2022-06-24 13:36 ` [PATCH v2 2/5] pinctrl: mediatek: add drive for I2C related pins " Guodong Liu
2022-06-24 13:36   ` Guodong Liu
2022-06-24 18:26   ` Nícolas F. R. A. Prado
2022-06-24 18:26     ` Nícolas F. R. A. Prado
2022-06-24 13:36 ` [PATCH v2 3/5] pinctrl: mediatek: add rsel setting " Guodong Liu
2022-06-24 13:36   ` Guodong Liu
2022-06-24 15:29   ` Nícolas F. R. A. Prado
2022-06-24 15:29     ` Nícolas F. R. A. Prado
2022-06-26  4:48     ` Guodong Liu
2022-06-26  4:48       ` Guodong Liu
2022-06-24 13:36 ` [PATCH v2 4/5] pinctrl: mediatek: dropping original advanced drive configuration function Guodong Liu
2022-06-24 13:36   ` Guodong Liu
2022-06-24 16:08   ` Nícolas F. R. A. Prado [this message]
2022-06-24 16:08     ` Nícolas F. R. A. Prado
2022-06-26  4:44     ` Guodong Liu
2022-06-26  4:44       ` Guodong Liu
2022-06-24 13:37 ` [PATCH v2 5/5] pinctrl: mediatek: fix the pinconf definition of some GPIO pins Guodong Liu
2022-06-24 13:37   ` Guodong Liu
2022-06-24 16:10   ` Nícolas F. R. A. Prado
2022-06-24 16:10     ` Nícolas F. R. A. Prado

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220624160810.alotw7iwvivp5zg6@notapiano \
    --to=nfraprado@collabora.com \
    --cc=Project_Global_Chrome_Upstream_Group@mediatek.com \
    --cc=devicetree@vger.kernel.org \
    --cc=guodong.liu@mediatek.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=matthias.bgg@gmail.com \
    --cc=robh+dt@kernel.org \
    --cc=sean.wang@kernel.org \
    --cc=sean.wang@mediatek.com \
    --cc=zhiyong.tao@mediatek.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.