From: Sathvika Vasireddy <sv@linux.ibm.com> To: linuxppc-dev@lists.ozlabs.org Cc: jpoimboe@redhat.com, peterz@infradead.org, linux-kernel@vger.kernel.org, aik@ozlabs.ru, mpe@ellerman.id.au, christophe.leroy@csgroup.eu, mingo@redhat.com, rostedt@goodmis.org, naveen.n.rao@linux.vnet.ibm.com, sv@linux.ibm.com, mbenes@suse.cz, benh@kernel.crashing.org, paulus@samba.org Subject: [RFC PATCH v3 11/12] powerpc: Remove unreachable() from WARN_ON() Date: Sat, 25 Jun 2022 00:02:37 +0530 [thread overview] Message-ID: <20220624183238.388144-12-sv@linux.ibm.com> (raw) In-Reply-To: <20220624183238.388144-1-sv@linux.ibm.com> objtool is throwing *unannotated intra-function call* warnings with a few instructions that are marked unreachable. Remove unreachable() from WARN_ON() to fix these warnings, as the codegen remains same with and without unreachable() in WARN_ON(). Signed-off-by: Sathvika Vasireddy <sv@linux.ibm.com> --- arch/powerpc/include/asm/bug.h | 1 - 1 file changed, 1 deletion(-) diff --git a/arch/powerpc/include/asm/bug.h b/arch/powerpc/include/asm/bug.h index ecbae1832de3..df6c11e008b9 100644 --- a/arch/powerpc/include/asm/bug.h +++ b/arch/powerpc/include/asm/bug.h @@ -97,7 +97,6 @@ __label__ __label_warn_on; \ \ WARN_ENTRY("twi 31, 0, 0", BUGFLAG_WARNING | (flags), __label_warn_on); \ - unreachable(); \ \ __label_warn_on: \ break; \ -- 2.25.1
WARNING: multiple messages have this Message-ID (diff)
From: Sathvika Vasireddy <sv@linux.ibm.com> To: linuxppc-dev@lists.ozlabs.org Cc: peterz@infradead.org, linux-kernel@vger.kernel.org, aik@ozlabs.ru, mingo@redhat.com, sv@linux.ibm.com, rostedt@goodmis.org, jpoimboe@redhat.com, paulus@samba.org, naveen.n.rao@linux.vnet.ibm.com, mbenes@suse.cz Subject: [RFC PATCH v3 11/12] powerpc: Remove unreachable() from WARN_ON() Date: Sat, 25 Jun 2022 00:02:37 +0530 [thread overview] Message-ID: <20220624183238.388144-12-sv@linux.ibm.com> (raw) In-Reply-To: <20220624183238.388144-1-sv@linux.ibm.com> objtool is throwing *unannotated intra-function call* warnings with a few instructions that are marked unreachable. Remove unreachable() from WARN_ON() to fix these warnings, as the codegen remains same with and without unreachable() in WARN_ON(). Signed-off-by: Sathvika Vasireddy <sv@linux.ibm.com> --- arch/powerpc/include/asm/bug.h | 1 - 1 file changed, 1 deletion(-) diff --git a/arch/powerpc/include/asm/bug.h b/arch/powerpc/include/asm/bug.h index ecbae1832de3..df6c11e008b9 100644 --- a/arch/powerpc/include/asm/bug.h +++ b/arch/powerpc/include/asm/bug.h @@ -97,7 +97,6 @@ __label__ __label_warn_on; \ \ WARN_ENTRY("twi 31, 0, 0", BUGFLAG_WARNING | (flags), __label_warn_on); \ - unreachable(); \ \ __label_warn_on: \ break; \ -- 2.25.1
next prev parent reply other threads:[~2022-06-24 18:35 UTC|newest] Thread overview: 95+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-06-24 18:32 [RFC PATCH v3 00/12] objtool: Enable and implement --mcount option on powerpc Sathvika Vasireddy 2022-06-24 18:32 ` Sathvika Vasireddy 2022-06-24 18:32 ` [RFC PATCH v3 01/12] objtool: Fix SEGFAULT Sathvika Vasireddy 2022-06-24 18:32 ` Sathvika Vasireddy 2022-07-08 15:10 ` Christophe Leroy 2022-07-08 15:10 ` Christophe Leroy 2022-06-24 18:32 ` [RFC PATCH v3 02/12] objtool: Use target file endianness instead of a compiled constant Sathvika Vasireddy 2022-06-24 18:32 ` Sathvika Vasireddy 2022-06-24 18:32 ` [RFC PATCH v3 03/12] objtool: Use target file class size " Sathvika Vasireddy 2022-06-24 18:32 ` Sathvika Vasireddy 2022-07-08 17:35 ` Christophe Leroy 2022-07-08 17:35 ` Christophe Leroy 2022-06-24 18:32 ` [RFC PATCH v3 04/12] objtool: Add --mnop as an option to --mcount Sathvika Vasireddy 2022-06-24 18:32 ` Sathvika Vasireddy 2022-06-24 18:32 ` [RFC PATCH v3 05/12] powerpc: Skip objtool from running on VDSO files Sathvika Vasireddy 2022-06-24 18:32 ` Sathvika Vasireddy 2022-06-24 18:32 ` [RFC PATCH v3 06/12] objtool: Read special sections with alts only when specific options are selected Sathvika Vasireddy 2022-06-24 18:32 ` Sathvika Vasireddy 2022-06-24 18:32 ` [RFC PATCH v3 07/12] objtool: Use macros to define arch specific reloc types Sathvika Vasireddy 2022-06-24 18:32 ` Sathvika Vasireddy 2022-07-04 11:14 ` Peter Zijlstra 2022-07-04 11:14 ` Peter Zijlstra 2022-07-04 15:53 ` Christophe Leroy 2022-07-04 15:53 ` Christophe Leroy 2022-07-04 16:18 ` Peter Zijlstra 2022-07-04 16:18 ` Peter Zijlstra 2022-06-24 18:32 ` [RFC PATCH v3 08/12] objtool: Add arch specific function arch_ftrace_match() Sathvika Vasireddy 2022-06-24 18:32 ` Sathvika Vasireddy 2022-06-24 18:32 ` [RFC PATCH v3 09/12] objtool/powerpc: Enable objtool to be built on ppc Sathvika Vasireddy 2022-06-24 18:32 ` Sathvika Vasireddy 2022-06-24 18:32 ` [RFC PATCH v3 10/12] objtool/powerpc: Add --mcount specific implementation Sathvika Vasireddy 2022-06-24 18:32 ` Sathvika Vasireddy 2022-06-24 18:32 ` Sathvika Vasireddy [this message] 2022-06-24 18:32 ` [RFC PATCH v3 11/12] powerpc: Remove unreachable() from WARN_ON() Sathvika Vasireddy 2022-06-25 6:46 ` Christophe Leroy 2022-06-25 6:46 ` Christophe Leroy 2022-06-27 15:21 ` Sathvika Vasireddy 2022-06-27 15:35 ` Sathvika Vasireddy 2022-06-27 15:35 ` Sathvika Vasireddy 2022-06-27 15:46 ` Christophe Leroy 2022-06-27 15:46 ` Christophe Leroy 2022-06-29 18:30 ` Christophe Leroy 2022-06-29 18:30 ` Christophe Leroy 2022-06-29 18:30 ` Christophe Leroy 2022-06-30 8:05 ` Naveen N. Rao 2022-06-30 8:05 ` Naveen N. Rao 2022-06-30 8:05 ` Naveen N. Rao 2022-06-30 9:58 ` Christophe Leroy 2022-06-30 9:58 ` Christophe Leroy 2022-06-30 9:58 ` Christophe Leroy 2022-06-30 10:33 ` Christophe Leroy 2022-06-30 10:33 ` Christophe Leroy 2022-06-30 10:33 ` Christophe Leroy 2022-06-30 10:37 ` Naveen N. Rao 2022-06-30 10:37 ` Naveen N. Rao 2022-06-30 10:37 ` Naveen N. Rao 2022-06-30 15:58 ` Segher Boessenkool 2022-06-30 15:58 ` Segher Boessenkool 2022-06-30 15:58 ` Segher Boessenkool 2022-07-04 12:01 ` Peter Zijlstra 2022-07-04 12:01 ` Peter Zijlstra 2022-07-04 12:01 ` Peter Zijlstra 2022-07-04 11:43 ` Peter Zijlstra 2022-07-04 11:43 ` Peter Zijlstra 2022-07-04 11:43 ` Peter Zijlstra 2022-07-01 2:13 ` Chen Zhongjin 2022-07-01 2:13 ` Chen Zhongjin 2022-07-01 2:13 ` Chen Zhongjin 2022-07-01 6:56 ` Sathvika Vasireddy 2022-07-01 6:56 ` Sathvika Vasireddy 2022-07-01 6:56 ` Sathvika Vasireddy 2022-07-01 11:40 ` [RFC PATCH v3 11/12] powerpc: Remove unreachable() from WARN_ON() (gcc issue ?) Christophe Leroy 2022-07-01 11:40 ` Christophe Leroy 2022-07-01 11:40 ` Christophe Leroy 2022-07-04 11:45 ` [RFC PATCH v3 11/12] powerpc: Remove unreachable() from WARN_ON() Peter Zijlstra 2022-07-04 11:45 ` Peter Zijlstra 2022-07-04 11:45 ` Peter Zijlstra 2022-07-04 12:34 ` Christophe Leroy 2022-07-04 12:34 ` Christophe Leroy 2022-07-04 12:34 ` Christophe Leroy 2022-07-05 15:48 ` Segher Boessenkool 2022-07-05 15:48 ` Segher Boessenkool 2022-07-05 15:48 ` Segher Boessenkool 2022-07-04 12:05 ` Peter Zijlstra 2022-07-04 12:05 ` Peter Zijlstra 2022-07-04 12:44 ` Christophe Leroy 2022-07-04 12:44 ` Christophe Leroy 2022-07-04 14:19 ` Peter Zijlstra 2022-07-04 14:19 ` Peter Zijlstra 2022-06-24 18:32 ` [RFC PATCH v3 12/12] objtool/powerpc: Fix unannotated intra-function call warnings Sathvika Vasireddy 2022-06-24 18:32 ` Sathvika Vasireddy 2022-07-08 15:06 ` [RFC PATCH v3 00/12] objtool: Enable and implement --mcount option on powerpc Christophe Leroy 2022-07-08 15:06 ` Christophe Leroy 2022-07-08 15:42 ` Christophe Leroy 2022-07-08 15:42 ` Christophe Leroy
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20220624183238.388144-12-sv@linux.ibm.com \ --to=sv@linux.ibm.com \ --cc=aik@ozlabs.ru \ --cc=benh@kernel.crashing.org \ --cc=christophe.leroy@csgroup.eu \ --cc=jpoimboe@redhat.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linuxppc-dev@lists.ozlabs.org \ --cc=mbenes@suse.cz \ --cc=mingo@redhat.com \ --cc=mpe@ellerman.id.au \ --cc=naveen.n.rao@linux.vnet.ibm.com \ --cc=paulus@samba.org \ --cc=peterz@infradead.org \ --cc=rostedt@goodmis.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.