All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] server/process: Fix logging issues where only the first message was displayed
@ 2022-06-24 21:56 Richard Purdie
  0 siblings, 0 replies; only message in thread
From: Richard Purdie @ 2022-06-24 21:56 UTC (permalink / raw)
  To: bitbake-devel

I realised only the first logging message was being displayed in a given
parsing process. The reason turned out to be the UI handler failing
with a "pop from empty list". The default handler was then lost and
no further messages were processed.

Fix this by catching the exception correctly in the connection writer code.

Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
---
 lib/bb/server/process.py | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/lib/bb/server/process.py b/lib/bb/server/process.py
index 43790b6631..5d02c0b9f5 100644
--- a/lib/bb/server/process.py
+++ b/lib/bb/server/process.py
@@ -756,8 +756,11 @@ class ConnectionWriter(object):
                 process.queue_signals = True
                 self._send(obj)
                 process.queue_signals = False
-                for sig in process.signal_received.pop():
-                    process.handle_sig(sig, None)
+                try:
+                    for sig in process.signal_received.pop():
+                        process.handle_sig(sig, None)
+                except IndexError:
+                    pass
         else:
             self._send(obj)
 
-- 
2.34.1



^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2022-06-24 21:56 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-06-24 21:56 [PATCH] server/process: Fix logging issues where only the first message was displayed Richard Purdie

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.