From: Jonathan Lemon <jonathan.lemon@gmail.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: Vadim Fedorenko <vfedorenko@novek.ru>, netdev@vger.kernel.org
Subject: Re: [PATCH net] ptp: ocp: add EEPROM_AT24 dependency
Date: Sat, 25 Jun 2022 13:36:09 -0700 [thread overview]
Message-ID: <20220625203609.27hzzmljbyrvrzl6@bsd-mbp.dhcp.thefacebook.com> (raw)
In-Reply-To: <20220624224530.359d16b1@kernel.org>
On Fri, Jun 24, 2022 at 10:45:30PM -0700, Jakub Kicinski wrote:
> On Thu, 23 Jun 2022 16:53:08 -0700 Jonathan Lemon wrote:
> > On Fri, Jun 24, 2022 at 02:31:41AM +0300, Vadim Fedorenko wrote:
> > > Various information which is provided via devlink is stored in
> > > EEPROM and is not accessible unless at24 eeprom is supported.
> > >
> > > Fixes: 773bda964921 ("ptp: ocp: Expose various resources on the timecard.")
> > > Signed-off-by: Vadim Fedorenko <vfedorenko@novek.ru>
> > > ---
> > > drivers/ptp/Kconfig | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/drivers/ptp/Kconfig b/drivers/ptp/Kconfig
> > > index 458218f88c5e..c86be47e69ed 100644
> > > --- a/drivers/ptp/Kconfig
> > > +++ b/drivers/ptp/Kconfig
> > > @@ -171,7 +171,7 @@ config PTP_1588_CLOCK_OCP
> > > tristate "OpenCompute TimeCard as PTP clock"
> > > depends on PTP_1588_CLOCK
> > > depends on HAS_IOMEM && PCI
> > > - depends on I2C && MTD
> > > + depends on I2C && EEPROM_AT24 && MTD
> > > depends on SERIAL_8250
> > > depends on !S390
> > > depends on COMMON_CLK
> >
> > The intent was to list the minimum dependencies for the PTP clock to
> > operate and for the module to compile.
> >
> > While EEPROM_AT24 is needed to read the chip, it can operate without it.
> >
> > Full access to all features needs addtional configuration options, for
> > example, MTD_SPI_NOR, SPI_XILINX, I2C_XILINX. These are not required
> > for the basic ptp clock operation.
> >
> > I think listing these configuration options would be more appropriate
> > in the Documentation entry.
>
> You can try "imply".
We have been down this road before.
https://lore.kernel.org/netdev/CAK8P3a3QGF2=WZz6N8wQo2ZQxmVqKToHGmhT4wEtB7tAL+-ruQ@mail.gmail.com/
https://lore.kernel.org/netdev/20210825211733.264844-1-jonathan.lemon@gmail.com/
--
Jonathan
prev parent reply other threads:[~2022-06-25 20:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-23 23:31 [PATCH net] ptp: ocp: add EEPROM_AT24 dependency Vadim Fedorenko
2022-06-23 23:53 ` Jonathan Lemon
2022-06-25 5:45 ` Jakub Kicinski
2022-06-25 20:36 ` Jonathan Lemon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220625203609.27hzzmljbyrvrzl6@bsd-mbp.dhcp.thefacebook.com \
--to=jonathan.lemon@gmail.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=vfedorenko@novek.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.