All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] pinctrl: mediatek: mt8192: Fix compile warnings
@ 2022-06-26 23:57 Linus Walleij
  2022-06-27 14:44 ` Nícolas F. R. A. Prado
  0 siblings, 1 reply; 3+ messages in thread
From: Linus Walleij @ 2022-06-26 23:57 UTC (permalink / raw)
  To: linux-gpio; +Cc: Linus Walleij, Guodong Liu, Nícolas F . R . A . Prado

After applying patches I get these warnings:

  drivers/pinctrl/mediatek/pinctrl-mt8192.c:1302:56:
  warning: "/*" within comment [-Wcomment]
  drivers/pinctrl/mediatek/pinctrl-mt8192.c:1362:56:
  warning: "/*" within comment [-Wcomment]

Something is wrong with the missing end-slashes. Add them.

Cc: Guodong Liu <guodong.liu@mediatek.com>
Cc: Nícolas F. R. A. Prado <nfraprado@collabora.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
---
 drivers/pinctrl/mediatek/pinctrl-mt8192.c | 18 +++++++++---------
 1 file changed, 9 insertions(+), 9 deletions(-)

diff --git a/drivers/pinctrl/mediatek/pinctrl-mt8192.c b/drivers/pinctrl/mediatek/pinctrl-mt8192.c
index a66394c6f443..78c02b7c81f0 100644
--- a/drivers/pinctrl/mediatek/pinctrl-mt8192.c
+++ b/drivers/pinctrl/mediatek/pinctrl-mt8192.c
@@ -1299,15 +1299,15 @@ static const unsigned int mt8192_pull_type[] = {
 	MTK_PULL_PU_PD_TYPE,/*94*/ MTK_PULL_PU_PD_TYPE,/*95*/
 	MTK_PULL_PU_PD_TYPE,/*96*/ MTK_PULL_PU_PD_TYPE,/*97*/
 	MTK_PULL_PU_PD_TYPE,/*98*/ MTK_PULL_PU_PD_TYPE,/*99*/
-	MTK_PULL_PU_PD_TYPE,/*100* MTK_PULL_PU_PD_TYPE,/*101*/
-	MTK_PULL_PU_PD_TYPE,/*102* MTK_PULL_PU_PD_TYPE,/*103*/
-	MTK_PULL_PU_PD_TYPE,/*104* MTK_PULL_PU_PD_TYPE,/*105*/
-	MTK_PULL_PU_PD_TYPE,/*106* MTK_PULL_PU_PD_TYPE,/*107*/
-	MTK_PULL_PU_PD_TYPE,/*108* MTK_PULL_PU_PD_TYPE,/*109*/
-	MTK_PULL_PU_PD_TYPE,/*110* MTK_PULL_PU_PD_TYPE,/*111*/
-	MTK_PULL_PU_PD_TYPE,/*112* MTK_PULL_PU_PD_TYPE,/*113*/
-	MTK_PULL_PU_PD_TYPE,/*114* MTK_PULL_PU_PD_TYPE,/*115*/
-	MTK_PULL_PU_PD_TYPE,/*116* MTK_PULL_PU_PD_TYPE,/*117*/
+	MTK_PULL_PU_PD_TYPE,/*100*/ MTK_PULL_PU_PD_TYPE,/*101*/
+	MTK_PULL_PU_PD_TYPE,/*102*/ MTK_PULL_PU_PD_TYPE,/*103*/
+	MTK_PULL_PU_PD_TYPE,/*104*/ MTK_PULL_PU_PD_TYPE,/*105*/
+	MTK_PULL_PU_PD_TYPE,/*106*/ MTK_PULL_PU_PD_TYPE,/*107*/
+	MTK_PULL_PU_PD_TYPE,/*108*/ MTK_PULL_PU_PD_TYPE,/*109*/
+	MTK_PULL_PU_PD_TYPE,/*110*/ MTK_PULL_PU_PD_TYPE,/*111*/
+	MTK_PULL_PU_PD_TYPE,/*112*/ MTK_PULL_PU_PD_TYPE,/*113*/
+	MTK_PULL_PU_PD_TYPE,/*114*/ MTK_PULL_PU_PD_TYPE,/*115*/
+	MTK_PULL_PU_PD_TYPE,/*116*/ MTK_PULL_PU_PD_TYPE,/*117*/
 	MTK_PULL_PU_PD_RSEL_TYPE,/*118*/ MTK_PULL_PU_PD_RSEL_TYPE,/*119*/
 	MTK_PULL_PU_PD_RSEL_TYPE,/*120*/ MTK_PULL_PU_PD_RSEL_TYPE,/*121*/
 	MTK_PULL_PU_PD_RSEL_TYPE,/*122*/ MTK_PULL_PU_PD_RSEL_TYPE,/*123*/
-- 
2.36.1


^ permalink raw reply related	[flat|nested] 3+ messages in thread
* Re: [PATCH] pinctrl: mediatek: mt8192: Fix compile warnings
  2022-06-26 23:57 [PATCH] pinctrl: mediatek: mt8192: Fix compile warnings Linus Walleij
@ 2022-06-27 14:44 ` Nícolas F. R. A. Prado
  2022-06-28 14:14   ` Linus Walleij
  0 siblings, 1 reply; 3+ messages in thread
From: Nícolas F. R. A. Prado @ 2022-06-27 14:44 UTC (permalink / raw)
  To: Linus Walleij; +Cc: linux-gpio, Guodong Liu

On Mon, Jun 27, 2022 at 01:57:43AM +0200, Linus Walleij wrote:
> After applying patches I get these warnings:
> 
>   drivers/pinctrl/mediatek/pinctrl-mt8192.c:1302:56:
>   warning: "/*" within comment [-Wcomment]
>   drivers/pinctrl/mediatek/pinctrl-mt8192.c:1362:56:
>   warning: "/*" within comment [-Wcomment]
> 
> Something is wrong with the missing end-slashes. Add them.
> 
> Cc: Guodong Liu <guodong.liu@mediatek.com>
> Cc: Nícolas F. R. A. Prado <nfraprado@collabora.com>
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>

Hi,

yes, this issue was noticed during review [1], and fixed on the following
version [2], but since the commit before the correction was applied, this fix
LGTM.

Reviewed-by: Nícolas F. R. A. Prado <nfraprado@collabora.com>

Thanks,
Nícolas

[1] https://lore.kernel.org/all/20220624152926.76hvymguryhfv4sq@notapiano
[2] https://lore.kernel.org/all/20220626043955.32756-4-guodong.liu@mediatek.com/

> ---
>  drivers/pinctrl/mediatek/pinctrl-mt8192.c | 18 +++++++++---------
>  1 file changed, 9 insertions(+), 9 deletions(-)
> 
> diff --git a/drivers/pinctrl/mediatek/pinctrl-mt8192.c b/drivers/pinctrl/mediatek/pinctrl-mt8192.c
> index a66394c6f443..78c02b7c81f0 100644
> --- a/drivers/pinctrl/mediatek/pinctrl-mt8192.c
> +++ b/drivers/pinctrl/mediatek/pinctrl-mt8192.c
> @@ -1299,15 +1299,15 @@ static const unsigned int mt8192_pull_type[] = {
>  	MTK_PULL_PU_PD_TYPE,/*94*/ MTK_PULL_PU_PD_TYPE,/*95*/
>  	MTK_PULL_PU_PD_TYPE,/*96*/ MTK_PULL_PU_PD_TYPE,/*97*/
>  	MTK_PULL_PU_PD_TYPE,/*98*/ MTK_PULL_PU_PD_TYPE,/*99*/
> -	MTK_PULL_PU_PD_TYPE,/*100* MTK_PULL_PU_PD_TYPE,/*101*/
> -	MTK_PULL_PU_PD_TYPE,/*102* MTK_PULL_PU_PD_TYPE,/*103*/
> -	MTK_PULL_PU_PD_TYPE,/*104* MTK_PULL_PU_PD_TYPE,/*105*/
> -	MTK_PULL_PU_PD_TYPE,/*106* MTK_PULL_PU_PD_TYPE,/*107*/
> -	MTK_PULL_PU_PD_TYPE,/*108* MTK_PULL_PU_PD_TYPE,/*109*/
> -	MTK_PULL_PU_PD_TYPE,/*110* MTK_PULL_PU_PD_TYPE,/*111*/
> -	MTK_PULL_PU_PD_TYPE,/*112* MTK_PULL_PU_PD_TYPE,/*113*/
> -	MTK_PULL_PU_PD_TYPE,/*114* MTK_PULL_PU_PD_TYPE,/*115*/
> -	MTK_PULL_PU_PD_TYPE,/*116* MTK_PULL_PU_PD_TYPE,/*117*/
> +	MTK_PULL_PU_PD_TYPE,/*100*/ MTK_PULL_PU_PD_TYPE,/*101*/
> +	MTK_PULL_PU_PD_TYPE,/*102*/ MTK_PULL_PU_PD_TYPE,/*103*/
> +	MTK_PULL_PU_PD_TYPE,/*104*/ MTK_PULL_PU_PD_TYPE,/*105*/
> +	MTK_PULL_PU_PD_TYPE,/*106*/ MTK_PULL_PU_PD_TYPE,/*107*/
> +	MTK_PULL_PU_PD_TYPE,/*108*/ MTK_PULL_PU_PD_TYPE,/*109*/
> +	MTK_PULL_PU_PD_TYPE,/*110*/ MTK_PULL_PU_PD_TYPE,/*111*/
> +	MTK_PULL_PU_PD_TYPE,/*112*/ MTK_PULL_PU_PD_TYPE,/*113*/
> +	MTK_PULL_PU_PD_TYPE,/*114*/ MTK_PULL_PU_PD_TYPE,/*115*/
> +	MTK_PULL_PU_PD_TYPE,/*116*/ MTK_PULL_PU_PD_TYPE,/*117*/
>  	MTK_PULL_PU_PD_RSEL_TYPE,/*118*/ MTK_PULL_PU_PD_RSEL_TYPE,/*119*/
>  	MTK_PULL_PU_PD_RSEL_TYPE,/*120*/ MTK_PULL_PU_PD_RSEL_TYPE,/*121*/
>  	MTK_PULL_PU_PD_RSEL_TYPE,/*122*/ MTK_PULL_PU_PD_RSEL_TYPE,/*123*/
> -- 
> 2.36.1
> 

^ permalink raw reply	[flat|nested] 3+ messages in thread
* Re: [PATCH] pinctrl: mediatek: mt8192: Fix compile warnings
  2022-06-27 14:44 ` Nícolas F. R. A. Prado
@ 2022-06-28 14:14   ` Linus Walleij
  0 siblings, 0 replies; 3+ messages in thread
From: Linus Walleij @ 2022-06-28 14:14 UTC (permalink / raw)
  To: Nícolas F. R. A. Prado; +Cc: linux-gpio, Guodong Liu

On Mon, Jun 27, 2022 at 4:45 PM Nícolas F. R. A. Prado
<nfraprado@collabora.com> wrote:
> On Mon, Jun 27, 2022 at 01:57:43AM +0200, Linus Walleij wrote:
> > After applying patches I get these warnings:
> >
> >   drivers/pinctrl/mediatek/pinctrl-mt8192.c:1302:56:
> >   warning: "/*" within comment [-Wcomment]
> >   drivers/pinctrl/mediatek/pinctrl-mt8192.c:1362:56:
> >   warning: "/*" within comment [-Wcomment]
> >
> > Something is wrong with the missing end-slashes. Add them.
> >
> > Cc: Guodong Liu <guodong.liu@mediatek.com>
> > Cc: Nícolas F. R. A. Prado <nfraprado@collabora.com>
> > Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
>
> Hi,
>
> yes, this issue was noticed during review [1], and fixed on the following
> version [2], but since the commit before the correction was applied, this fix
> LGTM.
>
> Reviewed-by: Nícolas F. R. A. Prado <nfraprado@collabora.com>

Thanks, yeah the real problem is me lagging behind in reviewing
and applying patches and making mistakes like not seeing there
are newer patches in the front of the review queue...

Yours,
Linus Walleij

^ permalink raw reply	[flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-06-28 14:14 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-06-26 23:57 [PATCH] pinctrl: mediatek: mt8192: Fix compile warnings Linus Walleij
2022-06-27 14:44 ` Nícolas F. R. A. Prado
2022-06-28 14:14   ` Linus Walleij

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.