* [PATCH] dt-bindings: cpufreq: qcom-cpufreq-nvmem: fix board compatible in example
@ 2022-06-27 14:33 Krzysztof Kozlowski
2022-06-27 19:50 ` Rob Herring
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Krzysztof Kozlowski @ 2022-06-27 14:33 UTC (permalink / raw)
To: Ilia Lin, Andy Gross, Bjorn Andersson, Rafael J. Wysocki,
Viresh Kumar, Rob Herring, Krzysztof Kozlowski, linux-pm,
linux-arm-msm, devicetree, linux-kernel
Cc: Krzysztof Kozlowski, Rob Herring
In the example, alone compatible "qcom,qcs404" is not correct. Add
proper board compatibles for QCS404 Evaluation Board.
Reported-by: Rob Herring <robh@kernel.org>
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
Can be picked up independently, although the issue reported by Rob was
caused by:
https://lore.kernel.org/all/CAL_JsqKXDs=QHKob2Xy6vAFZfnkM9ggfmqf9TNA1hv8TScTmgQ@mail.gmail.com/
---
.../devicetree/bindings/cpufreq/qcom-cpufreq-nvmem.yaml | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/Documentation/devicetree/bindings/cpufreq/qcom-cpufreq-nvmem.yaml b/Documentation/devicetree/bindings/cpufreq/qcom-cpufreq-nvmem.yaml
index a9a776da5505..10b3a7a4af36 100644
--- a/Documentation/devicetree/bindings/cpufreq/qcom-cpufreq-nvmem.yaml
+++ b/Documentation/devicetree/bindings/cpufreq/qcom-cpufreq-nvmem.yaml
@@ -63,8 +63,8 @@ additionalProperties: true
examples:
- |
/ {
- model = "Qualcomm Technologies, Inc. QCS404";
- compatible = "qcom,qcs404";
+ model = "Qualcomm Technologies, Inc. QCS404 EVB 1000";
+ compatible = "qcom,qcs404-evb-1000", "qcom,qcs404-evb", "qcom,qcs404";
#address-cells = <2>;
#size-cells = <2>;
--
2.34.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] dt-bindings: cpufreq: qcom-cpufreq-nvmem: fix board compatible in example
2022-06-27 14:33 [PATCH] dt-bindings: cpufreq: qcom-cpufreq-nvmem: fix board compatible in example Krzysztof Kozlowski
@ 2022-06-27 19:50 ` Rob Herring
2022-06-28 0:45 ` Viresh Kumar
2022-06-28 7:54 ` Viresh Kumar
2022-06-28 9:09 ` Krzysztof Kozlowski
2 siblings, 1 reply; 6+ messages in thread
From: Rob Herring @ 2022-06-27 19:50 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Ilia Lin, Andy Gross, Bjorn Andersson, Rafael J. Wysocki,
Viresh Kumar, Krzysztof Kozlowski, linux-pm, linux-arm-msm,
devicetree, linux-kernel
On Mon, Jun 27, 2022 at 04:33:40PM +0200, Krzysztof Kozlowski wrote:
> In the example, alone compatible "qcom,qcs404" is not correct. Add
> proper board compatibles for QCS404 Evaluation Board.
>
> Reported-by: Rob Herring <robh@kernel.org>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>
> ---
>
> Can be picked up independently, although the issue reported by Rob was
> caused by:
> https://lore.kernel.org/all/CAL_JsqKXDs=QHKob2Xy6vAFZfnkM9ggfmqf9TNA1hv8TScTmgQ@mail.gmail.com/
Best to go in that tree unless it's going to take weeks...
> ---
> .../devicetree/bindings/cpufreq/qcom-cpufreq-nvmem.yaml | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Acked-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] dt-bindings: cpufreq: qcom-cpufreq-nvmem: fix board compatible in example
2022-06-27 19:50 ` Rob Herring
@ 2022-06-28 0:45 ` Viresh Kumar
2022-06-28 7:52 ` Krzysztof Kozlowski
0 siblings, 1 reply; 6+ messages in thread
From: Viresh Kumar @ 2022-06-28 0:45 UTC (permalink / raw)
To: Rob Herring
Cc: Krzysztof Kozlowski, Ilia Lin, Andy Gross, Bjorn Andersson,
Rafael J. Wysocki, Krzysztof Kozlowski, linux-pm, linux-arm-msm,
devicetree, linux-kernel
On 27-06-22, 13:50, Rob Herring wrote:
> On Mon, Jun 27, 2022 at 04:33:40PM +0200, Krzysztof Kozlowski wrote:
> > In the example, alone compatible "qcom,qcs404" is not correct. Add
> > proper board compatibles for QCS404 Evaluation Board.
> >
> > Reported-by: Rob Herring <robh@kernel.org>
> > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> >
> > ---
> >
> > Can be picked up independently, although the issue reported by Rob was
> > caused by:
> > https://lore.kernel.org/all/CAL_JsqKXDs=QHKob2Xy6vAFZfnkM9ggfmqf9TNA1hv8TScTmgQ@mail.gmail.com/
>
> Best to go in that tree unless it's going to take weeks...
Lemme know Krzysztof about the timing, I am going to send a pull
request for cpufreq fixes very soon, so I can take it as well if you
want.
> > ---
> > .../devicetree/bindings/cpufreq/qcom-cpufreq-nvmem.yaml | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
>
> Acked-by: Rob Herring <robh@kernel.org>
--
viresh
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] dt-bindings: cpufreq: qcom-cpufreq-nvmem: fix board compatible in example
2022-06-28 0:45 ` Viresh Kumar
@ 2022-06-28 7:52 ` Krzysztof Kozlowski
0 siblings, 0 replies; 6+ messages in thread
From: Krzysztof Kozlowski @ 2022-06-28 7:52 UTC (permalink / raw)
To: Viresh Kumar, Rob Herring
Cc: Ilia Lin, Andy Gross, Bjorn Andersson, Rafael J. Wysocki,
Krzysztof Kozlowski, linux-pm, linux-arm-msm, devicetree,
linux-kernel
On 28/06/2022 02:45, Viresh Kumar wrote:
> On 27-06-22, 13:50, Rob Herring wrote:
>> On Mon, Jun 27, 2022 at 04:33:40PM +0200, Krzysztof Kozlowski wrote:
>>> In the example, alone compatible "qcom,qcs404" is not correct. Add
>>> proper board compatibles for QCS404 Evaluation Board.
>>>
>>> Reported-by: Rob Herring <robh@kernel.org>
>>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>>>
>>> ---
>>>
>>> Can be picked up independently, although the issue reported by Rob was
>>> caused by:
>>> https://lore.kernel.org/all/CAL_JsqKXDs=QHKob2Xy6vAFZfnkM9ggfmqf9TNA1hv8TScTmgQ@mail.gmail.com/
>>
>> Best to go in that tree unless it's going to take weeks...
>
> Lemme know Krzysztof about the timing, I am going to send a pull
> request for cpufreq fixes very soon, so I can take it as well if you
> want.
Thanks Viresh, but I think Rob has a point here - this should be rather
same tree, otherwise checks on your tree complain about undocumented
board compatibles from this patch (because they are in this original tree).
I'll take it and add to my pull request for Rob or Bjorn.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] dt-bindings: cpufreq: qcom-cpufreq-nvmem: fix board compatible in example
2022-06-27 14:33 [PATCH] dt-bindings: cpufreq: qcom-cpufreq-nvmem: fix board compatible in example Krzysztof Kozlowski
2022-06-27 19:50 ` Rob Herring
@ 2022-06-28 7:54 ` Viresh Kumar
2022-06-28 9:09 ` Krzysztof Kozlowski
2 siblings, 0 replies; 6+ messages in thread
From: Viresh Kumar @ 2022-06-28 7:54 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Ilia Lin, Andy Gross, Bjorn Andersson, Rafael J. Wysocki,
Rob Herring, Krzysztof Kozlowski, linux-pm, linux-arm-msm,
devicetree, linux-kernel, Rob Herring
On 27-06-22, 16:33, Krzysztof Kozlowski wrote:
> In the example, alone compatible "qcom,qcs404" is not correct. Add
> proper board compatibles for QCS404 Evaluation Board.
>
> Reported-by: Rob Herring <robh@kernel.org>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>
> ---
>
> Can be picked up independently, although the issue reported by Rob was
> caused by:
> https://lore.kernel.org/all/CAL_JsqKXDs=QHKob2Xy6vAFZfnkM9ggfmqf9TNA1hv8TScTmgQ@mail.gmail.com/
> ---
> .../devicetree/bindings/cpufreq/qcom-cpufreq-nvmem.yaml | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/cpufreq/qcom-cpufreq-nvmem.yaml b/Documentation/devicetree/bindings/cpufreq/qcom-cpufreq-nvmem.yaml
> index a9a776da5505..10b3a7a4af36 100644
> --- a/Documentation/devicetree/bindings/cpufreq/qcom-cpufreq-nvmem.yaml
> +++ b/Documentation/devicetree/bindings/cpufreq/qcom-cpufreq-nvmem.yaml
> @@ -63,8 +63,8 @@ additionalProperties: true
> examples:
> - |
> / {
> - model = "Qualcomm Technologies, Inc. QCS404";
> - compatible = "qcom,qcs404";
> + model = "Qualcomm Technologies, Inc. QCS404 EVB 1000";
> + compatible = "qcom,qcs404-evb-1000", "qcom,qcs404-evb", "qcom,qcs404";
> #address-cells = <2>;
> #size-cells = <2>;
Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
--
viresh
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] dt-bindings: cpufreq: qcom-cpufreq-nvmem: fix board compatible in example
2022-06-27 14:33 [PATCH] dt-bindings: cpufreq: qcom-cpufreq-nvmem: fix board compatible in example Krzysztof Kozlowski
2022-06-27 19:50 ` Rob Herring
2022-06-28 7:54 ` Viresh Kumar
@ 2022-06-28 9:09 ` Krzysztof Kozlowski
2 siblings, 0 replies; 6+ messages in thread
From: Krzysztof Kozlowski @ 2022-06-28 9:09 UTC (permalink / raw)
To: linux-kernel, robh+dt, krzysztof.kozlowski+dt,
krzysztof.kozlowski, bjorn.andersson, agross, linux-pm,
Viresh Kumar, rafael, ilia.lin, devicetree, linux-arm-msm
Cc: robh
On Mon, 27 Jun 2022 16:33:40 +0200, Krzysztof Kozlowski wrote:
> In the example, alone compatible "qcom,qcs404" is not correct. Add
> proper board compatibles for QCS404 Evaluation Board.
>
>
Applied, thanks!
[1/1] dt-bindings: cpufreq: qcom-cpufreq-nvmem: fix board compatible in example
https://git.kernel.org/krzk/linux-dt/c/062529700fdb843eee921961eb3cbc6a51419491
Best regards,
--
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2022-06-28 9:10 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-06-27 14:33 [PATCH] dt-bindings: cpufreq: qcom-cpufreq-nvmem: fix board compatible in example Krzysztof Kozlowski
2022-06-27 19:50 ` Rob Herring
2022-06-28 0:45 ` Viresh Kumar
2022-06-28 7:52 ` Krzysztof Kozlowski
2022-06-28 7:54 ` Viresh Kumar
2022-06-28 9:09 ` Krzysztof Kozlowski
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.