* [kvm-unit-tests PATCH v2] s390x/intercept: Test invalid prefix argument to SET PREFIX
@ 2022-06-27 15:24 Janis Schoetterl-Glausch
2022-06-28 9:03 ` Claudio Imbrenda
0 siblings, 1 reply; 2+ messages in thread
From: Janis Schoetterl-Glausch @ 2022-06-27 15:24 UTC (permalink / raw)
To: Thomas Huth, Janosch Frank, Claudio Imbrenda
Cc: Janis Schoetterl-Glausch, David Hildenbrand, kvm, linux-s390
According to the architecture, SET PREFIX must try to access the new
prefix area and recognize an addressing exception if the area is not
accessible.
Test that the exception occurs when we try to set a prefix higher
than the available memory.
Signed-off-by: Janis Schoetterl-Glausch <scgl@linux.ibm.com>
---
v1 -> v2
* report skip if we're running with too much memory (thanks Claudio)
s390x/intercept.c | 16 ++++++++++++++++
1 file changed, 16 insertions(+)
diff --git a/s390x/intercept.c b/s390x/intercept.c
index 86e57e11..54bed5a4 100644
--- a/s390x/intercept.c
+++ b/s390x/intercept.c
@@ -74,6 +74,22 @@ static void test_spx(void)
expect_pgm_int();
asm volatile(" spx 0(%0) " : : "r"(-8L));
check_pgm_int_code(PGM_INT_CODE_ADDRESSING);
+
+ new_prefix = get_ram_size() & 0x7fffe000;
+ if (get_ram_size() - new_prefix < 2 * PAGE_SIZE) {
+ expect_pgm_int();
+ asm volatile("spx %0 " : : "Q"(new_prefix));
+ check_pgm_int_code(PGM_INT_CODE_ADDRESSING);
+
+ /*
+ * Cannot test inaccessibility of the second page the same way.
+ * If we try to use the last page as first half of the prefix
+ * area and our ram size is a multiple of 8k, after SPX aligns
+ * the address to 8k we have a completely accessible area.
+ */
+ } else {
+ report_skip("inaccessible prefix area");
+ }
}
/* Test the STORE CPU ADDRESS instruction */
base-commit: 110c69492b53f0070e1bbce986fb635e72a423b4
--
2.36.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [kvm-unit-tests PATCH v2] s390x/intercept: Test invalid prefix argument to SET PREFIX
2022-06-27 15:24 [kvm-unit-tests PATCH v2] s390x/intercept: Test invalid prefix argument to SET PREFIX Janis Schoetterl-Glausch
@ 2022-06-28 9:03 ` Claudio Imbrenda
0 siblings, 0 replies; 2+ messages in thread
From: Claudio Imbrenda @ 2022-06-28 9:03 UTC (permalink / raw)
To: Janis Schoetterl-Glausch
Cc: Thomas Huth, Janosch Frank, David Hildenbrand, kvm, linux-s390
On Mon, 27 Jun 2022 17:24:11 +0200
Janis Schoetterl-Glausch <scgl@linux.ibm.com> wrote:
> According to the architecture, SET PREFIX must try to access the new
> prefix area and recognize an addressing exception if the area is not
> accessible.
> Test that the exception occurs when we try to set a prefix higher
> than the available memory.
>
> Signed-off-by: Janis Schoetterl-Glausch <scgl@linux.ibm.com>
thanks, queued
> ---
>
> v1 -> v2
> * report skip if we're running with too much memory (thanks Claudio)
>
>
> s390x/intercept.c | 16 ++++++++++++++++
> 1 file changed, 16 insertions(+)
>
> diff --git a/s390x/intercept.c b/s390x/intercept.c
> index 86e57e11..54bed5a4 100644
> --- a/s390x/intercept.c
> +++ b/s390x/intercept.c
> @@ -74,6 +74,22 @@ static void test_spx(void)
> expect_pgm_int();
> asm volatile(" spx 0(%0) " : : "r"(-8L));
> check_pgm_int_code(PGM_INT_CODE_ADDRESSING);
> +
> + new_prefix = get_ram_size() & 0x7fffe000;
> + if (get_ram_size() - new_prefix < 2 * PAGE_SIZE) {
> + expect_pgm_int();
> + asm volatile("spx %0 " : : "Q"(new_prefix));
> + check_pgm_int_code(PGM_INT_CODE_ADDRESSING);
> +
> + /*
> + * Cannot test inaccessibility of the second page the same way.
> + * If we try to use the last page as first half of the prefix
> + * area and our ram size is a multiple of 8k, after SPX aligns
> + * the address to 8k we have a completely accessible area.
> + */
> + } else {
> + report_skip("inaccessible prefix area");
> + }
> }
>
> /* Test the STORE CPU ADDRESS instruction */
>
> base-commit: 110c69492b53f0070e1bbce986fb635e72a423b4
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-06-28 9:03 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-06-27 15:24 [kvm-unit-tests PATCH v2] s390x/intercept: Test invalid prefix argument to SET PREFIX Janis Schoetterl-Glausch
2022-06-28 9:03 ` Claudio Imbrenda
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.