* [PATCH 0/3] Break VM to rq reference loop
@ 2022-06-14 18:43 ` Ramalingam C
0 siblings, 0 replies; 19+ messages in thread
From: Ramalingam C @ 2022-06-14 18:43 UTC (permalink / raw)
To: intel-gfx, dri-devel; +Cc: Hellstrom Thomas, Matthew Auld
The i915_request holds a reference to intel_context, which in
turn holds a reference on the VM. But the dma-resv update for
VM_BIND feature would require VM hold a reference to the
i915_request through dma-resv fences of VM_PRIVATE objects
(which share a per VM dma-resv object).
Thus, we have a circular reference pattern causing the VM
reference to never reach 0, hence VM is not destroyed.
Break this by reverting the below patch which is making the
i915_request to hold a reference on intel_context.
"drm/i915: Hold reference to intel_context over life of i915_request"
This means we can't access rq->engine in i915_fence_get_driver_name()
as user do not hold a reference on rq->engine here. So, instead
store required device private pointer in 'rq->i915' and use it.
Niranjana Vishwanathapura (2):
drm/i915: Do not access rq->engine without a reference
Revert "drm/i915: Hold reference to intel_context over life of
i915_request"
Ramalingam C (1):
drm/i915: Do not use reserved requests for virtual engines
drivers/gpu/drm/i915/i915_request.c | 55 ++++++++++++++++++-----------
drivers/gpu/drm/i915/i915_request.h | 2 ++
2 files changed, 36 insertions(+), 21 deletions(-)
--
2.20.1
^ permalink raw reply [flat|nested] 19+ messages in thread
* [Intel-gfx] [PATCH 0/3] Break VM to rq reference loop
@ 2022-06-14 18:43 ` Ramalingam C
0 siblings, 0 replies; 19+ messages in thread
From: Ramalingam C @ 2022-06-14 18:43 UTC (permalink / raw)
To: intel-gfx, dri-devel; +Cc: Hellstrom Thomas, Matthew Auld
The i915_request holds a reference to intel_context, which in
turn holds a reference on the VM. But the dma-resv update for
VM_BIND feature would require VM hold a reference to the
i915_request through dma-resv fences of VM_PRIVATE objects
(which share a per VM dma-resv object).
Thus, we have a circular reference pattern causing the VM
reference to never reach 0, hence VM is not destroyed.
Break this by reverting the below patch which is making the
i915_request to hold a reference on intel_context.
"drm/i915: Hold reference to intel_context over life of i915_request"
This means we can't access rq->engine in i915_fence_get_driver_name()
as user do not hold a reference on rq->engine here. So, instead
store required device private pointer in 'rq->i915' and use it.
Niranjana Vishwanathapura (2):
drm/i915: Do not access rq->engine without a reference
Revert "drm/i915: Hold reference to intel_context over life of
i915_request"
Ramalingam C (1):
drm/i915: Do not use reserved requests for virtual engines
drivers/gpu/drm/i915/i915_request.c | 55 ++++++++++++++++++-----------
drivers/gpu/drm/i915/i915_request.h | 2 ++
2 files changed, 36 insertions(+), 21 deletions(-)
--
2.20.1
^ permalink raw reply [flat|nested] 19+ messages in thread
* [PATCH 1/3] drm/i915: Do not access rq->engine without a reference
2022-06-14 18:43 ` [Intel-gfx] " Ramalingam C
@ 2022-06-14 18:43 ` Ramalingam C
-1 siblings, 0 replies; 19+ messages in thread
From: Ramalingam C @ 2022-06-14 18:43 UTC (permalink / raw)
To: intel-gfx, dri-devel
Cc: Matthew Brost, Niranjana Vishwanathapura, Hellstrom Thomas, Matthew Auld
From: Niranjana Vishwanathapura <niranjana.vishwanathapura@intel.com>
In i915_fence_get_driver_name(), user may not hold a
reference to rq->engine. Hence do not access it. Instead,
store required device private pointer in 'rq->i915' and use it.
Signed-off-by: Niranjana Vishwanathapura <niranjana.vishwanathapura@intel.com>
Suggested-by: Matthew Brost <matthew.brost@intel.com>
---
drivers/gpu/drm/i915/i915_request.c | 3 ++-
drivers/gpu/drm/i915/i915_request.h | 2 ++
2 files changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/i915_request.c b/drivers/gpu/drm/i915/i915_request.c
index 73d5195146b0..7f6998bf390c 100644
--- a/drivers/gpu/drm/i915/i915_request.c
+++ b/drivers/gpu/drm/i915/i915_request.c
@@ -60,7 +60,7 @@ static struct kmem_cache *slab_execute_cbs;
static const char *i915_fence_get_driver_name(struct dma_fence *fence)
{
- return dev_name(to_request(fence)->engine->i915->drm.dev);
+ return dev_name(to_request(fence)->i915->drm.dev);
}
static const char *i915_fence_get_timeline_name(struct dma_fence *fence)
@@ -937,6 +937,7 @@ __i915_request_create(struct intel_context *ce, gfp_t gfp)
rq->engine = ce->engine;
rq->ring = ce->ring;
rq->execution_mask = ce->engine->mask;
+ rq->i915 = ce->engine->i915;
ret = intel_timeline_get_seqno(tl, rq, &seqno);
if (ret)
diff --git a/drivers/gpu/drm/i915/i915_request.h b/drivers/gpu/drm/i915/i915_request.h
index 28b1f9db5487..47041ec68df8 100644
--- a/drivers/gpu/drm/i915/i915_request.h
+++ b/drivers/gpu/drm/i915/i915_request.h
@@ -196,6 +196,8 @@ struct i915_request {
struct dma_fence fence;
spinlock_t lock;
+ struct drm_i915_private *i915;
+
/**
* Context and ring buffer related to this request
* Contexts are refcounted, so when this request is associated with a
--
2.20.1
^ permalink raw reply related [flat|nested] 19+ messages in thread
* [Intel-gfx] [PATCH 1/3] drm/i915: Do not access rq->engine without a reference
@ 2022-06-14 18:43 ` Ramalingam C
0 siblings, 0 replies; 19+ messages in thread
From: Ramalingam C @ 2022-06-14 18:43 UTC (permalink / raw)
To: intel-gfx, dri-devel; +Cc: Hellstrom Thomas, Matthew Auld
From: Niranjana Vishwanathapura <niranjana.vishwanathapura@intel.com>
In i915_fence_get_driver_name(), user may not hold a
reference to rq->engine. Hence do not access it. Instead,
store required device private pointer in 'rq->i915' and use it.
Signed-off-by: Niranjana Vishwanathapura <niranjana.vishwanathapura@intel.com>
Suggested-by: Matthew Brost <matthew.brost@intel.com>
---
drivers/gpu/drm/i915/i915_request.c | 3 ++-
drivers/gpu/drm/i915/i915_request.h | 2 ++
2 files changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/i915_request.c b/drivers/gpu/drm/i915/i915_request.c
index 73d5195146b0..7f6998bf390c 100644
--- a/drivers/gpu/drm/i915/i915_request.c
+++ b/drivers/gpu/drm/i915/i915_request.c
@@ -60,7 +60,7 @@ static struct kmem_cache *slab_execute_cbs;
static const char *i915_fence_get_driver_name(struct dma_fence *fence)
{
- return dev_name(to_request(fence)->engine->i915->drm.dev);
+ return dev_name(to_request(fence)->i915->drm.dev);
}
static const char *i915_fence_get_timeline_name(struct dma_fence *fence)
@@ -937,6 +937,7 @@ __i915_request_create(struct intel_context *ce, gfp_t gfp)
rq->engine = ce->engine;
rq->ring = ce->ring;
rq->execution_mask = ce->engine->mask;
+ rq->i915 = ce->engine->i915;
ret = intel_timeline_get_seqno(tl, rq, &seqno);
if (ret)
diff --git a/drivers/gpu/drm/i915/i915_request.h b/drivers/gpu/drm/i915/i915_request.h
index 28b1f9db5487..47041ec68df8 100644
--- a/drivers/gpu/drm/i915/i915_request.h
+++ b/drivers/gpu/drm/i915/i915_request.h
@@ -196,6 +196,8 @@ struct i915_request {
struct dma_fence fence;
spinlock_t lock;
+ struct drm_i915_private *i915;
+
/**
* Context and ring buffer related to this request
* Contexts are refcounted, so when this request is associated with a
--
2.20.1
^ permalink raw reply related [flat|nested] 19+ messages in thread
* [PATCH 2/3] Revert "drm/i915: Hold reference to intel_context over life of i915_request"
2022-06-14 18:43 ` [Intel-gfx] " Ramalingam C
@ 2022-06-14 18:43 ` Ramalingam C
-1 siblings, 0 replies; 19+ messages in thread
From: Ramalingam C @ 2022-06-14 18:43 UTC (permalink / raw)
To: intel-gfx, dri-devel
Cc: Matthew Brost, Niranjana Vishwanathapura, Hellstrom Thomas, Matthew Auld
From: Niranjana Vishwanathapura <niranjana.vishwanathapura@intel.com>
This reverts commit 1e98d8c52ed5dfbaf273c4423c636525c2ce59e7.
The problem with this patch is that it makes i915_request to hold a
reference to intel_context, which in turn holds a reference on the VM.
This strong back referencing can lead to reference loops which leads
to resource leak.
An example is the upcoming VM_BIND work which requires VM to hold
a reference to some shared VM specific BO. But this BO's dma-resv
fences holds reference to the i915_request thus leading to reference
loop.
Signed-off-by: Niranjana Vishwanathapura <niranjana.vishwanathapura@intel.com>
Signed-off-by: Ramalingam C <ramalingam.c@intel.com>
Suggested-by: Matthew Brost <matthew.brost@intel.com>
---
drivers/gpu/drm/i915/i915_request.c | 55 +++++++++++++++++------------
1 file changed, 32 insertions(+), 23 deletions(-)
diff --git a/drivers/gpu/drm/i915/i915_request.c b/drivers/gpu/drm/i915/i915_request.c
index 7f6998bf390c..c71905d8e154 100644
--- a/drivers/gpu/drm/i915/i915_request.c
+++ b/drivers/gpu/drm/i915/i915_request.c
@@ -134,17 +134,39 @@ static void i915_fence_release(struct dma_fence *fence)
i915_sw_fence_fini(&rq->semaphore);
/*
- * Keep one request on each engine for reserved use under mempressure,
- * do not use with virtual engines as this really is only needed for
- * kernel contexts.
+ * Keep one request on each engine for reserved use under mempressure
+ *
+ * We do not hold a reference to the engine here and so have to be
+ * very careful in what rq->engine we poke. The virtual engine is
+ * referenced via the rq->context and we released that ref during
+ * i915_request_retire(), ergo we must not dereference a virtual
+ * engine here. Not that we would want to, as the only consumer of
+ * the reserved engine->request_pool is the power management parking,
+ * which must-not-fail, and that is only run on the physical engines.
+ *
+ * Since the request must have been executed to be have completed,
+ * we know that it will have been processed by the HW and will
+ * not be unsubmitted again, so rq->engine and rq->execution_mask
+ * at this point is stable. rq->execution_mask will be a single
+ * bit if the last and _only_ engine it could execution on was a
+ * physical engine, if it's multiple bits then it started on and
+ * could still be on a virtual engine. Thus if the mask is not a
+ * power-of-two we assume that rq->engine may still be a virtual
+ * engine and so a dangling invalid pointer that we cannot dereference
+ *
+ * For example, consider the flow of a bonded request through a virtual
+ * engine. The request is created with a wide engine mask (all engines
+ * that we might execute on). On processing the bond, the request mask
+ * is reduced to one or more engines. If the request is subsequently
+ * bound to a single engine, it will then be constrained to only
+ * execute on that engine and never returned to the virtual engine
+ * after timeslicing away, see __unwind_incomplete_requests(). Thus we
+ * know that if the rq->execution_mask is a single bit, rq->engine
+ * can be a physical engine with the exact corresponding mask.
*/
- if (!intel_engine_is_virtual(rq->engine) &&
- !cmpxchg(&rq->engine->request_pool, NULL, rq)) {
- intel_context_put(rq->context);
+ if (is_power_of_2(rq->execution_mask) &&
+ !cmpxchg(&rq->engine->request_pool, NULL, rq))
return;
- }
-
- intel_context_put(rq->context);
kmem_cache_free(slab_requests, rq);
}
@@ -921,19 +943,7 @@ __i915_request_create(struct intel_context *ce, gfp_t gfp)
}
}
- /*
- * Hold a reference to the intel_context over life of an i915_request.
- * Without this an i915_request can exist after the context has been
- * destroyed (e.g. request retired, context closed, but user space holds
- * a reference to the request from an out fence). In the case of GuC
- * submission + virtual engine, the engine that the request references
- * is also destroyed which can trigger bad pointer dref in fence ops
- * (e.g. i915_fence_get_driver_name). We could likely change these
- * functions to avoid touching the engine but let's just be safe and
- * hold the intel_context reference. In execlist mode the request always
- * eventually points to a physical engine so this isn't an issue.
- */
- rq->context = intel_context_get(ce);
+ rq->context = ce;
rq->engine = ce->engine;
rq->ring = ce->ring;
rq->execution_mask = ce->engine->mask;
@@ -1009,7 +1019,6 @@ __i915_request_create(struct intel_context *ce, gfp_t gfp)
GEM_BUG_ON(!list_empty(&rq->sched.waiters_list));
err_free:
- intel_context_put(ce);
kmem_cache_free(slab_requests, rq);
err_unreserve:
intel_context_unpin(ce);
--
2.20.1
^ permalink raw reply related [flat|nested] 19+ messages in thread
* [Intel-gfx] [PATCH 2/3] Revert "drm/i915: Hold reference to intel_context over life of i915_request"
@ 2022-06-14 18:43 ` Ramalingam C
0 siblings, 0 replies; 19+ messages in thread
From: Ramalingam C @ 2022-06-14 18:43 UTC (permalink / raw)
To: intel-gfx, dri-devel; +Cc: Hellstrom Thomas, Matthew Auld
From: Niranjana Vishwanathapura <niranjana.vishwanathapura@intel.com>
This reverts commit 1e98d8c52ed5dfbaf273c4423c636525c2ce59e7.
The problem with this patch is that it makes i915_request to hold a
reference to intel_context, which in turn holds a reference on the VM.
This strong back referencing can lead to reference loops which leads
to resource leak.
An example is the upcoming VM_BIND work which requires VM to hold
a reference to some shared VM specific BO. But this BO's dma-resv
fences holds reference to the i915_request thus leading to reference
loop.
Signed-off-by: Niranjana Vishwanathapura <niranjana.vishwanathapura@intel.com>
Signed-off-by: Ramalingam C <ramalingam.c@intel.com>
Suggested-by: Matthew Brost <matthew.brost@intel.com>
---
drivers/gpu/drm/i915/i915_request.c | 55 +++++++++++++++++------------
1 file changed, 32 insertions(+), 23 deletions(-)
diff --git a/drivers/gpu/drm/i915/i915_request.c b/drivers/gpu/drm/i915/i915_request.c
index 7f6998bf390c..c71905d8e154 100644
--- a/drivers/gpu/drm/i915/i915_request.c
+++ b/drivers/gpu/drm/i915/i915_request.c
@@ -134,17 +134,39 @@ static void i915_fence_release(struct dma_fence *fence)
i915_sw_fence_fini(&rq->semaphore);
/*
- * Keep one request on each engine for reserved use under mempressure,
- * do not use with virtual engines as this really is only needed for
- * kernel contexts.
+ * Keep one request on each engine for reserved use under mempressure
+ *
+ * We do not hold a reference to the engine here and so have to be
+ * very careful in what rq->engine we poke. The virtual engine is
+ * referenced via the rq->context and we released that ref during
+ * i915_request_retire(), ergo we must not dereference a virtual
+ * engine here. Not that we would want to, as the only consumer of
+ * the reserved engine->request_pool is the power management parking,
+ * which must-not-fail, and that is only run on the physical engines.
+ *
+ * Since the request must have been executed to be have completed,
+ * we know that it will have been processed by the HW and will
+ * not be unsubmitted again, so rq->engine and rq->execution_mask
+ * at this point is stable. rq->execution_mask will be a single
+ * bit if the last and _only_ engine it could execution on was a
+ * physical engine, if it's multiple bits then it started on and
+ * could still be on a virtual engine. Thus if the mask is not a
+ * power-of-two we assume that rq->engine may still be a virtual
+ * engine and so a dangling invalid pointer that we cannot dereference
+ *
+ * For example, consider the flow of a bonded request through a virtual
+ * engine. The request is created with a wide engine mask (all engines
+ * that we might execute on). On processing the bond, the request mask
+ * is reduced to one or more engines. If the request is subsequently
+ * bound to a single engine, it will then be constrained to only
+ * execute on that engine and never returned to the virtual engine
+ * after timeslicing away, see __unwind_incomplete_requests(). Thus we
+ * know that if the rq->execution_mask is a single bit, rq->engine
+ * can be a physical engine with the exact corresponding mask.
*/
- if (!intel_engine_is_virtual(rq->engine) &&
- !cmpxchg(&rq->engine->request_pool, NULL, rq)) {
- intel_context_put(rq->context);
+ if (is_power_of_2(rq->execution_mask) &&
+ !cmpxchg(&rq->engine->request_pool, NULL, rq))
return;
- }
-
- intel_context_put(rq->context);
kmem_cache_free(slab_requests, rq);
}
@@ -921,19 +943,7 @@ __i915_request_create(struct intel_context *ce, gfp_t gfp)
}
}
- /*
- * Hold a reference to the intel_context over life of an i915_request.
- * Without this an i915_request can exist after the context has been
- * destroyed (e.g. request retired, context closed, but user space holds
- * a reference to the request from an out fence). In the case of GuC
- * submission + virtual engine, the engine that the request references
- * is also destroyed which can trigger bad pointer dref in fence ops
- * (e.g. i915_fence_get_driver_name). We could likely change these
- * functions to avoid touching the engine but let's just be safe and
- * hold the intel_context reference. In execlist mode the request always
- * eventually points to a physical engine so this isn't an issue.
- */
- rq->context = intel_context_get(ce);
+ rq->context = ce;
rq->engine = ce->engine;
rq->ring = ce->ring;
rq->execution_mask = ce->engine->mask;
@@ -1009,7 +1019,6 @@ __i915_request_create(struct intel_context *ce, gfp_t gfp)
GEM_BUG_ON(!list_empty(&rq->sched.waiters_list));
err_free:
- intel_context_put(ce);
kmem_cache_free(slab_requests, rq);
err_unreserve:
intel_context_unpin(ce);
--
2.20.1
^ permalink raw reply related [flat|nested] 19+ messages in thread
* [PATCH 3/3] drm/i915: Do not use reserved requests for virtual engines
2022-06-14 18:43 ` [Intel-gfx] " Ramalingam C
@ 2022-06-14 18:43 ` Ramalingam C
-1 siblings, 0 replies; 19+ messages in thread
From: Ramalingam C @ 2022-06-14 18:43 UTC (permalink / raw)
To: intel-gfx, dri-devel; +Cc: Matthew Brost, Hellstrom Thomas, Matthew Auld
Do not use reserved requests for virtual engines as this is only
needed for kernel contexts.
Signed-off-by: Ramalingam C <ramalingam.c@intel.com>
Suggested-by: Matthew Brost <matthew.brost@intel.com>
---
drivers/gpu/drm/i915/i915_request.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/i915_request.c b/drivers/gpu/drm/i915/i915_request.c
index c71905d8e154..f0392b053bca 100644
--- a/drivers/gpu/drm/i915/i915_request.c
+++ b/drivers/gpu/drm/i915/i915_request.c
@@ -135,6 +135,8 @@ static void i915_fence_release(struct dma_fence *fence)
/*
* Keep one request on each engine for reserved use under mempressure
+ * do not use with virtual engines as this really is only needed for
+ * kernel contexts.
*
* We do not hold a reference to the engine here and so have to be
* very careful in what rq->engine we poke. The virtual engine is
@@ -164,7 +166,8 @@ static void i915_fence_release(struct dma_fence *fence)
* know that if the rq->execution_mask is a single bit, rq->engine
* can be a physical engine with the exact corresponding mask.
*/
- if (is_power_of_2(rq->execution_mask) &&
+ if (!intel_engine_is_virtual(rq->engine) &&
+ is_power_of_2(rq->execution_mask) &&
!cmpxchg(&rq->engine->request_pool, NULL, rq))
return;
--
2.20.1
^ permalink raw reply related [flat|nested] 19+ messages in thread
* [Intel-gfx] [PATCH 3/3] drm/i915: Do not use reserved requests for virtual engines
@ 2022-06-14 18:43 ` Ramalingam C
0 siblings, 0 replies; 19+ messages in thread
From: Ramalingam C @ 2022-06-14 18:43 UTC (permalink / raw)
To: intel-gfx, dri-devel; +Cc: Hellstrom Thomas, Matthew Auld
Do not use reserved requests for virtual engines as this is only
needed for kernel contexts.
Signed-off-by: Ramalingam C <ramalingam.c@intel.com>
Suggested-by: Matthew Brost <matthew.brost@intel.com>
---
drivers/gpu/drm/i915/i915_request.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/i915_request.c b/drivers/gpu/drm/i915/i915_request.c
index c71905d8e154..f0392b053bca 100644
--- a/drivers/gpu/drm/i915/i915_request.c
+++ b/drivers/gpu/drm/i915/i915_request.c
@@ -135,6 +135,8 @@ static void i915_fence_release(struct dma_fence *fence)
/*
* Keep one request on each engine for reserved use under mempressure
+ * do not use with virtual engines as this really is only needed for
+ * kernel contexts.
*
* We do not hold a reference to the engine here and so have to be
* very careful in what rq->engine we poke. The virtual engine is
@@ -164,7 +166,8 @@ static void i915_fence_release(struct dma_fence *fence)
* know that if the rq->execution_mask is a single bit, rq->engine
* can be a physical engine with the exact corresponding mask.
*/
- if (is_power_of_2(rq->execution_mask) &&
+ if (!intel_engine_is_virtual(rq->engine) &&
+ is_power_of_2(rq->execution_mask) &&
!cmpxchg(&rq->engine->request_pool, NULL, rq))
return;
--
2.20.1
^ permalink raw reply related [flat|nested] 19+ messages in thread
* [Intel-gfx] ✗ Fi.CI.SPARSE: warning for Break VM to rq reference loop
2022-06-14 18:43 ` [Intel-gfx] " Ramalingam C
` (3 preceding siblings ...)
(?)
@ 2022-06-14 19:56 ` Patchwork
-1 siblings, 0 replies; 19+ messages in thread
From: Patchwork @ 2022-06-14 19:56 UTC (permalink / raw)
To: Ramalingam C; +Cc: intel-gfx
== Series Details ==
Series: Break VM to rq reference loop
URL : https://patchwork.freedesktop.org/series/105122/
State : warning
== Summary ==
Error: dim sparse failed
Sparse version: v0.6.2
Fast mode used, each commit won't be checked separately.
^ permalink raw reply [flat|nested] 19+ messages in thread
* [Intel-gfx] ✓ Fi.CI.BAT: success for Break VM to rq reference loop
2022-06-14 18:43 ` [Intel-gfx] " Ramalingam C
` (4 preceding siblings ...)
(?)
@ 2022-06-14 20:27 ` Patchwork
-1 siblings, 0 replies; 19+ messages in thread
From: Patchwork @ 2022-06-14 20:27 UTC (permalink / raw)
To: Ramalingam C; +Cc: intel-gfx
[-- Attachment #1: Type: text/plain, Size: 11423 bytes --]
== Series Details ==
Series: Break VM to rq reference loop
URL : https://patchwork.freedesktop.org/series/105122/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_11757 -> Patchwork_105122v1
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105122v1/index.html
Participating hosts (46 -> 45)
------------------------------
Additional (2): fi-rkl-11600 bat-jsl-2
Missing (3): fi-ctg-p8600 fi-bdw-samus fi-hsw-4200u
Known issues
------------
Here are the changes found in Patchwork_105122v1 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_huc_copy@huc-copy:
- fi-rkl-11600: NOTRUN -> [SKIP][1] ([i915#2190])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105122v1/fi-rkl-11600/igt@gem_huc_copy@huc-copy.html
* igt@gem_lmem_swapping@basic:
- fi-rkl-11600: NOTRUN -> [SKIP][2] ([i915#4613]) +3 similar issues
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105122v1/fi-rkl-11600/igt@gem_lmem_swapping@basic.html
* igt@gem_tiled_pread_basic:
- fi-rkl-11600: NOTRUN -> [SKIP][3] ([i915#3282])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105122v1/fi-rkl-11600/igt@gem_tiled_pread_basic.html
* igt@i915_pm_backlight@basic-brightness:
- fi-rkl-11600: NOTRUN -> [SKIP][4] ([i915#3012])
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105122v1/fi-rkl-11600/igt@i915_pm_backlight@basic-brightness.html
* igt@i915_pm_rpm@module-reload:
- fi-bsw-kefka: [PASS][5] -> [DMESG-WARN][6] ([i915#1982])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11757/fi-bsw-kefka/igt@i915_pm_rpm@module-reload.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105122v1/fi-bsw-kefka/igt@i915_pm_rpm@module-reload.html
- bat-adlp-4: [PASS][7] -> [DMESG-WARN][8] ([i915#3576]) +1 similar issue
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11757/bat-adlp-4/igt@i915_pm_rpm@module-reload.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105122v1/bat-adlp-4/igt@i915_pm_rpm@module-reload.html
* igt@i915_selftest@live@gem:
- fi-blb-e6850: NOTRUN -> [DMESG-FAIL][9] ([i915#4528])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105122v1/fi-blb-e6850/igt@i915_selftest@live@gem.html
* igt@i915_selftest@live@hangcheck:
- bat-dg1-5: [PASS][10] -> [DMESG-FAIL][11] ([i915#4494] / [i915#4957])
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11757/bat-dg1-5/igt@i915_selftest@live@hangcheck.html
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105122v1/bat-dg1-5/igt@i915_selftest@live@hangcheck.html
- bat-dg1-6: [PASS][12] -> [DMESG-FAIL][13] ([i915#4494] / [i915#4957])
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11757/bat-dg1-6/igt@i915_selftest@live@hangcheck.html
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105122v1/bat-dg1-6/igt@i915_selftest@live@hangcheck.html
* igt@i915_suspend@basic-s3-without-i915:
- fi-rkl-11600: NOTRUN -> [INCOMPLETE][14] ([i915#5982])
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105122v1/fi-rkl-11600/igt@i915_suspend@basic-s3-without-i915.html
* igt@kms_busy@basic@modeset:
- fi-tgl-u2: [PASS][15] -> [DMESG-WARN][16] ([i915#402])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11757/fi-tgl-u2/igt@kms_busy@basic@modeset.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105122v1/fi-tgl-u2/igt@kms_busy@basic@modeset.html
* igt@kms_chamelium@common-hpd-after-suspend:
- fi-pnv-d510: NOTRUN -> [SKIP][17] ([fdo#109271])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105122v1/fi-pnv-d510/igt@kms_chamelium@common-hpd-after-suspend.html
* igt@kms_chamelium@hdmi-edid-read:
- fi-rkl-11600: NOTRUN -> [SKIP][18] ([fdo#111827]) +7 similar issues
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105122v1/fi-rkl-11600/igt@kms_chamelium@hdmi-edid-read.html
* igt@kms_cursor_legacy@basic-busy-flip-before-cursor-legacy:
- fi-rkl-11600: NOTRUN -> [SKIP][19] ([i915#4103]) +1 similar issue
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105122v1/fi-rkl-11600/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-legacy.html
* igt@kms_force_connector_basic@force-load-detect:
- fi-rkl-11600: NOTRUN -> [SKIP][20] ([fdo#109285] / [i915#4098])
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105122v1/fi-rkl-11600/igt@kms_force_connector_basic@force-load-detect.html
* igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-d:
- fi-rkl-11600: NOTRUN -> [SKIP][21] ([i915#533])
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105122v1/fi-rkl-11600/igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-d.html
* igt@kms_psr@primary_page_flip:
- fi-rkl-11600: NOTRUN -> [SKIP][22] ([i915#1072]) +3 similar issues
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105122v1/fi-rkl-11600/igt@kms_psr@primary_page_flip.html
* igt@kms_setmode@basic-clone-single-crtc:
- fi-rkl-11600: NOTRUN -> [SKIP][23] ([i915#3555] / [i915#4098])
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105122v1/fi-rkl-11600/igt@kms_setmode@basic-clone-single-crtc.html
* igt@prime_vgem@basic-read:
- fi-rkl-11600: NOTRUN -> [SKIP][24] ([fdo#109295] / [i915#3291] / [i915#3708]) +2 similar issues
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105122v1/fi-rkl-11600/igt@prime_vgem@basic-read.html
* igt@prime_vgem@basic-userptr:
- fi-rkl-11600: NOTRUN -> [SKIP][25] ([fdo#109295] / [i915#3301] / [i915#3708])
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105122v1/fi-rkl-11600/igt@prime_vgem@basic-userptr.html
#### Possible fixes ####
* igt@gem_exec_suspend@basic-s0@smem:
- {fi-ehl-2}: [DMESG-WARN][26] ([i915#5122]) -> [PASS][27]
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11757/fi-ehl-2/igt@gem_exec_suspend@basic-s0@smem.html
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105122v1/fi-ehl-2/igt@gem_exec_suspend@basic-s0@smem.html
* igt@i915_selftest@live@requests:
- fi-pnv-d510: [DMESG-FAIL][28] ([i915#4528]) -> [PASS][29]
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11757/fi-pnv-d510/igt@i915_selftest@live@requests.html
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105122v1/fi-pnv-d510/igt@i915_selftest@live@requests.html
- fi-blb-e6850: [DMESG-FAIL][30] ([i915#4528]) -> [PASS][31]
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11757/fi-blb-e6850/igt@i915_selftest@live@requests.html
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105122v1/fi-blb-e6850/igt@i915_selftest@live@requests.html
* igt@kms_busy@basic@modeset:
- bat-adlp-4: [DMESG-WARN][32] ([i915#3576]) -> [PASS][33]
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11757/bat-adlp-4/igt@kms_busy@basic@modeset.html
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105122v1/bat-adlp-4/igt@kms_busy@basic@modeset.html
* igt@kms_flip@basic-flip-vs-modeset@a-edp1:
- fi-tgl-u2: [DMESG-WARN][34] ([i915#402]) -> [PASS][35]
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11757/fi-tgl-u2/igt@kms_flip@basic-flip-vs-modeset@a-edp1.html
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105122v1/fi-tgl-u2/igt@kms_flip@basic-flip-vs-modeset@a-edp1.html
* igt@kms_frontbuffer_tracking@basic:
- fi-cfl-8109u: [DMESG-FAIL][36] ([i915#62]) -> [PASS][37] +1 similar issue
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11757/fi-cfl-8109u/igt@kms_frontbuffer_tracking@basic.html
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105122v1/fi-cfl-8109u/igt@kms_frontbuffer_tracking@basic.html
* igt@kms_pipe_crc_basic@nonblocking-crc-pipe-a:
- fi-cfl-8109u: [DMESG-WARN][38] ([i915#62]) -> [PASS][39] +13 similar issues
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11757/fi-cfl-8109u/igt@kms_pipe_crc_basic@nonblocking-crc-pipe-a.html
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105122v1/fi-cfl-8109u/igt@kms_pipe_crc_basic@nonblocking-crc-pipe-a.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285
[fdo#109295]: https://bugs.freedesktop.org/show_bug.cgi?id=109295
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
[i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982
[i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190
[i915#3012]: https://gitlab.freedesktop.org/drm/intel/issues/3012
[i915#3282]: https://gitlab.freedesktop.org/drm/intel/issues/3282
[i915#3291]: https://gitlab.freedesktop.org/drm/intel/issues/3291
[i915#3301]: https://gitlab.freedesktop.org/drm/intel/issues/3301
[i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
[i915#3576]: https://gitlab.freedesktop.org/drm/intel/issues/3576
[i915#3708]: https://gitlab.freedesktop.org/drm/intel/issues/3708
[i915#402]: https://gitlab.freedesktop.org/drm/intel/issues/402
[i915#4098]: https://gitlab.freedesktop.org/drm/intel/issues/4098
[i915#4103]: https://gitlab.freedesktop.org/drm/intel/issues/4103
[i915#4312]: https://gitlab.freedesktop.org/drm/intel/issues/4312
[i915#4494]: https://gitlab.freedesktop.org/drm/intel/issues/4494
[i915#4528]: https://gitlab.freedesktop.org/drm/intel/issues/4528
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#4957]: https://gitlab.freedesktop.org/drm/intel/issues/4957
[i915#5122]: https://gitlab.freedesktop.org/drm/intel/issues/5122
[i915#5270]: https://gitlab.freedesktop.org/drm/intel/issues/5270
[i915#533]: https://gitlab.freedesktop.org/drm/intel/issues/533
[i915#5763]: https://gitlab.freedesktop.org/drm/intel/issues/5763
[i915#5886]: https://gitlab.freedesktop.org/drm/intel/issues/5886
[i915#5903]: https://gitlab.freedesktop.org/drm/intel/issues/5903
[i915#5982]: https://gitlab.freedesktop.org/drm/intel/issues/5982
[i915#62]: https://gitlab.freedesktop.org/drm/intel/issues/62
[i915#6227]: https://gitlab.freedesktop.org/drm/intel/issues/6227
Build changes
-------------
* Linux: CI_DRM_11757 -> Patchwork_105122v1
CI-20190529: 20190529
CI_DRM_11757: da1e3835cdf5e8c449d1edeb993105efd7c8815d @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_6524: 4b17146f2a0504db694eb89e19d7f9f7f5051983 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_105122v1: da1e3835cdf5e8c449d1edeb993105efd7c8815d @ git://anongit.freedesktop.org/gfx-ci/linux
### Linux commits
bdcb778c099c drm/i915: Do not use reserved requests for virtual engines
0edc085f014e Revert "drm/i915: Hold reference to intel_context over life of i915_request"
a737dc41f214 drm/i915: Do not access rq->engine without a reference
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105122v1/index.html
[-- Attachment #2: Type: text/html, Size: 12969 bytes --]
^ permalink raw reply [flat|nested] 19+ messages in thread
* [Intel-gfx] ✗ Fi.CI.IGT: failure for Break VM to rq reference loop
2022-06-14 18:43 ` [Intel-gfx] " Ramalingam C
` (5 preceding siblings ...)
(?)
@ 2022-06-15 6:41 ` Patchwork
-1 siblings, 0 replies; 19+ messages in thread
From: Patchwork @ 2022-06-15 6:41 UTC (permalink / raw)
To: Ramalingam C; +Cc: intel-gfx
[-- Attachment #1: Type: text/plain, Size: 55383 bytes --]
== Series Details ==
Series: Break VM to rq reference loop
URL : https://patchwork.freedesktop.org/series/105122/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_11757_full -> Patchwork_105122v1_full
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with Patchwork_105122v1_full absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_105122v1_full, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
Participating hosts (10 -> 13)
------------------------------
Additional (3): shard-rkl shard-dg1 shard-tglu
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_105122v1_full:
### IGT changes ###
#### Possible regressions ####
* igt@i915_pm_rps@reset:
- shard-skl: [PASS][1] -> [FAIL][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11757/shard-skl10/igt@i915_pm_rps@reset.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105122v1/shard-skl2/igt@i915_pm_rps@reset.html
#### Suppressed ####
The following results come from untrusted machines, tests, or statuses.
They do not affect the overall result.
* {igt@api_intel_bb@crc32}:
- {shard-dg1}: NOTRUN -> [SKIP][3]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105122v1/shard-dg1-13/igt@api_intel_bb@crc32.html
* igt@debugfs_test@read_all_entries_display_on:
- {shard-dg1}: NOTRUN -> [INCOMPLETE][4]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105122v1/shard-dg1-16/igt@debugfs_test@read_all_entries_display_on.html
* {igt@kms_cdclk@mode-transition-all-outputs}:
- {shard-tglu}: NOTRUN -> [SKIP][5] +1 similar issue
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105122v1/shard-tglu-4/igt@kms_cdclk@mode-transition-all-outputs.html
* {igt@kms_plane_lowres@tiling-y@pipe-a-edp-1}:
- {shard-rkl}: NOTRUN -> [SKIP][6] +3 similar issues
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105122v1/shard-rkl-6/igt@kms_plane_lowres@tiling-y@pipe-a-edp-1.html
### Piglit changes ###
#### Possible regressions ####
* spec@glsl-1.50@execution@built-in-functions@gs-max-uvec3-uint:
- pig-skl-6260u: NOTRUN -> [CRASH][7]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105122v1/pig-skl-6260u/spec@glsl-1.50@execution@built-in-functions@gs-max-uvec3-uint.html
* spec@glsl-4.30@execution@built-in-functions@cs-transpose-mat2:
- pig-glk-j5005: NOTRUN -> [CRASH][8] +4 similar issues
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105122v1/pig-glk-j5005/spec@glsl-4.30@execution@built-in-functions@cs-transpose-mat2.html
Known issues
------------
Here are the changes found in Patchwork_105122v1_full that come from known issues:
### CI changes ###
#### Possible fixes ####
* boot:
- shard-glk: ([PASS][9], [PASS][10], [PASS][11], [PASS][12], [PASS][13], [PASS][14], [PASS][15], [PASS][16], [PASS][17], [FAIL][18], [PASS][19], [PASS][20], [PASS][21], [PASS][22], [PASS][23], [PASS][24], [PASS][25], [PASS][26], [PASS][27], [PASS][28], [PASS][29], [PASS][30], [PASS][31], [PASS][32]) ([i915#4392]) -> ([PASS][33], [PASS][34], [PASS][35], [PASS][36], [PASS][37], [PASS][38], [PASS][39], [PASS][40], [PASS][41], [PASS][42], [PASS][43], [PASS][44], [PASS][45], [PASS][46], [PASS][47], [PASS][48], [PASS][49], [PASS][50], [PASS][51], [PASS][52], [PASS][53], [PASS][54], [PASS][55], [PASS][56], [PASS][57])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11757/shard-glk1/boot.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11757/shard-glk1/boot.html
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11757/shard-glk1/boot.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11757/shard-glk2/boot.html
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11757/shard-glk2/boot.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11757/shard-glk2/boot.html
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11757/shard-glk3/boot.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11757/shard-glk3/boot.html
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11757/shard-glk3/boot.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11757/shard-glk4/boot.html
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11757/shard-glk4/boot.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11757/shard-glk4/boot.html
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11757/shard-glk4/boot.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11757/shard-glk5/boot.html
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11757/shard-glk5/boot.html
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11757/shard-glk6/boot.html
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11757/shard-glk6/boot.html
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11757/shard-glk7/boot.html
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11757/shard-glk7/boot.html
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11757/shard-glk8/boot.html
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11757/shard-glk8/boot.html
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11757/shard-glk9/boot.html
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11757/shard-glk9/boot.html
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11757/shard-glk9/boot.html
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105122v1/shard-glk7/boot.html
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105122v1/shard-glk7/boot.html
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105122v1/shard-glk8/boot.html
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105122v1/shard-glk8/boot.html
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105122v1/shard-glk8/boot.html
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105122v1/shard-glk7/boot.html
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105122v1/shard-glk1/boot.html
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105122v1/shard-glk1/boot.html
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105122v1/shard-glk1/boot.html
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105122v1/shard-glk2/boot.html
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105122v1/shard-glk2/boot.html
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105122v1/shard-glk2/boot.html
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105122v1/shard-glk3/boot.html
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105122v1/shard-glk3/boot.html
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105122v1/shard-glk4/boot.html
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105122v1/shard-glk4/boot.html
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105122v1/shard-glk4/boot.html
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105122v1/shard-glk5/boot.html
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105122v1/shard-glk5/boot.html
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105122v1/shard-glk5/boot.html
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105122v1/shard-glk6/boot.html
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105122v1/shard-glk6/boot.html
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105122v1/shard-glk9/boot.html
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105122v1/shard-glk9/boot.html
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105122v1/shard-glk9/boot.html
### IGT changes ###
#### Issues hit ####
* igt@gem_ctx_isolation@dirty-create@rcs0:
- shard-glk: NOTRUN -> [INCOMPLETE][58] ([i915#5843])
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105122v1/shard-glk2/igt@gem_ctx_isolation@dirty-create@rcs0.html
* igt@gem_ctx_isolation@preservation-s3@bcs0:
- shard-apl: [PASS][59] -> [DMESG-WARN][60] ([i915#180]) +2 similar issues
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11757/shard-apl8/igt@gem_ctx_isolation@preservation-s3@bcs0.html
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105122v1/shard-apl4/igt@gem_ctx_isolation@preservation-s3@bcs0.html
* igt@gem_ctx_persistence@smoketest:
- shard-glk: [PASS][61] -> [INCOMPLETE][62] ([i915#5843] / [i915#6060])
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11757/shard-glk1/igt@gem_ctx_persistence@smoketest.html
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105122v1/shard-glk8/igt@gem_ctx_persistence@smoketest.html
- shard-skl: [PASS][63] -> [INCOMPLETE][64] ([i915#5843] / [i915#6060])
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11757/shard-skl1/igt@gem_ctx_persistence@smoketest.html
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105122v1/shard-skl6/igt@gem_ctx_persistence@smoketest.html
* igt@gem_eio@unwedge-stress:
- shard-tglb: NOTRUN -> [TIMEOUT][65] ([i915#3063])
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105122v1/shard-tglb6/igt@gem_eio@unwedge-stress.html
* igt@gem_exec_balancer@parallel-balancer:
- shard-iclb: [PASS][66] -> [SKIP][67] ([i915#4525]) +1 similar issue
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11757/shard-iclb2/igt@gem_exec_balancer@parallel-balancer.html
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105122v1/shard-iclb8/igt@gem_exec_balancer@parallel-balancer.html
* igt@gem_exec_fair@basic-none-rrul@rcs0:
- shard-glk: [PASS][68] -> [FAIL][69] ([i915#2842])
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11757/shard-glk5/igt@gem_exec_fair@basic-none-rrul@rcs0.html
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105122v1/shard-glk7/igt@gem_exec_fair@basic-none-rrul@rcs0.html
* igt@gem_exec_fair@basic-none@vcs0:
- shard-kbl: [PASS][70] -> [FAIL][71] ([i915#2842])
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11757/shard-kbl4/igt@gem_exec_fair@basic-none@vcs0.html
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105122v1/shard-kbl1/igt@gem_exec_fair@basic-none@vcs0.html
* igt@gem_exec_fair@basic-pace-solo@rcs0:
- shard-tglb: NOTRUN -> [FAIL][72] ([i915#2842])
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105122v1/shard-tglb6/igt@gem_exec_fair@basic-pace-solo@rcs0.html
* igt@gem_exec_fair@basic-pace@vcs1:
- shard-kbl: [PASS][73] -> [SKIP][74] ([fdo#109271])
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11757/shard-kbl1/igt@gem_exec_fair@basic-pace@vcs1.html
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105122v1/shard-kbl4/igt@gem_exec_fair@basic-pace@vcs1.html
* igt@gem_exec_fair@basic-pace@vecs0:
- shard-iclb: [PASS][75] -> [FAIL][76] ([i915#2842]) +1 similar issue
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11757/shard-iclb1/igt@gem_exec_fair@basic-pace@vecs0.html
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105122v1/shard-iclb7/igt@gem_exec_fair@basic-pace@vecs0.html
* igt@gem_huc_copy@huc-copy:
- shard-tglb: [PASS][77] -> [SKIP][78] ([i915#2190])
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11757/shard-tglb2/igt@gem_huc_copy@huc-copy.html
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105122v1/shard-tglb7/igt@gem_huc_copy@huc-copy.html
- shard-glk: NOTRUN -> [SKIP][79] ([fdo#109271] / [i915#2190])
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105122v1/shard-glk2/igt@gem_huc_copy@huc-copy.html
* igt@gem_lmem_swapping@heavy-verify-multi-ccs:
- shard-skl: NOTRUN -> [SKIP][80] ([fdo#109271] / [i915#4613]) +1 similar issue
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105122v1/shard-skl10/igt@gem_lmem_swapping@heavy-verify-multi-ccs.html
* igt@gem_lmem_swapping@heavy-verify-random:
- shard-kbl: NOTRUN -> [SKIP][81] ([fdo#109271] / [i915#4613]) +1 similar issue
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105122v1/shard-kbl7/igt@gem_lmem_swapping@heavy-verify-random.html
* igt@gem_lmem_swapping@smem-oom:
- shard-glk: NOTRUN -> [SKIP][82] ([fdo#109271] / [i915#4613])
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105122v1/shard-glk2/igt@gem_lmem_swapping@smem-oom.html
* igt@gem_lmem_swapping@verify:
- shard-apl: NOTRUN -> [SKIP][83] ([fdo#109271] / [i915#4613])
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105122v1/shard-apl3/igt@gem_lmem_swapping@verify.html
* igt@gem_pxp@reject-modify-context-protection-off-2:
- shard-tglb: NOTRUN -> [SKIP][84] ([i915#4270]) +1 similar issue
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105122v1/shard-tglb6/igt@gem_pxp@reject-modify-context-protection-off-2.html
* igt@gen9_exec_parse@bb-start-cmd:
- shard-tglb: NOTRUN -> [SKIP][85] ([i915#2527] / [i915#2856])
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105122v1/shard-tglb6/igt@gen9_exec_parse@bb-start-cmd.html
* igt@i915_hangman@gt-engine-error@vecs0:
- shard-glk: [PASS][86] -> [INCOMPLETE][87] ([i915#5843])
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11757/shard-glk8/igt@i915_hangman@gt-engine-error@vecs0.html
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105122v1/shard-glk7/igt@i915_hangman@gt-engine-error@vecs0.html
* igt@i915_pm_backlight@bad-brightness:
- shard-glk: NOTRUN -> [SKIP][88] ([fdo#109271]) +70 similar issues
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105122v1/shard-glk2/igt@i915_pm_backlight@bad-brightness.html
* igt@i915_pm_dc@dc6-psr:
- shard-iclb: [PASS][89] -> [FAIL][90] ([i915#454])
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11757/shard-iclb6/igt@i915_pm_dc@dc6-psr.html
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105122v1/shard-iclb3/igt@i915_pm_dc@dc6-psr.html
* igt@i915_pm_lpsp@kms-lpsp@kms-lpsp-hdmi-a:
- shard-glk: NOTRUN -> [SKIP][91] ([fdo#109271] / [i915#1937])
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105122v1/shard-glk2/igt@i915_pm_lpsp@kms-lpsp@kms-lpsp-hdmi-a.html
* igt@i915_selftest@live@hangcheck:
- shard-tglb: [PASS][92] -> [DMESG-WARN][93] ([i915#5591])
[92]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11757/shard-tglb3/igt@i915_selftest@live@hangcheck.html
[93]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105122v1/shard-tglb8/igt@i915_selftest@live@hangcheck.html
* igt@kms_big_fb@4-tiled-max-hw-stride-64bpp-rotate-180:
- shard-tglb: NOTRUN -> [SKIP][94] ([i915#5286]) +1 similar issue
[94]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105122v1/shard-tglb6/igt@kms_big_fb@4-tiled-max-hw-stride-64bpp-rotate-180.html
* igt@kms_big_fb@x-tiled-32bpp-rotate-270:
- shard-tglb: NOTRUN -> [SKIP][95] ([fdo#111614])
[95]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105122v1/shard-tglb6/igt@kms_big_fb@x-tiled-32bpp-rotate-270.html
* igt@kms_big_fb@yf-tiled-8bpp-rotate-180:
- shard-tglb: NOTRUN -> [SKIP][96] ([fdo#111615])
[96]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105122v1/shard-tglb6/igt@kms_big_fb@yf-tiled-8bpp-rotate-180.html
* igt@kms_big_fb@yf-tiled-max-hw-stride-32bpp-rotate-180-async-flip:
- shard-skl: NOTRUN -> [FAIL][97] ([i915#3743])
[97]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105122v1/shard-skl10/igt@kms_big_fb@yf-tiled-max-hw-stride-32bpp-rotate-180-async-flip.html
* igt@kms_ccs@pipe-a-crc-primary-rotation-180-y_tiled_gen12_mc_ccs:
- shard-skl: NOTRUN -> [SKIP][98] ([fdo#109271] / [i915#3886]) +1 similar issue
[98]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105122v1/shard-skl1/igt@kms_ccs@pipe-a-crc-primary-rotation-180-y_tiled_gen12_mc_ccs.html
* igt@kms_ccs@pipe-a-crc-primary-rotation-180-y_tiled_gen12_rc_ccs_cc:
- shard-apl: NOTRUN -> [SKIP][99] ([fdo#109271] / [i915#3886]) +2 similar issues
[99]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105122v1/shard-apl3/igt@kms_ccs@pipe-a-crc-primary-rotation-180-y_tiled_gen12_rc_ccs_cc.html
* igt@kms_ccs@pipe-b-bad-rotation-90-4_tiled_dg2_rc_ccs:
- shard-tglb: NOTRUN -> [SKIP][100] ([i915#3689]) +2 similar issues
[100]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105122v1/shard-tglb6/igt@kms_ccs@pipe-b-bad-rotation-90-4_tiled_dg2_rc_ccs.html
* igt@kms_ccs@pipe-b-crc-primary-rotation-180-y_tiled_gen12_mc_ccs:
- shard-kbl: NOTRUN -> [SKIP][101] ([fdo#109271] / [i915#3886]) +5 similar issues
[101]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105122v1/shard-kbl3/igt@kms_ccs@pipe-b-crc-primary-rotation-180-y_tiled_gen12_mc_ccs.html
* igt@kms_ccs@pipe-b-crc-sprite-planes-basic-yf_tiled_ccs:
- shard-tglb: NOTRUN -> [SKIP][102] ([fdo#111615] / [i915#3689]) +1 similar issue
[102]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105122v1/shard-tglb6/igt@kms_ccs@pipe-b-crc-sprite-planes-basic-yf_tiled_ccs.html
* igt@kms_ccs@pipe-c-random-ccs-data-y_tiled_gen12_mc_ccs:
- shard-glk: NOTRUN -> [SKIP][103] ([fdo#109271] / [i915#3886]) +3 similar issues
[103]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105122v1/shard-glk2/igt@kms_ccs@pipe-c-random-ccs-data-y_tiled_gen12_mc_ccs.html
* igt@kms_chamelium@dp-edid-change-during-suspend:
- shard-glk: NOTRUN -> [SKIP][104] ([fdo#109271] / [fdo#111827]) +5 similar issues
[104]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105122v1/shard-glk2/igt@kms_chamelium@dp-edid-change-during-suspend.html
- shard-skl: NOTRUN -> [SKIP][105] ([fdo#109271] / [fdo#111827]) +5 similar issues
[105]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105122v1/shard-skl6/igt@kms_chamelium@dp-edid-change-during-suspend.html
* igt@kms_chamelium@dp-frame-dump:
- shard-kbl: NOTRUN -> [SKIP][106] ([fdo#109271] / [fdo#111827]) +9 similar issues
[106]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105122v1/shard-kbl7/igt@kms_chamelium@dp-frame-dump.html
* igt@kms_chamelium@vga-hpd-after-suspend:
- shard-apl: NOTRUN -> [SKIP][107] ([fdo#109271] / [fdo#111827]) +3 similar issues
[107]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105122v1/shard-apl3/igt@kms_chamelium@vga-hpd-after-suspend.html
* igt@kms_color_chamelium@pipe-c-ctm-negative:
- shard-tglb: NOTRUN -> [SKIP][108] ([fdo#109284] / [fdo#111827]) +4 similar issues
[108]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105122v1/shard-tglb6/igt@kms_color_chamelium@pipe-c-ctm-negative.html
* igt@kms_cursor_crc@pipe-a-cursor-32x32-rapid-movement:
- shard-tglb: NOTRUN -> [SKIP][109] ([i915#3319])
[109]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105122v1/shard-tglb6/igt@kms_cursor_crc@pipe-a-cursor-32x32-rapid-movement.html
* igt@kms_cursor_crc@pipe-c-cursor-suspend:
- shard-kbl: [PASS][110] -> [DMESG-WARN][111] ([i915#180]) +3 similar issues
[110]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11757/shard-kbl1/igt@kms_cursor_crc@pipe-c-cursor-suspend.html
[111]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105122v1/shard-kbl1/igt@kms_cursor_crc@pipe-c-cursor-suspend.html
* igt@kms_cursor_crc@pipe-d-cursor-128x42-sliding:
- shard-kbl: NOTRUN -> [SKIP][112] ([fdo#109271]) +126 similar issues
[112]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105122v1/shard-kbl7/igt@kms_cursor_crc@pipe-d-cursor-128x42-sliding.html
* igt@kms_draw_crc@draw-method-rgb565-render-4tiled:
- shard-tglb: NOTRUN -> [SKIP][113] ([i915#5287])
[113]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105122v1/shard-tglb6/igt@kms_draw_crc@draw-method-rgb565-render-4tiled.html
* igt@kms_flip@2x-flip-vs-absolute-wf_vblank:
- shard-tglb: NOTRUN -> [SKIP][114] ([fdo#109274] / [fdo#111825]) +2 similar issues
[114]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105122v1/shard-tglb6/igt@kms_flip@2x-flip-vs-absolute-wf_vblank.html
* igt@kms_flip@2x-plain-flip-fb-recreate@ab-hdmi-a1-hdmi-a2:
- shard-glk: [PASS][115] -> [FAIL][116] ([i915#2122])
[115]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11757/shard-glk3/igt@kms_flip@2x-plain-flip-fb-recreate@ab-hdmi-a1-hdmi-a2.html
[116]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105122v1/shard-glk7/igt@kms_flip@2x-plain-flip-fb-recreate@ab-hdmi-a1-hdmi-a2.html
* igt@kms_flip@flip-vs-expired-vblank-interruptible@a-hdmi-a2:
- shard-glk: [PASS][117] -> [FAIL][118] ([i915#79])
[117]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11757/shard-glk6/igt@kms_flip@flip-vs-expired-vblank-interruptible@a-hdmi-a2.html
[118]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105122v1/shard-glk6/igt@kms_flip@flip-vs-expired-vblank-interruptible@a-hdmi-a2.html
* igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-64bpp-ytile-downscaling:
- shard-iclb: [PASS][119] -> [SKIP][120] ([i915#3701])
[119]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11757/shard-iclb8/igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-64bpp-ytile-downscaling.html
[120]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105122v1/shard-iclb2/igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-64bpp-ytile-downscaling.html
* igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-spr-indfb-onoff:
- shard-tglb: NOTRUN -> [SKIP][121] ([fdo#109280] / [fdo#111825]) +10 similar issues
[121]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105122v1/shard-tglb6/igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-spr-indfb-onoff.html
* igt@kms_frontbuffer_tracking@fbc-suspend:
- shard-kbl: [PASS][122] -> [DMESG-WARN][123] ([i915#180] / [i915#1982])
[122]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11757/shard-kbl7/igt@kms_frontbuffer_tracking@fbc-suspend.html
[123]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105122v1/shard-kbl4/igt@kms_frontbuffer_tracking@fbc-suspend.html
* igt@kms_frontbuffer_tracking@fbcpsr-1p-offscren-pri-indfb-draw-mmap-wc:
- shard-skl: NOTRUN -> [SKIP][124] ([fdo#109271]) +88 similar issues
[124]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105122v1/shard-skl1/igt@kms_frontbuffer_tracking@fbcpsr-1p-offscren-pri-indfb-draw-mmap-wc.html
* igt@kms_frontbuffer_tracking@psr-suspend:
- shard-skl: [PASS][125] -> [DMESG-WARN][126] ([i915#1982])
[125]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11757/shard-skl1/igt@kms_frontbuffer_tracking@psr-suspend.html
[126]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105122v1/shard-skl1/igt@kms_frontbuffer_tracking@psr-suspend.html
* igt@kms_hdr@static-toggle-dpms:
- shard-tglb: NOTRUN -> [SKIP][127] ([i915#3555])
[127]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105122v1/shard-tglb6/igt@kms_hdr@static-toggle-dpms.html
* igt@kms_pipe_crc_basic@disable-crc-after-crtc-pipe-d:
- shard-glk: NOTRUN -> [SKIP][128] ([fdo#109271] / [i915#533])
[128]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105122v1/shard-glk2/igt@kms_pipe_crc_basic@disable-crc-after-crtc-pipe-d.html
* igt@kms_plane_alpha_blend@pipe-a-alpha-transparent-fb:
- shard-skl: NOTRUN -> [FAIL][129] ([i915#265])
[129]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105122v1/shard-skl10/igt@kms_plane_alpha_blend@pipe-a-alpha-transparent-fb.html
* igt@kms_plane_alpha_blend@pipe-b-alpha-transparent-fb:
- shard-kbl: NOTRUN -> [FAIL][130] ([i915#265])
[130]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105122v1/shard-kbl7/igt@kms_plane_alpha_blend@pipe-b-alpha-transparent-fb.html
* igt@kms_plane_lowres@tiling-4:
- shard-tglb: NOTRUN -> [SKIP][131] ([i915#5288])
[131]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105122v1/shard-tglb6/igt@kms_plane_lowres@tiling-4.html
* igt@kms_plane_scaling@plane-downscale-with-pixel-format-factor-0-5@pipe-b-edp-1:
- shard-iclb: [PASS][132] -> [SKIP][133] ([i915#5176]) +2 similar issues
[132]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11757/shard-iclb8/igt@kms_plane_scaling@plane-downscale-with-pixel-format-factor-0-5@pipe-b-edp-1.html
[133]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105122v1/shard-iclb2/igt@kms_plane_scaling@plane-downscale-with-pixel-format-factor-0-5@pipe-b-edp-1.html
* igt@kms_plane_scaling@plane-upscale-with-rotation-factor-0-25@pipe-a-dp-1:
- shard-apl: NOTRUN -> [SKIP][134] ([fdo#109271]) +54 similar issues
[134]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105122v1/shard-apl3/igt@kms_plane_scaling@plane-upscale-with-rotation-factor-0-25@pipe-a-dp-1.html
* igt@kms_psr2_sf@cursor-plane-move-continuous-exceed-fully-sf:
- shard-skl: NOTRUN -> [SKIP][135] ([fdo#109271] / [i915#658]) +1 similar issue
[135]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105122v1/shard-skl10/igt@kms_psr2_sf@cursor-plane-move-continuous-exceed-fully-sf.html
* igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area:
- shard-glk: NOTRUN -> [SKIP][136] ([fdo#109271] / [i915#658]) +1 similar issue
[136]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105122v1/shard-glk2/igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area.html
* igt@kms_psr2_sf@plane-move-sf-dmg-area:
- shard-apl: NOTRUN -> [SKIP][137] ([fdo#109271] / [i915#658]) +1 similar issue
[137]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105122v1/shard-apl3/igt@kms_psr2_sf@plane-move-sf-dmg-area.html
* igt@kms_psr2_su@page_flip-nv12:
- shard-kbl: NOTRUN -> [SKIP][138] ([fdo#109271] / [i915#658]) +1 similar issue
[138]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105122v1/shard-kbl3/igt@kms_psr2_su@page_flip-nv12.html
* igt@kms_psr@psr2_cursor_mmap_gtt:
- shard-tglb: NOTRUN -> [FAIL][139] ([i915#132] / [i915#3467]) +1 similar issue
[139]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105122v1/shard-tglb6/igt@kms_psr@psr2_cursor_mmap_gtt.html
- shard-iclb: [PASS][140] -> [SKIP][141] ([fdo#109441]) +1 similar issue
[140]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11757/shard-iclb2/igt@kms_psr@psr2_cursor_mmap_gtt.html
[141]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105122v1/shard-iclb5/igt@kms_psr@psr2_cursor_mmap_gtt.html
* igt@kms_vblank@pipe-b-ts-continuation-suspend:
- shard-kbl: NOTRUN -> [DMESG-WARN][142] ([i915#180]) +2 similar issues
[142]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105122v1/shard-kbl7/igt@kms_vblank@pipe-b-ts-continuation-suspend.html
* igt@kms_writeback@writeback-fb-id:
- shard-kbl: NOTRUN -> [SKIP][143] ([fdo#109271] / [i915#2437])
[143]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105122v1/shard-kbl3/igt@kms_writeback@writeback-fb-id.html
* igt@perf@polling-parameterized:
- shard-kbl: [PASS][144] -> [FAIL][145] ([i915#5639])
[144]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11757/shard-kbl7/igt@perf@polling-parameterized.html
[145]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105122v1/shard-kbl6/igt@perf@polling-parameterized.html
* igt@prime_nv_pcopy@test3_5:
- shard-tglb: NOTRUN -> [SKIP][146] ([fdo#109291]) +1 similar issue
[146]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105122v1/shard-tglb6/igt@prime_nv_pcopy@test3_5.html
* igt@sysfs_clients@fair-0:
- shard-tglb: NOTRUN -> [SKIP][147] ([i915#2994])
[147]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105122v1/shard-tglb6/igt@sysfs_clients@fair-0.html
* igt@sysfs_clients@fair-1:
- shard-glk: NOTRUN -> [SKIP][148] ([fdo#109271] / [i915#2994])
[148]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105122v1/shard-glk2/igt@sysfs_clients@fair-1.html
* igt@sysfs_clients@fair-3:
- shard-kbl: NOTRUN -> [SKIP][149] ([fdo#109271] / [i915#2994])
[149]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105122v1/shard-kbl3/igt@sysfs_clients@fair-3.html
* igt@sysfs_clients@split-50:
- shard-skl: NOTRUN -> [SKIP][150] ([fdo#109271] / [i915#2994])
[150]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105122v1/shard-skl10/igt@sysfs_clients@split-50.html
#### Possible fixes ####
* igt@gem_eio@in-flight-10ms:
- shard-tglb: [TIMEOUT][151] ([i915#3063]) -> [PASS][152]
[151]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11757/shard-tglb3/igt@gem_eio@in-flight-10ms.html
[152]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105122v1/shard-tglb8/igt@gem_eio@in-flight-10ms.html
* igt@gem_eio@in-flight-contexts-1us:
- shard-snb: [FAIL][153] ([i915#4409]) -> [PASS][154]
[153]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11757/shard-snb7/igt@gem_eio@in-flight-contexts-1us.html
[154]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105122v1/shard-snb2/igt@gem_eio@in-flight-contexts-1us.html
* igt@gem_exec_balancer@parallel-bb-first:
- shard-iclb: [SKIP][155] ([i915#4525]) -> [PASS][156]
[155]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11757/shard-iclb5/igt@gem_exec_balancer@parallel-bb-first.html
[156]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105122v1/shard-iclb1/igt@gem_exec_balancer@parallel-bb-first.html
* igt@gem_exec_fair@basic-pace-share@rcs0:
- shard-glk: [FAIL][157] ([i915#2842]) -> [PASS][158]
[157]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11757/shard-glk5/igt@gem_exec_fair@basic-pace-share@rcs0.html
[158]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105122v1/shard-glk3/igt@gem_exec_fair@basic-pace-share@rcs0.html
* igt@gem_exec_fair@basic-pace@bcs0:
- shard-tglb: [FAIL][159] ([i915#2842]) -> [PASS][160] +1 similar issue
[159]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11757/shard-tglb7/igt@gem_exec_fair@basic-pace@bcs0.html
[160]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105122v1/shard-tglb6/igt@gem_exec_fair@basic-pace@bcs0.html
* igt@gem_exec_fair@basic-pace@rcs0:
- shard-kbl: [FAIL][161] ([i915#2842]) -> [PASS][162] +1 similar issue
[161]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11757/shard-kbl1/igt@gem_exec_fair@basic-pace@rcs0.html
[162]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105122v1/shard-kbl4/igt@gem_exec_fair@basic-pace@rcs0.html
* igt@gem_workarounds@suspend-resume-fd:
- shard-kbl: [DMESG-WARN][163] ([i915#180]) -> [PASS][164] +1 similar issue
[163]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11757/shard-kbl4/igt@gem_workarounds@suspend-resume-fd.html
[164]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105122v1/shard-kbl3/igt@gem_workarounds@suspend-resume-fd.html
* igt@gen9_exec_parse@allowed-single:
- shard-kbl: [DMESG-WARN][165] ([i915#5566] / [i915#716]) -> [PASS][166]
[165]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11757/shard-kbl7/igt@gen9_exec_parse@allowed-single.html
[166]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105122v1/shard-kbl7/igt@gen9_exec_parse@allowed-single.html
* igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size:
- shard-glk: [FAIL][167] ([i915#2346] / [i915#533]) -> [PASS][168]
[167]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11757/shard-glk4/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size.html
[168]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105122v1/shard-glk9/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size.html
* igt@kms_flip@flip-vs-blocking-wf-vblank@b-edp1:
- shard-skl: [FAIL][169] ([i915#2122]) -> [PASS][170] +2 similar issues
[169]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11757/shard-skl2/igt@kms_flip@flip-vs-blocking-wf-vblank@b-edp1.html
[170]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105122v1/shard-skl9/igt@kms_flip@flip-vs-blocking-wf-vblank@b-edp1.html
* igt@kms_flip@flip-vs-suspend@b-edp1:
- shard-skl: [INCOMPLETE][171] ([i915#4839]) -> [PASS][172]
[171]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11757/shard-skl10/igt@kms_flip@flip-vs-suspend@b-edp1.html
[172]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105122v1/shard-skl1/igt@kms_flip@flip-vs-suspend@b-edp1.html
* igt@kms_frontbuffer_tracking@fbc-suspend:
- shard-apl: [DMESG-WARN][173] ([i915#180]) -> [PASS][174]
[173]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11757/shard-apl3/igt@kms_frontbuffer_tracking@fbc-suspend.html
[174]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105122v1/shard-apl3/igt@kms_frontbuffer_tracking@fbc-suspend.html
* igt@kms_psr@psr2_cursor_render:
- shard-iclb: [SKIP][175] ([fdo#109441]) -> [PASS][176]
[175]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11757/shard-iclb8/igt@kms_psr@psr2_cursor_render.html
[176]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105122v1/shard-iclb2/igt@kms_psr@psr2_cursor_render.html
* igt@perf@polling-parameterized:
- shard-glk: [FAIL][177] ([i915#5639]) -> [PASS][178]
[177]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11757/shard-glk1/igt@perf@polling-parameterized.html
[178]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105122v1/shard-glk8/igt@perf@polling-parameterized.html
* igt@perf@short-reads:
- shard-skl: [FAIL][179] ([i915#51]) -> [PASS][180]
[179]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11757/shard-skl7/igt@perf@short-reads.html
[180]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105122v1/shard-skl9/igt@perf@short-reads.html
#### Warnings ####
* igt@kms_ccs@pipe-a-crc-primary-rotation-180-y_tiled_gen12_mc_ccs:
- shard-glk: [SKIP][181] ([fdo#109271] / [i915#1888] / [i915#3886]) -> [SKIP][182] ([fdo#109271] / [i915#3886])
[181]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11757/shard-glk3/igt@kms_ccs@pipe-a-crc-primary-rotation-180-y_tiled_gen12_mc_ccs.html
[182]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105122v1/shard-glk7/igt@kms_ccs@pipe-a-crc-primary-rotation-180-y_tiled_gen12_mc_ccs.html
* igt@kms_chamelium@vga-frame-dump:
- shard-skl: [SKIP][183] ([fdo#109271] / [fdo#111827] / [i915#1888]) -> [SKIP][184] ([fdo#109271] / [fdo#111827])
[183]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11757/shard-skl4/igt@kms_chamelium@vga-frame-dump.html
[184]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105122v1/shard-skl4/igt@kms_chamelium@vga-frame-dump.html
* igt@kms_fbcon_fbt@fbc-suspend:
- shard-kbl: [FAIL][185] ([i915#4767]) -> [INCOMPLETE][186] ([i915#180])
[185]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11757/shard-kbl6/igt@kms_fbcon_fbt@fbc-suspend.html
[186]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105122v1/shard-kbl7/igt@kms_fbcon_fbt@fbc-suspend.html
* igt@kms_psr2_sf@cursor-plane-move-continuous-exceed-fully-sf:
- shard-iclb: [SKIP][187] ([i915#2920]) -> [SKIP][188] ([i915#658])
[187]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11757/shard-iclb2/igt@kms_psr2_sf@cursor-plane-move-continuous-exceed-fully-sf.html
[188]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105122v1/shard-iclb8/igt@kms_psr2_sf@cursor-plane-move-continuous-exceed-fully-sf.html
* igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-big-fb:
- shard-iclb: [SKIP][189] ([i915#658]) -> [SKIP][190] ([i915#2920]) +1 similar issue
[189]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11757/shard-iclb4/igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-big-fb.html
[190]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105122v1/shard-iclb2/igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-big-fb.html
* igt@runner@aborted:
- shard-apl: ([FAIL][191], [FAIL][192], [FAIL][193], [FAIL][194]) ([fdo#109271] / [i915#180] / [i915#3002] / [i915#4312] / [i915#5257]) -> ([FAIL][195], [FAIL][196], [FAIL][197], [FAIL][198], [FAIL][199]) ([i915#180] / [i915#3002] / [i915#4312] / [i915#5257])
[191]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11757/shard-apl3/igt@runner@aborted.html
[192]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11757/shard-apl2/igt@runner@aborted.html
[193]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11757/shard-apl4/igt@runner@aborted.html
[194]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11757/shard-apl3/igt@runner@aborted.html
[195]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105122v1/shard-apl4/igt@runner@aborted.html
[196]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105122v1/shard-apl7/igt@runner@aborted.html
[197]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105122v1/shard-apl3/igt@runner@aborted.html
[198]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105122v1/shard-apl4/igt@runner@aborted.html
[199]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105122v1/shard-apl7/igt@runner@aborted.html
- shard-kbl: ([FAIL][200], [FAIL][201], [FAIL][202], [FAIL][203], [FAIL][204], [FAIL][205], [FAIL][206], [FAIL][207], [FAIL][208]) ([fdo#109271] / [i915#180] / [i915#3002] / [i915#4312] / [i915#5257] / [i915#716]) -> ([FAIL][209], [FAIL][210], [FAIL][211], [FAIL][212], [FAIL][213], [FAIL][214], [FAIL][215], [FAIL][216], [FAIL][217], [FAIL][218], [FAIL][219], [FAIL][220], [FAIL][221], [FAIL][222]) ([fdo#109271] / [i915#180] / [i915#3002] / [i915#4312] / [i915#5257] / [i915#92])
[200]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11757/shard-kbl4/igt@runner@aborted.html
[201]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11757/shard-kbl1/igt@runner@aborted.html
[202]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11757/shard-kbl4/igt@runner@aborted.html
[203]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11757/shard-kbl4/igt@runner@aborted.html
[204]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11757/shard-kbl4/igt@runner@aborted.html
[205]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11757/shard-kbl1/igt@runner@aborted.html
[206]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11757/shard-kbl4/igt@runner@aborted.html
[207]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11757/shard-kbl7/igt@runner@aborted.html
[208]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11757/shard-kbl7/igt@runner@aborted.html
[209]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105122v1/shard-kbl1/igt@runner@aborted.html
[210]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105122v1/shard-kbl1/igt@runner@aborted.html
[211]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105122v1/shard-kbl1/igt@runner@aborted.html
[212]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105122v1/shard-kbl6/igt@runner@aborted.html
[213]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105122v1/shard-kbl4/igt@runner@aborted.html
[214]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105122v1/shard-kbl4/igt@runner@aborted.html
[215]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105122v1/shard-kbl7/igt@runner@aborted.html
[216]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105122v1/shard-kbl3/igt@runner@aborted.html
[217]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105122v1/shard-kbl7/igt@runner@aborted.html
[218]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105122v1/shard-kbl4/igt@runner@aborted.html
[219]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105122v1/shard-kbl7/igt@runner@aborted.html
[220]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105122v1/shard-kbl4/igt@runner@aborted.html
[221]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105122v1/shard-kbl7/igt@runner@aborted.html
[222]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105122v1/shard-kbl7/igt@runner@aborted.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[IGT#2]: https://gitlab.freedesktop.org/drm/igt-gpu-tools/issues/2
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109274]: https://bugs.freedesktop.org/show_bug.cgi?id=109274
[fdo#109279]: https://bugs.freedesktop.org/show_bug.cgi?id=109279
[fdo#109280]: https://bugs.freedesktop.org/show_bug.cgi?id=109280
[fdo#109283]: https://bugs.freedesktop.org/show_bug.cgi?id=109283
[fdo#109284]: https://bugs.freedesktop.org/show_bug.cgi?id=109284
[fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285
[fdo#109289]: https://bugs.freedesktop.org/show_bug.cgi?id=109289
[fdo#109291]: https://bugs.freedesktop.org/show_bug.cgi?id=109291
[fdo#109295]: https://bugs.freedesktop.org/show_bug.cgi?id=109295
[fdo#109302]: https://bugs.freedesktop.org/show_bug.cgi?id=109302
[fdo#109303]: https://bugs.freedesktop.org/show_bug.cgi?id=109303
[fdo#109307]: https://bugs.freedesktop.org/show_bug.cgi?id=109307
[fdo#109308]: https://bugs.freedesktop.org/show_bug.cgi?id=109308
[fdo#109309]: https://bugs.freedesktop.org/show_bug.cgi?id=109309
[fdo#109312]: https://bugs.freedesktop.org/show_bug.cgi?id=109312
[fdo#109314]: https://bugs.freedesktop.org/show_bug.cgi?id=109314
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[fdo#109506]: https://bugs.freedesktop.org/show_bug.cgi?id=109506
[fdo#109642]: https://bugs.freedesktop.org/show_bug.cgi?id=109642
[fdo#110189]: https://bugs.freedesktop.org/show_bug.cgi?id=110189
[fdo#110254]: https://bugs.freedesktop.org/show_bug.cgi?id=110254
[fdo#110542]: https://bugs.freedesktop.org/show_bug.cgi?id=110542
[fdo#110723]: https://bugs.freedesktop.org/show_bug.cgi?id=110723
[fdo#111068]: https://bugs.freedesktop.org/show_bug.cgi?id=111068
[fdo#111314]: https://bugs.freedesktop.org/show_bug.cgi?id=111314
[fdo#111614]: https://bugs.freedesktop.org/show_bug.cgi?id=111614
[fdo#111615]: https://bugs.freedesktop.org/show_bug.cgi?id=111615
[fdo#111644]: https://bugs.freedesktop.org/show_bug.cgi?id=111644
[fdo#111656]: https://bugs.freedesktop.org/show_bug.cgi?id=111656
[fdo#111825]: https://bugs.freedesktop.org/show_bug.cgi?id=111825
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[fdo#112022]: https://bugs.freedesktop.org/show_bug.cgi?id=112022
[fdo#112054]: https://bugs.freedesktop.org/show_bug.cgi?id=112054
[fdo#112283]: https://bugs.freedesktop.org/show_bug.cgi?id=112283
[i915#1063]: https://gitlab.freedesktop.org/drm/intel/issues/1063
[i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
[i915#1149]: https://gitlab.freedesktop.org/drm/intel/issues/1149
[i915#1155]: https://gitlab.freedesktop.org/drm/intel/issues/1155
[i915#1257]: https://gitlab.freedesktop.org/drm/intel/issues/1257
[i915#132]: https://gitlab.freedesktop.org/drm/intel/issues/132
[i915#1397]: https://gitlab.freedesktop.org/drm/intel/issues/1397
[i915#1722]: https://gitlab.freedesktop.org/drm/intel/issues/1722
[i915#1755]: https://gitlab.freedesktop.org/drm/intel/issues/1755
[i915#1769]: https://gitlab.freedesktop.org/drm/intel/issues/1769
[i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180
[i915#1825]: https://gitlab.freedesktop.org/drm/intel/issues/1825
[i915#1836]: https://gitlab.freedesktop.org/drm/intel/issues/1836
[i915#1839]: https://gitlab.freedesktop.org/drm/intel/issues/1839
[i915#1845]: https://gitlab.freedesktop.org/drm/intel/issues/1845
[i915#1849]: https://gitlab.freedesktop.org/drm/intel/issues/1849
[i915#1850]: https://gitlab.freedesktop.org/drm/intel/issues/1850
[i915#1888]: https://gitlab.freedesktop.org/drm/intel/issues/1888
[i915#1902]: https://gitlab.freedesktop.org/drm/intel/issues/1902
[i915#1911]: https://gitlab.freedesktop.org/drm/intel/issues/1911
[i915#1937]: https://gitlab.freedesktop.org/drm/intel/issues/1937
[i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982
[i915#2122]: https://gitlab.freedesktop.org/drm/intel/issues/2122
[i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190
[i915#2346]: https://gitlab.freedesktop.org/drm/intel/issues/2346
[i915#2410]: https://gitlab.freedesktop.org/drm/intel/issues/2410
[i915#2433]: https://gitlab.freedesktop.org/drm/intel/issues/2433
[i915#2434]: https://gitlab.freedesktop.org/drm/intel/issues/2434
[i915#2435]: https://gitlab.freedesktop.org/drm/intel/issues/2435
[i915#2436]: https://gitlab.freedesktop.org/drm/intel/issues/2436
[i915#2437]: https://gitlab.freedesktop.org/drm/intel/issues/2437
[i915#2527]: https://gitlab.freedesktop.org/drm/intel/issues/2527
[i915#2530]: https://gitlab.freedesktop.org/drm/intel/issues/2530
[i915#2582]: https://gitlab.freedesktop.org/drm/intel/issues/2582
[i915#2587]: https://gitlab.freedesktop.org/drm/intel/issues/2587
[i915#265]: https://gitlab.freedesktop.org/drm/intel/issues/265
[i915#2658]: https://gitlab.freedesktop.org/drm/intel/issues/2658
[i915#2681]: https://gitlab.freedesktop.org/drm/intel/issues/2681
[i915#2705]: https://gitlab.freedesktop.org/drm/intel/issues/2705
[i915#280]: https://gitlab.freedesktop.org/drm/intel/issues/280
[i915#284]: https://gitlab.freedesktop.org/drm/intel/issues/284
[i915#2842]: https://gitlab.freedesktop.org/drm/intel/issues/2842
[i915#2856]: https://gitlab.freedesktop.org/drm/intel/issues/2856
[i915#2920]: https://gitlab.freedesktop.org/drm/intel/issues/2920
[i915#2994]: https://gitlab.freedesktop.org/drm/intel/issues/2994
[i915#3002]: https://gitlab.freedesktop.org/drm/intel/issues/3002
[i915#3012]: https://gitlab.freedesktop.org/drm/intel/issues/3012
[i915#3063]: https://gitlab.freedesktop.org/drm/intel/issues/3063
[i915#3116]: https://gitlab.freedesktop.org/drm/intel/issues/3116
[i915#3281]: https://gitlab.freedesktop.org/drm/intel/issues/3281
[i915#3282]: https://gitlab.freedesktop.org/drm/intel/issues/3282
[i915#3291]: https://gitlab.freedesktop.org/drm/intel/issues/3291
[i915#3297]: https://gitlab.freedesktop.org/drm/intel/issues/3297
[i915#3299]: https://gitlab.freedesktop.org/drm/intel/issues/3299
[i915#3301]: https://gitlab.freedesktop.org/drm/intel/issues/3301
[i915#3318]: https://gitlab.freedesktop.org/drm/intel/issues/3318
[i915#3319]: https://gitlab.freedesktop.org/drm/intel/issues/3319
[i915#3323]: https://gitlab.freedesktop.org/drm/intel/issues/3323
[i915#3359]: https://gitlab.freedesktop.org/drm/intel/issues/3359
[i915#3361]: https://gitlab.freedesktop.org/drm/intel/issues/3361
[i915#3376]: https://gitlab.freedesktop.org/drm/intel/issues/3376
[i915#3458]: https://gitlab.freedesktop.org/drm/intel/issues/3458
[i915#3464]: https://gitlab.freedesktop.org/drm/intel/issues/3464
[i915#3467]: https://gitlab.freedesktop.org/drm/intel/issues/3467
[i915#3469]: https://gitlab.freedesktop.org/drm/intel/issues/3469
[i915#3539]: https://gitlab.freedesktop.org/drm/intel/issues/3539
[i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
[i915#3558]: https://gitlab.freedesktop.org/drm/intel/issues/3558
[i915#3637]: https://gitlab.freedesktop.org/drm/intel/issues/3637
[i915#3638]: https://gitlab.freedesktop.org/drm/intel/issues/3638
[i915#3689]: https://gitlab.freedesktop.org/drm/intel/issues/3689
[i915#3701]: https://gitlab.freedesktop.org/drm/intel/issues/3701
[i915#3708]: https://gitlab.freedesktop.org/drm/intel/issues/3708
[i915#3734]: https://gitlab.freedesktop.org/drm/intel/issues/3734
[i915#3742]: https://gitlab.freedesktop.org/drm/intel/issues/3742
[i915#3743]: https://gitlab.freedesktop.org/drm/intel/issues/3743
[i915#3825]: https://gitlab.freedesktop.org/drm/intel/issues/3825
[i915#3826]: https://gitlab.freedesktop.org/drm/intel/issues/3826
[i915#3828]: https://gitlab.freedesktop.org/drm/intel/issues/3828
[i915#3840]: https://gitlab.freedesktop.org/drm/intel/issues/3840
[i915#3886]: https://gitlab.freedesktop.org/drm/intel/issues/3886
[i915#3936]: https://gitlab.freedesktop.org/drm/intel/issues/3936
[i915#3938]: https://gitlab.freedesktop.org/drm/intel/issues/3938
[i915#3952]: https://gitlab.freedesktop.org/drm/intel/issues/3952
[i915#3955]: https://gitlab.freedesktop.org/drm/intel/issues/3955
[i915#3966]: https://gitlab.freedesktop.org/drm/intel/issues/3966
[i915#4016]: https://gitlab.freedesktop.org/drm/intel/issues/4016
[i915#4036]: https://gitlab.freedesktop.org/drm/intel/issues/4036
[i915#4070]: https://gitlab.freedesktop.org/drm/intel/issues/4070
[i915#4077]: https://gitlab.freedesktop.org/drm/intel/issues/4077
[i915#4078]: https://gitlab.freedesktop.org/drm/intel/issues/4078
[i915#4079]: https://gitlab.freedesktop.org/drm/intel/issues/4079
[i915#4083]: https://gitlab.freedesktop.org/drm/intel/issues/4083
[i915#4098]: https://gitlab.freedesktop.org/drm/intel/issues/4098
[i915#4103]: https://gitlab.freedesktop.org/drm/intel/issues/4103
[i915#4212]: https://gitlab.freedesktop.org/drm/intel/issues/4212
[i915#4213]: https://gitlab.freedesktop.org/drm/intel/issues/4213
[i915#426]: https://gitlab.freedesktop.org/drm/intel/issues/426
[i915#4270]: https://gitlab.freedesktop.org/drm/intel/issues/4270
[i915#4278]: https://gitlab.freedesktop.org/drm/intel/issues/4278
[i915#4281]: https://gitlab.freedesktop.org/drm/intel/issues/4281
[i915#4312]: https://gitlab.freedesktop.org/drm/intel/issues/4312
[i915#433]: https://gitlab.freedesktop.org/drm/intel/issues/433
[i915#4349]: https://gitlab.freedesktop.org/drm/intel/issues/4349
[i915#4369]: https://gitlab.freedesktop.org/drm/intel/issues/4369
[i915#4387]: https://gitlab.freedesktop.org/drm/intel/issues/4387
[i915#4392]: https://gitlab.freedesktop.org/drm/intel/issues/4392
[i915#4409]: https://gitlab.freedesktop.org/drm/intel/issues/4409
[i915#4521]: https://gitlab.freedesktop.org/drm/intel/issues/4521
[i915#4525]: https://gitlab.freedesktop.org/drm/intel/issues/4525
[i915#4538]: https://gitlab.freedesktop.org/drm/intel/issues/4538
[i915#454]: https://gitlab.freedesktop.org/drm/intel/issues/454
[i915#4565]: https://gitlab.freedesktop.org/drm/intel/issues/4565
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#4767]: https://gitlab.freedesktop.org/drm/intel/issues/4767
[i915#4771]: https://gitlab.freedesktop.org/drm/intel/issues/4771
[i915#4812]: https://gitlab.freedesktop.org/drm/intel/issues/4812
[i915#4818]: https://gitlab.freedesktop.org/drm/intel/issues/4818
[i915#4833]: https://gitlab.freedesktop.org/drm/intel/issues/4833
[i915#4839]: https://gitlab.freedesktop.org/drm/intel/issues/4839
[i915#4842]: https://gitlab.freedesktop.org/drm/intel/issues/4842
[i915#4852]: https://gitlab.freedesktop.org/drm/intel/issues/4852
[i915#4853]: https://gitlab.freedesktop.org/drm/intel/issues/4853
[i915#4854]: https://gitlab.freedesktop.org/drm/intel/issues/4854
[i915#4855]: https://gitlab.freedesktop.org/drm/intel/issues/4855
[i915#4859]: https://gitlab.freedesktop.org/drm/intel/issues/4859
[i915#4860]: https://gitlab.freedesktop.org/drm/intel/issues/4860
[i915#4873]: https://gitlab.freedesktop.org/drm/intel/issues/4873
[i915#4874]: https://gitlab.freedesktop.org/drm/intel/issues/4874
[i915#4880]: https://gitlab.freedesktop.org/drm/intel/issues/4880
[i915#4881]: https://gitlab.freedesktop.org/drm/intel/issues/4881
[i915#4883]: https://gitlab.freedesktop.org/drm/intel/issues/4883
[i915#4885]: https://gitlab.freedesktop.org/drm/intel/issues/4885
[i915#4893]: https://gitlab.freedesktop.org/drm/intel/issues/4893
[i915#4936]: https://gitlab.freedesktop.org/drm/intel/issues/4936
[i915#4941]: https://gitlab.freedesktop.org/drm/intel/issues/4941
[i915#4958]: https://gitlab.freedesktop.org/drm/intel/issues/4958
[i915#4991]: https://gitlab.freedesktop.org/drm/intel/issues/4991
[i915#51]: https://gitlab.freedesktop.org/drm/intel/issues/51
[i915#5176]: https://gitlab.freedesktop.org/drm/intel/issues/5176
[i915#5182]: https://gitlab.freedesktop.org/drm/intel/issues/5182
[i915#5235]: https://gitlab.freedesktop.org/drm/intel/issues/5235
[i915#5257]: https://gitlab.freedesktop.org/drm/intel/issues/5257
[i915#5286]: https://gitlab.freedesktop.org/drm/intel/issues/5286
[i915#5287]: https://gitlab.freedesktop.org/drm/intel/issues/5287
[i915#5288]: https://gitlab.freedesktop.org/drm/intel/issues/5288
[i915#5289]: https://gitlab.freedesktop.org/drm/intel/issues/5289
[i915#5303]: https://gitlab.freedesktop.org/drm/intel/issues/5303
[i915#5325]: https://gitlab.freedesktop.org/drm/intel/issues/5325
[i915#533]: https://gitlab.freedesktop.org/drm/intel/issues/533
[i915#5439]: https://gitlab.freedesktop.org/drm/intel/issues/5439
[i915#5461]: https://gitlab.freedesktop.org/drm/intel/issues/5461
[i915#5563]: https://gitlab.freedesktop.org/drm/intel/issues/5563
[i915#5566]: https://gitlab.freedesktop.org/drm/intel/issues/5566
[i915#5591]: https://gitlab.freedesktop.org/drm/intel/issues/5591
[i915#5639]: https://gitlab.freedesktop.org/drm/intel/issues/5639
[i915#5723]: https://gitlab.freedesktop.org/drm/intel/issues/5723
[i915#5784]: https://gitlab.freedesktop.org/drm/intel/issues/5784
[i915#5843]: https://gitlab.freedesktop.org/drm/intel/issues/5843
[i915#5903]: https://gitlab.freedesktop.org/drm/intel/issues/5903
[i915#6011]: https://gitlab.freedesktop.org/drm/intel/issues/6011
[i915#6060]: https://gitlab.freedesktop.org/drm/intel/issues/6060
[i915#6076]: https://gitlab.freedesktop.org/drm/intel/issues/6076
[i915#6095]: https://gitlab.freedesktop.org/drm/intel/issues/6095
[i915#6140]: https://gitlab.freedesktop.org/drm/intel/issues/6140
[i915#6141]: https://gitlab.freedesktop.org/drm/intel/issues/6141
[i915#6227]: https://gitlab.freedesktop.org/drm/intel/issues/6227
[i915#658]: https://gitlab.freedesktop.org/drm/intel/issues/658
[i915#716]: https://gitlab.freedesktop.org/drm/intel/issues/716
[i915#79]: https://gitlab.freedesktop.org/drm/intel/issues/79
[i915#92]: https://gitlab.freedesktop.org/drm/intel/issues/92
Build changes
-------------
* Linux: CI_DRM_11757 -> Patchwork_105122v1
CI-20190529: 20190529
CI_DRM_11757: da1e3835cdf5e8c449d1edeb993105efd7c8815d @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_6524: 4b17146f2a0504db694eb89e19d7f9f7f5051983 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_105122v1: da1e3835cdf5e8c449d1edeb993105efd7c8815d @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105122v1/index.html
[-- Attachment #2: Type: text/html, Size: 55465 bytes --]
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [PATCH 1/3] drm/i915: Do not access rq->engine without a reference
2022-06-14 18:43 ` [Intel-gfx] " Ramalingam C
@ 2022-06-27 17:09 ` Matthew Brost
-1 siblings, 0 replies; 19+ messages in thread
From: Matthew Brost @ 2022-06-27 17:09 UTC (permalink / raw)
To: Ramalingam C
Cc: Niranjana Vishwanathapura, intel-gfx, Hellstrom Thomas,
Matthew Auld, dri-devel
On Wed, Jun 15, 2022 at 12:13:46AM +0530, Ramalingam C wrote:
> From: Niranjana Vishwanathapura <niranjana.vishwanathapura@intel.com>
>
> In i915_fence_get_driver_name(), user may not hold a
> reference to rq->engine. Hence do not access it. Instead,
> store required device private pointer in 'rq->i915' and use it.
>
> Signed-off-by: Niranjana Vishwanathapura <niranjana.vishwanathapura@intel.com>
> Suggested-by: Matthew Brost <matthew.brost@intel.com>
Reviewed-by: Matthew Brost <matthew.brost@intel.com>
> ---
> drivers/gpu/drm/i915/i915_request.c | 3 ++-
> drivers/gpu/drm/i915/i915_request.h | 2 ++
> 2 files changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_request.c b/drivers/gpu/drm/i915/i915_request.c
> index 73d5195146b0..7f6998bf390c 100644
> --- a/drivers/gpu/drm/i915/i915_request.c
> +++ b/drivers/gpu/drm/i915/i915_request.c
> @@ -60,7 +60,7 @@ static struct kmem_cache *slab_execute_cbs;
>
> static const char *i915_fence_get_driver_name(struct dma_fence *fence)
> {
> - return dev_name(to_request(fence)->engine->i915->drm.dev);
> + return dev_name(to_request(fence)->i915->drm.dev);
> }
>
> static const char *i915_fence_get_timeline_name(struct dma_fence *fence)
> @@ -937,6 +937,7 @@ __i915_request_create(struct intel_context *ce, gfp_t gfp)
> rq->engine = ce->engine;
> rq->ring = ce->ring;
> rq->execution_mask = ce->engine->mask;
> + rq->i915 = ce->engine->i915;
>
> ret = intel_timeline_get_seqno(tl, rq, &seqno);
> if (ret)
> diff --git a/drivers/gpu/drm/i915/i915_request.h b/drivers/gpu/drm/i915/i915_request.h
> index 28b1f9db5487..47041ec68df8 100644
> --- a/drivers/gpu/drm/i915/i915_request.h
> +++ b/drivers/gpu/drm/i915/i915_request.h
> @@ -196,6 +196,8 @@ struct i915_request {
> struct dma_fence fence;
> spinlock_t lock;
>
> + struct drm_i915_private *i915;
> +
> /**
> * Context and ring buffer related to this request
> * Contexts are refcounted, so when this request is associated with a
> --
> 2.20.1
>
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [Intel-gfx] [PATCH 1/3] drm/i915: Do not access rq->engine without a reference
@ 2022-06-27 17:09 ` Matthew Brost
0 siblings, 0 replies; 19+ messages in thread
From: Matthew Brost @ 2022-06-27 17:09 UTC (permalink / raw)
To: Ramalingam C; +Cc: intel-gfx, Hellstrom Thomas, Matthew Auld, dri-devel
On Wed, Jun 15, 2022 at 12:13:46AM +0530, Ramalingam C wrote:
> From: Niranjana Vishwanathapura <niranjana.vishwanathapura@intel.com>
>
> In i915_fence_get_driver_name(), user may not hold a
> reference to rq->engine. Hence do not access it. Instead,
> store required device private pointer in 'rq->i915' and use it.
>
> Signed-off-by: Niranjana Vishwanathapura <niranjana.vishwanathapura@intel.com>
> Suggested-by: Matthew Brost <matthew.brost@intel.com>
Reviewed-by: Matthew Brost <matthew.brost@intel.com>
> ---
> drivers/gpu/drm/i915/i915_request.c | 3 ++-
> drivers/gpu/drm/i915/i915_request.h | 2 ++
> 2 files changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_request.c b/drivers/gpu/drm/i915/i915_request.c
> index 73d5195146b0..7f6998bf390c 100644
> --- a/drivers/gpu/drm/i915/i915_request.c
> +++ b/drivers/gpu/drm/i915/i915_request.c
> @@ -60,7 +60,7 @@ static struct kmem_cache *slab_execute_cbs;
>
> static const char *i915_fence_get_driver_name(struct dma_fence *fence)
> {
> - return dev_name(to_request(fence)->engine->i915->drm.dev);
> + return dev_name(to_request(fence)->i915->drm.dev);
> }
>
> static const char *i915_fence_get_timeline_name(struct dma_fence *fence)
> @@ -937,6 +937,7 @@ __i915_request_create(struct intel_context *ce, gfp_t gfp)
> rq->engine = ce->engine;
> rq->ring = ce->ring;
> rq->execution_mask = ce->engine->mask;
> + rq->i915 = ce->engine->i915;
>
> ret = intel_timeline_get_seqno(tl, rq, &seqno);
> if (ret)
> diff --git a/drivers/gpu/drm/i915/i915_request.h b/drivers/gpu/drm/i915/i915_request.h
> index 28b1f9db5487..47041ec68df8 100644
> --- a/drivers/gpu/drm/i915/i915_request.h
> +++ b/drivers/gpu/drm/i915/i915_request.h
> @@ -196,6 +196,8 @@ struct i915_request {
> struct dma_fence fence;
> spinlock_t lock;
>
> + struct drm_i915_private *i915;
> +
> /**
> * Context and ring buffer related to this request
> * Contexts are refcounted, so when this request is associated with a
> --
> 2.20.1
>
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [PATCH 2/3] Revert "drm/i915: Hold reference to intel_context over life of i915_request"
2022-06-14 18:43 ` [Intel-gfx] " Ramalingam C
@ 2022-06-27 17:18 ` Matthew Brost
-1 siblings, 0 replies; 19+ messages in thread
From: Matthew Brost @ 2022-06-27 17:18 UTC (permalink / raw)
To: Ramalingam C
Cc: Niranjana Vishwanathapura, intel-gfx, Hellstrom Thomas,
Matthew Auld, dri-devel
On Wed, Jun 15, 2022 at 12:13:47AM +0530, Ramalingam C wrote:
> From: Niranjana Vishwanathapura <niranjana.vishwanathapura@intel.com>
>
> This reverts commit 1e98d8c52ed5dfbaf273c4423c636525c2ce59e7.
>
> The problem with this patch is that it makes i915_request to hold a
> reference to intel_context, which in turn holds a reference on the VM.
> This strong back referencing can lead to reference loops which leads
> to resource leak.
>
> An example is the upcoming VM_BIND work which requires VM to hold
> a reference to some shared VM specific BO. But this BO's dma-resv
> fences holds reference to the i915_request thus leading to reference
> loop.
>
> Signed-off-by: Niranjana Vishwanathapura <niranjana.vishwanathapura@intel.com>
> Signed-off-by: Ramalingam C <ramalingam.c@intel.com>
> Suggested-by: Matthew Brost <matthew.brost@intel.com>
Talked with Ram, this patch needs to be squashed with the following
patch. The reasoning is with just this patch, the tree is broken -
parallel submission contexts will leak requests.
With the patches squashed:
Reviewed-by: Mathew Brost <matthew.brost@intel.com>
> ---
> drivers/gpu/drm/i915/i915_request.c | 55 +++++++++++++++++------------
> 1 file changed, 32 insertions(+), 23 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_request.c b/drivers/gpu/drm/i915/i915_request.c
> index 7f6998bf390c..c71905d8e154 100644
> --- a/drivers/gpu/drm/i915/i915_request.c
> +++ b/drivers/gpu/drm/i915/i915_request.c
> @@ -134,17 +134,39 @@ static void i915_fence_release(struct dma_fence *fence)
> i915_sw_fence_fini(&rq->semaphore);
>
> /*
> - * Keep one request on each engine for reserved use under mempressure,
> - * do not use with virtual engines as this really is only needed for
> - * kernel contexts.
> + * Keep one request on each engine for reserved use under mempressure
> + *
> + * We do not hold a reference to the engine here and so have to be
> + * very careful in what rq->engine we poke. The virtual engine is
> + * referenced via the rq->context and we released that ref during
> + * i915_request_retire(), ergo we must not dereference a virtual
> + * engine here. Not that we would want to, as the only consumer of
> + * the reserved engine->request_pool is the power management parking,
> + * which must-not-fail, and that is only run on the physical engines.
> + *
> + * Since the request must have been executed to be have completed,
> + * we know that it will have been processed by the HW and will
> + * not be unsubmitted again, so rq->engine and rq->execution_mask
> + * at this point is stable. rq->execution_mask will be a single
> + * bit if the last and _only_ engine it could execution on was a
> + * physical engine, if it's multiple bits then it started on and
> + * could still be on a virtual engine. Thus if the mask is not a
> + * power-of-two we assume that rq->engine may still be a virtual
> + * engine and so a dangling invalid pointer that we cannot dereference
> + *
> + * For example, consider the flow of a bonded request through a virtual
> + * engine. The request is created with a wide engine mask (all engines
> + * that we might execute on). On processing the bond, the request mask
> + * is reduced to one or more engines. If the request is subsequently
> + * bound to a single engine, it will then be constrained to only
> + * execute on that engine and never returned to the virtual engine
> + * after timeslicing away, see __unwind_incomplete_requests(). Thus we
> + * know that if the rq->execution_mask is a single bit, rq->engine
> + * can be a physical engine with the exact corresponding mask.
> */
> - if (!intel_engine_is_virtual(rq->engine) &&
> - !cmpxchg(&rq->engine->request_pool, NULL, rq)) {
> - intel_context_put(rq->context);
> + if (is_power_of_2(rq->execution_mask) &&
> + !cmpxchg(&rq->engine->request_pool, NULL, rq))
> return;
> - }
> -
> - intel_context_put(rq->context);
>
> kmem_cache_free(slab_requests, rq);
> }
> @@ -921,19 +943,7 @@ __i915_request_create(struct intel_context *ce, gfp_t gfp)
> }
> }
>
> - /*
> - * Hold a reference to the intel_context over life of an i915_request.
> - * Without this an i915_request can exist after the context has been
> - * destroyed (e.g. request retired, context closed, but user space holds
> - * a reference to the request from an out fence). In the case of GuC
> - * submission + virtual engine, the engine that the request references
> - * is also destroyed which can trigger bad pointer dref in fence ops
> - * (e.g. i915_fence_get_driver_name). We could likely change these
> - * functions to avoid touching the engine but let's just be safe and
> - * hold the intel_context reference. In execlist mode the request always
> - * eventually points to a physical engine so this isn't an issue.
> - */
> - rq->context = intel_context_get(ce);
> + rq->context = ce;
> rq->engine = ce->engine;
> rq->ring = ce->ring;
> rq->execution_mask = ce->engine->mask;
> @@ -1009,7 +1019,6 @@ __i915_request_create(struct intel_context *ce, gfp_t gfp)
> GEM_BUG_ON(!list_empty(&rq->sched.waiters_list));
>
> err_free:
> - intel_context_put(ce);
> kmem_cache_free(slab_requests, rq);
> err_unreserve:
> intel_context_unpin(ce);
> --
> 2.20.1
>
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [Intel-gfx] [PATCH 2/3] Revert "drm/i915: Hold reference to intel_context over life of i915_request"
@ 2022-06-27 17:18 ` Matthew Brost
0 siblings, 0 replies; 19+ messages in thread
From: Matthew Brost @ 2022-06-27 17:18 UTC (permalink / raw)
To: Ramalingam C; +Cc: intel-gfx, Hellstrom Thomas, Matthew Auld, dri-devel
On Wed, Jun 15, 2022 at 12:13:47AM +0530, Ramalingam C wrote:
> From: Niranjana Vishwanathapura <niranjana.vishwanathapura@intel.com>
>
> This reverts commit 1e98d8c52ed5dfbaf273c4423c636525c2ce59e7.
>
> The problem with this patch is that it makes i915_request to hold a
> reference to intel_context, which in turn holds a reference on the VM.
> This strong back referencing can lead to reference loops which leads
> to resource leak.
>
> An example is the upcoming VM_BIND work which requires VM to hold
> a reference to some shared VM specific BO. But this BO's dma-resv
> fences holds reference to the i915_request thus leading to reference
> loop.
>
> Signed-off-by: Niranjana Vishwanathapura <niranjana.vishwanathapura@intel.com>
> Signed-off-by: Ramalingam C <ramalingam.c@intel.com>
> Suggested-by: Matthew Brost <matthew.brost@intel.com>
Talked with Ram, this patch needs to be squashed with the following
patch. The reasoning is with just this patch, the tree is broken -
parallel submission contexts will leak requests.
With the patches squashed:
Reviewed-by: Mathew Brost <matthew.brost@intel.com>
> ---
> drivers/gpu/drm/i915/i915_request.c | 55 +++++++++++++++++------------
> 1 file changed, 32 insertions(+), 23 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_request.c b/drivers/gpu/drm/i915/i915_request.c
> index 7f6998bf390c..c71905d8e154 100644
> --- a/drivers/gpu/drm/i915/i915_request.c
> +++ b/drivers/gpu/drm/i915/i915_request.c
> @@ -134,17 +134,39 @@ static void i915_fence_release(struct dma_fence *fence)
> i915_sw_fence_fini(&rq->semaphore);
>
> /*
> - * Keep one request on each engine for reserved use under mempressure,
> - * do not use with virtual engines as this really is only needed for
> - * kernel contexts.
> + * Keep one request on each engine for reserved use under mempressure
> + *
> + * We do not hold a reference to the engine here and so have to be
> + * very careful in what rq->engine we poke. The virtual engine is
> + * referenced via the rq->context and we released that ref during
> + * i915_request_retire(), ergo we must not dereference a virtual
> + * engine here. Not that we would want to, as the only consumer of
> + * the reserved engine->request_pool is the power management parking,
> + * which must-not-fail, and that is only run on the physical engines.
> + *
> + * Since the request must have been executed to be have completed,
> + * we know that it will have been processed by the HW and will
> + * not be unsubmitted again, so rq->engine and rq->execution_mask
> + * at this point is stable. rq->execution_mask will be a single
> + * bit if the last and _only_ engine it could execution on was a
> + * physical engine, if it's multiple bits then it started on and
> + * could still be on a virtual engine. Thus if the mask is not a
> + * power-of-two we assume that rq->engine may still be a virtual
> + * engine and so a dangling invalid pointer that we cannot dereference
> + *
> + * For example, consider the flow of a bonded request through a virtual
> + * engine. The request is created with a wide engine mask (all engines
> + * that we might execute on). On processing the bond, the request mask
> + * is reduced to one or more engines. If the request is subsequently
> + * bound to a single engine, it will then be constrained to only
> + * execute on that engine and never returned to the virtual engine
> + * after timeslicing away, see __unwind_incomplete_requests(). Thus we
> + * know that if the rq->execution_mask is a single bit, rq->engine
> + * can be a physical engine with the exact corresponding mask.
> */
> - if (!intel_engine_is_virtual(rq->engine) &&
> - !cmpxchg(&rq->engine->request_pool, NULL, rq)) {
> - intel_context_put(rq->context);
> + if (is_power_of_2(rq->execution_mask) &&
> + !cmpxchg(&rq->engine->request_pool, NULL, rq))
> return;
> - }
> -
> - intel_context_put(rq->context);
>
> kmem_cache_free(slab_requests, rq);
> }
> @@ -921,19 +943,7 @@ __i915_request_create(struct intel_context *ce, gfp_t gfp)
> }
> }
>
> - /*
> - * Hold a reference to the intel_context over life of an i915_request.
> - * Without this an i915_request can exist after the context has been
> - * destroyed (e.g. request retired, context closed, but user space holds
> - * a reference to the request from an out fence). In the case of GuC
> - * submission + virtual engine, the engine that the request references
> - * is also destroyed which can trigger bad pointer dref in fence ops
> - * (e.g. i915_fence_get_driver_name). We could likely change these
> - * functions to avoid touching the engine but let's just be safe and
> - * hold the intel_context reference. In execlist mode the request always
> - * eventually points to a physical engine so this isn't an issue.
> - */
> - rq->context = intel_context_get(ce);
> + rq->context = ce;
> rq->engine = ce->engine;
> rq->ring = ce->ring;
> rq->execution_mask = ce->engine->mask;
> @@ -1009,7 +1019,6 @@ __i915_request_create(struct intel_context *ce, gfp_t gfp)
> GEM_BUG_ON(!list_empty(&rq->sched.waiters_list));
>
> err_free:
> - intel_context_put(ce);
> kmem_cache_free(slab_requests, rq);
> err_unreserve:
> intel_context_unpin(ce);
> --
> 2.20.1
>
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [PATCH 3/3] drm/i915: Do not use reserved requests for virtual engines
2022-06-14 18:43 ` [Intel-gfx] " Ramalingam C
@ 2022-06-27 17:18 ` Matthew Brost
-1 siblings, 0 replies; 19+ messages in thread
From: Matthew Brost @ 2022-06-27 17:18 UTC (permalink / raw)
To: Ramalingam C; +Cc: intel-gfx, Hellstrom Thomas, Matthew Auld, dri-devel
On Wed, Jun 15, 2022 at 12:13:48AM +0530, Ramalingam C wrote:
> Do not use reserved requests for virtual engines as this is only
> needed for kernel contexts.
>
> Signed-off-by: Ramalingam C <ramalingam.c@intel.com>
> Suggested-by: Matthew Brost <matthew.brost@intel.com>
With the patch squashed into the previous patch:
Reviewed-by: Matthew Brost <matthew.brost@intel.com>
> ---
> drivers/gpu/drm/i915/i915_request.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_request.c b/drivers/gpu/drm/i915/i915_request.c
> index c71905d8e154..f0392b053bca 100644
> --- a/drivers/gpu/drm/i915/i915_request.c
> +++ b/drivers/gpu/drm/i915/i915_request.c
> @@ -135,6 +135,8 @@ static void i915_fence_release(struct dma_fence *fence)
>
> /*
> * Keep one request on each engine for reserved use under mempressure
> + * do not use with virtual engines as this really is only needed for
> + * kernel contexts.
> *
> * We do not hold a reference to the engine here and so have to be
> * very careful in what rq->engine we poke. The virtual engine is
> @@ -164,7 +166,8 @@ static void i915_fence_release(struct dma_fence *fence)
> * know that if the rq->execution_mask is a single bit, rq->engine
> * can be a physical engine with the exact corresponding mask.
> */
> - if (is_power_of_2(rq->execution_mask) &&
> + if (!intel_engine_is_virtual(rq->engine) &&
> + is_power_of_2(rq->execution_mask) &&
> !cmpxchg(&rq->engine->request_pool, NULL, rq))
> return;
>
> --
> 2.20.1
>
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [Intel-gfx] [PATCH 3/3] drm/i915: Do not use reserved requests for virtual engines
@ 2022-06-27 17:18 ` Matthew Brost
0 siblings, 0 replies; 19+ messages in thread
From: Matthew Brost @ 2022-06-27 17:18 UTC (permalink / raw)
To: Ramalingam C; +Cc: intel-gfx, Hellstrom Thomas, Matthew Auld, dri-devel
On Wed, Jun 15, 2022 at 12:13:48AM +0530, Ramalingam C wrote:
> Do not use reserved requests for virtual engines as this is only
> needed for kernel contexts.
>
> Signed-off-by: Ramalingam C <ramalingam.c@intel.com>
> Suggested-by: Matthew Brost <matthew.brost@intel.com>
With the patch squashed into the previous patch:
Reviewed-by: Matthew Brost <matthew.brost@intel.com>
> ---
> drivers/gpu/drm/i915/i915_request.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_request.c b/drivers/gpu/drm/i915/i915_request.c
> index c71905d8e154..f0392b053bca 100644
> --- a/drivers/gpu/drm/i915/i915_request.c
> +++ b/drivers/gpu/drm/i915/i915_request.c
> @@ -135,6 +135,8 @@ static void i915_fence_release(struct dma_fence *fence)
>
> /*
> * Keep one request on each engine for reserved use under mempressure
> + * do not use with virtual engines as this really is only needed for
> + * kernel contexts.
> *
> * We do not hold a reference to the engine here and so have to be
> * very careful in what rq->engine we poke. The virtual engine is
> @@ -164,7 +166,8 @@ static void i915_fence_release(struct dma_fence *fence)
> * know that if the rq->execution_mask is a single bit, rq->engine
> * can be a physical engine with the exact corresponding mask.
> */
> - if (is_power_of_2(rq->execution_mask) &&
> + if (!intel_engine_is_virtual(rq->engine) &&
> + is_power_of_2(rq->execution_mask) &&
> !cmpxchg(&rq->engine->request_pool, NULL, rq))
> return;
>
> --
> 2.20.1
>
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [PATCH 3/3] drm/i915: Do not use reserved requests for virtual engines
2022-06-27 17:18 ` [Intel-gfx] " Matthew Brost
@ 2022-06-27 18:01 ` Ramalingam C
-1 siblings, 0 replies; 19+ messages in thread
From: Ramalingam C @ 2022-06-27 18:01 UTC (permalink / raw)
To: Matthew Brost; +Cc: intel-gfx, Hellstrom Thomas, Matthew Auld, dri-devel
On 2022-06-27 at 10:18:59 -0700, Matthew Brost wrote:
> On Wed, Jun 15, 2022 at 12:13:48AM +0530, Ramalingam C wrote:
> > Do not use reserved requests for virtual engines as this is only
> > needed for kernel contexts.
> >
> > Signed-off-by: Ramalingam C <ramalingam.c@intel.com>
> > Suggested-by: Matthew Brost <matthew.brost@intel.com>
>
> With the patch squashed into the previous patch:
> Reviewed-by: Matthew Brost <matthew.brost@intel.com>
Thank you Matthew. I will squash them while merging.
Ram
>
> > ---
> > drivers/gpu/drm/i915/i915_request.c | 5 ++++-
> > 1 file changed, 4 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/i915/i915_request.c b/drivers/gpu/drm/i915/i915_request.c
> > index c71905d8e154..f0392b053bca 100644
> > --- a/drivers/gpu/drm/i915/i915_request.c
> > +++ b/drivers/gpu/drm/i915/i915_request.c
> > @@ -135,6 +135,8 @@ static void i915_fence_release(struct dma_fence *fence)
> >
> > /*
> > * Keep one request on each engine for reserved use under mempressure
> > + * do not use with virtual engines as this really is only needed for
> > + * kernel contexts.
> > *
> > * We do not hold a reference to the engine here and so have to be
> > * very careful in what rq->engine we poke. The virtual engine is
> > @@ -164,7 +166,8 @@ static void i915_fence_release(struct dma_fence *fence)
> > * know that if the rq->execution_mask is a single bit, rq->engine
> > * can be a physical engine with the exact corresponding mask.
> > */
> > - if (is_power_of_2(rq->execution_mask) &&
> > + if (!intel_engine_is_virtual(rq->engine) &&
> > + is_power_of_2(rq->execution_mask) &&
> > !cmpxchg(&rq->engine->request_pool, NULL, rq))
> > return;
> >
> > --
> > 2.20.1
> >
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [Intel-gfx] [PATCH 3/3] drm/i915: Do not use reserved requests for virtual engines
@ 2022-06-27 18:01 ` Ramalingam C
0 siblings, 0 replies; 19+ messages in thread
From: Ramalingam C @ 2022-06-27 18:01 UTC (permalink / raw)
To: Matthew Brost; +Cc: intel-gfx, Hellstrom Thomas, Matthew Auld, dri-devel
On 2022-06-27 at 10:18:59 -0700, Matthew Brost wrote:
> On Wed, Jun 15, 2022 at 12:13:48AM +0530, Ramalingam C wrote:
> > Do not use reserved requests for virtual engines as this is only
> > needed for kernel contexts.
> >
> > Signed-off-by: Ramalingam C <ramalingam.c@intel.com>
> > Suggested-by: Matthew Brost <matthew.brost@intel.com>
>
> With the patch squashed into the previous patch:
> Reviewed-by: Matthew Brost <matthew.brost@intel.com>
Thank you Matthew. I will squash them while merging.
Ram
>
> > ---
> > drivers/gpu/drm/i915/i915_request.c | 5 ++++-
> > 1 file changed, 4 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/i915/i915_request.c b/drivers/gpu/drm/i915/i915_request.c
> > index c71905d8e154..f0392b053bca 100644
> > --- a/drivers/gpu/drm/i915/i915_request.c
> > +++ b/drivers/gpu/drm/i915/i915_request.c
> > @@ -135,6 +135,8 @@ static void i915_fence_release(struct dma_fence *fence)
> >
> > /*
> > * Keep one request on each engine for reserved use under mempressure
> > + * do not use with virtual engines as this really is only needed for
> > + * kernel contexts.
> > *
> > * We do not hold a reference to the engine here and so have to be
> > * very careful in what rq->engine we poke. The virtual engine is
> > @@ -164,7 +166,8 @@ static void i915_fence_release(struct dma_fence *fence)
> > * know that if the rq->execution_mask is a single bit, rq->engine
> > * can be a physical engine with the exact corresponding mask.
> > */
> > - if (is_power_of_2(rq->execution_mask) &&
> > + if (!intel_engine_is_virtual(rq->engine) &&
> > + is_power_of_2(rq->execution_mask) &&
> > !cmpxchg(&rq->engine->request_pool, NULL, rq))
> > return;
> >
> > --
> > 2.20.1
> >
^ permalink raw reply [flat|nested] 19+ messages in thread
end of thread, other threads:[~2022-06-27 17:59 UTC | newest]
Thread overview: 19+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-06-14 18:43 [PATCH 0/3] Break VM to rq reference loop Ramalingam C
2022-06-14 18:43 ` [Intel-gfx] " Ramalingam C
2022-06-14 18:43 ` [PATCH 1/3] drm/i915: Do not access rq->engine without a reference Ramalingam C
2022-06-14 18:43 ` [Intel-gfx] " Ramalingam C
2022-06-27 17:09 ` Matthew Brost
2022-06-27 17:09 ` [Intel-gfx] " Matthew Brost
2022-06-14 18:43 ` [PATCH 2/3] Revert "drm/i915: Hold reference to intel_context over life of i915_request" Ramalingam C
2022-06-14 18:43 ` [Intel-gfx] " Ramalingam C
2022-06-27 17:18 ` Matthew Brost
2022-06-27 17:18 ` [Intel-gfx] " Matthew Brost
2022-06-14 18:43 ` [PATCH 3/3] drm/i915: Do not use reserved requests for virtual engines Ramalingam C
2022-06-14 18:43 ` [Intel-gfx] " Ramalingam C
2022-06-27 17:18 ` Matthew Brost
2022-06-27 17:18 ` [Intel-gfx] " Matthew Brost
2022-06-27 18:01 ` Ramalingam C
2022-06-27 18:01 ` [Intel-gfx] " Ramalingam C
2022-06-14 19:56 ` [Intel-gfx] ✗ Fi.CI.SPARSE: warning for Break VM to rq reference loop Patchwork
2022-06-14 20:27 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2022-06-15 6:41 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.