All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Jander <david@protonic.nl>
To: Mark Brown <broonie@kernel.org>
Cc: linux-spi@vger.kernel.org, Marc Kleine-Budde <mkl@pengutronix.de>,
	Andrew Lunn <andrew@lunn.ch>
Subject: Re: [PATCH v3 00/11] Optimize spi_sync path
Date: Tue, 28 Jun 2022 08:32:14 +0200	[thread overview]
Message-ID: <20220628083214.566e76da@erd992> (raw)
In-Reply-To: <YrYfFiiYuvazKBtu@sirena.org.uk>

On Fri, 24 Jun 2022 21:31:18 +0100
Mark Brown <broonie@kernel.org> wrote:

> On Tue, Jun 21, 2022 at 08:12:23AM +0200, David Jander wrote:
> > These patches optimize the spi_sync call for the common case that the
> > worker thread is idle and the queue is empty. It also opens the
> > possibility to potentially further optimize the async path also, since
> > it doesn't need to take into account the direct sync path anymore.
> > 
> > As an example for the performance gain, on an i.MX8MM SoC with a SPI CAN
> > controller attached (MCP2518FD), the time the interrupt line stays
> > active (which corresponds roughly with the time it takes to send 3
> > relatively short consecutive spi_sync messages) is reduced from 98us to
> > only 72us by this patch.  
> 
> This seems to be testing fine so far so I'm thinking it's probably a
> good idea to get it into -next which will hopefully trigger wider
> testing, unless someone shouts I'll look into that early next week.  The
> only feedback I've seen was Andy's review which is broadly stylistic so
> can safely be addressed incrementally (like the improvement in patch 4
> already does for example), I didn't see any comments there which went to
> correctness.

Great. So I will wait for this series to hit -next and then send incremental
patches to address Andy's feedback, or do you prefer I re-submit a v4 with
Andy's comments addressed right away?

Best regards,

-- 
David Jander

  reply	other threads:[~2022-06-28  6:33 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-21  6:12 [PATCH v3 00/11] Optimize spi_sync path David Jander
2022-06-21  6:12 ` [PATCH v3 01/11] spi: Move ctlr->cur_msg_prepared to struct spi_message David Jander
2022-06-21  6:12 ` [PATCH v3 02/11] spi: Don't use the message queue if possible in spi_sync David Jander
2022-06-21  6:12 ` [PATCH v3 03/11] spi: Lock controller idling transition inside the io_mutex David Jander
2022-06-21 13:36   ` Andy Shevchenko
2022-06-29 13:08     ` David Jander
2022-06-21  6:12 ` [PATCH v3 04/11] spi: __spi_pump_messages: Consolidate spin_unlocks to goto target David Jander
2022-06-21  6:12 ` [PATCH v3 05/11] spi: Remove check for controller idling in spi sync path David Jander
2022-06-21  6:12 ` [PATCH v3 06/11] spi: Remove check for idling in __spi_pump_messages() David Jander
2022-06-21  6:12 ` [PATCH v3 07/11] spi: Remove the now unused ctlr->idling flag David Jander
2022-06-21  6:12 ` [PATCH v3 08/11] spi: Remove unneeded READ_ONCE for ctlr->busy flag David Jander
2022-06-21  6:12 ` [PATCH v3 09/11] spi: Set ctlr->cur_msg also in the sync transfer case David Jander
2022-06-21  6:12 ` [PATCH v3 10/11] spi: Ensure the io_mutex is held until spi_finalize_current_message() David Jander
2022-06-21 13:41   ` Andy Shevchenko
2022-06-21  6:12 ` [PATCH v3 11/11] spi: opportunistically skip ctlr->cur_msg_completion David Jander
2022-06-21 13:46   ` Andy Shevchenko
2022-06-21 17:21 ` [PATCH v3 00/11] Optimize spi_sync path Mark Brown
2022-06-24 20:31 ` Mark Brown
2022-06-28  6:32   ` David Jander [this message]
2022-06-28 10:31     ` Mark Brown
2022-06-28 10:31 ` Mark Brown
2022-07-15 14:13 ` Thomas Kopp
2022-07-18  6:02   ` David Jander

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220628083214.566e76da@erd992 \
    --to=david@protonic.nl \
    --cc=andrew@lunn.ch \
    --cc=broonie@kernel.org \
    --cc=linux-spi@vger.kernel.org \
    --cc=mkl@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.