[RFC PATCH] arm64: dts: renesas: ebisu: add port node to ak4613

* [RFC PATCH] arm64: dts: renesas: ebisu: add port node to ak4613
@ 2022-06-28 12:23 Wolfram Sang
  2022-06-29  0:19 ` Kuninori Morimoto
  0 siblings, 1 reply; 4+ messages in thread
From: Wolfram Sang @ 2022-06-28 12:23 UTC (permalink / raw)
  To: linux-renesas-soc; +Cc: Kuninori Morimoto, Wolfram Sang

My Ebisu complains about the missing node when booting:

 OF: graph: no port node found in /soc/i2c@e66d0000/codec@10
 ------------[ cut here ]------------
 WARNING: CPU: 1 PID: 37 at sound/soc/codecs/ak4613.c:873 ak4613_i2c_probe+0x274/0x2a0
 CPU: 1 PID: 37 Comm: kworker/u4:2 Not tainted 5.19.0-rc3-arm64-renesas-00003-g57c83727d651 #50
 Hardware name: Renesas Ebisu board based on r8a77990 (DT)

Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
---

Hi Morimoto-san, I have never done any sound stuff with R-Car. Is this
the correct approach which I copied over from Salvator boards?

All the best,

   Wolfram

 arch/arm64/boot/dts/renesas/ebisu.dtsi | 26 +++++++++++++++++++++-----
 1 file changed, 21 insertions(+), 5 deletions(-)

diff --git a/arch/arm64/boot/dts/renesas/ebisu.dtsi b/arch/arm64/boot/dts/renesas/ebisu.dtsi
index 8fc03491a11c..cec23a3287c0 100644
--- a/arch/arm64/boot/dts/renesas/ebisu.dtsi
+++ b/arch/arm64/boot/dts/renesas/ebisu.dtsi
@@ -478,6 +478,12 @@ ak4613: codec@10 {
 		asahi-kasei,out4-single-end;
 		asahi-kasei,out5-single-end;
 		asahi-kasei,out6-single-end;
+
+		port {
+			ak4613_endpoint: endpoint {
+				remote-endpoint = <&rsnd_endpoint0>;
+			};
+		};
 	};
 
 	cs2000: clk-multiplier@4f {
@@ -708,13 +714,23 @@ &rcar_sound {
 		 <&audio_clk_a>, <&cs2000>, <&audio_clk_c>,
 		 <&cpg CPG_CORE R8A77990_CLK_ZA2>;
 
-	rcar_sound,dai {
-		dai0 {
-			playback = <&ssi0>, <&src0>, <&dvc0>;
-			capture = <&ssi1>, <&src1>, <&dvc1>;
+	ports {
+		#address-cells = <1>;
+		#size-cells = <0>;
+		rsnd_port0: port@0 {
+			reg = <0>;
+			rsnd_endpoint0: endpoint {
+				remote-endpoint = <&ak4613_endpoint>;
+
+				dai-format = "left_j";
+				bitclock-master = <&rsnd_endpoint0>;
+				frame-master = <&rsnd_endpoint0>;
+
+				playback = <&ssi0>, <&src0>, <&dvc0>;
+				capture = <&ssi1>, <&src1>, <&dvc1>;
+			};
 		};
 	};
-
 };
 
 &rpc {
-- 
2.35.1


^ permalink raw reply related	[flat|nested] 4+ messages in thread