[PATCH] LoongArch: efi: Simplify arch_efi_call_virt() macro by using typeof()

[PATCH] LoongArch: efi: Simplify arch_efi_call_virt() macro by using typeof()

[Sudeep Holla]

Currently, the arch_efi_call_virt() assumes all users of it will have
defined a type 'efi_##f##_t' to make use of it. It is unnecessarily
forcing the users to create a new typedef when __efi_rt_asm_wrapper()
actually expects void pointer.

Simplify the arch_efi_call_virt() macro by using typeof(p->f) which must
be a pointer as required by __efi_rt_asm_wrapper() and eliminate the
explicit need for efi_##f##_t type for every user of this macro.

This change is done to align with implementations on other similar
architectures.

Cc: Ard Biesheuvel <ardb@kernel.org>
Cc: Huacai Chen <chenhuacai@kernel.org>
Cc: WANG Xuerui <kernel@xen0n.name>
Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
---
 arch/loongarch/include/asm/efi.h | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

Hi,

Reference for this change [1] and in particular[2]

Regards,
Sudeep

[1] https://lore.kernel.org/r/20220628125346.693304-1-sudeep.holla@arm.com
[2] https://lore.kernel.org/r/20220628125346.693304-3-sudeep.holla@arm.com/

diff --git a/arch/loongarch/include/asm/efi.h b/arch/loongarch/include/asm/efi.h
index 0127d84d5e1d..b5f23b501196 100644
--- a/arch/loongarch/include/asm/efi.h
+++ b/arch/loongarch/include/asm/efi.h
@@ -19,8 +19,7 @@ void efifb_setup_from_dmi(struct screen_info *si, const char *opt);
 
 #define arch_efi_call_virt(p, f, args...)        \
 ({                                               \
-	efi_##f##_t * __f;                       \
-	__f = p->f;                              \
+	typeof(p->f) __f = p->f;                 \
 	__f(args);                               \
 })
 
-- 
2.37.0