* Re: [PATCH -next] net: pcs-rzn1-miic: fix return value check in miic_probe()
2022-06-28 12:08 [PATCH -next] net: pcs-rzn1-miic: fix return value check in miic_probe() Yang Yingliang
@ 2022-06-28 12:05 ` Clément Léger
0 siblings, 0 replies; 2+ messages in thread
From: Clément Léger @ 2022-06-28 12:05 UTC (permalink / raw)
To: Yang Yingliang
Cc: linux-kernel, netdev, linux-renesas-soc, olteanv, f.fainelli, davem
Le Tue, 28 Jun 2022 20:08:50 +0800,
Yang Yingliang <yangyingliang@huawei.com> a écrit :
> If devm_platform_ioremap_resource() fails, it never return
> NULL pointer, replace NULL test with IS_ERR().
Thanks for your patch, maybe this description would be better:
"On failure, devm_platform_ioremap_resource() returns a ERR_PTR() value
and not NULL. Fix return value checking by using IS_ERR() and
return PTR_ERR() as error value."
Clément
>
> Fixes: 7dc54d3b8d91 ("net: pcs: add Renesas MII converter driver")
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
> ---
> drivers/net/pcs/pcs-rzn1-miic.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/pcs/pcs-rzn1-miic.c b/drivers/net/pcs/pcs-rzn1-miic.c
> index 8f5e910f443d..d896961e48cc 100644
> --- a/drivers/net/pcs/pcs-rzn1-miic.c
> +++ b/drivers/net/pcs/pcs-rzn1-miic.c
> @@ -461,8 +461,8 @@ static int miic_probe(struct platform_device *pdev)
> spin_lock_init(&miic->lock);
> miic->dev = dev;
> miic->base = devm_platform_ioremap_resource(pdev, 0);
> - if (!miic->base)
> - return -EINVAL;
> + if (IS_ERR(miic->base))
> + return PTR_ERR(miic->base);
>
> ret = devm_pm_runtime_enable(dev);
> if (ret < 0)
--
Clément Léger,
Embedded Linux and Kernel engineer at Bootlin
https://bootlin.com
^ permalink raw reply [flat|nested] 2+ messages in thread
* [PATCH -next] net: pcs-rzn1-miic: fix return value check in miic_probe()
@ 2022-06-28 12:08 Yang Yingliang
2022-06-28 12:05 ` Clément Léger
0 siblings, 1 reply; 2+ messages in thread
From: Yang Yingliang @ 2022-06-28 12:08 UTC (permalink / raw)
To: linux-kernel, netdev, linux-renesas-soc
Cc: clement.leger, olteanv, f.fainelli, davem
If devm_platform_ioremap_resource() fails, it never return
NULL pointer, replace NULL test with IS_ERR().
Fixes: 7dc54d3b8d91 ("net: pcs: add Renesas MII converter driver")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
---
drivers/net/pcs/pcs-rzn1-miic.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/pcs/pcs-rzn1-miic.c b/drivers/net/pcs/pcs-rzn1-miic.c
index 8f5e910f443d..d896961e48cc 100644
--- a/drivers/net/pcs/pcs-rzn1-miic.c
+++ b/drivers/net/pcs/pcs-rzn1-miic.c
@@ -461,8 +461,8 @@ static int miic_probe(struct platform_device *pdev)
spin_lock_init(&miic->lock);
miic->dev = dev;
miic->base = devm_platform_ioremap_resource(pdev, 0);
- if (!miic->base)
- return -EINVAL;
+ if (IS_ERR(miic->base))
+ return PTR_ERR(miic->base);
ret = devm_pm_runtime_enable(dev);
if (ret < 0)
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-06-28 12:07 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-06-28 12:08 [PATCH -next] net: pcs-rzn1-miic: fix return value check in miic_probe() Yang Yingliang
2022-06-28 12:05 ` Clément Léger
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.