From: Colin Foster <colin.foster@in-advantage.com> To: Andy Shevchenko <andy.shevchenko@gmail.com> Cc: Vladimir Oltean <vladimir.oltean@nxp.com>, "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, "netdev@vger.kernel.org" <netdev@vger.kernel.org>, "linux-arm-kernel@lists.infradead.org" <linux-arm-kernel@lists.infradead.org>, "linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>, Lee Jones <lee.jones@linaro.org>, Rob Herring <robh+dt@kernel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Andrew Lunn <andrew@lunn.ch>, Heiner Kallweit <hkallweit1@gmail.com>, Russell King <linux@armlinux.org.uk>, "David S. Miller" <davem@davemloft.net>, Eric Dumazet <edumazet@google.com>, Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>, Lars Povlsen <lars.povlsen@microchip.com>, Steen Hegelund <Steen.Hegelund@microchip.com>, "UNGLinuxDriver@microchip.com" <UNGLinuxDriver@microchip.com>, Linus Walleij <linus.walleij@linaro.org>, Wolfram Sang <wsa@kernel.org>, Terry Bowman <terry.bowman@amd.com>, Alexandre Belloni <alexandre.belloni@bootlin.com>, Arnd Bergmann <arnd@kernel.org> Subject: Re: [PATCH v11 net-next 1/9] mfd: ocelot: add helper to get regmap from a resource Date: Tue, 28 Jun 2022 12:56:54 -0700 [thread overview] Message-ID: <20220628195654.GE855398@euler> (raw) In-Reply-To: <CAHp75Ve-MF=MafvwYbFvW330-GhZM9VKKUWmSVxUQ4r_8U1mJQ@mail.gmail.com> On Tue, Jun 28, 2022 at 09:04:21PM +0200, Andy Shevchenko wrote: > On Tue, Jun 28, 2022 at 8:56 PM Vladimir Oltean <vladimir.oltean@nxp.com> wrote: > > > > On Tue, Jun 28, 2022 at 09:46:59PM +0300, Vladimir Oltean wrote: > > > I searched for 5 minutes or so, and I noticed regmap_attach_dev() and > > > dev_get_regmap(), maybe those could be of help? > > > > ah, I see I haven't really brought anything of value to the table, > > dev_get_regmap() was discussed around v1 or so. I'll read the > > discussions again in a couple of hours to remember what was wrong with > > it such that you aren't using it anymore. > > It would be nice if you can comment after here to clarify that. > Because in another series (not related to this anyhow) somebody > insisted to use dev_get_regmap(). To add some info: The main issue at that time was "how do I get a spi regmap instead of an mmio regmap from the device". V1 was very early, and was before I knew about the pinctrl / mdio drivers that were to come, so that led to the existing MFD implementation. I came across the IORESOURCE_REG, which seems to be created for exactly this purpose. Seemingly I'm pretty unique though, since IORESOURCE_REG doesn't get used much compared to IORESOURCE_MEM. Though I'll revisit this again. The switch portion of this driver (no longer included in this patch set) is actually quite different from the rest of the MFD in how it allocates regmaps, and that might have been a major contributor at the time. So maybe I dismissed it at the time, but it actually makes sense for the MFD portion now. > > -- > With Best Regards, > Andy Shevchenko _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Colin Foster <colin.foster@in-advantage.com> To: Andy Shevchenko <andy.shevchenko@gmail.com> Cc: Vladimir Oltean <vladimir.oltean@nxp.com>, "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, "netdev@vger.kernel.org" <netdev@vger.kernel.org>, "linux-arm-kernel@lists.infradead.org" <linux-arm-kernel@lists.infradead.org>, "linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>, Lee Jones <lee.jones@linaro.org>, Rob Herring <robh+dt@kernel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Andrew Lunn <andrew@lunn.ch>, Heiner Kallweit <hkallweit1@gmail.com>, Russell King <linux@armlinux.org.uk>, "David S. Miller" <davem@davemloft.net>, Eric Dumazet <edumazet@google.com>, Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>, Lars Povlsen <lars.povlsen@microchip.com>, Steen Hegelund <Steen.Hegelund@microchip.com>, "UNGLinuxDriver@microchip.com" <UNGLinuxDriver@microchip.com>, Linus Walleij <linus.walleij@linaro.org>, Wolfram Sang <wsa@kernel.org>, Terry Bowman <terry.bowman@amd.com>, Alexandre Belloni <alexandre.belloni@bootlin.com>, Arnd Bergmann <arnd@kernel.org> Subject: Re: [PATCH v11 net-next 1/9] mfd: ocelot: add helper to get regmap from a resource Date: Tue, 28 Jun 2022 12:56:54 -0700 [thread overview] Message-ID: <20220628195654.GE855398@euler> (raw) In-Reply-To: <CAHp75Ve-MF=MafvwYbFvW330-GhZM9VKKUWmSVxUQ4r_8U1mJQ@mail.gmail.com> On Tue, Jun 28, 2022 at 09:04:21PM +0200, Andy Shevchenko wrote: > On Tue, Jun 28, 2022 at 8:56 PM Vladimir Oltean <vladimir.oltean@nxp.com> wrote: > > > > On Tue, Jun 28, 2022 at 09:46:59PM +0300, Vladimir Oltean wrote: > > > I searched for 5 minutes or so, and I noticed regmap_attach_dev() and > > > dev_get_regmap(), maybe those could be of help? > > > > ah, I see I haven't really brought anything of value to the table, > > dev_get_regmap() was discussed around v1 or so. I'll read the > > discussions again in a couple of hours to remember what was wrong with > > it such that you aren't using it anymore. > > It would be nice if you can comment after here to clarify that. > Because in another series (not related to this anyhow) somebody > insisted to use dev_get_regmap(). To add some info: The main issue at that time was "how do I get a spi regmap instead of an mmio regmap from the device". V1 was very early, and was before I knew about the pinctrl / mdio drivers that were to come, so that led to the existing MFD implementation. I came across the IORESOURCE_REG, which seems to be created for exactly this purpose. Seemingly I'm pretty unique though, since IORESOURCE_REG doesn't get used much compared to IORESOURCE_MEM. Though I'll revisit this again. The switch portion of this driver (no longer included in this patch set) is actually quite different from the rest of the MFD in how it allocates regmaps, and that might have been a major contributor at the time. So maybe I dismissed it at the time, but it actually makes sense for the MFD portion now. > > -- > With Best Regards, > Andy Shevchenko
next prev parent reply other threads:[~2022-06-28 19:58 UTC|newest] Thread overview: 82+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-06-28 8:17 [PATCH v11 net-next 0/9] add support for VSC7512 control over SPI Colin Foster 2022-06-28 8:17 ` Colin Foster 2022-06-28 8:17 ` [PATCH v11 net-next 1/9] mfd: ocelot: add helper to get regmap from a resource Colin Foster 2022-06-28 8:17 ` Colin Foster 2022-06-28 12:50 ` Andy Shevchenko 2022-06-28 12:50 ` Andy Shevchenko 2022-06-28 15:33 ` Vladimir Oltean 2022-06-28 15:33 ` Vladimir Oltean 2022-06-28 16:08 ` Vladimir Oltean 2022-06-28 16:08 ` Vladimir Oltean 2022-06-28 17:25 ` Colin Foster 2022-06-28 17:25 ` Colin Foster 2022-06-28 18:47 ` Vladimir Oltean 2022-06-28 18:47 ` Vladimir Oltean 2022-06-28 18:56 ` Vladimir Oltean 2022-06-28 18:56 ` Vladimir Oltean 2022-06-28 19:04 ` Andy Shevchenko 2022-06-28 19:04 ` Andy Shevchenko 2022-06-28 19:56 ` Colin Foster [this message] 2022-06-28 19:56 ` Colin Foster 2022-06-29 17:53 ` Vladimir Oltean 2022-06-29 17:53 ` Vladimir Oltean 2022-06-29 20:39 ` Colin Foster 2022-06-29 20:39 ` Colin Foster 2022-06-29 23:08 ` Vladimir Oltean 2022-06-29 23:08 ` Vladimir Oltean 2022-06-29 23:54 ` Colin Foster 2022-06-29 23:54 ` Colin Foster 2022-06-30 7:54 ` Lee Jones 2022-06-30 7:54 ` Lee Jones 2022-06-30 13:11 ` Vladimir Oltean 2022-06-30 13:11 ` Vladimir Oltean 2022-06-30 20:09 ` Colin Foster 2022-06-30 20:09 ` Colin Foster 2022-07-01 16:21 ` Vladimir Oltean 2022-07-01 16:21 ` Vladimir Oltean 2022-07-01 17:18 ` Colin Foster 2022-07-01 17:18 ` Colin Foster 2022-07-02 12:42 ` Vladimir Oltean 2022-07-02 12:42 ` Vladimir Oltean 2022-07-02 16:17 ` Colin Foster 2022-07-02 16:17 ` Colin Foster 2022-06-28 8:17 ` [PATCH v11 net-next 2/9] net: mdio: mscc-miim: add ability to be used in a non-mmio configuration Colin Foster 2022-06-28 8:17 ` Colin Foster 2022-06-28 16:26 ` Vladimir Oltean 2022-06-28 16:26 ` Vladimir Oltean 2022-06-28 18:31 ` Colin Foster 2022-06-28 18:31 ` Colin Foster 2022-06-28 8:17 ` [PATCH v11 net-next 3/9] pinctrl: ocelot: allow pinctrl-ocelot to be loaded as a module Colin Foster 2022-06-28 8:17 ` Colin Foster 2022-06-28 12:53 ` Andy Shevchenko 2022-06-28 12:53 ` Andy Shevchenko 2022-06-28 18:25 ` Colin Foster 2022-06-28 18:25 ` Colin Foster 2022-06-28 19:00 ` Andy Shevchenko 2022-06-28 19:00 ` Andy Shevchenko 2022-06-30 11:56 ` Linus Walleij 2022-06-30 11:56 ` Linus Walleij 2022-06-28 8:17 ` [PATCH v11 net-next 4/9] pinctrl: ocelot: add ability to be used in a non-mmio configuration Colin Foster 2022-06-28 8:17 ` Colin Foster 2022-06-28 8:17 ` [PATCH v11 net-next 5/9] pinctrl: microchip-sgpio: allow sgpio driver to be used as a module Colin Foster 2022-06-28 8:17 ` Colin Foster 2022-06-28 12:55 ` Andy Shevchenko 2022-06-28 12:55 ` Andy Shevchenko 2022-06-28 8:17 ` [PATCH v11 net-next 6/9] pinctrl: microchip-sgpio: add ability to be used in a non-mmio configuration Colin Foster 2022-06-28 8:17 ` Colin Foster 2022-06-28 8:17 ` [PATCH v11 net-next 7/9] resource: add define macro for register address resources Colin Foster 2022-06-28 8:17 ` Colin Foster 2022-06-28 8:17 ` [PATCH v11 net-next 8/9] dt-bindings: mfd: ocelot: add bindings for VSC7512 Colin Foster 2022-06-28 8:17 ` Colin Foster 2022-06-28 13:15 ` Rob Herring 2022-06-28 13:15 ` Rob Herring 2022-06-28 18:19 ` Colin Foster 2022-06-28 18:19 ` Colin Foster 2022-06-30 13:17 ` Vladimir Oltean 2022-06-30 13:17 ` Vladimir Oltean 2022-06-28 8:17 ` [PATCH v11 net-next 9/9] mfd: ocelot: add support for the vsc7512 chip via spi Colin Foster 2022-06-28 8:17 ` Colin Foster 2022-06-28 20:07 ` Randy Dunlap 2022-06-28 20:07 ` Randy Dunlap 2022-06-28 20:24 ` Colin Foster 2022-06-28 20:24 ` Colin Foster
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20220628195654.GE855398@euler \ --to=colin.foster@in-advantage.com \ --cc=Steen.Hegelund@microchip.com \ --cc=UNGLinuxDriver@microchip.com \ --cc=alexandre.belloni@bootlin.com \ --cc=andrew@lunn.ch \ --cc=andy.shevchenko@gmail.com \ --cc=arnd@kernel.org \ --cc=davem@davemloft.net \ --cc=devicetree@vger.kernel.org \ --cc=edumazet@google.com \ --cc=hkallweit1@gmail.com \ --cc=krzysztof.kozlowski+dt@linaro.org \ --cc=kuba@kernel.org \ --cc=lars.povlsen@microchip.com \ --cc=lee.jones@linaro.org \ --cc=linus.walleij@linaro.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-gpio@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux@armlinux.org.uk \ --cc=netdev@vger.kernel.org \ --cc=pabeni@redhat.com \ --cc=robh+dt@kernel.org \ --cc=terry.bowman@amd.com \ --cc=vladimir.oltean@nxp.com \ --cc=wsa@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.