All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] dec/tulip:fix repeated words in comments
@ 2022-06-29  9:54 Jilin Yuan
  2022-06-30  6:22 ` Helge Deller
  0 siblings, 1 reply; 2+ messages in thread
From: Jilin Yuan @ 2022-06-29  9:54 UTC (permalink / raw)
  To: edumazet, kuba, pabeni; +Cc: netdev, linux-parisc, linux-kernel, Jilin Yuan

Delete the redundant word 'this'.

Signed-off-by: Jilin Yuan <yuanjilin@cdjrlc.com>
---
 drivers/net/ethernet/dec/tulip/xircom_cb.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/ethernet/dec/tulip/xircom_cb.c b/drivers/net/ethernet/dec/tulip/xircom_cb.c
index 8759f9f76b62..61825c9bd6be 100644
--- a/drivers/net/ethernet/dec/tulip/xircom_cb.c
+++ b/drivers/net/ethernet/dec/tulip/xircom_cb.c
@@ -742,7 +742,7 @@ static void activate_receiver(struct xircom_private *card)
 
 /*
 deactivate_receiver disables the receiver on the card.
-To achieve this this code disables the receiver first;
+To achieve this code disables the receiver first;
 then it waits for the receiver to become inactive.
 
 must be called with the lock held and interrupts disabled.
@@ -829,7 +829,7 @@ static void activate_transmitter(struct xircom_private *card)
 
 /*
 deactivate_transmitter disables the transmitter on the card.
-To achieve this this code disables the transmitter first;
+To achieve this code disables the transmitter first;
 then it waits for the transmitter to become inactive.
 
 must be called with the lock held and interrupts disabled.
-- 
2.36.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] dec/tulip:fix repeated words in comments
  2022-06-29  9:54 [PATCH] dec/tulip:fix repeated words in comments Jilin Yuan
@ 2022-06-30  6:22 ` Helge Deller
  0 siblings, 0 replies; 2+ messages in thread
From: Helge Deller @ 2022-06-30  6:22 UTC (permalink / raw)
  To: Jilin Yuan, edumazet, kuba, pabeni; +Cc: netdev, linux-parisc, linux-kernel

On 6/29/22 11:54, Jilin Yuan wrote:
> Delete the redundant word 'this'.
>
> Signed-off-by: Jilin Yuan <yuanjilin@cdjrlc.com>
> ---
>  drivers/net/ethernet/dec/tulip/xircom_cb.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/ethernet/dec/tulip/xircom_cb.c b/drivers/net/ethernet/dec/tulip/xircom_cb.c
> index 8759f9f76b62..61825c9bd6be 100644
> --- a/drivers/net/ethernet/dec/tulip/xircom_cb.c
> +++ b/drivers/net/ethernet/dec/tulip/xircom_cb.c
> @@ -742,7 +742,7 @@ static void activate_receiver(struct xircom_private *card)
>
>  /*
>  deactivate_receiver disables the receiver on the card.
> -To achieve this this code disables the receiver first;
> +To achieve this code disables the receiver first;

No.
Instead it should be something like:
To achieve this, this code disables the receiver first; ...

but better look at the whole comment including the next line,
in which case it could become:

Disable the receiver first, then wait for it to become inactive.

...

>  then it waits for the receiver to become inactive.
>
>  must be called with the lock held and interrupts disabled.
> @@ -829,7 +829,7 @@ static void activate_transmitter(struct xircom_private *card)
>
>  /*
>  deactivate_transmitter disables the transmitter on the card.
> -To achieve this this code disables the transmitter first;
> +To achieve this code disables the transmitter first;
>  then it waits for the transmitter to become inactive.

same here...


>
>  must be called with the lock held and interrupts disabled.


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2022-06-30  6:23 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-06-29  9:54 [PATCH] dec/tulip:fix repeated words in comments Jilin Yuan
2022-06-30  6:22 ` Helge Deller

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.