* [PATCH] arm64: dts: juno: Add cache-level property to L2 caches
@ 2022-06-29 9:59 Sudeep Holla
2022-06-29 10:19 ` Liviu Dudau
2022-06-29 10:53 ` Sudeep Holla
0 siblings, 2 replies; 3+ messages in thread
From: Sudeep Holla @ 2022-06-29 9:59 UTC (permalink / raw)
To: linux-arm-kernel; +Cc: Sudeep Holla, Liviu Dudau, Lorenzo Pieralisi
Add the missing cache-level property to L2 caches. This is needed if
we need to find the last level cache directly from the device tree cache
node.
Cc: Liviu Dudau <liviu.dudau@arm.com>
Cc: Lorenzo Pieralisi <lpieralisi@kernel.org>
Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
---
arch/arm64/boot/dts/arm/juno-r1.dts | 2 ++
arch/arm64/boot/dts/arm/juno-r2.dts | 2 ++
arch/arm64/boot/dts/arm/juno.dts | 2 ++
3 files changed, 6 insertions(+)
Hi,
I found out that of_find_last_cache_level() was returning 0 for L2 cache
on juno when I was attempting to use of_find_last_cache_level() during the
rework of my {arch,cache_topology} series[1], although I ended up not
using that function at the end.
Regards,
Sudeep
[1] https://lore.kernel.org/all/20220627165047.336669-1-sudeep.holla@arm.com/
diff --git a/arch/arm64/boot/dts/arm/juno-r1.dts b/arch/arm64/boot/dts/arm/juno-r1.dts
index f099fb611d4e..6451c62146fd 100644
--- a/arch/arm64/boot/dts/arm/juno-r1.dts
+++ b/arch/arm64/boot/dts/arm/juno-r1.dts
@@ -192,6 +192,7 @@ A57_L2: l2-cache0 {
cache-size = <0x200000>;
cache-line-size = <64>;
cache-sets = <2048>;
+ cache-level = <2>;
};
A53_L2: l2-cache1 {
@@ -199,6 +200,7 @@ A53_L2: l2-cache1 {
cache-size = <0x100000>;
cache-line-size = <64>;
cache-sets = <1024>;
+ cache-level = <2>;
};
};
diff --git a/arch/arm64/boot/dts/arm/juno-r2.dts b/arch/arm64/boot/dts/arm/juno-r2.dts
index 709389582ae3..438cd1ff4bd0 100644
--- a/arch/arm64/boot/dts/arm/juno-r2.dts
+++ b/arch/arm64/boot/dts/arm/juno-r2.dts
@@ -198,6 +198,7 @@ A72_L2: l2-cache0 {
cache-size = <0x200000>;
cache-line-size = <64>;
cache-sets = <2048>;
+ cache-level = <2>;
};
A53_L2: l2-cache1 {
@@ -205,6 +206,7 @@ A53_L2: l2-cache1 {
cache-size = <0x100000>;
cache-line-size = <64>;
cache-sets = <1024>;
+ cache-level = <2>;
};
};
diff --git a/arch/arm64/boot/dts/arm/juno.dts b/arch/arm64/boot/dts/arm/juno.dts
index dbc22e70b62c..cf4a58211399 100644
--- a/arch/arm64/boot/dts/arm/juno.dts
+++ b/arch/arm64/boot/dts/arm/juno.dts
@@ -197,6 +197,7 @@ A57_L2: l2-cache0 {
cache-size = <0x200000>;
cache-line-size = <64>;
cache-sets = <2048>;
+ cache-level = <2>;
};
A53_L2: l2-cache1 {
@@ -204,6 +205,7 @@ A53_L2: l2-cache1 {
cache-size = <0x100000>;
cache-line-size = <64>;
cache-sets = <1024>;
+ cache-level = <2>;
};
};
--
2.37.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] arm64: dts: juno: Add cache-level property to L2 caches
2022-06-29 9:59 [PATCH] arm64: dts: juno: Add cache-level property to L2 caches Sudeep Holla
@ 2022-06-29 10:19 ` Liviu Dudau
2022-06-29 10:53 ` Sudeep Holla
1 sibling, 0 replies; 3+ messages in thread
From: Liviu Dudau @ 2022-06-29 10:19 UTC (permalink / raw)
To: Sudeep Holla; +Cc: linux-arm-kernel, Lorenzo Pieralisi
On Wed, Jun 29, 2022 at 10:59:59AM +0100, Sudeep Holla wrote:
> Add the missing cache-level property to L2 caches. This is needed if
> we need to find the last level cache directly from the device tree cache
> node.
>
> Cc: Liviu Dudau <liviu.dudau@arm.com>
> Cc: Lorenzo Pieralisi <lpieralisi@kernel.org>
> Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
Acked-by: Liviu Dudau <liviu.dudau@arm.com>
Thanks for the useful addition!
Best regards,
Liviu
> ---
> arch/arm64/boot/dts/arm/juno-r1.dts | 2 ++
> arch/arm64/boot/dts/arm/juno-r2.dts | 2 ++
> arch/arm64/boot/dts/arm/juno.dts | 2 ++
> 3 files changed, 6 insertions(+)
>
> Hi,
>
> I found out that of_find_last_cache_level() was returning 0 for L2 cache
> on juno when I was attempting to use of_find_last_cache_level() during the
> rework of my {arch,cache_topology} series[1], although I ended up not
> using that function at the end.
>
> Regards,
> Sudeep
>
> [1] https://lore.kernel.org/all/20220627165047.336669-1-sudeep.holla@arm.com/
>
> diff --git a/arch/arm64/boot/dts/arm/juno-r1.dts b/arch/arm64/boot/dts/arm/juno-r1.dts
> index f099fb611d4e..6451c62146fd 100644
> --- a/arch/arm64/boot/dts/arm/juno-r1.dts
> +++ b/arch/arm64/boot/dts/arm/juno-r1.dts
> @@ -192,6 +192,7 @@ A57_L2: l2-cache0 {
> cache-size = <0x200000>;
> cache-line-size = <64>;
> cache-sets = <2048>;
> + cache-level = <2>;
> };
>
> A53_L2: l2-cache1 {
> @@ -199,6 +200,7 @@ A53_L2: l2-cache1 {
> cache-size = <0x100000>;
> cache-line-size = <64>;
> cache-sets = <1024>;
> + cache-level = <2>;
> };
> };
>
> diff --git a/arch/arm64/boot/dts/arm/juno-r2.dts b/arch/arm64/boot/dts/arm/juno-r2.dts
> index 709389582ae3..438cd1ff4bd0 100644
> --- a/arch/arm64/boot/dts/arm/juno-r2.dts
> +++ b/arch/arm64/boot/dts/arm/juno-r2.dts
> @@ -198,6 +198,7 @@ A72_L2: l2-cache0 {
> cache-size = <0x200000>;
> cache-line-size = <64>;
> cache-sets = <2048>;
> + cache-level = <2>;
> };
>
> A53_L2: l2-cache1 {
> @@ -205,6 +206,7 @@ A53_L2: l2-cache1 {
> cache-size = <0x100000>;
> cache-line-size = <64>;
> cache-sets = <1024>;
> + cache-level = <2>;
> };
> };
>
> diff --git a/arch/arm64/boot/dts/arm/juno.dts b/arch/arm64/boot/dts/arm/juno.dts
> index dbc22e70b62c..cf4a58211399 100644
> --- a/arch/arm64/boot/dts/arm/juno.dts
> +++ b/arch/arm64/boot/dts/arm/juno.dts
> @@ -197,6 +197,7 @@ A57_L2: l2-cache0 {
> cache-size = <0x200000>;
> cache-line-size = <64>;
> cache-sets = <2048>;
> + cache-level = <2>;
> };
>
> A53_L2: l2-cache1 {
> @@ -204,6 +205,7 @@ A53_L2: l2-cache1 {
> cache-size = <0x100000>;
> cache-line-size = <64>;
> cache-sets = <1024>;
> + cache-level = <2>;
> };
> };
>
> --
> 2.37.0
>
--
====================
| I would like to |
| fix the world, |
| but they're not |
| giving me the |
\ source code! /
---------------
¯\_(ツ)_/¯
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] arm64: dts: juno: Add cache-level property to L2 caches
2022-06-29 9:59 [PATCH] arm64: dts: juno: Add cache-level property to L2 caches Sudeep Holla
2022-06-29 10:19 ` Liviu Dudau
@ 2022-06-29 10:53 ` Sudeep Holla
1 sibling, 0 replies; 3+ messages in thread
From: Sudeep Holla @ 2022-06-29 10:53 UTC (permalink / raw)
To: Sudeep Holla, linux-arm-kernel; +Cc: Liviu Dudau, Lorenzo Pieralisi
On Wed, 29 Jun 2022 10:59:59 +0100, Sudeep Holla wrote:
> Add the missing cache-level property to L2 caches. This is needed if
> we need to find the last level cache directly from the device tree cache
> node.
>
Applied to sudeep.holla/linux (for-next/juno), thanks!
[1/1] arm64: dts: juno: Add cache-level property to L2 caches
https://git.kernel.org/sudeep.holla/c/156c90415b
--
Regards,
Sudeep
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-06-29 11:18 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-06-29 9:59 [PATCH] arm64: dts: juno: Add cache-level property to L2 caches Sudeep Holla
2022-06-29 10:19 ` Liviu Dudau
2022-06-29 10:53 ` Sudeep Holla
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.