[PATCH] netfilter: in nf_nat_initialized(), use const struct nf_conn *

[PATCH] netfilter: in nf_nat_initialized(), use const struct nf_conn *

[James Yonan]

nf_nat_initialized() doesn't modify passed struct nf_conn,
so declare as const.

This is helpful for code readability and makes it possible
to call nf_nat_initialized() with a const struct nf_conn *.

Signed-off-by: James Yonan <james@openvpn.net>
---
 include/net/netfilter/nf_nat.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/net/netfilter/nf_nat.h b/include/net/netfilter/nf_nat.h
index 987111ae5240..e9eb01e99d2f 100644
--- a/include/net/netfilter/nf_nat.h
+++ b/include/net/netfilter/nf_nat.h
@@ -104,7 +104,7 @@ unsigned int
 nf_nat_inet_fn(void *priv, struct sk_buff *skb,
 	       const struct nf_hook_state *state);
 
-static inline int nf_nat_initialized(struct nf_conn *ct,
+static inline int nf_nat_initialized(const struct nf_conn *ct,
 				     enum nf_nat_manip_type manip)
 {
 	if (manip == NF_NAT_MANIP_SRC)
-- 
2.25.1

Re: [PATCH] netfilter: in nf_nat_initialized(), use const struct nf_conn *

[Pablo Neira Ayuso]

On Wed, Jun 29, 2022 at 01:22:10PM -0600, James Yonan wrote:
> nf_nat_initialized() doesn't modify passed struct nf_conn,
> so declare as const.
> 
> This is helpful for code readability and makes it possible
> to call nf_nat_initialized() with a const struct nf_conn *.

Applied, thanks