From: Guillaume Nault <gnault@redhat.com>
To: Marcin Szycik <marcin.szycik@linux.intel.com>
Cc: netdev@vger.kernel.org, anthony.l.nguyen@intel.com,
davem@davemloft.net, xiyou.wangcong@gmail.com,
jesse.brandeburg@intel.com, gustavoars@kernel.org,
baowen.zheng@corigine.com, boris.sukholitko@broadcom.com,
edumazet@google.com, kuba@kernel.org, jhs@mojatatu.com,
jiri@resnulli.us, kurt@linutronix.de, pablo@netfilter.org,
pabeni@redhat.com, paulb@nvidia.com, simon.horman@corigine.com,
komachi.yoshiki@gmail.com, zhangkaiheb@126.com,
intel-wired-lan@lists.osuosl.org,
michal.swiatkowski@linux.intel.com, wojciech.drewek@intel.com,
alexandr.lobakin@intel.com, mostrows@earthlink.net,
paulus@samba.org
Subject: Re: [RFC PATCH net-next v3 4/4] ice: Add support for PPPoE hardware offload
Date: Fri, 1 Jul 2022 01:12:44 +0200 [thread overview]
Message-ID: <20220630231244.GC392@debian.home> (raw)
In-Reply-To: <20220629143859.209028-5-marcin.szycik@linux.intel.com>
On Wed, Jun 29, 2022 at 04:38:59PM +0200, Marcin Szycik wrote:
> Add support for creating PPPoE filters in switchdev mode. Add support
> for parsing PPPoE and PPP-specific tc options: pppoe_sid and ppp_proto.
>
> Example filter:
> tc filter add dev $PF1 ingress protocol ppp_ses prio 1 flower pppoe_sid \
> 1234 ppp_proto ip skip_sw action mirred egress redirect dev $VF1_PR
>
> Changes in iproute2 are required to use the new fields.
>
> ICE COMMS DDP package is required to create a filter as it contains PPPoE
> profiles. Added a warning message when loaded DDP package does not contain
> required profiles.
>
> Note: currently matching on vlan + PPPoE fields is not supported. Patch [0]
> will add this feature.
>
> [0] https://patchwork.ozlabs.org/project/intel-wired-lan/patch/20220420210048.5809-1-martyna.szapar-mudlaw@intel.com
Out of curiosity, can ice direct PPPoE Session packets to different
queues with RSS (based on the session ID)?
WARNING: multiple messages have this Message-ID (diff)
From: Guillaume Nault <gnault@redhat.com>
To: Marcin Szycik <marcin.szycik@linux.intel.com>
Cc: simon.horman@corigine.com, kurt@linutronix.de, paulb@nvidia.com,
edumazet@google.com, boris.sukholitko@broadcom.com,
jiri@resnulli.us, paulus@samba.org, jesse.brandeburg@intel.com,
intel-wired-lan@lists.osuosl.org, kuba@kernel.org,
zhangkaiheb@126.com, pablo@netfilter.org,
baowen.zheng@corigine.com, komachi.yoshiki@gmail.com,
jhs@mojatatu.com, mostrows@earthlink.net,
xiyou.wangcong@gmail.com, pabeni@redhat.com,
netdev@vger.kernel.org, gustavoars@kernel.org,
davem@davemloft.net
Subject: Re: [Intel-wired-lan] [RFC PATCH net-next v3 4/4] ice: Add support for PPPoE hardware offload
Date: Fri, 1 Jul 2022 01:12:44 +0200 [thread overview]
Message-ID: <20220630231244.GC392@debian.home> (raw)
In-Reply-To: <20220629143859.209028-5-marcin.szycik@linux.intel.com>
On Wed, Jun 29, 2022 at 04:38:59PM +0200, Marcin Szycik wrote:
> Add support for creating PPPoE filters in switchdev mode. Add support
> for parsing PPPoE and PPP-specific tc options: pppoe_sid and ppp_proto.
>
> Example filter:
> tc filter add dev $PF1 ingress protocol ppp_ses prio 1 flower pppoe_sid \
> 1234 ppp_proto ip skip_sw action mirred egress redirect dev $VF1_PR
>
> Changes in iproute2 are required to use the new fields.
>
> ICE COMMS DDP package is required to create a filter as it contains PPPoE
> profiles. Added a warning message when loaded DDP package does not contain
> required profiles.
>
> Note: currently matching on vlan + PPPoE fields is not supported. Patch [0]
> will add this feature.
>
> [0] https://patchwork.ozlabs.org/project/intel-wired-lan/patch/20220420210048.5809-1-martyna.szapar-mudlaw@intel.com
Out of curiosity, can ice direct PPPoE Session packets to different
queues with RSS (based on the session ID)?
_______________________________________________
Intel-wired-lan mailing list
Intel-wired-lan@osuosl.org
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan
next prev parent reply other threads:[~2022-06-30 23:13 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-29 14:38 [RFC PATCH net-next v3 0/4] ice: PPPoE offload support Marcin Szycik
2022-06-29 14:38 ` [Intel-wired-lan] " Marcin Szycik
2022-06-29 14:38 ` [RFC PATCH net-next v3 1/4] flow_dissector: Add PPPoE dissectors Marcin Szycik
2022-06-29 14:38 ` [Intel-wired-lan] " Marcin Szycik
2022-06-30 23:10 ` Guillaume Nault
2022-06-30 23:10 ` [Intel-wired-lan] " Guillaume Nault
2022-07-01 10:53 ` Drewek, Wojciech
2022-07-01 10:53 ` [Intel-wired-lan] " Drewek, Wojciech
2022-07-01 12:41 ` Guillaume Nault
2022-07-01 12:41 ` [Intel-wired-lan] " Guillaume Nault
2022-07-01 13:33 ` Drewek, Wojciech
2022-07-01 13:33 ` [Intel-wired-lan] " Drewek, Wojciech
2022-06-29 14:38 ` [RFC PATCH net-next v3 2/4] net/sched: flower: Add PPPoE filter Marcin Szycik
2022-06-29 14:38 ` [Intel-wired-lan] " Marcin Szycik
2022-06-30 23:11 ` Guillaume Nault
2022-06-30 23:11 ` [Intel-wired-lan] " Guillaume Nault
2022-06-29 14:38 ` [RFC PATCH net-next v3 3/4] flow_offload: Introduce flow_match_pppoe Marcin Szycik
2022-06-29 14:38 ` [Intel-wired-lan] " Marcin Szycik
2022-06-29 14:38 ` [RFC PATCH net-next v3 4/4] ice: Add support for PPPoE hardware offload Marcin Szycik
2022-06-29 14:38 ` [Intel-wired-lan] " Marcin Szycik
2022-06-30 23:12 ` Guillaume Nault [this message]
2022-06-30 23:12 ` Guillaume Nault
2022-07-01 16:12 ` Marcin Szycik
2022-07-01 16:12 ` [Intel-wired-lan] " Marcin Szycik
2022-07-05 9:54 ` Marcin Szycik
2022-07-05 9:54 ` Marcin Szycik
2022-07-07 14:14 ` Guillaume Nault
2022-07-07 14:14 ` [Intel-wired-lan] " Guillaume Nault
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220630231244.GC392@debian.home \
--to=gnault@redhat.com \
--cc=alexandr.lobakin@intel.com \
--cc=anthony.l.nguyen@intel.com \
--cc=baowen.zheng@corigine.com \
--cc=boris.sukholitko@broadcom.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=gustavoars@kernel.org \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jesse.brandeburg@intel.com \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=komachi.yoshiki@gmail.com \
--cc=kuba@kernel.org \
--cc=kurt@linutronix.de \
--cc=marcin.szycik@linux.intel.com \
--cc=michal.swiatkowski@linux.intel.com \
--cc=mostrows@earthlink.net \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pablo@netfilter.org \
--cc=paulb@nvidia.com \
--cc=paulus@samba.org \
--cc=simon.horman@corigine.com \
--cc=wojciech.drewek@intel.com \
--cc=xiyou.wangcong@gmail.com \
--cc=zhangkaiheb@126.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.