[PATCH] net: usb: Fix typo in code

[PATCH] net: usb: Fix typo in code

[Li kunyu]

hasdata does not need to be initialized to zero. It will be assigned a
value in the following judgment conditions.
Remove the repeated ';' from code.

Signed-off-by: Li kunyu <kunyu@nfschina.com>
---
 drivers/net/usb/catc.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/net/usb/catc.c b/drivers/net/usb/catc.c
index e7fe9c0f63a9..268c32521691 100644
--- a/drivers/net/usb/catc.c
+++ b/drivers/net/usb/catc.c
@@ -280,7 +280,7 @@ static void catc_irq_done(struct urb *urb)
 	struct catc *catc = urb->context;
 	u8 *data = urb->transfer_buffer;
 	int status = urb->status;
-	unsigned int hasdata = 0, linksts = LinkNoChange;
+	unsigned int hasdata, linksts = LinkNoChange;
 	int res;
 
 	if (!catc->is_f5u011) {
@@ -335,7 +335,7 @@ static void catc_irq_done(struct urb *urb)
 		} 
 	}
 resubmit:
-	res = usb_submit_urb (urb, GFP_ATOMIC);
+	res = usb_submit_urb(urb, GFP_ATOMIC);
 	if (res)
 		dev_err(&catc->usbdev->dev,
 			"can't resubmit intr, %s-%s, status %d\n",
@@ -781,7 +781,7 @@ static int catc_probe(struct usb_interface *intf, const struct usb_device_id *id
 			intf->altsetting->desc.bInterfaceNumber, 1)) {
 		dev_err(dev, "Can't set altsetting 1.\n");
 		ret = -EIO;
-		goto fail_mem;;
+		goto fail_mem;
 	}
 
 	netdev = alloc_etherdev(sizeof(struct catc));
-- 
2.18.2

Re: [PATCH] net: usb: Fix typo in code

[Greg KH]

On Fri, Jul 01, 2022 at 10:07:51AM +0800, Li kunyu wrote:
> hasdata does not need to be initialized to zero. It will be assigned a
> value in the following judgment conditions.
> Remove the repeated ';' from code.

That is a lot of different things all in the same commit.  Please break
this up into one-change-per-commit like is required.

You also do something in here that you do not document :(

thanks,

greg k-h

[PATCH v2] net: usb: Fix typo in code

[Li kunyu]

Remove the repeated ';' from code.

Signed-off-by: Li kunyu <kunyu@nfschina.com>
---
 drivers/net/usb/catc.c | 2 +-
 1 file changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/net/usb/catc.c b/drivers/net/usb/catc.c
index e7fe9c0f63a9..268c32521691 100644
--- a/drivers/net/usb/catc.c
+++ b/drivers/net/usb/catc.c
@@ -781,7 +781,7 @@ static int catc_probe(struct usb_interface *intf, const struct usb_device_id *id
 			intf->altsetting->desc.bInterfaceNumber, 1)) {
 		dev_err(dev, "Can't set altsetting 1.\n");
 		ret = -EIO;
-		goto fail_mem;;
+		goto fail_mem;
 	}
 
 	netdev = alloc_etherdev(sizeof(struct catc));
-- 
2.18.2

Re: [PATCH v2] net: usb: Fix typo in code

[Greg KH]

On Fri, Jul 01, 2022 at 02:47:23PM +0800, Li kunyu wrote:
> Remove the repeated ';' from code.
> 
> Signed-off-by: Li kunyu <kunyu@nfschina.com>
> ---
>  drivers/net/usb/catc.c | 2 +-
>  1 file changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/net/usb/catc.c b/drivers/net/usb/catc.c
> index e7fe9c0f63a9..268c32521691 100644
> --- a/drivers/net/usb/catc.c
> +++ b/drivers/net/usb/catc.c
> @@ -781,7 +781,7 @@ static int catc_probe(struct usb_interface *intf, const struct usb_device_id *id
>  			intf->altsetting->desc.bInterfaceNumber, 1)) {
>  		dev_err(dev, "Can't set altsetting 1.\n");
>  		ret = -EIO;
> -		goto fail_mem;;
> +		goto fail_mem;
>  	}
>  
>  	netdev = alloc_etherdev(sizeof(struct catc));
> -- 
> 2.18.2
> 

Hi,

This is the friendly patch-bot of Greg Kroah-Hartman.  You have sent him
a patch that has triggered this response.  He used to manually respond
to these common problems, but in order to save his sanity (he kept
writing the same thing over and over, yet to different people), I was
created.  Hopefully you will not take offence and will fix the problem
in your patch and resubmit it so that it can be accepted into the Linux
kernel tree.

You are receiving this message because of the following common error(s)
as indicated below:

- You did not specify a description of why the patch is needed, or
  possibly, any description at all, in the email body.  Please read the
  section entitled "The canonical patch format" in the kernel file,
  Documentation/SubmittingPatches for what is needed in order to
  properly describe the change.

- You did not write a descriptive Subject: for the patch, allowing Greg,
  and everyone else, to know what this patch is all about.  Please read
  the section entitled "The canonical patch format" in the kernel file,
  Documentation/SubmittingPatches for what a proper Subject: line should
  look like.

- This looks like a new version of a previously submitted patch, but you
  did not list below the --- line any changes from the previous version.
  Please read the section entitled "The canonical patch format" in the
  kernel file, Documentation/SubmittingPatches for what needs to be done
  here to properly describe this.

If you wish to discuss this problem further, or you have questions about
how to resolve this issue, please feel free to respond to this email and
Greg will reply once he has dug out from the pending patches received
from other developers.

thanks,

greg k-h's patch email bot

Re: [PATCH v2] net: usb: Fix typo in code

[patchwork-bot+netdevbpf]

Hello:

This patch was applied to netdev/net.git (master)
by David S. Miller <davem@davemloft.net>:

On Fri,  1 Jul 2022 14:47:23 +0800 you wrote:
> Remove the repeated ';' from code.
> 
> Signed-off-by: Li kunyu <kunyu@nfschina.com>
> ---
>  drivers/net/usb/catc.c | 2 +-
>  1 file changed, 1 insertions(+), 1 deletions(-)

Here is the summary with links:
  - [v2] net: usb: Fix typo in code
    https://git.kernel.org/netdev/net/c/8dfeee9dc52c

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html