From: Christoph Hellwig <hch@lst.de>
To: Logan Gunthorpe <logang@deltatee.com>
Cc: "Christoph Hellwig" <hch@lst.de>,
"Jason Gunthorpe" <jgg@ziepe.ca>,
linux-kernel@vger.kernel.org, linux-nvme@lists.infradead.org,
linux-block@vger.kernel.org, linux-pci@vger.kernel.org,
linux-mm@kvack.org, iommu@lists.linux-foundation.org,
"Stephen Bates" <sbates@raithlin.com>,
"Dan Williams" <dan.j.williams@intel.com>,
"Christian König" <christian.koenig@amd.com>,
"John Hubbard" <jhubbard@nvidia.com>,
"Don Dutile" <ddutile@redhat.com>,
"Matthew Wilcox" <willy@infradead.org>,
"Daniel Vetter" <daniel.vetter@ffwll.ch>,
"Minturn Dave B" <dave.b.minturn@intel.com>,
"Jason Ekstrand" <jason@jlekstrand.net>,
"Dave Hansen" <dave.hansen@linux.intel.com>,
"Xiong Jianxin" <jianxin.xiong@intel.com>,
"Bjorn Helgaas" <helgaas@kernel.org>,
"Ira Weiny" <ira.weiny@intel.com>,
"Robin Murphy" <robin.murphy@arm.com>,
"Martin Oliveira" <martin.oliveira@eideticom.com>,
"Chaitanya Kulkarni" <ckulkarnilinux@gmail.com>,
"Ralph Campbell" <rcampbell@nvidia.com>,
"Bjorn Helgaas" <bhelgaas@google.com>
Subject: Re: [PATCH v7 20/21] PCI/P2PDMA: Introduce pci_mmap_p2pmem()
Date: Tue, 5 Jul 2022 18:43:15 +0200 [thread overview]
Message-ID: <20220705164315.GB14484@lst.de> (raw)
In-Reply-To: <a509b13c-244b-23fc-f989-339750a733a5@deltatee.com>
On Tue, Jul 05, 2022 at 10:41:52AM -0600, Logan Gunthorpe wrote:
> Using sysfs means we don't need all the messy callbacks from the nvme
> driver, which is a plus. But I'm not sure how we'd get or unmap the
> mapping of a sysfs file or avoid the anonymous inode. Seems with the
> existing PCI resources, it uses an bin_attribute->f_mapping() callback
> to pass back the iomem_get_mapping() mapping on file open.
> revoke_iomem() is then used to nuke the VMAs. I don't think we can use
> the same infrastructure here as that would add a dependency on
> CONFIG_IO_STRICT_DEVMEM; which would be odd. And I'm not sure whether
> there is a better way.
Why can't we do the revoke on the actual sysfs inode?
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@lst.de>
To: Logan Gunthorpe <logang@deltatee.com>
Cc: linux-pci@vger.kernel.org,
"Dave Hansen" <dave.hansen@linux.intel.com>,
linux-nvme@lists.infradead.org,
"Stephen Bates" <sbates@raithlin.com>,
linux-mm@kvack.org, "Jason Ekstrand" <jason@jlekstrand.net>,
"Ira Weiny" <ira.weiny@intel.com>,
"Christoph Hellwig" <hch@lst.de>,
"Minturn Dave B" <dave.b.minturn@intel.com>,
"Martin Oliveira" <martin.oliveira@eideticom.com>,
"Matthew Wilcox" <willy@infradead.org>,
"Jason Gunthorpe" <jgg@ziepe.ca>,
"Chaitanya Kulkarni" <ckulkarnilinux@gmail.com>,
"Bjorn Helgaas" <helgaas@kernel.org>,
"Daniel Vetter" <daniel.vetter@ffwll.ch>,
"Ralph Campbell" <rcampbell@nvidia.com>,
"John Hubbard" <jhubbard@nvidia.com>,
linux-block@vger.kernel.org,
"Bjorn Helgaas" <bhelgaas@google.com>,
"Dan Williams" <dan.j.williams@intel.com>,
"Xiong Jianxin" <jianxin.xiong@intel.com>,
linux-kernel@vger.kernel.org, iommu@lists.linux-foundation.org,
"Robin Murphy" <robin.murphy@arm.com>,
"Christian König" <christian.koenig@amd.com>
Subject: Re: [PATCH v7 20/21] PCI/P2PDMA: Introduce pci_mmap_p2pmem()
Date: Tue, 5 Jul 2022 18:43:15 +0200 [thread overview]
Message-ID: <20220705164315.GB14484@lst.de> (raw)
In-Reply-To: <a509b13c-244b-23fc-f989-339750a733a5@deltatee.com>
On Tue, Jul 05, 2022 at 10:41:52AM -0600, Logan Gunthorpe wrote:
> Using sysfs means we don't need all the messy callbacks from the nvme
> driver, which is a plus. But I'm not sure how we'd get or unmap the
> mapping of a sysfs file or avoid the anonymous inode. Seems with the
> existing PCI resources, it uses an bin_attribute->f_mapping() callback
> to pass back the iomem_get_mapping() mapping on file open.
> revoke_iomem() is then used to nuke the VMAs. I don't think we can use
> the same infrastructure here as that would add a dependency on
> CONFIG_IO_STRICT_DEVMEM; which would be odd. And I'm not sure whether
> there is a better way.
Why can't we do the revoke on the actual sysfs inode?
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
next prev parent reply other threads:[~2022-07-05 16:43 UTC|newest]
Thread overview: 141+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-15 16:12 [PATCH v7 00/21] Userspace P2PDMA with O_DIRECT NVMe devices Logan Gunthorpe
2022-06-15 16:12 ` Logan Gunthorpe
2022-06-15 16:12 ` [PATCH v7 01/21] lib/scatterlist: add flag for indicating P2PDMA segments in an SGL Logan Gunthorpe
2022-06-15 16:12 ` Logan Gunthorpe
2022-06-29 6:33 ` Christoph Hellwig
2022-06-29 6:33 ` Christoph Hellwig
2022-06-29 9:05 ` Robin Murphy
2022-06-29 9:05 ` Robin Murphy
2022-06-29 15:39 ` Logan Gunthorpe
2022-06-29 15:39 ` Logan Gunthorpe
2022-06-29 18:02 ` Robin Murphy
2022-06-29 18:02 ` Robin Murphy
2022-06-29 18:24 ` Logan Gunthorpe
2022-06-29 18:24 ` Logan Gunthorpe
2022-07-04 15:08 ` Robin Murphy
2022-07-04 15:08 ` Robin Murphy
2022-06-15 16:12 ` [PATCH v7 02/21] PCI/P2PDMA: Attempt to set map_type if it has not been set Logan Gunthorpe
2022-06-15 16:12 ` Logan Gunthorpe
2022-06-29 6:33 ` Christoph Hellwig
2022-06-29 6:33 ` Christoph Hellwig
2022-06-15 16:12 ` [PATCH v7 03/21] PCI/P2PDMA: Expose pci_p2pdma_map_type() Logan Gunthorpe
2022-06-15 16:12 ` Logan Gunthorpe
2022-06-29 6:39 ` Christoph Hellwig
2022-06-29 6:39 ` Christoph Hellwig
2022-06-15 16:12 ` [PATCH v7 04/21] PCI/P2PDMA: Introduce helpers for dma_map_sg implementations Logan Gunthorpe
2022-06-15 16:12 ` Logan Gunthorpe
2022-06-29 6:39 ` Christoph Hellwig
2022-06-29 6:39 ` Christoph Hellwig
2022-06-15 16:12 ` [PATCH v7 05/21] dma-mapping: allow EREMOTEIO return code for P2PDMA transfers Logan Gunthorpe
2022-06-15 16:12 ` Logan Gunthorpe
2022-06-29 6:40 ` Christoph Hellwig
2022-06-29 6:40 ` Christoph Hellwig
2022-06-15 16:12 ` [PATCH v7 06/21] dma-direct: support PCI P2PDMA pages in dma-direct map_sg Logan Gunthorpe
2022-06-15 16:12 ` Logan Gunthorpe
2022-06-29 6:40 ` Christoph Hellwig
2022-06-29 6:40 ` Christoph Hellwig
2022-06-15 16:12 ` [PATCH v7 07/21] dma-mapping: add flags to dma_map_ops to indicate PCI P2PDMA support Logan Gunthorpe
2022-06-15 16:12 ` Logan Gunthorpe
2022-06-29 6:41 ` Christoph Hellwig
2022-06-29 6:41 ` Christoph Hellwig
2022-06-15 16:12 ` [PATCH v7 08/21] iommu/dma: support PCI P2PDMA pages in dma-iommu map_sg Logan Gunthorpe
2022-06-15 16:12 ` Logan Gunthorpe
2022-06-29 12:07 ` Robin Murphy
2022-06-29 12:07 ` Robin Murphy
2022-06-29 15:57 ` Logan Gunthorpe
2022-06-29 15:57 ` Logan Gunthorpe
2022-06-29 19:15 ` Robin Murphy
2022-06-29 19:15 ` Robin Murphy
2022-06-29 22:41 ` Logan Gunthorpe
2022-06-29 22:41 ` Logan Gunthorpe
2022-06-30 14:56 ` Robin Murphy
2022-06-30 14:56 ` Robin Murphy
2022-06-30 21:21 ` Logan Gunthorpe
2022-06-30 21:21 ` Logan Gunthorpe
2022-06-15 16:12 ` [PATCH v7 09/21] nvme-pci: check DMA ops when indicating support for PCI P2PDMA Logan Gunthorpe
2022-06-15 16:12 ` Logan Gunthorpe
2022-06-29 6:41 ` Christoph Hellwig
2022-06-29 6:41 ` Christoph Hellwig
2022-06-15 16:12 ` [PATCH v7 10/21] nvme-pci: convert to using dma_map_sgtable() Logan Gunthorpe
2022-06-15 16:12 ` Logan Gunthorpe
2022-06-29 6:42 ` Christoph Hellwig
2022-06-29 6:42 ` Christoph Hellwig
2022-06-15 16:12 ` [PATCH v7 11/21] RDMA/core: introduce ib_dma_pci_p2p_dma_supported() Logan Gunthorpe
2022-06-15 16:12 ` Logan Gunthorpe
2022-06-29 6:42 ` Christoph Hellwig
2022-06-29 6:42 ` Christoph Hellwig
2022-06-15 16:12 ` [PATCH v7 12/21] RDMA/rw: drop pci_p2pdma_[un]map_sg() Logan Gunthorpe
2022-06-15 16:12 ` Logan Gunthorpe
2022-06-29 6:42 ` Christoph Hellwig
2022-06-29 6:42 ` Christoph Hellwig
2022-06-15 16:12 ` [PATCH v7 13/21] PCI/P2PDMA: Remove pci_p2pdma_[un]map_sg() Logan Gunthorpe
2022-06-15 16:12 ` Logan Gunthorpe
2022-06-29 6:43 ` Christoph Hellwig
2022-06-29 6:43 ` Christoph Hellwig
2022-06-15 16:12 ` [PATCH v7 14/21] mm: introduce FOLL_PCI_P2PDMA to gate getting PCI P2PDMA pages Logan Gunthorpe
2022-06-15 16:12 ` Logan Gunthorpe
2022-06-29 6:45 ` Christoph Hellwig
2022-06-29 6:45 ` Christoph Hellwig
2022-06-15 16:12 ` [PATCH v7 15/21] iov_iter: introduce iov_iter_get_pages_[alloc_]flags() Logan Gunthorpe
2022-06-15 16:12 ` Logan Gunthorpe
2022-06-29 6:45 ` Christoph Hellwig
2022-06-29 6:45 ` Christoph Hellwig
2022-06-15 16:12 ` [PATCH v7 16/21] block: add check when merging zone device pages Logan Gunthorpe
2022-06-15 16:12 ` Logan Gunthorpe
2022-06-29 6:46 ` Christoph Hellwig
2022-06-29 6:46 ` Christoph Hellwig
2022-06-29 16:06 ` Logan Gunthorpe
2022-06-29 16:06 ` Logan Gunthorpe
2022-06-30 21:50 ` Logan Gunthorpe
2022-06-30 21:50 ` Logan Gunthorpe
2022-07-04 6:07 ` Christoph Hellwig
2022-07-04 6:07 ` Christoph Hellwig
2022-06-15 16:12 ` [PATCH v7 17/21] lib/scatterlist: " Logan Gunthorpe
2022-06-15 16:12 ` Logan Gunthorpe
2022-06-15 16:12 ` [PATCH v7 18/21] block: set FOLL_PCI_P2PDMA in __bio_iov_iter_get_pages() Logan Gunthorpe
2022-06-15 16:12 ` Logan Gunthorpe
2022-06-15 16:12 ` [PATCH v7 19/21] block: set FOLL_PCI_P2PDMA in bio_map_user_iov() Logan Gunthorpe
2022-06-15 16:12 ` Logan Gunthorpe
2022-06-15 16:12 ` [PATCH v7 20/21] PCI/P2PDMA: Introduce pci_mmap_p2pmem() Logan Gunthorpe
2022-06-15 16:12 ` Logan Gunthorpe
2022-06-29 6:48 ` Christoph Hellwig
2022-06-29 6:48 ` Christoph Hellwig
2022-06-29 16:00 ` Logan Gunthorpe
2022-06-29 16:00 ` Logan Gunthorpe
2022-06-29 17:59 ` Jason Gunthorpe
2022-06-29 17:59 ` Jason Gunthorpe
2022-07-05 7:51 ` Christoph Hellwig
2022-07-05 7:51 ` Christoph Hellwig
2022-07-05 13:51 ` Jason Gunthorpe
2022-07-05 13:51 ` Jason Gunthorpe
2022-07-05 16:12 ` Christoph Hellwig
2022-07-05 16:12 ` Christoph Hellwig
2022-07-05 16:29 ` Jason Gunthorpe
2022-07-05 16:29 ` Jason Gunthorpe
2022-07-05 16:40 ` Christoph Hellwig
2022-07-05 16:40 ` Christoph Hellwig
2022-07-05 16:41 ` Logan Gunthorpe
2022-07-05 16:41 ` Logan Gunthorpe
2022-07-05 16:43 ` Christoph Hellwig [this message]
2022-07-05 16:43 ` Christoph Hellwig
2022-07-05 16:44 ` Logan Gunthorpe
2022-07-05 16:44 ` Logan Gunthorpe
2022-07-05 16:50 ` Christoph Hellwig
2022-07-05 16:50 ` Christoph Hellwig
2022-07-05 17:21 ` Greg Kroah-Hartman
2022-07-05 17:21 ` Greg Kroah-Hartman
2022-07-05 17:32 ` Logan Gunthorpe
2022-07-05 17:32 ` Logan Gunthorpe
2022-07-05 17:42 ` Greg Kroah-Hartman
2022-07-05 17:42 ` Greg Kroah-Hartman
2022-07-05 18:16 ` Logan Gunthorpe
2022-07-05 18:16 ` Logan Gunthorpe
2022-07-06 6:51 ` Christoph Hellwig
2022-07-06 6:51 ` Christoph Hellwig
2022-07-06 7:04 ` Greg Kroah-Hartman
2022-07-06 7:04 ` Greg Kroah-Hartman
2022-07-06 21:30 ` Logan Gunthorpe
2022-06-15 16:12 ` [PATCH v7 21/21] nvme-pci: allow mmaping the CMB in userspace Logan Gunthorpe
2022-06-15 16:12 ` Logan Gunthorpe
2022-06-29 6:49 ` [PATCH v7 00/21] Userspace P2PDMA with O_DIRECT NVMe devices Christoph Hellwig
2022-06-29 6:49 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220705164315.GB14484@lst.de \
--to=hch@lst.de \
--cc=bhelgaas@google.com \
--cc=christian.koenig@amd.com \
--cc=ckulkarnilinux@gmail.com \
--cc=dan.j.williams@intel.com \
--cc=daniel.vetter@ffwll.ch \
--cc=dave.b.minturn@intel.com \
--cc=dave.hansen@linux.intel.com \
--cc=ddutile@redhat.com \
--cc=helgaas@kernel.org \
--cc=iommu@lists.linux-foundation.org \
--cc=ira.weiny@intel.com \
--cc=jason@jlekstrand.net \
--cc=jgg@ziepe.ca \
--cc=jhubbard@nvidia.com \
--cc=jianxin.xiong@intel.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-nvme@lists.infradead.org \
--cc=linux-pci@vger.kernel.org \
--cc=logang@deltatee.com \
--cc=martin.oliveira@eideticom.com \
--cc=rcampbell@nvidia.com \
--cc=robin.murphy@arm.com \
--cc=sbates@raithlin.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.