From: Claudiu Beznea <claudiu.beznea@microchip.com> To: <tglx@linutronix.de>, <maz@kernel.org>, <nicolas.ferre@microchip.com>, <alexandre.belloni@bootlin.com> Cc: <linux-arm-kernel@lists.infradead.org>, <linux-kernel@vger.kernel.org>, Claudiu Beznea <claudiu.beznea@microchip.com> Subject: [PATCH 1/2] irqchip/atmel-aic: remove #ifdef CONFIG_PM Date: Wed, 6 Jul 2022 10:46:29 +0300 [thread overview] Message-ID: <20220706074630.829607-1-claudiu.beznea@microchip.com> (raw) Remove #ifdef CONFIG_PM around aic_suspend() function. Coding style recommends (at chapter Conditional Compilation) to avoid using preprocessor conditional in .c files. gc->chip_types->chip.irq_suspend()/gc->chip_types->chip.irq_resume() is called in irq_gc_suspend()/irq_gc_resume() which is NULL in case CONFIG_PM is not defined. With this gc->chip_types->chip.irq_pm_shutdown is populated all the time as it should be as irq_gc_shutdown() is not conditioned by CONFIG_PM. Signed-off-by: Claudiu Beznea <claudiu.beznea@microchip.com> --- drivers/irqchip/irq-atmel-aic.c | 6 ------ 1 file changed, 6 deletions(-) diff --git a/drivers/irqchip/irq-atmel-aic.c b/drivers/irqchip/irq-atmel-aic.c index 4631f6847953..02a9f45a7d2e 100644 --- a/drivers/irqchip/irq-atmel-aic.c +++ b/drivers/irqchip/irq-atmel-aic.c @@ -102,7 +102,6 @@ static int aic_set_type(struct irq_data *d, unsigned type) return 0; } -#ifdef CONFIG_PM static void aic_suspend(struct irq_data *d) { struct irq_chip_generic *gc = irq_data_get_irq_chip_data(d); @@ -132,11 +131,6 @@ static void aic_pm_shutdown(struct irq_data *d) irq_reg_writel(gc, 0xffffffff, AT91_AIC_ICCR); irq_gc_unlock(gc); } -#else -#define aic_suspend NULL -#define aic_resume NULL -#define aic_pm_shutdown NULL -#endif /* CONFIG_PM */ static void __init aic_hw_init(struct irq_domain *domain) { -- 2.34.1
WARNING: multiple messages have this Message-ID (diff)
From: Claudiu Beznea <claudiu.beznea@microchip.com> To: <tglx@linutronix.de>, <maz@kernel.org>, <nicolas.ferre@microchip.com>, <alexandre.belloni@bootlin.com> Cc: <linux-arm-kernel@lists.infradead.org>, <linux-kernel@vger.kernel.org>, Claudiu Beznea <claudiu.beznea@microchip.com> Subject: [PATCH 1/2] irqchip/atmel-aic: remove #ifdef CONFIG_PM Date: Wed, 6 Jul 2022 10:46:29 +0300 [thread overview] Message-ID: <20220706074630.829607-1-claudiu.beznea@microchip.com> (raw) Remove #ifdef CONFIG_PM around aic_suspend() function. Coding style recommends (at chapter Conditional Compilation) to avoid using preprocessor conditional in .c files. gc->chip_types->chip.irq_suspend()/gc->chip_types->chip.irq_resume() is called in irq_gc_suspend()/irq_gc_resume() which is NULL in case CONFIG_PM is not defined. With this gc->chip_types->chip.irq_pm_shutdown is populated all the time as it should be as irq_gc_shutdown() is not conditioned by CONFIG_PM. Signed-off-by: Claudiu Beznea <claudiu.beznea@microchip.com> --- drivers/irqchip/irq-atmel-aic.c | 6 ------ 1 file changed, 6 deletions(-) diff --git a/drivers/irqchip/irq-atmel-aic.c b/drivers/irqchip/irq-atmel-aic.c index 4631f6847953..02a9f45a7d2e 100644 --- a/drivers/irqchip/irq-atmel-aic.c +++ b/drivers/irqchip/irq-atmel-aic.c @@ -102,7 +102,6 @@ static int aic_set_type(struct irq_data *d, unsigned type) return 0; } -#ifdef CONFIG_PM static void aic_suspend(struct irq_data *d) { struct irq_chip_generic *gc = irq_data_get_irq_chip_data(d); @@ -132,11 +131,6 @@ static void aic_pm_shutdown(struct irq_data *d) irq_reg_writel(gc, 0xffffffff, AT91_AIC_ICCR); irq_gc_unlock(gc); } -#else -#define aic_suspend NULL -#define aic_resume NULL -#define aic_pm_shutdown NULL -#endif /* CONFIG_PM */ static void __init aic_hw_init(struct irq_domain *domain) { -- 2.34.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next reply other threads:[~2022-07-06 7:44 UTC|newest] Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-07-06 7:46 Claudiu Beznea [this message] 2022-07-06 7:46 ` [PATCH 1/2] irqchip/atmel-aic: remove #ifdef CONFIG_PM Claudiu Beznea 2022-07-06 7:46 ` [PATCH 2/2] irqchip/atmel-aic5: " Claudiu Beznea 2022-07-06 7:46 ` Claudiu Beznea 2022-07-11 8:49 ` [PATCH 1/2] irqchip/atmel-aic: " Marc Zyngier 2022-07-11 8:49 ` Marc Zyngier 2022-07-11 10:56 ` Claudiu.Beznea 2022-07-11 10:56 ` Claudiu.Beznea
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20220706074630.829607-1-claudiu.beznea@microchip.com \ --to=claudiu.beznea@microchip.com \ --cc=alexandre.belloni@bootlin.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=maz@kernel.org \ --cc=nicolas.ferre@microchip.com \ --cc=tglx@linutronix.de \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.