All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] drm/ssd130x: Fix pre-charge period setting
@ 2022-07-06 18:41 ` Ezequiel Garcia
  0 siblings, 0 replies; 5+ messages in thread
From: Ezequiel Garcia @ 2022-07-06 18:41 UTC (permalink / raw)
  To: dri-devel, linux-kernel
  Cc: Javier Martinez Canillas, David Airlie, Ezequiel Garcia

Fix small typo which causes the mask for the 'precharge1' setting
to be used with the 'precharge2' value.

Signed-off-by: Ezequiel Garcia <ezequiel@vanguardiasur.com.ar>
---
 drivers/gpu/drm/solomon/ssd130x.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/solomon/ssd130x.c b/drivers/gpu/drm/solomon/ssd130x.c
index 08394444dd6e..f4886e66ff34 100644
--- a/drivers/gpu/drm/solomon/ssd130x.c
+++ b/drivers/gpu/drm/solomon/ssd130x.c
@@ -350,7 +350,7 @@ static int ssd130x_init(struct ssd130x_device *ssd130x)
 
 	/* Set precharge period in number of ticks from the internal clock */
 	precharge = (SSD130X_SET_PRECHARGE_PERIOD1_SET(ssd130x->prechargep1) |
-		     SSD130X_SET_PRECHARGE_PERIOD1_SET(ssd130x->prechargep2));
+		     SSD130X_SET_PRECHARGE_PERIOD2_SET(ssd130x->prechargep2));
 	ret = ssd130x_write_cmd(ssd130x, 2, SSD130X_SET_PRECHARGE_PERIOD, precharge);
 	if (ret < 0)
 		return ret;
-- 
2.34.3


^ permalink raw reply related	[flat|nested] 5+ messages in thread
* [PATCH] drm/ssd130x: Fix pre-charge period setting
@ 2022-07-06 18:41 ` Ezequiel Garcia
  0 siblings, 0 replies; 5+ messages in thread
From: Ezequiel Garcia @ 2022-07-06 18:41 UTC (permalink / raw)
  To: dri-devel, linux-kernel
  Cc: David Airlie, Javier Martinez Canillas, Ezequiel Garcia

Fix small typo which causes the mask for the 'precharge1' setting
to be used with the 'precharge2' value.

Signed-off-by: Ezequiel Garcia <ezequiel@vanguardiasur.com.ar>
---
 drivers/gpu/drm/solomon/ssd130x.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/solomon/ssd130x.c b/drivers/gpu/drm/solomon/ssd130x.c
index 08394444dd6e..f4886e66ff34 100644
--- a/drivers/gpu/drm/solomon/ssd130x.c
+++ b/drivers/gpu/drm/solomon/ssd130x.c
@@ -350,7 +350,7 @@ static int ssd130x_init(struct ssd130x_device *ssd130x)
 
 	/* Set precharge period in number of ticks from the internal clock */
 	precharge = (SSD130X_SET_PRECHARGE_PERIOD1_SET(ssd130x->prechargep1) |
-		     SSD130X_SET_PRECHARGE_PERIOD1_SET(ssd130x->prechargep2));
+		     SSD130X_SET_PRECHARGE_PERIOD2_SET(ssd130x->prechargep2));
 	ret = ssd130x_write_cmd(ssd130x, 2, SSD130X_SET_PRECHARGE_PERIOD, precharge);
 	if (ret < 0)
 		return ret;
-- 
2.34.3


^ permalink raw reply related	[flat|nested] 5+ messages in thread
* Re: [PATCH] drm/ssd130x: Fix pre-charge period setting
  2022-07-06 18:41 ` Ezequiel Garcia
  (?)
@ 2022-07-07  8:37 ` Javier Martinez Canillas
  2022-07-08 21:03     ` Ezequiel Garcia
  -1 siblings, 1 reply; 5+ messages in thread
From: Javier Martinez Canillas @ 2022-07-07  8:37 UTC (permalink / raw)
  To: Ezequiel Garcia, dri-devel, linux-kernel; +Cc: David Airlie

Hello Ezequiel,

Thanks a lot for your patch.

On 7/6/22 20:41, Ezequiel Garcia wrote:
> Fix small typo which causes the mask for the 'precharge1' setting
> to be used with the 'precharge2' value.
> 
> Signed-off-by: Ezequiel Garcia <ezequiel@vanguardiasur.com.ar>
> ---
>  drivers/gpu/drm/solomon/ssd130x.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/solomon/ssd130x.c b/drivers/gpu/drm/solomon/ssd130x.c
> index 08394444dd6e..f4886e66ff34 100644
> --- a/drivers/gpu/drm/solomon/ssd130x.c
> +++ b/drivers/gpu/drm/solomon/ssd130x.c
> @@ -350,7 +350,7 @@ static int ssd130x_init(struct ssd130x_device *ssd130x)
>  
>  	/* Set precharge period in number of ticks from the internal clock */
>  	precharge = (SSD130X_SET_PRECHARGE_PERIOD1_SET(ssd130x->prechargep1) |
> -		     SSD130X_SET_PRECHARGE_PERIOD1_SET(ssd130x->prechargep2));
> +		     SSD130X_SET_PRECHARGE_PERIOD2_SET(ssd130x->prechargep2));

It's a typo indeed. Nice catch!

I wonder how did you notice this. Or was it just looking at the code ?

Acked-by: Javier Martinez Canillas <javierm@redhat.com>

I'll push it to drm-misc (drm-misc-fixes).

-- 
Best regards,

Javier Martinez Canillas
Linux Engineering
Red Hat


^ permalink raw reply	[flat|nested] 5+ messages in thread
* Re: [PATCH] drm/ssd130x: Fix pre-charge period setting
  2022-07-07  8:37 ` Javier Martinez Canillas
@ 2022-07-08 21:03     ` Ezequiel Garcia
  0 siblings, 0 replies; 5+ messages in thread
From: Ezequiel Garcia @ 2022-07-08 21:03 UTC (permalink / raw)
  To: Javier Martinez Canillas
  Cc: dri-devel, Linux Kernel Mailing List, David Airlie

On Thu, Jul 7, 2022 at 5:37 AM Javier Martinez Canillas
<javierm@redhat.com> wrote:
>
> Hello Ezequiel,
>
> Thanks a lot for your patch.
>
> On 7/6/22 20:41, Ezequiel Garcia wrote:
> > Fix small typo which causes the mask for the 'precharge1' setting
> > to be used with the 'precharge2' value.
> >
> > Signed-off-by: Ezequiel Garcia <ezequiel@vanguardiasur.com.ar>
> > ---
> >  drivers/gpu/drm/solomon/ssd130x.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/solomon/ssd130x.c b/drivers/gpu/drm/solomon/ssd130x.c
> > index 08394444dd6e..f4886e66ff34 100644
> > --- a/drivers/gpu/drm/solomon/ssd130x.c
> > +++ b/drivers/gpu/drm/solomon/ssd130x.c
> > @@ -350,7 +350,7 @@ static int ssd130x_init(struct ssd130x_device *ssd130x)
> >
> >       /* Set precharge period in number of ticks from the internal clock */
> >       precharge = (SSD130X_SET_PRECHARGE_PERIOD1_SET(ssd130x->prechargep1) |
> > -                  SSD130X_SET_PRECHARGE_PERIOD1_SET(ssd130x->prechargep2));
> > +                  SSD130X_SET_PRECHARGE_PERIOD2_SET(ssd130x->prechargep2));
>
> It's a typo indeed. Nice catch!
>
> I wonder how did you notice this. Or was it just looking at the code ?
>

Indeed, I was just reviewing the code while getting a SH1106 display to work.

> Acked-by: Javier Martinez Canillas <javierm@redhat.com>
>
> I'll push it to drm-misc (drm-misc-fixes).
>

Thanks!
Ezequiel

> --
> Best regards,
>
> Javier Martinez Canillas
> Linux Engineering
> Red Hat
>

^ permalink raw reply	[flat|nested] 5+ messages in thread
* Re: [PATCH] drm/ssd130x: Fix pre-charge period setting
@ 2022-07-08 21:03     ` Ezequiel Garcia
  0 siblings, 0 replies; 5+ messages in thread
From: Ezequiel Garcia @ 2022-07-08 21:03 UTC (permalink / raw)
  To: Javier Martinez Canillas
  Cc: David Airlie, Linux Kernel Mailing List, dri-devel

On Thu, Jul 7, 2022 at 5:37 AM Javier Martinez Canillas
<javierm@redhat.com> wrote:
>
> Hello Ezequiel,
>
> Thanks a lot for your patch.
>
> On 7/6/22 20:41, Ezequiel Garcia wrote:
> > Fix small typo which causes the mask for the 'precharge1' setting
> > to be used with the 'precharge2' value.
> >
> > Signed-off-by: Ezequiel Garcia <ezequiel@vanguardiasur.com.ar>
> > ---
> >  drivers/gpu/drm/solomon/ssd130x.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/solomon/ssd130x.c b/drivers/gpu/drm/solomon/ssd130x.c
> > index 08394444dd6e..f4886e66ff34 100644
> > --- a/drivers/gpu/drm/solomon/ssd130x.c
> > +++ b/drivers/gpu/drm/solomon/ssd130x.c
> > @@ -350,7 +350,7 @@ static int ssd130x_init(struct ssd130x_device *ssd130x)
> >
> >       /* Set precharge period in number of ticks from the internal clock */
> >       precharge = (SSD130X_SET_PRECHARGE_PERIOD1_SET(ssd130x->prechargep1) |
> > -                  SSD130X_SET_PRECHARGE_PERIOD1_SET(ssd130x->prechargep2));
> > +                  SSD130X_SET_PRECHARGE_PERIOD2_SET(ssd130x->prechargep2));
>
> It's a typo indeed. Nice catch!
>
> I wonder how did you notice this. Or was it just looking at the code ?
>

Indeed, I was just reviewing the code while getting a SH1106 display to work.

> Acked-by: Javier Martinez Canillas <javierm@redhat.com>
>
> I'll push it to drm-misc (drm-misc-fixes).
>

Thanks!
Ezequiel

> --
> Best regards,
>
> Javier Martinez Canillas
> Linux Engineering
> Red Hat
>

^ permalink raw reply	[flat|nested] 5+ messages in thread
end of thread, other threads:[~2022-07-09  7:09 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-07-06 18:41 [PATCH] drm/ssd130x: Fix pre-charge period setting Ezequiel Garcia
2022-07-06 18:41 ` Ezequiel Garcia
2022-07-07  8:37 ` Javier Martinez Canillas
2022-07-08 21:03   ` Ezequiel Garcia
2022-07-08 21:03     ` Ezequiel Garcia

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.