From: "Christian König" <ckoenig.leichtzumerken@gmail.com>
To: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
nouveau@lists.freedesktop.org, amd-gfx@lists.freedesktop.org
Cc: "Christian König" <christian.koenig@amd.com>
Subject: [PATCH 5/6] drm/ttm: stop allocating dummy resources during BO creation
Date: Thu, 7 Jul 2022 12:24:52 +0200 [thread overview]
Message-ID: <20220707102453.3633-6-christian.koenig@amd.com> (raw)
In-Reply-To: <20220707102453.3633-1-christian.koenig@amd.com>
That should not be necessary any more when drivers should at least be
able to handle the move without a resource.
Signed-off-by: Christian König <christian.koenig@amd.com>
---
drivers/gpu/drm/ttm/ttm_bo.c | 7 -------
1 file changed, 7 deletions(-)
diff --git a/drivers/gpu/drm/ttm/ttm_bo.c b/drivers/gpu/drm/ttm/ttm_bo.c
index a2f49bdda8a1..f491be751a2f 100644
--- a/drivers/gpu/drm/ttm/ttm_bo.c
+++ b/drivers/gpu/drm/ttm/ttm_bo.c
@@ -960,7 +960,6 @@ int ttm_bo_init_reserved(struct ttm_device *bdev, struct ttm_buffer_object *bo,
struct sg_table *sg, struct dma_resv *resv,
void (*destroy) (struct ttm_buffer_object *))
{
- static const struct ttm_place sys_mem = { .mem_type = TTM_PL_SYSTEM };
int ret;
kref_init(&bo->kref);
@@ -978,12 +977,6 @@ int ttm_bo_init_reserved(struct ttm_device *bdev, struct ttm_buffer_object *bo,
bo->base.resv = &bo->base._resv;
atomic_inc(&ttm_glob.bo_count);
- ret = ttm_resource_alloc(bo, &sys_mem, &bo->resource);
- if (unlikely(ret)) {
- ttm_bo_put(bo);
- return ret;
- }
-
/*
* For ttm_bo_type_device buffers, allocate
* address space from the device.
--
2.25.1
WARNING: multiple messages have this Message-ID (diff)
From: "Christian König" <ckoenig.leichtzumerken@gmail.com>
To: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
nouveau@lists.freedesktop.org, amd-gfx@lists.freedesktop.org
Cc: "Christian König" <christian.koenig@amd.com>
Subject: [Nouveau] [PATCH 5/6] drm/ttm: stop allocating dummy resources during BO creation
Date: Thu, 7 Jul 2022 12:24:52 +0200 [thread overview]
Message-ID: <20220707102453.3633-6-christian.koenig@amd.com> (raw)
In-Reply-To: <20220707102453.3633-1-christian.koenig@amd.com>
That should not be necessary any more when drivers should at least be
able to handle the move without a resource.
Signed-off-by: Christian König <christian.koenig@amd.com>
---
drivers/gpu/drm/ttm/ttm_bo.c | 7 -------
1 file changed, 7 deletions(-)
diff --git a/drivers/gpu/drm/ttm/ttm_bo.c b/drivers/gpu/drm/ttm/ttm_bo.c
index a2f49bdda8a1..f491be751a2f 100644
--- a/drivers/gpu/drm/ttm/ttm_bo.c
+++ b/drivers/gpu/drm/ttm/ttm_bo.c
@@ -960,7 +960,6 @@ int ttm_bo_init_reserved(struct ttm_device *bdev, struct ttm_buffer_object *bo,
struct sg_table *sg, struct dma_resv *resv,
void (*destroy) (struct ttm_buffer_object *))
{
- static const struct ttm_place sys_mem = { .mem_type = TTM_PL_SYSTEM };
int ret;
kref_init(&bo->kref);
@@ -978,12 +977,6 @@ int ttm_bo_init_reserved(struct ttm_device *bdev, struct ttm_buffer_object *bo,
bo->base.resv = &bo->base._resv;
atomic_inc(&ttm_glob.bo_count);
- ret = ttm_resource_alloc(bo, &sys_mem, &bo->resource);
- if (unlikely(ret)) {
- ttm_bo_put(bo);
- return ret;
- }
-
/*
* For ttm_bo_type_device buffers, allocate
* address space from the device.
--
2.25.1
WARNING: multiple messages have this Message-ID (diff)
From: "Christian König" <ckoenig.leichtzumerken@gmail.com>
To: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
nouveau@lists.freedesktop.org, amd-gfx@lists.freedesktop.org
Cc: "Christian König" <christian.koenig@amd.com>
Subject: [Intel-gfx] [PATCH 5/6] drm/ttm: stop allocating dummy resources during BO creation
Date: Thu, 7 Jul 2022 12:24:52 +0200 [thread overview]
Message-ID: <20220707102453.3633-6-christian.koenig@amd.com> (raw)
In-Reply-To: <20220707102453.3633-1-christian.koenig@amd.com>
That should not be necessary any more when drivers should at least be
able to handle the move without a resource.
Signed-off-by: Christian König <christian.koenig@amd.com>
---
drivers/gpu/drm/ttm/ttm_bo.c | 7 -------
1 file changed, 7 deletions(-)
diff --git a/drivers/gpu/drm/ttm/ttm_bo.c b/drivers/gpu/drm/ttm/ttm_bo.c
index a2f49bdda8a1..f491be751a2f 100644
--- a/drivers/gpu/drm/ttm/ttm_bo.c
+++ b/drivers/gpu/drm/ttm/ttm_bo.c
@@ -960,7 +960,6 @@ int ttm_bo_init_reserved(struct ttm_device *bdev, struct ttm_buffer_object *bo,
struct sg_table *sg, struct dma_resv *resv,
void (*destroy) (struct ttm_buffer_object *))
{
- static const struct ttm_place sys_mem = { .mem_type = TTM_PL_SYSTEM };
int ret;
kref_init(&bo->kref);
@@ -978,12 +977,6 @@ int ttm_bo_init_reserved(struct ttm_device *bdev, struct ttm_buffer_object *bo,
bo->base.resv = &bo->base._resv;
atomic_inc(&ttm_glob.bo_count);
- ret = ttm_resource_alloc(bo, &sys_mem, &bo->resource);
- if (unlikely(ret)) {
- ttm_bo_put(bo);
- return ret;
- }
-
/*
* For ttm_bo_type_device buffers, allocate
* address space from the device.
--
2.25.1
next prev parent reply other threads:[~2022-07-07 10:25 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-07 10:24 [Nouveau] Cleanup of TTM NULL resources Christian König
2022-07-07 10:24 ` [Intel-gfx] " Christian König
2022-07-07 10:24 ` Christian König
2022-07-07 10:24 ` [Nouveau] [PATCH 1/6] drm/ttm: rename and cleanup ttm_bo_init_reserved Christian König
2022-07-07 10:24 ` [Intel-gfx] " Christian König
2022-07-07 10:24 ` Christian König
2022-07-07 10:35 ` [Nouveau] " Christian König
2022-07-07 10:35 ` [Intel-gfx] " Christian König
2022-07-07 10:35 ` Christian König
2022-07-07 17:24 ` [Nouveau] [Intel-gfx] " kernel test robot
2022-07-07 17:24 ` kernel test robot
2022-07-08 13:31 ` Ruhl, Michael J
2022-07-08 13:31 ` [Nouveau] " Ruhl, Michael J
2022-07-08 13:31 ` [Intel-gfx] " Ruhl, Michael J
2022-07-07 10:24 ` [PATCH 2/6] drm/amdgpu: audit bo->resource usage Christian König
2022-07-07 10:24 ` [Intel-gfx] " Christian König
2022-07-07 10:24 ` [Nouveau] " Christian König
2022-07-08 13:34 ` [Intel-gfx] " Ruhl, Michael J
2022-07-08 13:34 ` [Nouveau] " Ruhl, Michael J
2022-07-08 13:34 ` Ruhl, Michael J
2022-07-07 10:24 ` [Nouveau] [PATCH 3/6] drm/nouveau: " Christian König
2022-07-07 10:24 ` [Intel-gfx] " Christian König
2022-07-07 10:24 ` Christian König
2022-07-08 13:35 ` [Intel-gfx] " Ruhl, Michael J
2022-07-08 13:35 ` [Nouveau] " Ruhl, Michael J
2022-07-08 13:35 ` Ruhl, Michael J
2022-07-07 10:24 ` [Nouveau] [PATCH 4/6] drm/ttm: audit bo->resource usage v2 Christian König
2022-07-07 10:24 ` [Intel-gfx] " Christian König
2022-07-07 10:24 ` Christian König
2022-07-08 13:48 ` [Intel-gfx] " Ruhl, Michael J
2022-07-08 13:48 ` [Nouveau] " Ruhl, Michael J
2022-07-08 13:48 ` Ruhl, Michael J
2022-07-07 10:24 ` Christian König [this message]
2022-07-07 10:24 ` [Intel-gfx] [PATCH 5/6] drm/ttm: stop allocating dummy resources during BO creation Christian König
2022-07-07 10:24 ` [Nouveau] " Christian König
2022-07-08 13:54 ` Ruhl, Michael J
2022-07-08 13:54 ` [Nouveau] " Ruhl, Michael J
2022-07-08 13:54 ` [Intel-gfx] " Ruhl, Michael J
2022-07-09 14:31 ` [drm/ttm] b297c22b70: canonical_address#:#[##] kernel test robot
2022-07-09 14:31 ` kernel test robot
2022-07-09 14:31 ` [Intel-gfx] " kernel test robot
2022-07-09 14:31 ` kernel test robot
2022-07-07 10:24 ` [Nouveau] [PATCH 6/6] drm/ttm: stop allocating a dummy resource for pipelined gutting Christian König
2022-07-07 10:24 ` [Intel-gfx] " Christian König
2022-07-07 10:24 ` Christian König
2022-07-08 13:56 ` Ruhl, Michael J
2022-07-08 13:56 ` [Nouveau] " Ruhl, Michael J
2022-07-08 13:56 ` [Intel-gfx] " Ruhl, Michael J
2022-07-07 14:16 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/6] drm/ttm: rename and cleanup ttm_bo_init_reserved Patchwork
2022-07-07 14:16 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
2022-07-07 14:37 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220707102453.3633-6-christian.koenig@amd.com \
--to=ckoenig.leichtzumerken@gmail.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=christian.koenig@amd.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=nouveau@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.