All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] regulator: Fix MFD_MAX597X dependency
@ 2022-07-07 11:17 Mark Brown
  2022-07-07 14:56 ` Mark Brown
  0 siblings, 1 reply; 2+ messages in thread
From: Mark Brown @ 2022-07-07 11:17 UTC (permalink / raw)
  To: Liam Girdwood, Naresh Solanki, Patrick Rudolph
  Cc: linux-kernel, Mark Brown, Stephen Rothwell

Drivers should depend on rather than select their MFDs.

Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
Signed-off-by: Mark Brown <broonie@kernel.org>
---
 drivers/regulator/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/regulator/Kconfig b/drivers/regulator/Kconfig
index aedc4cba9240..23e3e4a35cc9 100644
--- a/drivers/regulator/Kconfig
+++ b/drivers/regulator/Kconfig
@@ -550,7 +550,7 @@ config REGULATOR_MAX597X
 	tristate "Maxim 597x power switch and monitor"
 	depends on I2C
 	depends on OF
-	select MFD_MAX597X
+	depends on MFD_MAX597X
 	help
 	  This driver controls a Maxim 5970/5978 switch via I2C bus.
 	  The MAX5970/5978 is a smart switch with no output regulation, but
-- 
2.30.2


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] regulator: Fix MFD_MAX597X dependency
  2022-07-07 11:17 [PATCH] regulator: Fix MFD_MAX597X dependency Mark Brown
@ 2022-07-07 14:56 ` Mark Brown
  0 siblings, 0 replies; 2+ messages in thread
From: Mark Brown @ 2022-07-07 14:56 UTC (permalink / raw)
  To: naresh.solanki, lgirdwood, broonie, patrick.rudolph; +Cc: sfr, linux-kernel

On Thu, 7 Jul 2022 12:17:53 +0100, Mark Brown wrote:
> Drivers should depend on rather than select their MFDs.
> 
> 

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator.git for-next

Thanks!

[1/1] regulator: Fix MFD_MAX597X dependency
      commit: 79152fc74ff664e2912abe17f21c42d7c49c90c9

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2022-07-07 14:58 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-07-07 11:17 [PATCH] regulator: Fix MFD_MAX597X dependency Mark Brown
2022-07-07 14:56 ` Mark Brown

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.