[PATCH] drm/i915/selftests: fix a couple IS_ERR() vs NULL tests

* [PATCH] drm/i915/selftests: fix a couple IS_ERR() vs NULL tests
@ 2022-07-08  8:40 ` Dan Carpenter
  0 siblings, 0 replies; 8+ messages in thread
From: Dan Carpenter @ 2022-07-08  8:40 UTC (permalink / raw)
  To: Jani Nikula, Chris Wilson
  Cc: Joonas Lahtinen, Rodrigo Vivi, Tvrtko Ursulin, David Airlie,
	Daniel Vetter, Ramalingam C, Matt Roper, Matthew Auld,
	Akeem G Abodunrin, Michał Winiarski, Daniele Ceraolo Spurio,
	intel-gfx, kernel-janitors

The shmem_pin_map() function doesn't return error pointers, it returns
NULL.

Fixes: a0d3fdb628b8 ("drm/i915/gt: Split logical ring contexts from execlist submission"
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
 drivers/gpu/drm/i915/gt/selftest_lrc.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/gpu/drm/i915/gt/selftest_lrc.c b/drivers/gpu/drm/i915/gt/selftest_lrc.c
index 8b2c11dbe354..1109088fe8f6 100644
--- a/drivers/gpu/drm/i915/gt/selftest_lrc.c
+++ b/drivers/gpu/drm/i915/gt/selftest_lrc.c
@@ -176,8 +176,8 @@ static int live_lrc_layout(void *arg)
 			continue;
 
 		hw = shmem_pin_map(engine->default_state);
-		if (IS_ERR(hw)) {
-			err = PTR_ERR(hw);
+		if (!hw) {
+			err = -ENOMEM;
 			break;
 		}
 		hw += LRC_STATE_OFFSET / sizeof(*hw);
@@ -365,8 +365,8 @@ static int live_lrc_fixed(void *arg)
 			continue;
 
 		hw = shmem_pin_map(engine->default_state);
-		if (IS_ERR(hw)) {
-			err = PTR_ERR(hw);
+		if (!hw) {
+			err = -ENOMEM;
 			break;
 		}
 		hw += LRC_STATE_OFFSET / sizeof(*hw);
-- 
2.35.1


^ permalink raw reply related	[flat|nested] 8+ messages in thread