Re: [PATCH] distroboot: Fix ubifs

From: Tom Rini <trini@konsulko.com>
To: "Pali Rohár" <pali@kernel.org>
Cc: Simon Glass <sjg@chromium.org>,
	Sjoerd Simons <sjoerd.simons@collabora.co.uk>,
	Govindaraji Sivanantham <Govindaraji.Sivanantham@in.bosch.com>,
	Hiremath Gireesh <Gireesh.Hiremath@in.bosch.com>,
	Marcel Ziswiler <marcel.ziswiler@toradex.com>,
	Frieder Schrempf <frieder.schrempf@kontron.de>,
	Parthiban Nallathambi <parthiban@linumiz.com>,
	Navin Sankar Velliangiri <navin@linumiz.com>,
	"Derald D. Woods" <woods.technical@gmail.com>,
	Martyn Welch <martyn.welch@collabora.com>,
	Patrick Delaunay <patrick.delaunay@foss.st.com>,
	Patrice Chotard <patrice.chotard@foss.st.com>,
	u-boot@lists.denx.de
Subject: Re: [PATCH] distroboot: Fix ubifs
Date: Fri, 8 Jul 2022 12:38:32 -0400	[thread overview]
Message-ID: <20220708163832.GC1146598@bill-the-cat> (raw)
In-Reply-To: <20220531083236.18968-1-pali@kernel.org>

[-- Attachment #1: Type: text/plain, Size: 1902 bytes --]

On Tue, May 31, 2022 at 10:32:36AM +0200, Pali Rohár wrote:

> Fix multiple issues in ubifs distroboot code:
> 
> U-Boot supports attaching only one MTD device as UBI at the time. So
> always call 'ubifsmount ubi0:${bootubivol}' for mounting UBI volume
> ${bootubivol}. Usage of 'ubi${devnum}' is incorrect as 'ubi part'
> command attach MTD device always as UBI device ubi0.
> 
> Set distroboot ${bootfstype} variable to ubifs in ubifs_boot command.
> Distroboot scripts require ${bootfstype} variable to be properly set and it
> is already set for all other boot types.
> 
> Set distroboot ${distro_bootpart} variable to ${bootubivol} value. UBI
> device does not have partitions, but has volumes. Distroboot scripts
> require something to be set in ${distro_bootpart} variable, so set it to
> the UBI volume which is currently mounted by ubifs.
> 
> Set distroboot ${devnum} variable to fixed string "ubi0". ubifs code
> differs from the other partition code that it requires "ubi" prefix before
> number.
> 
> Explicitly unmount ubifs volume after loading all data from it. This allows
> to detach UBI device from MTD device.
> 
> Move definition of MTD device with UBI and UBI volume with ubifs filesystem
> from global env variables ${bootubipart} and ${bootubivol} into the
> distroboot "func" macro, defined in board include config files. UBIFS
> distroboot macros then set ${bootubipart} and ${bootubivol} local variables
> for compatibility with existing distroboot scripts.
> 
> This last change allows to define more UBIFS target devices and make it
> clear what is boot MTD/UBI device.
> 
> All board include config files are adjusted to use this new scheme of
> specifying boot MTD/UBI device.
> 
> Signed-off-by: Pali Rohár <pali@kernel.org>
> Acked-by: Frieder Schrempf <frieder.schrempf@kontron.de>

Applied to u-boot/next, thanks!

-- 
Tom

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]